| Posted | Nick | Remark | |
|---|---|---|---|
| #openstack-nova - 2021-01-11 | |||
| 21:32:43 | openstackgerrit | Lance Bragstad proposed openstack/placement master: Implement secure RBAC for allocation candidates https://review.opendev.org/c/openstack/placement/+/760237 | |
| 21:32:44 | openstackgerrit | Lance Bragstad proposed openstack/placement master: Implement secure RBAC for inventories https://review.opendev.org/c/openstack/placement/+/760238 | |
| 21:32:45 | openstackgerrit | Lance Bragstad proposed openstack/placement master: Implement secure RBAC for resource classes https://review.opendev.org/c/openstack/placement/+/760239 | |
| 21:32:47 | openstackgerrit | Lance Bragstad proposed openstack/placement master: Implement secure RBAC for traits https://review.opendev.org/c/openstack/placement/+/760241 | |
| 21:32:51 | openstackgerrit | Lance Bragstad proposed openstack/placement master: Implement secure RBAC for usage https://review.opendev.org/c/openstack/placement/+/760242 | |
| 22:19:21 | openstackgerrit | Merged openstack/nova master: api: Drop statistics-style fields from os-hypervisors https://review.opendev.org/c/openstack/nova/+/764040 | |
| #openstack-nova - 2021-01-12 | |||
| 02:54:36 | alex_xu | gibi: bauzas could you help me confirm this https://review.opendev.org/c/openstack/nova/+/729563/26/nova/conductor/manager.py#1023, it looks like a bug we left before or I missed something. also not sure if we can move forware with fix later or not. just trying help brinzhang move forward his patch. | |
| 08:07:01 | openstackgerrit | Wenping Song proposed openstack/nova master: Nova supports password encrypted VNC https://review.opendev.org/c/openstack/nova/+/622336 | |
| 08:31:19 | gibi | alex_xu: ack, I will check | |
| 08:32:03 | gibi | lyarwood: I have to be away for keyboard for couple of hours this morning but I made some progress with the device detach code I will push it soon then at some point we can try to discuss it | |
| 08:36:27 | openstackgerrit | Balazs Gibizer proposed openstack/nova master: DNM try to replace retry with libvirt event in detach https://review.opendev.org/c/openstack/nova/+/770246 | |
| 08:37:17 | gibi | lyarwood: ^^ | |
| 09:41:23 | lyarwood | gibi: ack cool np, I'll take a look | |
| 10:55:10 | bauzas | sean-k-mooney: around ? | |
| 10:55:25 | bauzas | I'm facing a problem with the neutron API | |
| 10:55:37 | bauzas | I can't ask for getting the segments for a specific subnet | |
| 10:55:54 | bauzas | https://docs.openstack.org/api-ref/network/v2/index.html?expanded=list-segments-detail#segments | |
| 10:59:24 | bauzas | actually, https://docs.openstack.org/api-ref/network/v2/index.html?#segment-extension | |
| 11:00:29 | bauzas | we could get the segment ID from the subnet | |
| 11:43:16 | sean-k-mooney | bauzas: you don tneed too | |
| 11:43:22 | sean-k-mooney | the segment id is in the subnet | |
| 11:43:42 | sean-k-mooney | get the subnet id from the port then look up the subnet to get the id | |
| 11:44:21 | sean-k-mooney | if the subnet does not have a segemnt id then its not a routed network | |
| 11:52:45 | bauzas | right, that's what I found | |
| 12:47:34 | alex_xu | gibi: thanks | |
| 13:17:20 | openstackgerrit | Brin Zhang proposed openstack/nova master: Replaces tenant_id with project_id from List/Update Servers APIs https://review.opendev.org/c/openstack/nova/+/764292 | |
| 13:17:20 | openstackgerrit | Brin Zhang proposed openstack/nova master: Replace all_tenants with all_projects in List Server APIs https://review.opendev.org/c/openstack/nova/+/765311 | |
| 13:43:45 | stephenfin | gibi: So who's got the 2.89 microversion? | |
| 13:43:55 | stephenfin | Just started looking at brinzhang's series above ^ | |
| 13:44:01 | gibi | stephenfin: did you get 2.88? | |
| 13:44:02 | stephenfin | (assuming you know) | |
| 13:44:08 | stephenfin | I did, yeah. That's merged | |
| 13:44:11 | gibi | cool | |
| 13:44:31 | gibi | then I think the tenant_id series was closer to merge than the vnc password series | |
| 13:44:44 | gibi | but the vnc password series was updated recently | |
| 13:44:52 | gibi | but I haven't had time to get back to it to re-review | |
| 13:45:01 | gibi | so like 70-30 for the tenant_id | |
| 13:45:03 | brinzhang | gibi, stephenfin: I would like ti use 2.90 | |
| 13:45:17 | gibi | brinzhang: which patch to use 2.90? | |
| 13:45:17 | brinzhang | make the noVNC patch pre in tenant_id | |
| 13:45:32 | gibi | OK, so first vnc and then tenant_id? | |
| 13:45:37 | brinzhang | yes | |
| 13:45:41 | gibi | brinzhang: cool, noted | |
| 13:45:57 | brinzhang | so pls review noVNC in privority | |
| 13:46:09 | gibi | brinzhang: will try | |
| 13:46:14 | gibi | (bit bussy with other pressing things) | |
| 13:46:25 | brinzhang | and I rebase the tenatn_id patch recently | |
| 13:46:32 | brinzhang | gibi: thanks | |
| 13:47:41 | gibi | brinzhang: I see you made the patches depend on each other so there is now a single chain of patches staring with vnc and then continued with tenant_id | |
| 13:47:46 | gibi | that is helpful | |
| 13:47:48 | gibi | thanks for that | |
| 13:48:19 | brinzhang | gibi: I would like we can merge the cyborg shelve/unshelve too, it's too long for me to concern it | |
| 13:48:21 | gibi | stephenfin: I guess you got your answer, the vnc patch is pretty small | |
| 13:48:32 | gibi | brinzhang: I know | |
| 13:48:39 | gibi | brinzhang: that is on my plate too | |
| 13:48:53 | gibi | alex pinged me with some questions in the unshelve patch | |
| 13:49:12 | stephenfin | gibi: brinzhang: Okay, I'll focus my immediate efforts on that instead so. Thanks | |
| 13:49:38 | brinzhang | yes, alex_xu's question may we can resoulve by a bug fix, may it's a common issue | |
| 13:49:39 | gibi | stephenfin: thanks. I made one review round on vnc before but had some concerns so I will need to go back to that too | |
| 13:49:49 | brinzhang | stephenfin: thanks | |
| 14:01:39 | stephenfin | gibi, lyarwood, sean-k-mooney: if you have some spare time today, my final four (for now anyway) feature gap patches for OSC would benefit from nova dev eyes https://review.opendev.org/q/project:openstack/python-openstackclient+is:open+owner:stephenfin%2540redhat.com+branch:master+file:compute+is:mergeable | |
| 14:02:06 | stephenfin | I'll try update mriedem's OSC gap etherpad at some point this week to ensure everything is captured. I think I've got most of it so far | |
| 14:02:25 | gibi | stephenfin: ack, it is open in my queue | |
| 14:03:35 | stephenfin | gibi: Thanks | |
| 14:08:13 | lyarwood | yup same | |
| 15:21:34 | openstackgerrit | Merged openstack/python-novaclient master: Fix undesirable raw Python error https://review.opendev.org/c/openstack/python-novaclient/+/769082 | |
| 15:42:32 | sean-k-mooney | stephenfin reviewed suggestions inline | |
| 15:43:08 | sean-k-mooney | stephenfin: nothing major, more or less looks fine | |
| 15:58:14 | openstackgerrit | Balazs Gibizer proposed openstack/nova master: DNM try to replace retry with libvirt event in detach https://review.opendev.org/c/openstack/nova/+/770246 | |
| 15:58:20 | gibi | lyarwood: sorry it was a hectic day. I my current attempt on the detach event ^^ it passes some volume and interface detach tempest cases locally and the logs seems OK. But I have no way to generate slow libvirt related scenarios ^^ | |
| 15:58:26 | gibi | and again I have to leave the keyboard | |
| 15:58:37 | gibi | so we can talk about it maybe today | |
| 15:59:31 | gibi | melwitt: ^^ | |
| 15:59:41 | gibi | s/today/tomorrow/ | |
| 16:01:40 | sean-k-mooney | gibi: in func test you could jsut add a sleep right | |
| 16:02:23 | lyarwood | sean-k-mooney: the race is within QEMU so that isn't going to help unfortunatley | |
| 16:02:44 | sean-k-mooney | well its not really | |
| 16:03:10 | sean-k-mooney | the race was we were just retyrin gon a timer while the async operation in qemu was running | |
| 16:04:01 | sean-k-mooney | we cant recreate that behavior but we can simulate a slow libvirt event | |
| 16:04:16 | sean-k-mooney | it depends on what gibi actully wanted to recreate | |
| 16:05:21 | lyarwood | I don't see any value in simulating a slow event tbh, we should just be asserting that we don't retry the detach without getting a _FAILED event back from libvirt etc | |
| 16:05:46 | sean-k-mooney | lyarwood: well we could do that by posing the detach call | |
| 16:06:38 | sean-k-mooney | e.g. after the first invocation make it soe it raises an error if called again until we fail or complete | |
| 16:07:36 | sean-k-mooney | anyway im going to jsut review what gibi has instead of speculating | |
| 16:33:20 | bauzas | sean-k-mooney: quick question, do you know if an instance has 2 ports, the instance should use the same subnet for routed networks ? | |
| 16:35:24 | bauzas | nevermind, I'll provide a FIXME | |
| 16:36:18 | sean-k-mooney | no it can have different subnets in that case but they should be on the same segment | |
| 16:36:28 | sean-k-mooney | well technically that is not required either | |
| 16:36:36 | sean-k-mooney | but the host need to be connect ot both segment | |
| 16:36:46 | sean-k-mooney | if the subnets are form different ones | |
| 16:37:14 | sean-k-mooney | we need a host that would be in the intersection of all segments required by the ports | |
| 16:37:38 | sean-k-mooney | the simpelst case of tha twould be both ports are in the same subnet/segment | |
| 16:37:59 | sean-k-mooney | if the host has multiple nic however you can have other toplogies that are valid | |
| 17:09:59 | stephenfin | sean-k-mooney: addressed your comments on https://review.opendev.org/q/project:openstack/python-openstackclient+is:open+owner:stephenfin%2540redhat.com+branch:master+file:compute+is:mergeable | |
| 17:10:05 | stephenfin | let me know if anything isn't clear :) | |
| 17:12:15 | sean-k-mooney | thanks ill rereview them now | |
| 17:24:49 | sean-k-mooney | stephenfin: im +1 on the 4 patches now | |
| 17:24:58 | stephenfin | thanks! | |
| 17:25:00 | sean-k-mooney | thanks for respinning them | |
| 17:25:13 | stephenfin | nw, good to have other eyes on them | |