Earlier  
Later
New Search
Posted Nick Remark
#openstack-nova - 2021-01-12
13:44:44 gibi but the vnc password series was updated recently
13:44:52 gibi but I haven't had time to get back to it to re-review
13:45:01 gibi so like 70-30 for the tenant_id
13:45:03 brinzhang gibi, stephenfin: I would like ti use 2.90
13:45:17 gibi brinzhang: which patch to use 2.90?
13:45:17 brinzhang make the noVNC patch pre in tenant_id
13:45:32 gibi OK, so first vnc and then tenant_id?
13:45:37 brinzhang yes
13:45:41 gibi brinzhang: cool, noted
13:45:57 brinzhang so pls review noVNC in privority
13:46:09 gibi brinzhang: will try
13:46:14 gibi (bit bussy with other pressing things)
13:46:25 brinzhang and I rebase the tenatn_id patch recently
13:46:32 brinzhang gibi: thanks
13:47:41 gibi brinzhang: I see you made the patches depend on each other so there is now a single chain of patches staring with vnc and then continued with tenant_id
13:47:46 gibi that is helpful
13:47:48 gibi thanks for that
13:48:19 brinzhang gibi: I would like we can merge the cyborg shelve/unshelve too, it's too long for me to concern it
13:48:21 gibi stephenfin: I guess you got your answer, the vnc patch is pretty small
13:48:32 gibi brinzhang: I know
13:48:39 gibi brinzhang: that is on my plate too
13:48:53 gibi alex pinged me with some questions in the unshelve patch
13:49:12 stephenfin gibi: brinzhang: Okay, I'll focus my immediate efforts on that instead so. Thanks
13:49:38 brinzhang yes, alex_xu's question may we can resoulve by a bug fix, may it's a common issue
13:49:39 gibi stephenfin: thanks. I made one review round on vnc before but had some concerns so I will need to go back to that too
13:49:49 brinzhang stephenfin: thanks
14:01:39 stephenfin gibi, lyarwood, sean-k-mooney: if you have some spare time today, my final four (for now anyway) feature gap patches for OSC would benefit from nova dev eyes https://review.opendev.org/q/project:openstack/python-openstackclient+is:open+owner:stephenfin%2540redhat.com+branch:master+file:compute+is:mergeable
14:02:06 stephenfin I'll try update mriedem's OSC gap etherpad at some point this week to ensure everything is captured. I think I've got most of it so far
14:02:25 gibi stephenfin: ack, it is open in my queue
14:03:35 stephenfin gibi: Thanks
14:08:13 lyarwood yup same
15:21:34 openstackgerrit Merged openstack/python-novaclient master: Fix undesirable raw Python error https://review.opendev.org/c/openstack/python-novaclient/+/769082
15:42:32 sean-k-mooney stephenfin reviewed suggestions inline
15:43:08 sean-k-mooney stephenfin: nothing major, more or less looks fine
15:58:14 openstackgerrit Balazs Gibizer proposed openstack/nova master: DNM try to replace retry with libvirt event in detach https://review.opendev.org/c/openstack/nova/+/770246
15:58:20 gibi lyarwood: sorry it was a hectic day. I my current attempt on the detach event ^^ it passes some volume and interface detach tempest cases locally and the logs seems OK. But I have no way to generate slow libvirt related scenarios ^^
15:58:26 gibi and again I have to leave the keyboard
15:58:37 gibi so we can talk about it maybe today
15:59:31 gibi melwitt: ^^
15:59:41 gibi s/today/tomorrow/
16:01:40 sean-k-mooney gibi: in func test you could jsut add a sleep right
16:02:23 lyarwood sean-k-mooney: the race is within QEMU so that isn't going to help unfortunatley
16:02:44 sean-k-mooney well its not really
16:03:10 sean-k-mooney the race was we were just retyrin gon a timer while the async operation in qemu was running
16:04:01 sean-k-mooney we cant recreate that behavior but we can simulate a slow libvirt event
16:04:16 sean-k-mooney it depends on what gibi actully wanted to recreate
16:05:21 lyarwood I don't see any value in simulating a slow event tbh, we should just be asserting that we don't retry the detach without getting a _FAILED event back from libvirt etc
16:05:46 sean-k-mooney lyarwood: well we could do that by posing the detach call
16:06:38 sean-k-mooney e.g. after the first invocation make it soe it raises an error if called again until we fail or complete
16:07:36 sean-k-mooney anyway im going to jsut review what gibi has instead of speculating
16:33:20 bauzas sean-k-mooney: quick question, do you know if an instance has 2 ports, the instance should use the same subnet for routed networks ?
16:35:24 bauzas nevermind, I'll provide a FIXME
16:36:18 sean-k-mooney no it can have different subnets in that case but they should be on the same segment
16:36:28 sean-k-mooney well technically that is not required either
16:36:36 sean-k-mooney but the host need to be connect ot both segment
16:36:46 sean-k-mooney if the subnets are form different ones
16:37:14 sean-k-mooney we need a host that would be in the intersection of all segments required by the ports
16:37:38 sean-k-mooney the simpelst case of tha twould be both ports are in the same subnet/segment
16:37:59 sean-k-mooney if the host has multiple nic however you can have other toplogies that are valid
17:09:59 stephenfin sean-k-mooney: addressed your comments on https://review.opendev.org/q/project:openstack/python-openstackclient+is:open+owner:stephenfin%2540redhat.com+branch:master+file:compute+is:mergeable
17:10:05 stephenfin let me know if anything isn't clear :)
17:12:15 sean-k-mooney thanks ill rereview them now
17:24:49 sean-k-mooney stephenfin: im +1 on the 4 patches now
17:24:58 stephenfin thanks!
17:25:00 sean-k-mooney thanks for respinning them
17:25:13 stephenfin nw, good to have other eyes on them
17:47:49 lyarwood ~./
17:48:11 lyarwood *sigh*
17:48:13 sean-k-mooney hehe is that a way or a failed change of directory
17:48:26 lyarwood nope, my connection to my VPS stalled again
17:48:32 lyarwood at least it appears to
17:48:49 lyarwood no updates on my screen session until I ssh back in etc
17:49:42 lyarwood ~. was just to force ssh to die so I could log back in, looks like I borked the first attmept ^_^
17:50:22 sean-k-mooney ah right the sential escape sequence
17:50:35 sean-k-mooney i normally only have to use that with ipmi or some other serial connection
17:50:54 sean-k-mooney but i have had that kill my putty conenction before where they were the same
17:51:21 lyarwood yeah I think there's something up with the network on my vps (DO) tbh this has been going on since before the break
17:53:29 sean-k-mooney two days before we got back my server decided to not negociate full duplex connectivity. networking proablems that just happen are awsome...
17:53:48 sean-k-mooney my home cloud is now running on 2 usb 1 gig nics
17:55:10 sean-k-mooney huh i guess those are usb3 ports just hit 870mbps over the link lol
18:05:16 sean-k-mooney lyarwood: regarding the ppc unit test failures
18:05:48 sean-k-mooney lyarwood: could we set an arch env var and use a fixture to mock out different architetures
18:06:25 sean-k-mooney then jsut run OS_ARCH=ppc tox -e py3
18:06:52 sean-k-mooney we will see if ibm can run the tests it sound like they will be able too
18:07:06 sean-k-mooney but if not im wondering if we can fake it in the jobs
18:09:44 sean-k-mooney i guess that would not be quite the same as running them on ppc64le
18:30:45 lyarwood sean-k-mooney: sorry was afk, that could be one way of fixing this, https://review.opendev.org/c/openstack/nova/+/769920 has shown a huge number of tests calling arch.from_host that would need to be covered.
18:34:20 sean-k-mooney ya although we generally expect the test to be written as arch independent event if its called underneath
18:35:05 sean-k-mooney so even if they call it doesnt mean its wrong nessacaraly but im not suprrised to se the libvirt tests there
18:35:31 sean-k-mooney we check the arch on startup of the libvirt driver
18:37:49 lyarwood That should be easy enough to resolve there
18:38:21 lyarwood mock it out to return x86_64 and just override it for the specific tests for other archs
18:38:51 lyarwood anyway, that's something for closer to M3 unless others want to pick it up
20:31:23 artom Is there a list of the "tags" available in nova-specs (or specs in general I suppose)
20:31:40 artom Specifically I want something to indicate an aside, or annex (but inline, and not at the end)
20:56:04 openstackgerrit sean mooney proposed openstack/nova master: use psycopg2 binary instead of source package https://review.opendev.org/c/openstack/nova/+/770473
20:56:04 openstackgerrit sean mooney proposed openstack/nova master: add constants for vnic type vdpa https://review.opendev.org/c/openstack/nova/+/770474
20:56:20 sean-k-mooney artom: maybe just put it in ()
21:22:00 openstackgerrit Artom Lifshitz proposed openstack/nova-specs master: `socket` PCI NUMA-affinity Policy https://review.opendev.org/c/openstack/nova-specs/+/765551
21:27:45 artom sean-k-mooney, so apparently seealso is a thing, though I'm the first one to use it in Nova.

Earlier   Later