| Posted | Nick | Remark | |
|---|---|---|---|
| #openstack-nova - 2021-01-08 | |||
| 15:25:31 | openstackgerrit | Balazs Gibizer proposed openstack/nova master: Enable mypy on scheduler/utils.py https://review.opendev.org/c/openstack/nova/+/769942 | |
| 15:27:09 | openstackgerrit | Balazs Gibizer proposed openstack/nova master: Support interface attach with QoS ports https://review.opendev.org/c/openstack/nova/+/756530 | |
| 15:41:38 | dansmith | sean-k-mooney: do you know of any instances where we use the raw keystoneauth stuff to just make a quick call to another service, but with all the request info we got (i.e user token etc)? | |
| 15:41:48 | dansmith | looking for something to copy | |
| 15:43:14 | sean-k-mooney | maybe in the ironic code | |
| 15:43:28 | dansmith | okay I think we used to talk to placement like that didn't we? | |
| 15:43:45 | sean-k-mooney | maybe but i think palcment now uses the sdk | |
| 15:43:51 | dansmith | although not with the user's token I guess | |
| 15:43:54 | dansmith | yeah I know it does now | |
| 15:45:25 | sean-k-mooney | https://github.com/openstack/nova/blob/master/nova/virt/ironic/client_wrapper.py#L66-L73 | |
| 15:45:33 | dansmith | ironic lazy-imports ironic client, but it's also not using the user's token right? | |
| 15:45:51 | sean-k-mooney | ya that im not sure about it look like that is using the config options | |
| 15:47:33 | sean-k-mooney | dansmith: i guess for ironic and placment we just use admin tokens since they are normally admin only apis right | |
| 15:47:42 | sean-k-mooney | so we just use the configs | |
| 15:47:43 | dansmith | right | |
| 15:47:58 | sean-k-mooney | do you need ksa or could you just use the sdk | |
| 15:48:26 | dansmith | well, I'm trying to PoC something where glance calls to itself, | |
| 15:48:39 | sean-k-mooney | too answer you question though i dont know off the top of my head | |
| 15:48:46 | dansmith | so I could just import glanceclient, but I really just need to replay an http call so it seems a little heavy | |
| 15:49:05 | dansmith | ack | |
| 15:49:45 | sean-k-mooney | ah ok | |
| 15:53:57 | openstackgerrit | Elod Illes proposed openstack/nova stable/stein: [stable-only] Fix lower-constraints job https://review.opendev.org/c/openstack/nova/+/769809 | |
| 15:55:34 | stephenfin | dansmith: https://review.opendev.org/c/openstack/nova/+/706295/7/nova/network/neutron.py | |
| 15:55:55 | stephenfin | If I understood you correctly, I think that's what we do for port bindings in neutron | |
| 15:57:11 | dansmith | stephenfin: ah, yeah that might be it, thanks | |
| 15:57:39 | dansmith | I figured even though neutron was the right pattern, that everything would be through the client and not helpful, | |
| 15:57:48 | dansmith | but that chunk is like "in case of no client support, break glass" :) | |
| 16:05:20 | jawad_axd | @sean-k-mooney Apparently , hw_video_model doest work with none' anymore? I am getting invalid metadata.. I guess valid options are just graphics adapter model with this property.. | |
| 16:06:04 | openstackgerrit | Balazs Gibizer proposed openstack/nova master: Enable mypy on scheduler/report.py https://review.opendev.org/c/openstack/nova/+/765152 | |
| 16:06:18 | openstackgerrit | Balazs Gibizer proposed openstack/nova master: Remove unused Instance method https://review.opendev.org/c/openstack/nova/+/757615 | |
| 16:06:46 | gibi | stephenfin: I've resolved you comments in the qos interace attach series | |
| 16:06:58 | stephenfin | gibi: ack, I'll take a look straight after this meeting | |
| 16:07:05 | gibi | cool, thanks | |
| 16:36:53 | gibi | stephenfin: went through once again the db migration series, all my questions are answered or fixed so I'm positive all along the series | |
| 16:37:06 | stephenfin | great, thank you | |
| 16:37:13 | gibi | good job! | |
| 16:37:38 | sean-k-mooney | jawad_axd: what release are you on? | |
| 16:38:30 | sean-k-mooney | jawad_axd:https://github.com/openstack/nova/blob/46899968619e4ea0ff2ab380977619bb29578d43/nova/objects/fields.py#L562-L573 | |
| 16:39:13 | sean-k-mooney | jawad_axd: i added none in train https://github.com/openstack/nova/commit/35a591d33d8b1a6c30bf40ddc48a07715fd87339 | |
| 16:39:21 | jawad_axd | I am using stein | |
| 16:39:35 | sean-k-mooney | ah you one release too old | |
| 16:40:40 | sean-k-mooney | in your case i think your only really choice other then upgrading is to force the applciations to use the gpu via there config or runtime options | |
| 16:41:29 | sean-k-mooney | jawad_axd: the image properties are defiend in oslo versions objects so there is no way to backport support for none with out upgrade issues | |
| 16:42:29 | sean-k-mooney | form a nova poing of view the phsyical gpu passthough is working correctly but the applciaiton is just not selceting the correct gpu of the two avaiable | |
| 16:45:07 | jawad_axd | Alright.. | |
| 16:46:17 | sean-k-mooney | sorry cant help more but once nova has succfully booted the vm and made the gpu avaiable to it its jobs is basically done | |
| 16:56:55 | jawad_axd | @sean-k-mooney Atleast I got to know, passthrough is working fine. Now I need to figure out how to use it as default. Thanks | |
| 16:57:41 | sean-k-mooney | depending on your application it will differ | |
| 16:58:06 | sean-k-mooney | games/rendering applcaition like blender usally have an option you can set in there menu or config files | |
| 16:58:47 | sean-k-mooney | with tensorflow for example you can do https://www.tensorflow.org/api_docs/python/tf/config/set_visible_devices | |
| 17:16:50 | sean-k-mooney | huh did people know you can click on the files and expand them in the top review windows | |
| 17:16:56 | sean-k-mooney | https://review.opendev.org/c/openstack/python-openstackclient/+/762396 | |
| 17:17:28 | sean-k-mooney | so if you click on any of the boxes beside the file links not on the links it will render the files in a dropdown | |
| 17:18:28 | sean-k-mooney | that is what thos little arrows on earch row on the right are signaling | |
| 17:20:42 | sean-k-mooney | stephenfin: im 50:50 on that reviw by the way. it looks liek ti will work correctly but lee basically made the same point about doing it in parralel in as i did in my first review | |
| 17:21:07 | sean-k-mooney | stephenfin: i think we should do that optimisation but im kind of with gibi that it could be a follow up patch | |
| 17:22:55 | sean-k-mooney | i know you are also looking a provideing a generic way to do the waits in https://review.opendev.org/c/openstack/osc-lib/+/762503 | |
| 17:23:26 | sean-k-mooney | so i can see why you would prefer not to do it direcly in https://review.opendev.org/c/openstack/python-openstackclient/+/762396 and wait to reuse that | |
| 17:43:42 | sean-k-mooney | melwitt: just responed to your questions in https://review.opendev.org/c/openstack/nova/+/769614 i proably wont respin that today but let me know if you still have questions | |
| 17:44:32 | sean-k-mooney | melwitt: how urgent is the downstream issue by the way. this is not a escalation or anything is it | |
| 17:45:20 | sean-k-mooney | e.g. it can wait until next week while i update a spec | |
| 18:16:20 | sean-k-mooney | artom: responded to your questions in https://review.opendev.org/c/openstack/nova-specs/+/764999 | |
| 18:20:34 | dansmith | stephenfin: that wasn't exactly what I wanted, but definitely led me down the path to success, so thanks | |
| 18:25:50 | stephenfin | good stuff | |
| 18:30:16 | gmann | stephenfin: thanks for update, +2 on https://review.opendev.org/c/openstack/nova/+/764040/8 | |
| 18:30:35 | gmann | gibi: ^^ | |
| 18:31:25 | gmann | stephenfin: I added comment for policy updates also in case you missed it - https://review.opendev.org/c/openstack/nova/+/765798/3 | |
| 18:37:26 | stephenfin | gmann: ack, will take a look first thing monday. Thanks! | |
| 18:38:31 | gmann | sure. just pinged in case it was missed. have a happy weekend! | |
| 18:47:09 | sean-k-mooney | gmann: when you have time can you confirm i am uderstanding what we are doing for cyborg correctly and that this is fine for vdpa too https://review.opendev.org/c/openstack/nova-specs/+/764999/2/specs/wallaby/approved/libvirt-vdpa-support.rst#41 | |
| 18:47:43 | sean-k-mooney | you welcom to review the whole spec obviously but this spcificly would be good for you to weigh in on | |
| 18:47:43 | gmann | sean-k-mooney: sure | |
| 18:48:32 | sean-k-mooney | basiclaly blocking live migation with vdpa using a 403 until we support it to avoid a micorverion bump on the api side | |
| 18:49:40 | sean-k-mooney | when ever qemu actully add suport we would still need to check the compute capabliteis and may fail if both the source and destionation nodes are not updated | |
| 18:50:27 | sean-k-mooney | so even if we had a microversion saying nova supports this we would no know if your qemu supported it so i dont think a microverion is the way to go since there are no api changes involved | |
| 18:53:08 | artom | sean-k-mooney, yep, got the email. I'll be honest, understand your changes and replying will go to next week :) | |
| 18:53:16 | artom | *understanding | |
| 20:21:28 | sean-k-mooney | artom: no worries | |
| 21:04:13 | melwitt | sean-k-mooney: thanks! it's not an escalation and I hope it doesn't become one | |
| 22:55:42 | openstackgerrit | Ghanshyam proposed openstack/nova master: Fix ForbiddenWithAccelerators to HTTPForbidden for shelve API https://review.opendev.org/c/openstack/nova/+/770007 | |
| #openstack-nova - 2021-01-09 | |||
| 02:00:32 | openstackgerrit | Merged openstack/nova stable/train: [stable-only] Cap bandit to 1.6.2 and raise hacking, flake8 and stestr https://review.opendev.org/c/openstack/nova/+/766171 | |
| 08:56:09 | openstackgerrit | Takashi Natsume proposed openstack/nova stable/train: Fix a hacking test https://review.opendev.org/c/openstack/nova/+/767793 | |
| #openstack-nova - 2021-01-10 | |||
| 01:54:39 | openstackgerrit | Merged openstack/nova stable/victoria: Warn when starting services with older than N-1 computes https://review.opendev.org/c/openstack/nova/+/761923 | |
| 03:15:51 | openstackgerrit | Merged openstack/nova master: Remove dead code from SchedulerReportClient https://review.opendev.org/c/openstack/nova/+/769467 | |
| 06:54:27 | openstackgerrit | Merged openstack/nova master: only wait for plugtime events in pre-live-migration https://review.opendev.org/c/openstack/nova/+/767368 | |
| 09:50:26 | openstackgerrit | Merged openstack/nova stable/ussuri: Update pci stat pools based on PCI device changes https://review.opendev.org/c/openstack/nova/+/761701 | |
| 17:58:48 | openstackgerrit | Ghanshyam proposed openstack/nova master: Fix ForbiddenWithAccelerators to HTTPForbidden for shelve API https://review.opendev.org/c/openstack/nova/+/770007 | |
| 17:59:39 | openstackgerrit | Ghanshyam proposed openstack/nova master: Fix ForbiddenWithAccelerators to HTTPForbidden for shelve API https://review.opendev.org/c/openstack/nova/+/770007 | |
| #openstack-nova - 2021-01-11 | |||
| 00:14:47 | pfire | resized a powered off instance, cannot start instance while it is in task state resize finish, cannot confirmresize while in vmstate stopped | |
| 00:15:12 | pfire | should a resize have been allowed in the first place | |
| 00:28:48 | prometheanfire | got around it by manually starting the instance, then resize could be confirmed (but instance showed up as stopped), and then once instance start was issued the instance was restarted (instead of the state being updated in the db) | |
| 05:39:27 | openstackgerrit | Brin Zhang proposed openstack/python-novaclient master: Fix nova live migration task failed due respone value changed https://review.opendev.org/c/openstack/python-novaclient/+/769872 | |
| 05:39:28 | openstackgerrit | Brin Zhang proposed openstack/python-novaclient master: Microversion 2.88: Replace tenant* with project* in usage* commands https://review.opendev.org/c/openstack/python-novaclient/+/769675 | |
| 05:39:28 | openstackgerrit | Brin Zhang proposed openstack/python-novaclient master: Microversion 2.88: Replace tenant* with project* in quota* commands https://review.opendev.org/c/openstack/python-novaclient/+/769869 | |
| 05:39:29 | openstackgerrit | Brin Zhang proposed openstack/python-novaclient master: DNM/TEST: function test https://review.opendev.org/c/openstack/python-novaclient/+/770060 | |
| 07:33:08 | openstackgerrit | Brin Zhang proposed openstack/python-novaclient master: Microversion 2.88: Replace tenant* with project* in quota* commands https://review.opendev.org/c/openstack/python-novaclient/+/769869 | |
| 07:36:33 | openstackgerrit | Hemanth N proposed openstack/nova stable/train: Update pci stat pools based on PCI device changes https://review.opendev.org/c/openstack/nova/+/761725 | |
| 08:14:06 | openstackgerrit | Brin Zhang proposed openstack/python-novaclient master: Microversion 2.88: Replace tenant* with project* in limits commands https://review.opendev.org/c/openstack/python-novaclient/+/770065 | |
| 08:19:55 | gibi | good morning nova | |
| 08:26:14 | chengsheng1 | Please help review the code: https://review.opendev.org/c/openstack/nova/+/762330/ | |