| Posted | Nick | Remark | |
|---|---|---|---|
| #openstack-nova - 2021-01-08 | |||
| 17:16:56 | sean-k-mooney | https://review.opendev.org/c/openstack/python-openstackclient/+/762396 | |
| 17:17:28 | sean-k-mooney | so if you click on any of the boxes beside the file links not on the links it will render the files in a dropdown | |
| 17:18:28 | sean-k-mooney | that is what thos little arrows on earch row on the right are signaling | |
| 17:20:42 | sean-k-mooney | stephenfin: im 50:50 on that reviw by the way. it looks liek ti will work correctly but lee basically made the same point about doing it in parralel in as i did in my first review | |
| 17:21:07 | sean-k-mooney | stephenfin: i think we should do that optimisation but im kind of with gibi that it could be a follow up patch | |
| 17:22:55 | sean-k-mooney | i know you are also looking a provideing a generic way to do the waits in https://review.opendev.org/c/openstack/osc-lib/+/762503 | |
| 17:23:26 | sean-k-mooney | so i can see why you would prefer not to do it direcly in https://review.opendev.org/c/openstack/python-openstackclient/+/762396 and wait to reuse that | |
| 17:43:42 | sean-k-mooney | melwitt: just responed to your questions in https://review.opendev.org/c/openstack/nova/+/769614 i proably wont respin that today but let me know if you still have questions | |
| 17:44:32 | sean-k-mooney | melwitt: how urgent is the downstream issue by the way. this is not a escalation or anything is it | |
| 17:45:20 | sean-k-mooney | e.g. it can wait until next week while i update a spec | |
| 18:16:20 | sean-k-mooney | artom: responded to your questions in https://review.opendev.org/c/openstack/nova-specs/+/764999 | |
| 18:20:34 | dansmith | stephenfin: that wasn't exactly what I wanted, but definitely led me down the path to success, so thanks | |
| 18:25:50 | stephenfin | good stuff | |
| 18:30:16 | gmann | stephenfin: thanks for update, +2 on https://review.opendev.org/c/openstack/nova/+/764040/8 | |
| 18:30:35 | gmann | gibi: ^^ | |
| 18:31:25 | gmann | stephenfin: I added comment for policy updates also in case you missed it - https://review.opendev.org/c/openstack/nova/+/765798/3 | |
| 18:37:26 | stephenfin | gmann: ack, will take a look first thing monday. Thanks! | |
| 18:38:31 | gmann | sure. just pinged in case it was missed. have a happy weekend! | |
| 18:47:09 | sean-k-mooney | gmann: when you have time can you confirm i am uderstanding what we are doing for cyborg correctly and that this is fine for vdpa too https://review.opendev.org/c/openstack/nova-specs/+/764999/2/specs/wallaby/approved/libvirt-vdpa-support.rst#41 | |
| 18:47:43 | sean-k-mooney | you welcom to review the whole spec obviously but this spcificly would be good for you to weigh in on | |
| 18:47:43 | gmann | sean-k-mooney: sure | |
| 18:48:32 | sean-k-mooney | basiclaly blocking live migation with vdpa using a 403 until we support it to avoid a micorverion bump on the api side | |
| 18:49:40 | sean-k-mooney | when ever qemu actully add suport we would still need to check the compute capabliteis and may fail if both the source and destionation nodes are not updated | |
| 18:50:27 | sean-k-mooney | so even if we had a microversion saying nova supports this we would no know if your qemu supported it so i dont think a microverion is the way to go since there are no api changes involved | |
| 18:53:08 | artom | sean-k-mooney, yep, got the email. I'll be honest, understand your changes and replying will go to next week :) | |
| 18:53:16 | artom | *understanding | |
| 20:21:28 | sean-k-mooney | artom: no worries | |
| 21:04:13 | melwitt | sean-k-mooney: thanks! it's not an escalation and I hope it doesn't become one | |
| 22:55:42 | openstackgerrit | Ghanshyam proposed openstack/nova master: Fix ForbiddenWithAccelerators to HTTPForbidden for shelve API https://review.opendev.org/c/openstack/nova/+/770007 | |
| #openstack-nova - 2021-01-09 | |||
| 02:00:32 | openstackgerrit | Merged openstack/nova stable/train: [stable-only] Cap bandit to 1.6.2 and raise hacking, flake8 and stestr https://review.opendev.org/c/openstack/nova/+/766171 | |
| 08:56:09 | openstackgerrit | Takashi Natsume proposed openstack/nova stable/train: Fix a hacking test https://review.opendev.org/c/openstack/nova/+/767793 | |
| #openstack-nova - 2021-01-10 | |||
| 01:54:39 | openstackgerrit | Merged openstack/nova stable/victoria: Warn when starting services with older than N-1 computes https://review.opendev.org/c/openstack/nova/+/761923 | |
| 03:15:51 | openstackgerrit | Merged openstack/nova master: Remove dead code from SchedulerReportClient https://review.opendev.org/c/openstack/nova/+/769467 | |
| 06:54:27 | openstackgerrit | Merged openstack/nova master: only wait for plugtime events in pre-live-migration https://review.opendev.org/c/openstack/nova/+/767368 | |
| 09:50:26 | openstackgerrit | Merged openstack/nova stable/ussuri: Update pci stat pools based on PCI device changes https://review.opendev.org/c/openstack/nova/+/761701 | |
| 17:58:48 | openstackgerrit | Ghanshyam proposed openstack/nova master: Fix ForbiddenWithAccelerators to HTTPForbidden for shelve API https://review.opendev.org/c/openstack/nova/+/770007 | |
| 17:59:39 | openstackgerrit | Ghanshyam proposed openstack/nova master: Fix ForbiddenWithAccelerators to HTTPForbidden for shelve API https://review.opendev.org/c/openstack/nova/+/770007 | |
| #openstack-nova - 2021-01-11 | |||
| 00:14:47 | pfire | resized a powered off instance, cannot start instance while it is in task state resize finish, cannot confirmresize while in vmstate stopped | |
| 00:15:12 | pfire | should a resize have been allowed in the first place | |
| 00:28:48 | prometheanfire | got around it by manually starting the instance, then resize could be confirmed (but instance showed up as stopped), and then once instance start was issued the instance was restarted (instead of the state being updated in the db) | |
| 05:39:27 | openstackgerrit | Brin Zhang proposed openstack/python-novaclient master: Fix nova live migration task failed due respone value changed https://review.opendev.org/c/openstack/python-novaclient/+/769872 | |
| 05:39:28 | openstackgerrit | Brin Zhang proposed openstack/python-novaclient master: Microversion 2.88: Replace tenant* with project* in usage* commands https://review.opendev.org/c/openstack/python-novaclient/+/769675 | |
| 05:39:28 | openstackgerrit | Brin Zhang proposed openstack/python-novaclient master: Microversion 2.88: Replace tenant* with project* in quota* commands https://review.opendev.org/c/openstack/python-novaclient/+/769869 | |
| 05:39:29 | openstackgerrit | Brin Zhang proposed openstack/python-novaclient master: DNM/TEST: function test https://review.opendev.org/c/openstack/python-novaclient/+/770060 | |
| 07:33:08 | openstackgerrit | Brin Zhang proposed openstack/python-novaclient master: Microversion 2.88: Replace tenant* with project* in quota* commands https://review.opendev.org/c/openstack/python-novaclient/+/769869 | |
| 07:36:33 | openstackgerrit | Hemanth N proposed openstack/nova stable/train: Update pci stat pools based on PCI device changes https://review.opendev.org/c/openstack/nova/+/761725 | |
| 08:14:06 | openstackgerrit | Brin Zhang proposed openstack/python-novaclient master: Microversion 2.88: Replace tenant* with project* in limits commands https://review.opendev.org/c/openstack/python-novaclient/+/770065 | |
| 08:19:55 | gibi | good morning nova | |
| 08:26:14 | chengsheng1 | Please help review the code: https://review.opendev.org/c/openstack/nova/+/762330/ | |
| 08:27:24 | openstackgerrit | Brin Zhang proposed openstack/python-novaclient master: Microversion 2.88: Replace tenant* with project* in usage* commands https://review.opendev.org/c/openstack/python-novaclient/+/769675 | |
| 08:32:18 | openstackgerrit | Manik Sidana proposed openstack/nova master: Fix typo https://review.opendev.org/c/openstack/nova/+/770067 | |
| 08:36:24 | openstackgerrit | Manik Sidana proposed openstack/nova master: Fix typo in warning message https://review.opendev.org/c/openstack/nova/+/770067 | |
| 08:38:20 | openstackgerrit | Brin Zhang proposed openstack/python-novaclient master: Microversion 2.88: Replace tenant* with project* in quota* commands https://review.opendev.org/c/openstack/python-novaclient/+/769869 | |
| 08:44:34 | brinzhang | gibi: good morning, noVNC patch has updated, pls review again https://review.opendev.org/c/openstack/nova/+/622336 | |
| 08:45:17 | gibi | brinzhang: ack, | |
| 09:33:00 | gibi | lyarwood: if you have time could you check a tempest failure like https://storage.gra.cloud.ovh.net/v1/AUTH_dcaab5e32b234d56b626f72581e3644c/zuul_opendev_logs_637/764040/8/check/nova-live-migration/637f5c6/testr_results.html based on logstash we have similar failures pretty fequrently | |
| 09:33:05 | gibi | http://logstash.openstack.org/#dashboard/file/logstash.json?query=message%3A%5C%22failed%20to%20reach%20available%20status%20(current%20detaching)%20within%20the%20required%20time%5C%22 | |
| 09:43:44 | lyarwood | gibi: oh fun, not this again | |
| 09:43:55 | gibi | monday fun | |
| 09:44:02 | lyarwood | Device detach failed for vdb: Unable to detach the device from the live config. | |
| 09:44:19 | gibi | I'm not sure that it is only that test case failing with the same symptome | |
| 09:52:27 | openstackgerrit | Brin Zhang proposed openstack/python-novaclient master: Microversion 2.88: Replace tenant* with project* in limits commands https://review.opendev.org/c/openstack/python-novaclient/+/770065 | |
| 09:55:49 | openstackgerrit | Brin Zhang proposed openstack/python-novaclient master: Microversion 2.88: Replace tenant* with project* in quota* commands https://review.opendev.org/c/openstack/python-novaclient/+/769869 | |
| 09:57:11 | lyarwood | gibi: melwitt wrote an ER query for this before the break in https://bugs.launchpad.net/nova/+bug/1882521 | |
| 09:57:13 | openstack | Launchpad bug 1882521 in OpenStack Compute (nova) ussuri "Failing device detachments on Focal" [Undecided,New] | |
| 09:58:08 | lyarwood | gibi / melwitt ; looks different to the previous hit within libvirtd logs at least, we only see the device_del commands from libvirtd to QEMU and not the DEVICE_DELETED events being emitted by QEMU. | |
| 09:58:28 | lyarwood | gibi / melwitt ; we can try increasing the initial wait again but that's another hackaround | |
| 09:59:22 | lyarwood | gibi / melwitt ; the ultimate fix for this is waiting for libvirtd to emit events when detaching devices https://review.opendev.org/c/openstack/nova/+/749929 | |
| 10:00:56 | gibi | lyarwood: could I help with ^^ somehow? | |
| 10:01:29 | openstackgerrit | Brin Zhang proposed openstack/python-novaclient master: Microversion 2.88: Replace tenant* with project* in limits commands https://review.opendev.org/c/openstack/python-novaclient/+/770065 | |
| 10:01:52 | lyarwood | gibi: I don't have any cycles to spend on it at the moment, feel free to take a look if you do, that's only a PoC change I was using to work out how to tap into the event framework within the libvirt driver | |
| 10:02:39 | gibi | lyarwood: ack, I might need more context but I will take a look at that patch | |
| 10:03:39 | lyarwood | gibi: https://libvirt.org/html/libvirt-libvirt-domain.html#virDomainEventID & https://libvirt.org/html/libvirt-libvirt-domain.html#virConnectDomainEventDeviceRemovedCallback for the libvirt specific docs | |
| 10:21:29 | gibi | lyarwood: was this https://review.opendev.org/c/openstack/nova/+/749827 superseeded by https://review.opendev.org/c/openstack/nova/+/755799 ? | |
| 10:22:51 | lyarwood | gibi: yeah sorry I'm not sure why I eneded up with a different change there | |
| 10:23:01 | gibi | lyarwood: OK I will drop that | |
| 10:24:30 | lyarwood | gibi: one thing I've just noticed, there's a 5 second gap between the first and second device_del request in libvirtd, my change was supposed to add a 10 second delay | |
| 10:25:41 | gibi | I think on master we have inc_sleep_time=10 | |
| 10:26:26 | lyarwood | yeah I think the retry decorator only uses that for the second wait, ./me checks | |
| 10:31:32 | gibi | it seem so | |
| 10:32:02 | openstackgerrit | Lucas Alvares Gomes proposed openstack/nova master: DO NOT REVIEW: Test OVN devstack module https://review.opendev.org/c/openstack/nova/+/748226 | |
| 10:32:50 | openstackgerrit | Balazs Gibizer proposed openstack/nova master: WIP/DNM libvirt: Start emitting DeviceRemovedEvent and DeviceRemovalFailedEvent events https://review.opendev.org/c/openstack/nova/+/749929 | |
| 10:37:34 | openstackgerrit | Balazs Gibizer proposed openstack/nova master: WIP/DNM libvirt: Start emitting DeviceRemovedEvent and DeviceRemovalFailedEvent events https://review.opendev.org/c/openstack/nova/+/749929 | |
| 10:40:44 | openstackgerrit | Balazs Gibizer proposed openstack/nova master: WIP/DNM libvirt: Start emitting DeviceRemovedEvent and DeviceRemovalFailedEvent events https://review.opendev.org/c/openstack/nova/+/749929 | |
| 11:44:24 | stephenfin | gibi: Could you re +2 this, please? https://review.opendev.org/c/openstack/nova/+/769520/ | |
| 11:46:22 | gibi | stephenfin: oops I missed that, done noew | |
| 11:46:23 | gibi | now | |
| 11:46:35 | stephenfin | Also, gibi, lyarwood, sean-k-mooney: I addressed your concerns on that OSC change, I think https://review.opendev.org/c/openstack/python-openstackclient/+/762396/ | |
| 11:46:59 | stephenfin | gibi++ thanks | |
| 11:48:55 | gibi | I'm +1 on the osc patch too | |
| 11:49:04 | stephenfin | hurrah | |
| 11:55:03 | gibi | gmann: I still see tempest failing with "Multiple possible networks found, use a Network ID to be more specific." on master. e.g.: https://74ab9f21dcdd2e895607-6eadae60e9a1b03c6789f42d51c17d3a.ssl.cf2.rackcdn.com/756894/5/check/nova-next/1fb33ef/testr_results.html | |
| 11:56:38 | gibi | dansmith: I have two tempest failures in test_glance_direct_import_image_to_specific_stores[id-82fb131a-dd2b-11ea-aec7-340286b6c574] I tried to create a logstash signature for it but I failed | |
| 11:56:46 | gibi | 1) https://zuul.opendev.org/t/openstack/build/4a78ba5901474187a3bdc49cacf84b47/logs | |
| 11:56:52 | gibi | 2) https://zuul.opendev.org/t/openstack/build/9488788b59904e6f9bc1280f13fc0a6b/logs | |
| 11:57:09 | gibi | dansmith: is this the timeout failure you mentioned on the last week's meeting? | |
| 11:57:36 | sean-k-mooney | stephenfin: +1 also | |
| 12:02:11 | gibi | dansmith: I also see a full nova-ceph-multistore job timeout here https://zuul.opendev.org/t/openstack/build/8807547b038b4dd983fd7e0bb4cb4b40 it might be related too | |
| 13:45:32 | openstackgerrit | Balazs Gibizer proposed openstack/nova master: Refactor ResourceRequest constructor https://review.opendev.org/c/openstack/nova/+/769720 | |
| 13:46:56 | openstackgerrit | Balazs Gibizer proposed openstack/nova master: Support interface attach with QoS ports https://review.opendev.org/c/openstack/nova/+/756530 | |