Earlier  
Later
New Search
Posted Nick Remark
#openstack-nova - 2020-11-26
14:37:25 sean-k-mooney although it need a refresh
14:38:25 sean-k-mooney nicely done
14:38:42 gibi sean-k-mooney: never used that plugin, tampermonkey works for me in both firefox and chrome :)
14:39:05 sean-k-mooney its the one stephenfin recommened to me a while back
14:39:29 sean-k-mooney i might try tamer monkey but it works so i have not bothered changing
14:39:55 gibi sean-k-mooney: if it works for you in that tool, then I don't think tampermonkey adds too much.
14:39:57 sean-k-mooney gibi: we proaly coudl convert your script into a plugin for gerrit and run it automatically
14:40:23 gibi sean-k-mooney: I don't know how the CI table worked in the old gerrit, I assume that was a plugin that injected the js script from server side
14:40:40 sean-k-mooney gibi: well i have to refewsh as on page load is somethigns before the commensts are there but i could modify it to work more reliably if i really cared
14:40:58 sean-k-mooney gibi: i think it was in java
14:41:08 sean-k-mooney gibi: gerrit used to be written in gwt
14:41:19 sean-k-mooney so i think it was rendered server side
14:41:23 gibi sean-k-mooney: my script should wait for the comments to load with a PerformanceObserver
14:41:39 gibi listening to fetch evnets
14:41:41 gibi events
14:41:51 sean-k-mooney it does seam to work 90% of the time
14:41:52 gibi still there is a bit of sleep added to be sure
14:42:00 sean-k-mooney maybe im just impatiat
14:42:14 sean-k-mooney its working pretty well
14:42:41 sean-k-mooney it does not render the other cis but its good enough for now anyway
14:46:15 sean-k-mooney ah i just need to change if (author == 'Zuul'){
14:46:26 sean-k-mooney to allso look for author that have CI in there name
14:53:15 openstackgerrit Lee Yarwood proposed openstack/nova master: DNM test test_attach_scsi_disk_with_config_drive fix https://review.opendev.org/c/openstack/nova/+/764339
14:57:40 gibi sean-k-mooney: yeah, it is does a lot less than the original CI table
14:57:54 gibi I did a minimum implementation that is already useful for me
14:58:10 sean-k-mooney yep
14:58:48 sean-k-mooney i already refactored it to take the autohr name as an arge just need to get teh list of autor names and loop over all the ci ones
14:58:53 sean-k-mooney althouhg i might no bother
14:59:03 sean-k-mooney at least right now
14:59:25 sean-k-mooney it works fine
14:59:36 elod lyarwood: fyi, I've added a single note to today's nova meeting Stable Branches topic about the live-migration job. feel free to extend the list, either on the wiki or at the meeting :) https://wiki.openstack.org/wiki/Meetings/Nova
15:00:17 sean-k-mooney gibi: its a good basis however for creating plugin to do it server side if we want to long term
15:01:26 gibi sean-k-mooney: I'm not sure how the client side DOM structure relates to the server side java components. I'm happy if my hack helps for the side side work but I have no idea :)
15:01:54 sean-k-mooney gibi: the new gerrrit does not use java anymore
15:02:07 sean-k-mooney its entirely reriten using polomer.js
15:02:20 sean-k-mooney so its all html and javascript calling the rest api
15:03:10 sean-k-mooney its been a wile since i touched polomer but basically it implements web components whcich allows you do define new html tags
15:03:48 sean-k-mooney then you can just place those in the dom and it will invoke the javascript,css and html content of the compnet and redner it
15:05:28 sean-k-mooney i am supper rusty on my web dev but i used to work on https://kato.translatorswb.org/ before i started on openstack
15:05:49 sean-k-mooney it used polemebr.dart + php and twitter bootstracp fo rthe ui
15:06:28 sean-k-mooney ... https://github.com/dart-archive/polymer-dart
15:06:39 sean-k-mooney which was the dart binding to polymer.js
15:08:16 sean-k-mooney anyway it might be a nice side project to work on if i do ill keep you posted
15:09:59 stephenfin Or we finally add the checks plugin to Gerrit. I left a note on the etherpad https://etherpad.opendev.org/p/gerrit-3.2-post-upgrade-notes
15:10:35 sean-k-mooney ya we could but that would require cis to report slightly differently and its still experimental
15:11:01 sean-k-mooney the cheks api is not stable technically in gerrit yet as far as i know
15:22:21 stephenfin it's a plugin so I doubt it ever will be
15:29:09 tacco sean-k-mooney: i foundout something new about my more than 64CPUs issue
15:31:06 tacco i realized with ubuntu i did not had any issues. All 248CPUs up and running with a ubuntu cloud image. strange that fedora and debian buster had the same limitations in here. in debian it 100%is CUSTOM_NR_CPUS_DEFAULT kernel-parameter, could be overrided by grub with nr_cpus=248 but this won't work even if it should work. thats verry strange et all. :D
15:33:16 sean-k-mooney the virt kernels proably have it set smaller or somthign as an optimaisation
15:36:56 tacco yes could be, try to verrify what happens if i build the kernel by myself without that limitations. *crossingFingers*
15:52:22 stephenfin elod: Thank you :)
15:53:48 elod stephenfin: np :)
15:54:39 stephenfin sean-k-mooney: is this a race? If this call fails, we don't roll back the requests on the pools that passed https://github.com/openstack/nova/blob/master/nova/pci/stats.py#L419-L421
15:54:41 elod I didn't see your recheck, so I've double-stamped it :P
15:54:43 stephenfin a bug
15:54:50 stephenfin elod: all good!
15:55:10 stephenfin I checked. It was that eventlet issue. Nothing to be worried about, thankfully
15:55:10 elod :]
15:57:38 gibi nova meeting starts in 2 minutes
16:03:40 sean-k-mooney gibi: for got to add teh flavor metadata thing to the adgenda but we can cover it at the end
16:04:19 sean-k-mooney stephenfin: we operate on a copy in the filter
16:04:32 gibi sean-k-mooney: sure
16:04:44 gibi sean-k-mooney: I will ping you at the end
16:04:44 sean-k-mooney ill take a look after the nova meeting
16:09:37 sean-k-mooney stephenfin: that is only used in the schduler
16:10:02 sean-k-mooney at least i think that is the case checking
16:10:29 sean-k-mooney stephenfin: https://codesearch.opendev.org/?q=apply_requests&i=nope&files=&excludeFiles=&repos=
16:10:37 sean-k-mooney stephenfin: so its only operating on the copy
16:10:51 sean-k-mooney https://github.com/openstack/nova/blob/master/nova/pci/stats.py#L399
16:11:05 sean-k-mooney actully not that copy.
16:12:00 sean-k-mooney its called form https://github.com/openstack/nova/blob/5dbfbe692f7de33069746e4dc07bcbf0dd33f656/nova/scheduler/host_manager.py#L279
16:14:53 sean-k-mooney stephenfin: the ecpetion will propagate all the way up to select destiatnions in the conductor and keep koning
16:15:14 stephenfin okay, so effectively we'll never hit it
16:15:35 sean-k-mooney basically we never save the object to the db in that path
16:16:28 sean-k-mooney for spawn it is caught here https://github.com/openstack/nova/blob/5dbfbe692f7de33069746e4dc07bcbf0dd33f656/nova/conductor/manager.py#L676
16:18:10 sean-k-mooney look like there is similar logic for unshelve ectra in the other 3 places its called
16:40:11 openstackgerrit Merged openstack/nova stable/train: docs: Rework the PCI passthrough guides https://review.opendev.org/c/openstack/nova/+/764327
16:40:26 openstackgerrit Merged openstack/nova stable/train: docs: Change order of PCI configuration steps https://review.opendev.org/c/openstack/nova/+/764328
16:41:06 tacco yes could be, try to verrify what happens if i build the kernel by myself without that limitations. *crossingFingers*
17:03:31 openstackgerrit Lee Yarwood proposed openstack/nova master: nova-live-migration: Disable *all* virt services during negative tests https://review.opendev.org/c/openstack/nova/+/762623
18:13:04 openstackgerrit Stephen Finucane proposed openstack/nova master: pci: Add a '_filter_pools' helper function https://review.opendev.org/c/openstack/nova/+/764375
18:13:04 openstackgerrit Stephen Finucane proposed openstack/nova master: pci: Improve docs for '_filter_*' functions https://review.opendev.org/c/openstack/nova/+/764376
18:13:05 openstackgerrit Stephen Finucane proposed openstack/nova master: pci: Add logging for filtering https://review.opendev.org/c/openstack/nova/+/764377
18:13:18 stephenfin sean-k-mooney: Cast an eye over that an tell me if you think it's reasonable
18:13:39 stephenfin gibi: You might have thoughts on it
18:13:42 stephenfin ...too
18:17:11 stephenfin lyarwood: If you're around later/tomorrow, could you look at https://review.opendev.org/c/openstack/nova/+/751367/2 again? I don't think I need to anything more on it since elod's comment was just that, rather than a request for change
18:18:50 sean-k-mooney stephenfin: related bug i can proably live with but sure ill take a look
18:20:58 sean-k-mooney stephenfin: ok so you are not printing all the pools that are filtered out
18:21:14 sean-k-mooney i think that is a resonable approch
18:21:30 sean-k-mooney ill review it properly in a bit but skimming it looks fine
18:42:12 sean-k-mooney stephenfin: done. let me know what you think of the generator idea but over all i think it looks fine
#openstack-nova - 2020-11-27
04:35:58 gmann lyarwood: seems like tempest test cleanup change did not fix the nova-ceph-multistore job - https://storage.gra.cloud.ovh.net/v1/AUTH_dcaab5e32b234d56b626f72581e3644c/zuul_opendev_logs_548/763487/3/check/nova-ceph-multistore/5480be7/testr_results.html
04:53:21 gmann lyarwood: got the issue, its class level vs test level cleanup. fixing in https://review.opendev.org/c/openstack/tempest/+/764407
04:55:30 openstackgerrit Ghanshyam Mann proposed openstack/nova master: DNM: testing fix for nova-ceph-multistore https://review.opendev.org/c/openstack/nova/+/764408
04:55:51 gmann testing here ^^
07:06:23 gmann lyarwood: its late here, going to bed. I pinged other tempest core to merger the tempest change once it pass the job in nova testing patch
07:56:49 openstackgerrit Wenping Song proposed openstack/nova master: Nova supports password encrypted VNC https://review.opendev.org/c/openstack/nova/+/622336
08:09:10 bauzas good morning Nova

Earlier   Later