Earlier  
Later
New Search
Posted Nick Remark
#openstack-nova - 2020-11-27
04:55:51 gmann testing here ^^
07:06:23 gmann lyarwood: its late here, going to bed. I pinged other tempest core to merger the tempest change once it pass the job in nova testing patch
07:56:49 openstackgerrit Wenping Song proposed openstack/nova master: Nova supports password encrypted VNC https://review.opendev.org/c/openstack/nova/+/622336
08:09:10 bauzas good morning Nova
08:36:32 openstackgerrit Wenping Song proposed openstack/nova master: Cyborg shelve/unshelve support https://review.opendev.org/c/openstack/nova/+/729563
08:55:28 lyarwood gmann: ack thanks, I'm not sure if that's going to work tbh, it looks like my patch was working the DELETEs were just racing
08:59:00 lyarwood gmann: on my bad, the DELETE I was looking at was for the volume attachment
09:10:33 openstackgerrit Wenping Song proposed openstack/nova master: Cyborg shelve/unshelve support https://review.opendev.org/c/openstack/nova/+/729563
09:12:14 lyarwood gmann: okay that's also failing still
09:13:02 openstackgerrit Lee Yarwood proposed openstack/nova master: zuul: Skip test_attach_scsi_disk_with_config_drive in nova-ceph-multistore https://review.opendev.org/c/openstack/nova/+/764424
09:13:35 lyarwood gibi / stephenfin / bauzas ; ^ lets skip this test in the ceph job for now until we get is passing again
09:20:55 lyarwood that regex was written prior to coffe on a Friday morning after a long week and several night shifts with my child so lets wait to see if it skips the test before +W'ing ;)
09:23:54 bauzas lyarwood: I don't see a problem with the regex itself, and the test name is long so I'm pretty sure we don't remove another test too
09:24:39 bauzas https://github.com/openstack/tempest/search?q=test_attach_scsi_disk_with_config_drive proves me I was right
09:25:31 lyarwood cool thansk
09:25:33 lyarwood thanks*
09:34:02 openstackgerrit Lee Yarwood proposed openstack/nova stable/victoria: zuul: Introduce nova-evacuate https://review.opendev.org/c/openstack/nova/+/764430
09:34:03 openstackgerrit Lee Yarwood proposed openstack/nova stable/victoria: zuul: Merge nova-evacuate into nova-multinode-live-migration https://review.opendev.org/c/openstack/nova/+/764431
09:34:04 openstackgerrit Lee Yarwood proposed openstack/nova stable/victoria: zuul: Replace nova-live-migration with zuulv3 jobs https://review.opendev.org/c/openstack/nova/+/764432
09:34:19 lyarwood elod: ^ okay here's my attempt to unfsck the stable/victoria evacuation stuff, one of the squashed changes hasn't merged on master yet but I just wanted to start testing
09:37:52 elod lyarwood: wow, sounds good! thanks for the info (and for working on the issue :)), I'll look at them
09:38:05 elod \o/
09:38:48 lyarwood elod: np and apologies it took so long
09:39:02 Yumeng hi bauzas gibi and sean-k-mooney: about the cyborg-owned vgpu support spec, I've discussed all your concerns with the team and updated the spec https://review.opendev.org/c/openstack/nova-specs/+/750116/ please see my update at your convenience.
09:59:25 lyarwood stephenfin: random one, any idea why we trigger a full gate run with docs changes?
10:00:18 lyarwood https://review.opendev.org/c/openstack/nova/+/764329 - I guess it isn't full but still that's odd.
10:02:24 lyarwood oh fail
10:02:30 lyarwood you changed nova/conf/pci.py
10:02:36 lyarwood that triggers things, ignore me
10:07:57 stephenfin yeah
10:08:03 stephenfin it's the conf change that triggers things
10:08:13 stephenfin I considered changing the regex to skip changes to that but that's silly
10:10:00 lyarwood yeah I'm not sure it's worth it
10:14:57 stephenfin lyarwood: I've held off on +W of that, as requested. Feel free to stick it on if it works as expected
10:24:10 openstackgerrit Alexandre arents proposed openstack/nova master: libvirt: Abort live-migration job when monitoring fails https://review.opendev.org/c/openstack/nova/+/764435
10:24:14 lyarwood stephenfin: ack will do thanks
10:33:29 stephenfin holy s***, I always forget just how rough nova.pci is /o\
10:33:39 stephenfin some serious TLC needed there
11:35:27 openstackgerrit Stephen Finucane proposed openstack/nova master: pci: Improve docs for '_filter_*' functions https://review.opendev.org/c/openstack/nova/+/764376
11:35:27 openstackgerrit Stephen Finucane proposed openstack/nova master: pci: Add logging for filtering https://review.opendev.org/c/openstack/nova/+/764377
11:35:28 openstackgerrit Stephen Finucane proposed openstack/nova master: pci: Improve testing of 'nova.pci.request' module https://review.opendev.org/c/openstack/nova/+/764446
11:40:02 sean-k-mooney Yumeng: thanks im onloy around for a few hours today but ill try to review it before i leave
11:41:10 sean-k-mooney stephenfin: it is rough but it works. we very very rarely have any bugs or issue related to nova.pci we the bugs related to sriov/pci are almost always in the compute manager
11:41:58 Yumeng sean-k-mooney: That's great! Thanks sean. Just take your time. ^^
12:08:28 openstackgerrit Lee Yarwood proposed openstack/nova stable/victoria: zuul: Replace nova-live-migration with zuulv3 jobs https://review.opendev.org/c/openstack/nova/+/764432
12:23:04 openstackgerrit Stephen Finucane proposed openstack/nova stable/train: Validate id as integer for os-aggregates https://review.opendev.org/c/openstack/nova/+/764455
12:26:47 openstackgerrit Stephen Finucane proposed openstack/nova stable/stein: Validate id as integer for os-aggregates https://review.opendev.org/c/openstack/nova/+/764308
12:28:06 stephenfin hmm, cherry-picking via the web UI is curiously slow now :-\
12:28:39 openstackgerrit Stephen Finucane proposed openstack/nova stable/rocky: Validate id as integer for os-aggregates https://review.opendev.org/c/openstack/nova/+/764309
12:29:49 openstackgerrit Stephen Finucane proposed openstack/nova stable/queens: Validate id as integer for os-aggregates https://review.opendev.org/c/openstack/nova/+/764310
12:46:04 lyarwood FWIW git-review is also slow for me so I assume it's something on the backend
12:46:10 lyarwood not the ui
12:51:44 gibi yeah, the whole UI feels slower than the old one
13:27:57 openstackgerrit Merged openstack/nova master: zuul: Skip test_attach_scsi_disk_with_config_drive in nova-ceph-multistore https://review.opendev.org/c/openstack/nova/+/764424
13:32:59 openstackgerrit Lee Yarwood proposed openstack/nova master: compute: Don't detach volumes when RescheduledException raised without retry https://review.opendev.org/c/openstack/nova/+/757894
13:34:02 openstackgerrit Lee Yarwood proposed openstack/nova master: zuul: Add devstack-plugin-ceph-compute-local-ephemeral to experimental https://review.opendev.org/c/openstack/nova/+/743220
13:35:21 openstackgerrit Lee Yarwood proposed openstack/nova master: libvirt: Skip encryption metadata lookups if secret already exists on host https://review.opendev.org/c/openstack/nova/+/764246
13:35:52 openstackgerrit Lee Yarwood proposed openstack/nova master: nova-live-migration: Disable *all* virt services during negative tests https://review.opendev.org/c/openstack/nova/+/762623
13:42:03 openstackgerrit Lee Yarwood proposed openstack/nova stable/victoria: zuul: Skip test_attach_scsi_disk_with_config_drive in nova-ceph-multistore https://review.opendev.org/c/openstack/nova/+/764464
13:42:15 lyarwood ^ elod / bauzas ; looks like we also need this on stable/victoria
13:42:27 bauzas roger.
13:46:43 elod ACK
14:55:47 stephenfin lyarwood, elod: In theory, we could now +2 +W all stable backports and they won't be able to merge because of dansmith's cherry-pick test, right?
14:56:08 elod stephenfin: why? O.o
14:56:44 elod how do you mean?
14:56:58 stephenfin take this change (thanks for the reviews, btw :)) https://review.opendev.org/c/openstack/nova/+/764455
14:57:20 stephenfin that's for stable/train but I've got (identical) cherry-picks all the way back to stable/queens
14:58:00 stephenfin so in theory, if you were reviewing one, you could in theory review the others at the same time, and they'd have to merge in series because the pep8 job would fail otherwise
14:58:12 stephenfin *they'd have to merge in order
14:58:33 elod oh, so you mean we could +2+W in advance back till queens in this case
14:58:52 stephenfin Yup, exactly. That's much clearer :)
14:59:33 elod yeah, I guess that should work :]
15:00:32 elod I'm thinking now on cases where "somehowe-something-changes" but we don't realize and just recheck and patch merges...
15:02:12 elod hmmm. in case of a change in newer branch, the hash changes, so in that case it won't be a problem, on older branches the patches simply does not merge due to the same cherry-pick check
15:02:21 elod so that should work too
15:03:13 stephenfin yup, that what I'm thinking anyway
15:04:06 elod we just have to be careful that the hash of patch on branch N+1 is really there in patch on branch N
15:04:37 stephenfin well I assume the test does that
15:04:52 stephenfin what we need to validate is that the hash corresponds to what we think it does (as opposed to an arbitrary patch)
15:05:17 elod no, it just checks whether the listed hashes are merged somewhere
15:05:41 gmann lyarwood: humm that seems like image deleted with server seems, debugging
15:05:58 stephenfin oh, so you could in theory cherry-pick staight from master to e.g. stable/queens and it would pass
15:06:03 stephenfin okay, yeah, that's one to watch for
15:06:18 stephenfin but once we do that...! :D
15:09:32 elod :) well, we could try that... ;)
15:11:16 openstackgerrit Ghanshyam Mann proposed openstack/nova master: Revert "zuul: Skip test_attach_scsi_disk_with_config_drive in nova-ceph-multistore" https://review.opendev.org/c/openstack/nova/+/764311
15:48:00 lyarwood /o\ sorry ssh timed out and I didn't notice
15:48:29 lyarwood gmann: yeah that's odd
15:49:18 gmann lyarwood: or we are not passing the image_id for delete. testing changes in above revert, it should work now
15:50:00 gmann now i am passing image_id and image should be found and deleted correctly
15:51:38 lyarwood gmann: kk
15:52:09 lyarwood stephenfin: https://review.opendev.org/c/openstack/nova/+/764246 - would you mind taking a swing at that before you call it a day?
15:52:31 stephenfin sure
15:52:48 lyarwood https://review.opendev.org/c/openstack/nova/+/743220 is also trival
15:53:38 gmann gibi: as placement is under Nova now, this enable to notify the placement changes on nova channel too - https://review.opendev.org/c/openstack/project-config/+/764469
15:54:07 gmann as next step we can probably merge both channel (delete placement channel basically )
15:54:54 gmann while pushing few policy patches in placement i realized there are not bot to nova channel
15:56:26 openstackgerrit Lee Yarwood proposed openstack/nova stable/victoria: zuul: Replace nova-live-migration with zuulv3 jobs https://review.opendev.org/c/openstack/nova/+/764432
15:57:28 lyarwood elod / bauzas ; okay the ceph change is now squashed into that change so we hopefully have a passing gate again on stable/victoria
15:57:41 bauzas all good

Earlier   Later