| Posted | Nick | Remark | |
|---|---|---|---|
| #openstack-nova - 2020-11-25 | |||
| 10:49:14 | bauzas | anyway, back to the topic | |
| 10:49:26 | bauzas | gibi: anything worth for me reviewing about this ? | |
| 10:49:41 | gibi | midcycle up in the french alps! | |
| 10:49:43 | bauzas | I guess the WSGI config enablement is on its way, right? | |
| 10:50:37 | gibi | WSGI needs a second core https://review.opendev.org/c/openstack/nova/+/763750 | |
| 10:51:02 | bauzas | ack, looking | |
| 10:52:32 | gibi | there is a non-dangerous func test refactor here https://review.opendev.org/c/openstack/nova/+/758210 | |
| 10:52:49 | owalsh | gibi: re every conductor being a superconductor when api db is set - is that going to affect scaling? | |
| 10:53:37 | gibi | owalsh: good question | |
| 10:57:14 | gibi | owalsh: you might be able to still do conductor separation | |
| 10:57:43 | owalsh | still have mq/db sharding I guess | |
| 10:58:31 | owalsh | and only the cell local computes are on the same mq | |
| 10:58:33 | gibi | owalsh: if you have a conductor with an [api_database]connection config, but only configured to listen to the cell message bus, then that conductor will not get super-conductor type requests, but still can handled the upcalls for the late affinity check | |
| 10:59:06 | gibi | I would love dansmith to confirm this ^^ | |
| 10:59:13 | gibi | as I'm not 100% certain | |
| 11:00:03 | owalsh | gibi: ack, thanks. Makes sense. I'll make a note to check with dansmith in 2021 :-) | |
| 11:01:44 | bauzas | gibi: just begging for a relnote in https://review.opendev.org/c/openstack/nova/+/763750 so we don't hide this fancy feature | |
| 11:02:15 | bauzas | owalsh: gibi: I missed that point, dan is off until next year ? woah. | |
| 11:03:56 | gibi | bauzas: he told me that he will be away on PTO from this week until end of the year | |
| 11:04:11 | bauzas | that's good to know | |
| 11:04:29 | gibi | bauzas: I can add a reno for the sys.argv patch sure | |
| 11:04:35 | bauzas | I'm still facing unexpected and weird issues with the RPC API bump, I guess I'll defer it until he returns | |
| 11:04:52 | bauzas | because I'm out of steam on finding the problem | |
| 11:09:23 | openstackgerrit | Wenping Song proposed openstack/nova master: Nova supports password encrypted VNC https://review.opendev.org/c/openstack/nova/+/622336 | |
| 11:24:47 | openstackgerrit | Balazs Gibizer proposed openstack/nova master: Support sys.argv in wsgi app https://review.opendev.org/c/openstack/nova/+/763750 | |
| 11:24:55 | gibi | bauzas: now with a reno ^^ | |
| 11:31:22 | gibi | bauzas: also if you are in a review mood, there is another test refactor series here. This is a bit bigger though https://review.opendev.org/q/topic:%22remove-fake-notifier%22+(status:open%20OR%20status:merged) | |
| 11:39:17 | gibi | bauzas: and here is some testcoverage restored as a neutron bug has been fixed https://review.opendev.org/c/openstack/nova/+/755995 | |
| 11:42:22 | gibi | lyarwood: +2d https://review.opendev.org/c/openstack/nova/+/757894 then I realized the we have a possibly related fresh bug in the untriaged list https://bugs.launchpad.net/nova/+bug/1905224 | |
| 11:42:22 | openstack | Launchpad bug 1905224 in OpenStack Compute (nova) "bfv instance create failed due to insufficient resources, the volume is always attaching" [Undecided,New] | |
| 11:42:46 | lyarwood | gibi: looking | |
| 11:43:03 | gibi | "fresh" as it is reported from Pike | |
| 11:43:06 | lyarwood | gibi:`I am in pike version` | |
| 11:43:08 | lyarwood | yeah lol | |
| 11:43:24 | gibi | fresh means freshly opened :D | |
| 11:43:28 | gibi | sorry | |
| 11:43:59 | lyarwood | so that's https://review.opendev.org/c/openstack/nova/+/743220 I think | |
| 11:45:26 | openstackgerrit | Merged openstack/nova master: Use _evacuate_server helper in func test https://review.opendev.org/c/openstack/nova/+/758210 | |
| 11:47:06 | gibi | lyarwood: thanks! | |
| 14:00:34 | lyarwood | stephenfin: https://github.com/openstack/nova/blob/e035ff4079c2cc6b32db1f637a3e3a816c2af191/nova/api/validation/extra_specs/hw.py#L73-L77 - any reason we can't point at the o.vo types for this list of enums? https://github.com/openstack/nova/blob/e035ff4079c2cc6b32db1f637a3e3a816c2af191/nova/objects/fields.py#L271-L277 | |
| 14:00:56 | lyarwood | stephenfin: just wiring up a validator for my ephemeral encryption spec and didn't want to duplicate things between the two | |
| 14:01:17 | stephenfin | None that I'm aware of. I simply didn't think to | |
| 14:01:48 | lyarwood | stephenfin: kk, might give it a go in a FUP | |
| 14:23:22 | openstackgerrit | Takashi Natsume proposed openstack/nova master: doc: Fix rendering in the PTL guide https://review.opendev.org/c/openstack/nova/+/764175 | |
| 14:26:09 | stephenfin | elod: lyarwood: Do you think you could look through https://review.opendev.org/q/topic:%2522bug/1879878%2522+status:open+branch:stable/train this week? The stable/ussuri patches landed some time ago | |
| 14:26:29 | stephenfin | (https://review.opendev.org/q/topic:%2522bug/1879878%2522+status:merged+branch:stable/ussuri for reference) | |
| 14:26:44 | lyarwood | stephenfin: ack, can I trade https://review.opendev.org/c/openstack/nova/+/757894 | |
| 14:26:55 | stephenfin | fair | |
| 14:27:27 | lyarwood | stephenfin: FWIW you were previously +2 on this but I can't see the vote since the upgrade | |
| 14:27:32 | lyarwood | weird | |
| 14:27:50 | stephenfin | I was thinking I'd reviewed this previously | |
| 14:28:15 | gibi | lyarwood: there is a show all messages button | |
| 14:28:32 | stephenfin | ahhh | |
| 14:28:35 | stephenfin | good spot | |
| 14:28:40 | gibi | the new gerrit only shows the last X message in the log by default | |
| 14:30:20 | elod | stephenfin: i've gone through them a while ago, i don't remember exactly, but I think there is some patch that I would appriciate if some other stable core would also review, hence I gave +1 only | |
| 14:31:28 | stephenfin | Hmm, I wonder are there any other stable cores around this week? Mel and Dan are both out, afaik | |
| 14:31:43 | elod | (and maybe not all the patches were merged yet at that time, but if you say now they are, then I'll have another look :)) | |
| 14:32:13 | stephenfin | Perhaps I can answer any questions if it's to do with the functionality itself? | |
| 14:32:24 | lyarwood | elod: I think you were waiting for review on the bugfix itself, I've got that open now | |
| 14:33:40 | lyarwood | oh no you had comments in there | |
| 14:33:50 | lyarwood | stephenfin: https://review.opendev.org/c/openstack/nova/+/751367 | |
| 14:34:11 | elod | yeah, that's the one, just wanted to link that | |
| 14:34:20 | lyarwood | https://review.opendev.org/c/openstack/nova/+/751367/2/nova/compute/manager.py#4527 sorry | |
| 14:34:48 | elod | but I have to read my comments as I've forgotten already what I wrote :) | |
| 14:35:27 | stephenfin | Ah, I thought that was more of a note to self than a request for change. I can clarify the conflict in the commit message, sure | |
| 14:35:30 | elod | yes, I have to get used to the new gerrit UI too o:) | |
| 14:36:43 | stephenfin | Although, for the sake of potentially saving me some effort, I'm not wrong in saying the cross-cell resize patches are the culprit. I'm just less specific than I could be :) | |
| 14:39:09 | lyarwood | gibi: https://review.opendev.org/c/openstack/nova/+/758971 - btw forgot to ask for a review of this releasenote update now that the device detach issue is resolved | |
| 14:40:09 | gibi | lyarwood: on a call but look at it after it | |
| 14:40:50 | lyarwood | gibi: ack thanks, no rush. | |
| 14:51:36 | gibi | lyarwood: good catch +A | |
| 15:01:07 | gmann | gibi: fixed your comment on https://review.opendev.org/c/openstack/nova/+/762721 | |
| 15:03:42 | gibi | gmann: thanks +2 | |
| 15:03:54 | gmann | thanks | |
| 15:25:59 | stephenfin | bauzas: Think you could look at https://review.opendev.org/c/openstack/nova/+/756549/ if you're in a reviewing mood? | |
| 15:26:18 | bauzas | stephenfin: I'm always up for reviewinh | |
| 15:26:55 | bauzas | that's like a icecream for me watching the TV while crying | |
| 15:27:11 | bauzas | and singing "all by myself" along | |
| 16:01:40 | spatel | sean-k-mooney: morning | |
| 16:11:15 | openstackgerrit | Merged openstack/nova master: releasenotes: Add fixes note for bug #1882521 https://review.opendev.org/c/openstack/nova/+/758971 | |
| 16:11:15 | openstack | bug 1882521 in OpenStack Compute (nova) "Failing device detachments on Focal" [High,Fix released] https://launchpad.net/bugs/1882521 - Assigned to Lee Yarwood (lyarwood) | |
| 16:58:18 | stephenfin | bauzas, gibi: trivial amendment to that os-hypervisors spec here https://review.opendev.org/c/openstack/nova-specs/+/764041 (I forgot about vcpus and vcpus_used | |
| 16:58:18 | openstackgerrit | Stephen Finucane proposed openstack/nova master: db: Drop models for removed services, features https://review.opendev.org/c/openstack/nova/+/698706 | |
| 16:58:19 | openstackgerrit | Stephen Finucane proposed openstack/nova master: db: Remove KeyPair model from main DB https://review.opendev.org/c/openstack/nova/+/763989 | |
| 16:58:19 | stephenfin | ) | |
| 17:23:46 | openstackgerrit | Merged openstack/nova master: Fix config option default value for sample config file https://review.opendev.org/c/openstack/nova/+/762721 | |
| 18:55:32 | openstackgerrit | Ghanshyam Mann proposed openstack/nova master: Reuse code from oslo lib for JSON policy migration https://review.opendev.org/c/openstack/nova/+/763487 | |
| 19:32:59 | openstackgerrit | Elod Illes proposed openstack/nova stable/victoria: Add upgrade check about old computes https://review.opendev.org/c/openstack/nova/+/761924 | |
| 22:25:54 | openstackgerrit | Lee Yarwood proposed openstack/nova master: WIP libvirt: Skip encryption metadata lookups if secret already exists on host https://review.opendev.org/c/openstack/nova/+/764246 | |
| #openstack-nova - 2020-11-26 | |||
| 01:04:16 | openstackgerrit | Ghanshyam Mann proposed openstack/nova master: Reuse code from oslo lib for JSON policy migration https://review.opendev.org/c/openstack/nova/+/763487 | |
| 02:00:19 | openstackgerrit | MIKI Nobuhiro proposed openstack/nova master: libvirt: add IP address to libvirt guest metadata https://review.opendev.org/c/openstack/nova/+/750552 | |
| 02:11:16 | openstackgerrit | YumengBao proposed openstack/nova-specs master: libvirt supports composing cyborg owned vGPU accelerator into domain XML https://review.opendev.org/c/openstack/nova-specs/+/750116 | |
| 02:12:49 | openstackgerrit | YumengBao proposed openstack/nova-specs master: libvirt supports composing cyborg owned vGPU accelerator into domain XML https://review.opendev.org/c/openstack/nova-specs/+/750116 | |
| 02:19:14 | openstackgerrit | MIKI Nobuhiro proposed openstack/nova-specs master: Add IP address to libvirt guest metadata https://review.opendev.org/c/openstack/nova-specs/+/760750 | |
| 08:09:31 | gibi | good morning | |
| 08:12:26 | openstackgerrit | Merged openstack/nova-specs master: Add 'vcpus', 'vcpus_used' to modernize-os-hypervisors-api spec https://review.opendev.org/c/openstack/nova-specs/+/764041 | |
| 08:23:49 | bauzas | good morning nova | |
| 09:01:24 | openstackgerrit | Brin Zhang proposed openstack/nova master: WIP:Remove tenant from List Servers APIs https://review.opendev.org/c/openstack/nova/+/764292 | |
| 09:55:01 | openstackgerrit | Lee Yarwood proposed openstack/nova master: libvirt: Skip encryption metadata lookups if secret already exists on host https://review.opendev.org/c/openstack/nova/+/764246 | |