| Posted | Nick | Remark | |
|---|---|---|---|
| #openstack-nova - 2020-11-25 | |||
| 14:00:34 | lyarwood | stephenfin: https://github.com/openstack/nova/blob/e035ff4079c2cc6b32db1f637a3e3a816c2af191/nova/api/validation/extra_specs/hw.py#L73-L77 - any reason we can't point at the o.vo types for this list of enums? https://github.com/openstack/nova/blob/e035ff4079c2cc6b32db1f637a3e3a816c2af191/nova/objects/fields.py#L271-L277 | |
| 14:00:56 | lyarwood | stephenfin: just wiring up a validator for my ephemeral encryption spec and didn't want to duplicate things between the two | |
| 14:01:17 | stephenfin | None that I'm aware of. I simply didn't think to | |
| 14:01:48 | lyarwood | stephenfin: kk, might give it a go in a FUP | |
| 14:23:22 | openstackgerrit | Takashi Natsume proposed openstack/nova master: doc: Fix rendering in the PTL guide https://review.opendev.org/c/openstack/nova/+/764175 | |
| 14:26:09 | stephenfin | elod: lyarwood: Do you think you could look through https://review.opendev.org/q/topic:%2522bug/1879878%2522+status:open+branch:stable/train this week? The stable/ussuri patches landed some time ago | |
| 14:26:29 | stephenfin | (https://review.opendev.org/q/topic:%2522bug/1879878%2522+status:merged+branch:stable/ussuri for reference) | |
| 14:26:44 | lyarwood | stephenfin: ack, can I trade https://review.opendev.org/c/openstack/nova/+/757894 | |
| 14:26:55 | stephenfin | fair | |
| 14:27:27 | lyarwood | stephenfin: FWIW you were previously +2 on this but I can't see the vote since the upgrade | |
| 14:27:32 | lyarwood | weird | |
| 14:27:50 | stephenfin | I was thinking I'd reviewed this previously | |
| 14:28:15 | gibi | lyarwood: there is a show all messages button | |
| 14:28:32 | stephenfin | ahhh | |
| 14:28:35 | stephenfin | good spot | |
| 14:28:40 | gibi | the new gerrit only shows the last X message in the log by default | |
| 14:30:20 | elod | stephenfin: i've gone through them a while ago, i don't remember exactly, but I think there is some patch that I would appriciate if some other stable core would also review, hence I gave +1 only | |
| 14:31:28 | stephenfin | Hmm, I wonder are there any other stable cores around this week? Mel and Dan are both out, afaik | |
| 14:31:43 | elod | (and maybe not all the patches were merged yet at that time, but if you say now they are, then I'll have another look :)) | |
| 14:32:13 | stephenfin | Perhaps I can answer any questions if it's to do with the functionality itself? | |
| 14:32:24 | lyarwood | elod: I think you were waiting for review on the bugfix itself, I've got that open now | |
| 14:33:40 | lyarwood | oh no you had comments in there | |
| 14:33:50 | lyarwood | stephenfin: https://review.opendev.org/c/openstack/nova/+/751367 | |
| 14:34:11 | elod | yeah, that's the one, just wanted to link that | |
| 14:34:20 | lyarwood | https://review.opendev.org/c/openstack/nova/+/751367/2/nova/compute/manager.py#4527 sorry | |
| 14:34:48 | elod | but I have to read my comments as I've forgotten already what I wrote :) | |
| 14:35:27 | stephenfin | Ah, I thought that was more of a note to self than a request for change. I can clarify the conflict in the commit message, sure | |
| 14:35:30 | elod | yes, I have to get used to the new gerrit UI too o:) | |
| 14:36:43 | stephenfin | Although, for the sake of potentially saving me some effort, I'm not wrong in saying the cross-cell resize patches are the culprit. I'm just less specific than I could be :) | |
| 14:39:09 | lyarwood | gibi: https://review.opendev.org/c/openstack/nova/+/758971 - btw forgot to ask for a review of this releasenote update now that the device detach issue is resolved | |
| 14:40:09 | gibi | lyarwood: on a call but look at it after it | |
| 14:40:50 | lyarwood | gibi: ack thanks, no rush. | |
| 14:51:36 | gibi | lyarwood: good catch +A | |
| 15:01:07 | gmann | gibi: fixed your comment on https://review.opendev.org/c/openstack/nova/+/762721 | |
| 15:03:42 | gibi | gmann: thanks +2 | |
| 15:03:54 | gmann | thanks | |
| 15:25:59 | stephenfin | bauzas: Think you could look at https://review.opendev.org/c/openstack/nova/+/756549/ if you're in a reviewing mood? | |
| 15:26:18 | bauzas | stephenfin: I'm always up for reviewinh | |
| 15:26:55 | bauzas | that's like a icecream for me watching the TV while crying | |
| 15:27:11 | bauzas | and singing "all by myself" along | |
| 16:01:40 | spatel | sean-k-mooney: morning | |
| 16:11:15 | openstackgerrit | Merged openstack/nova master: releasenotes: Add fixes note for bug #1882521 https://review.opendev.org/c/openstack/nova/+/758971 | |
| 16:11:15 | openstack | bug 1882521 in OpenStack Compute (nova) "Failing device detachments on Focal" [High,Fix released] https://launchpad.net/bugs/1882521 - Assigned to Lee Yarwood (lyarwood) | |
| 16:58:18 | stephenfin | bauzas, gibi: trivial amendment to that os-hypervisors spec here https://review.opendev.org/c/openstack/nova-specs/+/764041 (I forgot about vcpus and vcpus_used | |
| 16:58:18 | openstackgerrit | Stephen Finucane proposed openstack/nova master: db: Drop models for removed services, features https://review.opendev.org/c/openstack/nova/+/698706 | |
| 16:58:19 | openstackgerrit | Stephen Finucane proposed openstack/nova master: db: Remove KeyPair model from main DB https://review.opendev.org/c/openstack/nova/+/763989 | |
| 16:58:19 | stephenfin | ) | |
| 17:23:46 | openstackgerrit | Merged openstack/nova master: Fix config option default value for sample config file https://review.opendev.org/c/openstack/nova/+/762721 | |
| 18:55:32 | openstackgerrit | Ghanshyam Mann proposed openstack/nova master: Reuse code from oslo lib for JSON policy migration https://review.opendev.org/c/openstack/nova/+/763487 | |
| 19:32:59 | openstackgerrit | Elod Illes proposed openstack/nova stable/victoria: Add upgrade check about old computes https://review.opendev.org/c/openstack/nova/+/761924 | |
| 22:25:54 | openstackgerrit | Lee Yarwood proposed openstack/nova master: WIP libvirt: Skip encryption metadata lookups if secret already exists on host https://review.opendev.org/c/openstack/nova/+/764246 | |
| #openstack-nova - 2020-11-26 | |||
| 01:04:16 | openstackgerrit | Ghanshyam Mann proposed openstack/nova master: Reuse code from oslo lib for JSON policy migration https://review.opendev.org/c/openstack/nova/+/763487 | |
| 02:00:19 | openstackgerrit | MIKI Nobuhiro proposed openstack/nova master: libvirt: add IP address to libvirt guest metadata https://review.opendev.org/c/openstack/nova/+/750552 | |
| 02:11:16 | openstackgerrit | YumengBao proposed openstack/nova-specs master: libvirt supports composing cyborg owned vGPU accelerator into domain XML https://review.opendev.org/c/openstack/nova-specs/+/750116 | |
| 02:12:49 | openstackgerrit | YumengBao proposed openstack/nova-specs master: libvirt supports composing cyborg owned vGPU accelerator into domain XML https://review.opendev.org/c/openstack/nova-specs/+/750116 | |
| 02:19:14 | openstackgerrit | MIKI Nobuhiro proposed openstack/nova-specs master: Add IP address to libvirt guest metadata https://review.opendev.org/c/openstack/nova-specs/+/760750 | |
| 08:09:31 | gibi | good morning | |
| 08:12:26 | openstackgerrit | Merged openstack/nova-specs master: Add 'vcpus', 'vcpus_used' to modernize-os-hypervisors-api spec https://review.opendev.org/c/openstack/nova-specs/+/764041 | |
| 08:23:49 | bauzas | good morning nova | |
| 09:01:24 | openstackgerrit | Brin Zhang proposed openstack/nova master: WIP:Remove tenant from List Servers APIs https://review.opendev.org/c/openstack/nova/+/764292 | |
| 09:55:01 | openstackgerrit | Lee Yarwood proposed openstack/nova master: libvirt: Skip encryption metadata lookups if secret already exists on host https://review.opendev.org/c/openstack/nova/+/764246 | |
| 09:55:09 | lyarwood | Morning all, ^ simple backportable fix if anyone has time this morning | |
| 10:17:28 | gibi | lyarwood: looks good to me | |
| 10:35:19 | kashyap | [Something Fun] ] So ... QEMU Advent Calendar 2020 will happen, if you have any cool ideas for small disk images, let me know in PM (so as not to spoil the surprise) | |
| 10:35:47 | kashyap | What _is_ QEMU Advent Calendar? Go to the "About" section here: https://www.qemu-advent-calendar.org/2018/ | |
| 10:36:23 | kashyap | I once tried, and failed, to package a "minimal" OpenStack -- but I couldn't reduce the disk image size around 250MB :-( | |
| 10:37:28 | lyarwood | kashyap: just checkout openstack/devstack and write a systemd service to run ./stack.sh at startup ^_^ | |
| 10:37:56 | kashyap | lyarwood: See my attempt from 2014: https://kashyapc.fedorapeople.org/virt/advent-qemu/Procedure-to-create-devstack-disk-image.txt | |
| 10:37:57 | lyarwood | or is that cheating | |
| 10:38:19 | kashyap | I even tried to xz-compress the sparse image | |
| 10:39:12 | kashyap | If anyone thinks it's possible ... let me know if you're up for collaborating on it. There are still some slots for 2020 Advent Cal. | |
| 10:39:27 | kashyap | Maybe if you ruthlessly cull man pages, and other stuff out from the filesystem | |
| 10:40:32 | lyarwood | kashyap: you shouldn't need to run ./stack.sh ahead of creating the image tbh, that pulls in loads of stuff that can wait until the guest starts | |
| 10:41:02 | kashyap | lyarwood: Right; I think I tried a few variants | |
| 10:42:23 | kashyap | [And for those who're lurking and wondering ... if you want to contribute an image, here's further instructions: https://www.qemu.org/2020/11/26/qemu-advent-announce/] | |
| 10:43:12 | kashyap | lyarwood: What are the least no. of services we can get away with? [Nova, Glance, Keystone, and Neutron] -- what services can we cull further in there? | |
| 10:44:12 | kashyap | lyarwood: I think it's cheating ... to have an systemd esrvice to just run a simple 'stack.sh' :D But I'll check | |
| 11:36:10 | openstackgerrit | Stephen Finucane proposed openstack/nova stable/train: docs: Rework the PCI passthrough guides https://review.opendev.org/c/openstack/nova/+/764327 | |
| 11:36:11 | openstackgerrit | Stephen Finucane proposed openstack/nova stable/train: docs: Change order of PCI configuration steps https://review.opendev.org/c/openstack/nova/+/764328 | |
| 11:36:12 | openstackgerrit | Stephen Finucane proposed openstack/nova stable/train: docs: Clarify configuration steps for PF devices https://review.opendev.org/c/openstack/nova/+/764329 | |
| 11:36:39 | stephenfin | lyarwood, elod: Would you be able to look at those doc backports real quick? They're clean cherry-picks and doc-only ^ | |
| 11:37:05 | stephenfin | I really want the last one, but it's easier bring the other two than resolve merge conflicts IMO | |
| 12:14:41 | lyarwood | tempest.api.compute.admin.test_volume.AttachSCSIVolumeTestJSON.test_attach_scsi_disk_with_config_drive keeps failing at the moment in the ceph job | |
| 12:18:11 | lyarwood | ah right, we try to cleanup the image before the server | |
| 12:28:34 | lyarwood | https://review.opendev.org/c/openstack/tempest/+/764337 & https://bugs.launchpad.net/tempest/+bug/1905725 posted | |
| 12:28:34 | openstack | Launchpad bug 1905725 in tempest "test_attach_scsi_disk_with_config_drive fails during cleanup when using RBD for Glance and Nova" [Undecided,New] | |
| 12:32:27 | openstackgerrit | Lee Yarwood proposed openstack/nova master: DNM test test_attach_scsi_disk_with_config_drive fix https://review.opendev.org/c/openstack/nova/+/764339 | |
| 12:40:28 | gibi | fyi, if you miss the CI test result table in the new gerrit UI then http://lists.openstack.org/pipermail/openstack-discuss/2020-November/019051.html | |
| 12:42:51 | hemanth_n | Hi can you take a look at following commits https://review.opendev.org/q/topic:%2522bug/1892361%2522+(status:open) these are backports from ussuri until rocky (patches merged on master and victoria) thanks | |
| 12:44:50 | lyarwood | gibi: noice :) | |
| 12:51:19 | lyarwood | feels like I've gone back in time 10 years, we had a load of greasemonkey scripts when I was in Red Hat support to workaround the awful backend(s) we had to work with at the time | |
| 12:52:47 | gibi | lyarwood: I hacked users script like one script per year. the ability to poke the webpage is useful, but horrible to maintain such script in a changing env. | |
| 12:54:09 | gibi | and for the record I have web development, and I'm bad at it | |
| 12:54:20 | gibi | s/have/hate/ | |
| 13:14:50 | elod | stephenfin: sorry, had to run some errands, I've added them to my review queue :) | |
| 13:27:40 | gibi | I got hit by a seemingly new error. grenade fails with to boot an instance with libvirt reporting: Could not open '/dev/sda': Permission denied | |
| 13:27:45 | gibi | https://zuul.opendev.org/t/openstack/build/e74f19d3a4464868b62b5c9dd61911bc/log/controller/logs/screen-n-cpu.txt#7529 | |
| 13:28:06 | gibi | logstash shows only a one hit http://logstash.openstack.org/#dashboard/file/logstash.json?query=message%3A%5C%22Could%20not%20open%20'%2Fdev%2Fsda'%3A%20Permission%20denied%5C%22 | |
| 13:47:00 | lyarwood | https://review.opendev.org/c/openstack/nova-specs/+/752284 - could use a spec review now that stephenfin is happy if anyone has time this week. | |
| 13:47:13 | lyarwood | gibi: looking | |