| Posted | Nick | Remark | |
|---|---|---|---|
| #openstack-nova - 2020-09-22 | |||
| 14:41:12 | sean-k-mooney | https://github.com/openstack/nova/blob/master/nova/tests/functional/__init__.py | |
| 14:41:23 | artom | dansmith, yeah, I said that last night :) | |
| 14:41:27 | artom | In functional it's fine | |
| 14:41:34 | sean-k-mooney | no i might of before mdbooth refactored this 3 release ago | |
| 14:41:49 | artom | But we'd have to add code similar to osprofiler to skip it with an env var | |
| 14:41:51 | sean-k-mooney | yes it did https://github.com/openstack/nova/blame/59f1f187e5dceb5841a711f265280346d70a972b/nova/tests/functional/__init__.py | |
| 14:41:59 | artom | (Actually, wait, would we? Don't think we would) | |
| 14:42:01 | dansmith | right, which artom eh? | |
| 14:42:16 | artom | But... it's not a functional test, is it? | |
| 14:42:24 | sean-k-mooney | this https://github.com/openstack/nova/commit/3c5e2b0e9fac985294a949852bb8c83d4ed77e04 reworkd most of our monkey patching | |
| 14:42:33 | dansmith | artom: yeah, I'm not getting what you're saying.. in the functional set, we can just run it natively and it will test what we want with that environment as it is already | |
| 14:42:53 | artom | dansmith, true | |
| 14:43:18 | artom | But... it's not a functional test :) It doesn't start any services, access the DB, etc | |
| 14:43:31 | dansmith | sean-k-mooney: okay I totally looked at this file yesterday, but maybe I just "saw" the older bare monkey patching and that stuck in my head | |
| 14:43:41 | artom | Like, if you want it in there I don't care | |
| 14:43:42 | dansmith | artom: you're joking right? | |
| 14:43:48 | artom | No? | |
| 14:44:07 | dansmith | I think it's fine in functional. | |
| 14:44:31 | artom | Sure, I'll move it there | |
| 14:45:08 | dansmith | apologies if I missed something previous about that, but I wasn't chatting with you "last night" about this, so maybe I wasn't around when it came up | |
| 14:45:31 | artom | dansmith, last afternoon? | |
| 14:45:35 | artom | I guess it was morning for you | |
| 14:45:59 | dansmith | okay, well, sorry if I missed it | |
| 14:46:12 | artom | (Let's be honest, https://i.imgur.com/aWxtlff.jpg is my go-to reaction for this kind of thing :P ) | |
| 14:47:12 | artom | But because I get a chance to prove dansmith publicly wrong (however insignificant the subject actually is), I'll still do it: http://eavesdrop.openstack.org/irclogs/%23openstack-nova/%23openstack-nova.2020-09-21.log.html#t2020-09-21T18:48:23 | |
| 14:48:20 | dansmith | ah, I see, right at the end | |
| 14:48:54 | dansmith | I had pretty much checked out, but I thought you were saying you'd need a way to turn it off and on (which I guess you were) and didn't go back to check or read what you were saying to grasp the reason | |
| 14:48:59 | dansmith | ANYWAY | |
| 14:49:07 | dansmith | I'd just do it there and then we can be done with it :) | |
| 14:49:11 | sean-k-mooney | to defend dansmith that also was not really night :P even in ireland | |
| 14:49:21 | dansmith | heh | |
| 14:49:43 | sean-k-mooney | by ya lets channel nike and just do it | |
| 14:49:44 | artom | sean-k-mooney, you're in no position to lecture people about time of day :P | |
| 14:49:54 | sean-k-mooney | :) | |
| 14:57:21 | openstackgerrit | Artom Lifshitz proposed openstack/nova master: Test for disabling greendns https://review.opendev.org/753072 | |
| 15:11:44 | openstackgerrit | Merged openstack/nova master: doc: Fix rendering in the accelerator support doc https://review.opendev.org/751574 | |
| 15:22:25 | openstackgerrit | Merged openstack/nova master: doc: correct the link to user/flavor.rst https://review.opendev.org/740176 | |
| 15:27:52 | openstackgerrit | Merged openstack/nova master: docs: fix aggregate weight multiplier property names https://review.opendev.org/746128 | |
| 15:55:13 | openstackgerrit | Mark Goddard proposed openstack/nova stable/ussuri: docs: fix aggregate weight multiplier property names https://review.opendev.org/753392 | |
| 16:12:57 | kashyap | Is there a code name for the "x" release yet? I don't see anything on the list ... so presumably no | |
| 19:32:51 | mnaser | kashyap: nope don't think we are there yet :) | |
| 20:06:13 | openstackgerrit | Lee Yarwood proposed openstack/nova stable/queens: Fix overcommit for NUMA-based instances https://review.opendev.org/726868 | |
| #openstack-nova - 2020-09-23 | |||
| 06:37:24 | openstackgerrit | Brin Zhang proposed openstack/nova master: WIP: Cyborg suspend/resume support https://review.opendev.org/729945 | |
| 06:54:40 | openstackgerrit | Brin Zhang proposed openstack/nova master: WIP: Cyborg suspend/resume support https://review.opendev.org/729945 | |
| 08:34:20 | brinzhang0 | frickler: hope you can review https://review.opendev.org/#/c/675304/22 while you have free time | |
| 08:34:45 | brinzhang0 | frickler: | |
| 08:34:45 | brinzhang0 | this patch "add server migration list CLI" | |
| 08:48:47 | kashyap | lyarwood: (or anyone): Have we ever deprecated / removed *allowed values* for a given image metadata property? | |
| 09:31:05 | stephenfin | kashyap: Not that I'm aware of, no | |
| 09:31:21 | kashyap | stephenfin: Okay; I'm just posting a little patch; we can discuss there | |
| 09:31:40 | stephenfin | It's technically possible, but no one has bothered. You'd need data migrations to remove DB entries using the old values | |
| 09:32:26 | stephenfin | bauzas: Am I correct in saying that AggregateInstanceExtraSpecsFilter and AggregateImagePropertiesIsolation have the same purpose but for extra specs and image metadata props? | |
| 09:32:57 | bauzas | correct | |
| 09:33:08 | bauzas | one is for aggregates related to flavors | |
| 09:33:14 | stephenfin | i.e. they do the same thing - filtering aggregates by aggregate metadata - but one builds its filters from extras specs and the other builds them from image metadata props | |
| 09:33:18 | bauzas | the other for aggregates related to images | |
| 09:33:24 | bauzas | yes indeed | |
| 09:33:33 | stephenfin | bauzas++ Thanks :) | |
| 09:34:09 | bauzas | but after 24 hours, I finally have some hardware \o/ | |
| 10:05:59 | Liang__ | hi cores, could you please take a look of the volume local cache patch: https://review.opendev.org/#/c/663542/ ? thanks | |
| 10:09:29 | lyarwood | Liang__: -W at the moment, we are about to cut RC this week, feature freeze was a few weeks ago. | |
| 10:09:37 | lyarwood | Liang__: didn't we reject the spec for this in V anyway? | |
| 10:11:56 | openstackgerrit | Lee Yarwood proposed openstack/nova master: zuul: Introduce nova-evacuate https://review.opendev.org/744883 | |
| 10:21:05 | Liang__ | lyarwood: it is approved in https://review.opendev.org/#/c/728778/ | |
| 10:21:58 | lyarwood | Liang__: ack apologies, we are still past feature freeze however. | |
| 10:22:40 | Liang__ | lyarwood: no problem:) | |
| 10:26:16 | Liang__ | lyarwood: https://review.opendev.org/#/c/750872/ this is the manual | |
| 10:56:36 | openstackgerrit | Sylvain Bauza proposed openstack/nova master: libvirt: make mdev types name attribute be optional https://review.opendev.org/753574 | |
| 10:57:06 | bauzas | gibi: stephenfin: lyarwood: very simple bugfix for supporting intel vGPUs ^ | |
| 10:57:35 | bauzas | if we could merge it before RC1, then I could backport it to Ussuri and Train | |
| 10:57:57 | bauzas | thanks | |
| 10:58:12 | bauzas | alex_xu: you could be interested in https://review.opendev.org/753574 too (intel support for vgpus) | |
| 11:01:06 | gibi | bauzas: ack | |
| 11:05:22 | bauzas | thanks | |
| 11:05:43 | bauzas | (for the moment, I see inventories so I still need to test to create mdevs) | |
| 11:10:44 | openstackgerrit | Stephen Finucane proposed openstack/os-traits master: List traits in documentation https://review.opendev.org/753579 | |
| 11:12:23 | sean-k-mooney | by the way are we going to defer deprecating the az filter to wallaby https://review.opendev.org/#/c/745605/ | |
| 11:12:57 | sean-k-mooney | the comput filter yes since there is work that needs to be done to have a placment only solution | |
| 11:13:45 | sean-k-mooney | bauzas: you wanted to punt it to wallby right? | |
| 11:31:24 | kashyap | 'mypy' doesn't recognize "-HEAD" here? `tox -epep8 -- -HEAD` now? | |
| 11:32:12 | brinzhang0 | stephenfin: thanks, addressed your comment for the server migration CLI support patch | |
| 11:33:26 | sean-k-mooney | kashyap: likely but 1 you should have been using tox -e fast8 instead of doing that manually and 2 we now have a pre-commit hook you can use isntead | |
| 11:33:54 | openstackgerrit | Merged openstack/nova master: Test for disabling greendns https://review.opendev.org/753072 | |
| 11:34:21 | kashyap | sean-k-mooney: Oh, right; I keep forgetting the 'fast8' | |
| 11:34:45 | sean-k-mooney | kashyap: stephenfin wants to eventually remove it but in favor of usign pre-commit | |
| 11:34:52 | sean-k-mooney | but its still there and eos what you want | |
| 11:35:17 | kashyap | I think I vaguely saw that discussion in the past | |
| 11:35:28 | openstackgerrit | Kashyap Chamarthy proposed openstack/nova master: [WIP] libvirt: Remove support for floppy drives https://review.opendev.org/753588 | |
| 11:35:45 | kashyap | sean-k-mooney: Either way ... take a look at the completely incompletely patch above :-) | |
| 11:36:09 | sean-k-mooney | lol but what if i want to run my dos games in the cloud :P | |
| 11:36:12 | kashyap | sean-k-mooney: Please do read the "TODO" in the commit message to see already what I have considered (including the versioned objects) | |
| 11:36:33 | sean-k-mooney | this is for wallaby right | |
| 11:36:48 | kashyap | sean-k-mooney: Would be useful; but I'm not hell-bent on it | |
| 11:36:58 | brinzhang0 | It seems tox -epep8 contains 'tox -e fast8', right? | |
| 11:37:11 | sean-k-mooney | brinzhang0: no | |
| 11:37:16 | kashyap | sean-k-mooney: On DOS games in the cloud via floppy: "Friends don't let friends play DOS Games via vulnerable floppy drive controllers" ;-) | |
| 11:37:31 | brinzhang0 | this is the description of fast8: Run style checks on the changes made since HEAD~. For a full run including docs, use 'pep8' | |
| 11:37:34 | sean-k-mooney | "tox -e pep8" runs flake8 on all files | |
| 11:37:45 | brinzhang0 | yep | |
| 11:37:49 | sean-k-mooney | tox -e fast8 runs flake8 on just the files that changed | |