| Posted | Nick | Remark | |
|---|---|---|---|
| #openstack-nova - 2020-09-23 | |||
| 09:32:57 | bauzas | correct | |
| 09:33:08 | bauzas | one is for aggregates related to flavors | |
| 09:33:14 | stephenfin | i.e. they do the same thing - filtering aggregates by aggregate metadata - but one builds its filters from extras specs and the other builds them from image metadata props | |
| 09:33:18 | bauzas | the other for aggregates related to images | |
| 09:33:24 | bauzas | yes indeed | |
| 09:33:33 | stephenfin | bauzas++ Thanks :) | |
| 09:34:09 | bauzas | but after 24 hours, I finally have some hardware \o/ | |
| 10:05:59 | Liang__ | hi cores, could you please take a look of the volume local cache patch: https://review.opendev.org/#/c/663542/ ? thanks | |
| 10:09:29 | lyarwood | Liang__: -W at the moment, we are about to cut RC this week, feature freeze was a few weeks ago. | |
| 10:09:37 | lyarwood | Liang__: didn't we reject the spec for this in V anyway? | |
| 10:11:56 | openstackgerrit | Lee Yarwood proposed openstack/nova master: zuul: Introduce nova-evacuate https://review.opendev.org/744883 | |
| 10:21:05 | Liang__ | lyarwood: it is approved in https://review.opendev.org/#/c/728778/ | |
| 10:21:58 | lyarwood | Liang__: ack apologies, we are still past feature freeze however. | |
| 10:22:40 | Liang__ | lyarwood: no problem:) | |
| 10:26:16 | Liang__ | lyarwood: https://review.opendev.org/#/c/750872/ this is the manual | |
| 10:56:36 | openstackgerrit | Sylvain Bauza proposed openstack/nova master: libvirt: make mdev types name attribute be optional https://review.opendev.org/753574 | |
| 10:57:06 | bauzas | gibi: stephenfin: lyarwood: very simple bugfix for supporting intel vGPUs ^ | |
| 10:57:35 | bauzas | if we could merge it before RC1, then I could backport it to Ussuri and Train | |
| 10:57:57 | bauzas | thanks | |
| 10:58:12 | bauzas | alex_xu: you could be interested in https://review.opendev.org/753574 too (intel support for vgpus) | |
| 11:01:06 | gibi | bauzas: ack | |
| 11:05:22 | bauzas | thanks | |
| 11:05:43 | bauzas | (for the moment, I see inventories so I still need to test to create mdevs) | |
| 11:10:44 | openstackgerrit | Stephen Finucane proposed openstack/os-traits master: List traits in documentation https://review.opendev.org/753579 | |
| 11:12:23 | sean-k-mooney | by the way are we going to defer deprecating the az filter to wallaby https://review.opendev.org/#/c/745605/ | |
| 11:12:57 | sean-k-mooney | the comput filter yes since there is work that needs to be done to have a placment only solution | |
| 11:13:45 | sean-k-mooney | bauzas: you wanted to punt it to wallby right? | |
| 11:31:24 | kashyap | 'mypy' doesn't recognize "-HEAD" here? `tox -epep8 -- -HEAD` now? | |
| 11:32:12 | brinzhang0 | stephenfin: thanks, addressed your comment for the server migration CLI support patch | |
| 11:33:26 | sean-k-mooney | kashyap: likely but 1 you should have been using tox -e fast8 instead of doing that manually and 2 we now have a pre-commit hook you can use isntead | |
| 11:33:54 | openstackgerrit | Merged openstack/nova master: Test for disabling greendns https://review.opendev.org/753072 | |
| 11:34:21 | kashyap | sean-k-mooney: Oh, right; I keep forgetting the 'fast8' | |
| 11:34:45 | sean-k-mooney | kashyap: stephenfin wants to eventually remove it but in favor of usign pre-commit | |
| 11:34:52 | sean-k-mooney | but its still there and eos what you want | |
| 11:35:17 | kashyap | I think I vaguely saw that discussion in the past | |
| 11:35:28 | openstackgerrit | Kashyap Chamarthy proposed openstack/nova master: [WIP] libvirt: Remove support for floppy drives https://review.opendev.org/753588 | |
| 11:35:45 | kashyap | sean-k-mooney: Either way ... take a look at the completely incompletely patch above :-) | |
| 11:36:09 | sean-k-mooney | lol but what if i want to run my dos games in the cloud :P | |
| 11:36:12 | kashyap | sean-k-mooney: Please do read the "TODO" in the commit message to see already what I have considered (including the versioned objects) | |
| 11:36:33 | sean-k-mooney | this is for wallaby right | |
| 11:36:48 | kashyap | sean-k-mooney: Would be useful; but I'm not hell-bent on it | |
| 11:36:58 | brinzhang0 | It seems tox -epep8 contains 'tox -e fast8', right? | |
| 11:37:11 | sean-k-mooney | brinzhang0: no | |
| 11:37:16 | kashyap | sean-k-mooney: On DOS games in the cloud via floppy: "Friends don't let friends play DOS Games via vulnerable floppy drive controllers" ;-) | |
| 11:37:31 | brinzhang0 | this is the description of fast8: Run style checks on the changes made since HEAD~. For a full run including docs, use 'pep8' | |
| 11:37:34 | sean-k-mooney | "tox -e pep8" runs flake8 on all files | |
| 11:37:45 | brinzhang0 | yep | |
| 11:37:49 | sean-k-mooney | tox -e fast8 runs flake8 on just the files that changed | |
| 11:38:07 | kashyap | sean-k-mooney: I have raised the floppy drive removal on the list Feb-2019, but "heard nothing" there. (Although that doesn't capture the full picture) | |
| 11:38:33 | sean-k-mooney | kashyap: this likely needs a specless blueprint and deprecation cycle | |
| 11:38:47 | kashyap | Blueprint already exists; filed same time as above | |
| 11:38:55 | kashyap | sean-k-mooney: https://blueprints.launchpad.net/nova/+spec/remove-support-for-floppy-disks | |
| 11:39:01 | sean-k-mooney | ah nice | |
| 11:39:06 | kashyap | sean-k-mooney: And the discussion on the list from 2019-Feb: | |
| 11:39:08 | kashyap | http://lists.openstack.org/pipermail/openstack-discuss/2019-February/002479.html | |
| 11:39:12 | sean-k-mooney | then ya i think the bigestr impediment is like deprecation cycle | |
| 11:39:25 | brinzhang0 | sean-k-mooney: yeah, so tox -epep8 can report the issue if the tox -efast8 report, but tox -e fast8 will be tox -efast8 than tox -epep8 | |
| 11:39:27 | kashyap | (Well, if you can call the exchange b/n me and Jay a "discussion" :D) | |
| 11:40:02 | brinzhang0 | sean-k-mooney: ... but tox -e fast8 will be faster than tox -epep8 | |
| 11:40:22 | sean-k-mooney | brinzhang0 yep which is why most peopel use fast8 | |
| 11:40:37 | sean-k-mooney | if you use pre-commit its faster the fast8 | |
| 11:40:48 | sean-k-mooney | and its nice to have it auto run on every commit | |
| 11:41:16 | brinzhang0 | kashyap: agree, now the big change we cannot merge into master now, may wallaby is a good choose | |
| 11:41:44 | sean-k-mooney | well we can merge it on friday but as is we cant merge it in wallaby either | |
| 11:41:58 | sean-k-mooney | since this is acutlly remove supprot | |
| 11:42:15 | sean-k-mooney | as i said above we need to have a deprecation cycle | |
| 11:42:46 | brinzhang0 | sean-k-mooney: I will try to use fast8 and pre-commit, since today I just only use tox -e pep8/docs/functional/py37 :) | |
| 11:43:22 | sean-k-mooney | if you swap py37 for py3 it will run using your systems default python | |
| 11:43:34 | sean-k-mooney | als py37 is not on the supported runtimes for victoria or wallaby | |
| 11:43:49 | sean-k-mooney | we support 3.6 and 3.8 | |
| 11:43:58 | brinzhang0 | yeah, py38 | |
| 11:44:25 | brinzhang0 | but in my env I used Python 3.6.9 (default, Jul 17 2020, 12:50:27) | |
| 11:45:03 | kashyap | sean-k-mooney: Right; on deprecation and reno (added in the TODO in the commit) | |
| 11:45:12 | kashyap | sean-k-mooney: Also, one more thing before I go AFK for a bit: | |
| 11:46:46 | openstackgerrit | Kashyap Chamarthy proposed openstack/nova master: [WIP] libvirt: Remove support for floppy drives https://review.opendev.org/753588 | |
| 11:47:28 | kashyap | sean-k-mooney: It is about the versioned object bump when removing / deprecating supported values for hw_floppy_bus | |
| 11:47:37 | kashyap | (In nova/objects/image_meta.py) | |
| 11:47:48 | kashyap | I also mentioned it in the commit message above | |
| 11:48:56 | sean-k-mooney | you can also use a floppy disk dirve as a parmater for hw_disk_bus or hw_rescue_bus | |
| 11:49:19 | sean-k-mooney | we cant raise raise exception.EmulatedFloppyDriveIsDeprecated() in wallby | |
| 11:49:29 | sean-k-mooney | this removes support it does not depcate it | |
| 11:50:04 | sean-k-mooney | we have to supprot them for one more cycle before we stop generating vms that can use floppy disk drives | |
| 11:58:41 | gibi | lyarwood: hi! if you have some spare time, could you look at https://bugs.launchpad.net/nova/+bug/1896617 ? the reporter refers to your change https://review.opendev.org/#/c/696834/ so I assume you have better context than me | |
| 11:58:41 | openstack | Launchpad bug 1896617 in OpenStack Compute (nova) "Creation of image (or live snapshot) from the existing VM fails if libvirt-image-backend is configured to qcow2 starting from Ussuri" [Undecided,New] | |
| 12:07:33 | brinzhang0 | sean-k-mooney: I saw https://review.opendev.org/#/c/702453/, that I can run "pip install --user pre-commit", but cannot run pre-commit command, do you have some suggestion? | |
| 12:07:45 | brinzhang0 | # pre-commit install --allow-missing-config | |
| 12:07:46 | brinzhang0 | -bash: pre-commit: command not found | |
| 12:13:35 | sean-k-mooney | brinzhang0: it may not be in you path by defualt | |
| 12:14:19 | sean-k-mooney | when you do a user install it proably put it in ~/.local/bin | |
| 12:14:31 | brinzhang0 | maybe yes, I try to use the docs of https://pre-commit.com/#pre-commit-configyaml---top-level to have a try | |
| 12:14:31 | sean-k-mooney | not all distos default to putting that in your path | |
| 12:15:04 | sean-k-mooney | i manually adde it to my path in my bashrc | |
| 12:15:50 | openstackgerrit | Federico Ressi proposed openstack/nova master: Requires default python3-devel package on CentOS https://review.opendev.org/752073 | |
| 12:16:25 | openstackgerrit | Federico Ressi proposed openstack/nova master: Requires default python3-devel package on CentOS https://review.opendev.org/752073 | |
| 12:17:43 | openstackgerrit | Federico Ressi proposed openstack/nova master: Requires default python3-devel package on CentOS 8 https://review.opendev.org/752073 | |
| 12:18:13 | openstackgerrit | Federico Ressi proposed openstack/nova master: Log stack trace when fails launching a defined domain https://review.opendev.org/750652 | |
| 12:19:11 | brinzhang0 | sean-k-mooney: yeah, you are right, I can run it by "~/.local/bin/pre-commit run -v -a | |
| 12:19:12 | brinzhang0 | " | |
| 12:38:27 | kashyap | sean-k-mooney: Right, the exception is not the right thing, I did it for discussion, as I noted it in the commit message :) | |
| 12:51:40 | openstackgerrit | Merged openstack/nova master: test_evacuate.sh: Stop using libvirt-bin https://review.opendev.org/753267 | |