| Posted | Nick | Remark | |
|---|---|---|---|
| #openstack-nova - 2020-09-17 | |||
| 10:29:07 | lyarwood | stephenfin: I can do that in the test itself as well tbh | |
| 10:55:11 | openstackgerrit | Lee Yarwood proposed openstack/nova master: Add regression test for bug #1895696 https://review.opendev.org/752247 | |
| 10:55:11 | openstack | bug 1895696 in OpenStack Compute (nova) "unable to boot instance from encrypted volume created from a glance image of an encrypted volume" [High,In progress] https://launchpad.net/bugs/1895696 - Assigned to Lee Yarwood (lyarwood) | |
| 10:55:11 | openstackgerrit | Lee Yarwood proposed openstack/nova master: compute: Skip cinder_encryption_key_id check when booting from volume https://review.opendev.org/752090 | |
| 10:55:11 | lyarwood | stephenfin: ^ there you go, slightly more self contained now. | |
| 10:55:24 | lyarwood | stephenfin: should be easy enough to backport as well | |
| 11:16:31 | gibi | lyarwood: +2 from me, sorry to take soo long I was distracted midday | |
| 11:17:11 | openstackgerrit | Lee Yarwood proposed openstack/nova master: Add regression test for bug #1895696 https://review.opendev.org/752247 | |
| 11:17:11 | openstack | bug 1895696 in OpenStack Compute (nova) "unable to boot instance from encrypted volume created from a glance image of an encrypted volume" [High,In progress] https://launchpad.net/bugs/1895696 - Assigned to Lee Yarwood (lyarwood) | |
| 11:17:11 | openstackgerrit | Lee Yarwood proposed openstack/nova master: compute: Skip cinder_encryption_key_id check when booting from volume https://review.opendev.org/752090 | |
| 11:17:13 | lyarwood | gibi: np, ^ just sorted the nit out quickly | |
| 11:19:24 | gibi | thanks | |
| 11:24:47 | openstackgerrit | Hemanth Nakkina proposed openstack/nova master: Update pci stat pools based on PCI device changes https://review.opendev.org/749175 | |
| 12:00:27 | nightmare_unreal | brinzhang_: hello \0 , brinzhang. Can you please see my comment on your patch : https://review.opendev.org/#/c/675304/ . Thanks | |
| 12:02:39 | brinzhang_ | nightmare_unreal: of course ^^ | |
| 12:04:05 | brinzhang_ | nightmare_unreal: IMO, this patch is ready a looong time, but I dont know the where need to change, and why no-body +2 or -1 for it | |
| 12:05:47 | sean-k-mooney | brinzhang_: it looks like it has not really got any code review | |
| 12:05:57 | sean-k-mooney | at least not in the last year or so | |
| 12:06:30 | sean-k-mooney | nightmare_unreal: brinzhang_ so ye need to join the sdk/osc irc channel and talk to the core team about it | |
| 12:06:36 | nightmare_unreal | can we please have a review for that patch | |
| 12:06:37 | brinzhang_ | IMHO, since mriedem left, there is no body care that pach | |
| 12:07:08 | nightmare_unreal | brinzhang_: i am in #osc channel but couldn't find your username | |
| 12:07:15 | nightmare_unreal | i mean sdk | |
| 12:07:15 | sean-k-mooney | this is not the correct channel to ask in really. i think stephenfin might have osc core rights | |
| 12:07:26 | nightmare_unreal | yeah right, sorry about the noise | |
| 12:07:33 | nightmare_unreal | we will move the disucssion | |
| 12:07:44 | sean-k-mooney | its ok to bring it up | |
| 12:07:50 | sean-k-mooney | its for nova migrations | |
| 12:08:05 | sean-k-mooney | but just bring it up here wont help get it merged | |
| 12:08:18 | nightmare_unreal | haha true | |
| 12:08:19 | sean-k-mooney | it might make sense to add a ptg topic | |
| 12:08:28 | sean-k-mooney | or a mailing list topic | |
| 12:08:29 | brinzhang_ | nightmare_unreal: yes, it also belongs to nova ^^ | |
| 12:08:38 | sean-k-mooney | it might make sense to add teh core teams to osc | |
| 12:09:11 | sean-k-mooney | i.e. so each project core team that does not ahve a plugin can review there onw part of osc | |
| 12:09:25 | nightmare_unreal | I see | |
| 12:09:48 | brinzhang_ | sean-k-mooney: ok, I will add the osc core to that patch | |
| 12:11:12 | brinzhang_ | nightmare_unreal: which channel? | |
| 12:11:35 | brinzhang_ | #osc, #sdk seems not right | |
| 12:11:43 | sean-k-mooney | #openstack-sdk | |
| 12:12:02 | sean-k-mooney | actully no that no right | |
| 12:12:04 | sean-k-mooney | one sec | |
| 12:12:10 | nightmare_unreal | i am in #openstack-sdks | |
| 12:12:18 | sean-k-mooney | ah yes plural | |
| 12:12:25 | nightmare_unreal | yup | |
| 12:13:08 | brinzhang_ | sean-k-mooney, nightmare_unreal: thanks | |
| 12:15:29 | brinzhang_ | sean-k-mooney> Maybe I cannot add all osc core as the reviewer, sometimes they dont like do that way :( | |
| 12:15:51 | sean-k-mooney | generally you are better off to ask for reviews in irc | |
| 12:16:20 | sean-k-mooney | if now one responds then after a day or two look at who has been active in stackaltics and add one or two | |
| 12:16:56 | brinzhang_ | yeah, this is a good way | |
| 12:17:12 | sean-k-mooney | https://www.stackalytics.com/?module=python-openstackclient&release=victoria | |
| 12:18:12 | sean-k-mooney | frickler nad gtema | |
| 12:18:19 | sean-k-mooney | *and | |
| 12:18:22 | brinzhang_ | Aha, I was missed this place, here we can know who is active in the project/model | |
| 12:18:31 | sean-k-mooney | yep | |
| 12:18:39 | sean-k-mooney | they are likely your best bet | |
| 12:18:54 | sean-k-mooney | monty has recently left openstack developement and changed job | |
| 12:19:23 | brinzhang_ | ack, thank for your help | |
| 12:21:00 | brinzhang_ | nightmare_unreal> I think I will review your patch tomorrow, I will go later, my timezone is UTC+8, thx | |
| 12:23:26 | nightmare_unreal | thanks brinzhang_ . Understood | |
| 12:46:36 | openstackgerrit | Merged openstack/nova master: tests: Remove '_FakeImageService' https://review.opendev.org/745908 | |
| 12:52:47 | openstackgerrit | Balazs Gibizer proposed openstack/nova master: Use cell targeted context to query instance metadata https://review.opendev.org/752459 | |
| 13:03:43 | openstackgerrit | Merged openstack/nova stable/ussuri: functional: Don't inherit from 'ProviderUsageBaseTestCase' https://review.opendev.org/751351 | |
| 13:03:48 | openstackgerrit | Merged openstack/nova stable/ussuri: Don't unset Instance.old_flavor, new_flavor until necessary https://review.opendev.org/751352 | |
| 13:35:54 | openstackgerrit | Sylvain Bauza proposed openstack/nova master: Victoria 22.0.0 prelude section https://review.opendev.org/751045 | |
| 13:36:47 | bauzas | gibi: stephenfin: takashi made a good comment on https://review.opendev.org/751045, could you please review again ? | |
| 13:37:01 | bauzas | ideally, we could merge this prelude now and just amend it in a later change if we need | |
| 13:37:28 | stephenfin | done | |
| 13:55:31 | bauzas | thanks | |
| 13:56:31 | gibi | will check soon | |
| 13:56:48 | openstackgerrit | Merged openstack/nova stable/queens: Removed the host FQDN from the exception message https://review.opendev.org/749613 | |
| 14:00:58 | bauzas | gibi: I saw you already looked at https://bugs.launchpad.net/nova/+bug/1884217 | |
| 14:00:58 | openstack | Launchpad bug 1884217 in OpenStack Compute (nova) "Nova informs Placement too early upon Ironic instance deletion" [Undecided,New] | |
| 14:01:12 | bauzas | gibi: this one seems legit to me but the bugfix isn't easy | |
| 14:16:12 | lyarwood | gibi: https://bugs.launchpad.net/nova/+bug/1888237 - shouldn't this be moved to fix released btw? | |
| 14:16:12 | openstack | Launchpad bug 1888237 in Ubuntu "nova-next job fails as novnc service fails with TypeError: _wrap_socket() argument 1 must be _socket.socket, not GreenSSLSocket" [Undecided,New] | |
| 14:28:22 | openstackgerrit | Elod Illes proposed openstack/nova stable/pike: Removed the host FQDN from the exception message https://review.opendev.org/752477 | |
| 14:30:53 | gibi | bauzas: I've just tagged https://bugs.launchpad.net/nova/+bug/1884217 I don't know the way forward with it | |
| 14:30:53 | openstack | Launchpad bug 1884217 in OpenStack Compute (nova) "Nova informs Placement too early upon Ironic instance deletion" [Low,Incomplete] | |
| 14:31:59 | gibi | lyarwood: you are correct. Now I marked it such | |
| 14:32:20 | lyarwood | gibi: coolio :) | |
| 14:32:33 | gibi | thanks for noticing | |
| 14:32:45 | gibi | bauzas: so if you have ideas how to fix please comment to the bug | |
| 14:33:02 | gibi | nvm | |
| 14:33:07 | gibi | I see your comment now | |
| 14:44:41 | stephenfin | elod, lyarwood, melwitt: Obviously the top few of these are still blocked by their Ussuri equivalents, but could you add https://review.opendev.org/#/q/topic:bug/1879878+status:open+branch:stable/train to your review queues? | |
| 14:46:23 | lyarwood | ack | |
| 14:51:47 | elod | stephenfin: sure, will do | |
| 14:53:56 | stephenfin | thanks | |
| 14:57:23 | elod | stephenfin: btw, can those heavy test refactors be avoided somehow? | |
| 14:58:15 | stephenfin | elod: Do you mean the first three patches I brought into the series or the changes I made to later patches? | |
| 14:59:52 | elod | stephenfin: for example this one: https://review.opendev.org/#/q/I33d8ac0a1cae0b2d275a21287d5e44c008a68122 | |
| 15:00:17 | openstackgerrit | Lee Yarwood proposed openstack/nova stable/ussuri: Add regression test for bug #1895696 https://review.opendev.org/752485 | |
| 15:00:17 | openstack | bug 1895696 in OpenStack Compute (nova) "unable to boot instance from encrypted volume created from a glance image of an encrypted volume" [High,In progress] https://launchpad.net/bugs/1895696 - Assigned to Lee Yarwood (lyarwood) | |
| 15:00:18 | openstackgerrit | Lee Yarwood proposed openstack/nova stable/ussuri: compute: Skip cinder_encryption_key_id check when booting from volume https://review.opendev.org/752486 | |
| 15:01:02 | openstackgerrit | Lee Yarwood proposed openstack/nova stable/train: Add regression test for bug #1895696 https://review.opendev.org/752487 | |
| 15:01:04 | openstackgerrit | Lee Yarwood proposed openstack/nova stable/train: Create volume attachment during boot from volume in compute https://review.opendev.org/752488 | |
| 15:01:04 | openstackgerrit | Lee Yarwood proposed openstack/nova stable/train: compute: Skip cinder_encryption_key_id check when booting from volume https://review.opendev.org/752489 | |
| 15:01:09 | stephenfin | elod: So the former. I could, but it would involve even more significant rewriting of the tests I'm bringing back plus significant rewrite of any future tests that depend on this feature | |
| 15:01:15 | lyarwood | stephenfin: ^ as requested | |