| Posted | Nick | Remark | |
|---|---|---|---|
| #openstack-nova - 2020-09-17 | |||
| 12:12:02 | sean-k-mooney | actully no that no right | |
| 12:12:04 | sean-k-mooney | one sec | |
| 12:12:10 | nightmare_unreal | i am in #openstack-sdks | |
| 12:12:18 | sean-k-mooney | ah yes plural | |
| 12:12:25 | nightmare_unreal | yup | |
| 12:13:08 | brinzhang_ | sean-k-mooney, nightmare_unreal: thanks | |
| 12:15:29 | brinzhang_ | sean-k-mooney> Maybe I cannot add all osc core as the reviewer, sometimes they dont like do that way :( | |
| 12:15:51 | sean-k-mooney | generally you are better off to ask for reviews in irc | |
| 12:16:20 | sean-k-mooney | if now one responds then after a day or two look at who has been active in stackaltics and add one or two | |
| 12:16:56 | brinzhang_ | yeah, this is a good way | |
| 12:17:12 | sean-k-mooney | https://www.stackalytics.com/?module=python-openstackclient&release=victoria | |
| 12:18:12 | sean-k-mooney | frickler nad gtema | |
| 12:18:19 | sean-k-mooney | *and | |
| 12:18:22 | brinzhang_ | Aha, I was missed this place, here we can know who is active in the project/model | |
| 12:18:31 | sean-k-mooney | yep | |
| 12:18:39 | sean-k-mooney | they are likely your best bet | |
| 12:18:54 | sean-k-mooney | monty has recently left openstack developement and changed job | |
| 12:19:23 | brinzhang_ | ack, thank for your help | |
| 12:21:00 | brinzhang_ | nightmare_unreal> I think I will review your patch tomorrow, I will go later, my timezone is UTC+8, thx | |
| 12:23:26 | nightmare_unreal | thanks brinzhang_ . Understood | |
| 12:46:36 | openstackgerrit | Merged openstack/nova master: tests: Remove '_FakeImageService' https://review.opendev.org/745908 | |
| 12:52:47 | openstackgerrit | Balazs Gibizer proposed openstack/nova master: Use cell targeted context to query instance metadata https://review.opendev.org/752459 | |
| 13:03:43 | openstackgerrit | Merged openstack/nova stable/ussuri: functional: Don't inherit from 'ProviderUsageBaseTestCase' https://review.opendev.org/751351 | |
| 13:03:48 | openstackgerrit | Merged openstack/nova stable/ussuri: Don't unset Instance.old_flavor, new_flavor until necessary https://review.opendev.org/751352 | |
| 13:35:54 | openstackgerrit | Sylvain Bauza proposed openstack/nova master: Victoria 22.0.0 prelude section https://review.opendev.org/751045 | |
| 13:36:47 | bauzas | gibi: stephenfin: takashi made a good comment on https://review.opendev.org/751045, could you please review again ? | |
| 13:37:01 | bauzas | ideally, we could merge this prelude now and just amend it in a later change if we need | |
| 13:37:28 | stephenfin | done | |
| 13:55:31 | bauzas | thanks | |
| 13:56:31 | gibi | will check soon | |
| 13:56:48 | openstackgerrit | Merged openstack/nova stable/queens: Removed the host FQDN from the exception message https://review.opendev.org/749613 | |
| 14:00:58 | bauzas | gibi: I saw you already looked at https://bugs.launchpad.net/nova/+bug/1884217 | |
| 14:00:58 | openstack | Launchpad bug 1884217 in OpenStack Compute (nova) "Nova informs Placement too early upon Ironic instance deletion" [Undecided,New] | |
| 14:01:12 | bauzas | gibi: this one seems legit to me but the bugfix isn't easy | |
| 14:16:12 | lyarwood | gibi: https://bugs.launchpad.net/nova/+bug/1888237 - shouldn't this be moved to fix released btw? | |
| 14:16:12 | openstack | Launchpad bug 1888237 in Ubuntu "nova-next job fails as novnc service fails with TypeError: _wrap_socket() argument 1 must be _socket.socket, not GreenSSLSocket" [Undecided,New] | |
| 14:28:22 | openstackgerrit | Elod Illes proposed openstack/nova stable/pike: Removed the host FQDN from the exception message https://review.opendev.org/752477 | |
| 14:30:53 | gibi | bauzas: I've just tagged https://bugs.launchpad.net/nova/+bug/1884217 I don't know the way forward with it | |
| 14:30:53 | openstack | Launchpad bug 1884217 in OpenStack Compute (nova) "Nova informs Placement too early upon Ironic instance deletion" [Low,Incomplete] | |
| 14:31:59 | gibi | lyarwood: you are correct. Now I marked it such | |
| 14:32:20 | lyarwood | gibi: coolio :) | |
| 14:32:33 | gibi | thanks for noticing | |
| 14:32:45 | gibi | bauzas: so if you have ideas how to fix please comment to the bug | |
| 14:33:02 | gibi | nvm | |
| 14:33:07 | gibi | I see your comment now | |
| 14:44:41 | stephenfin | elod, lyarwood, melwitt: Obviously the top few of these are still blocked by their Ussuri equivalents, but could you add https://review.opendev.org/#/q/topic:bug/1879878+status:open+branch:stable/train to your review queues? | |
| 14:46:23 | lyarwood | ack | |
| 14:51:47 | elod | stephenfin: sure, will do | |
| 14:53:56 | stephenfin | thanks | |
| 14:57:23 | elod | stephenfin: btw, can those heavy test refactors be avoided somehow? | |
| 14:58:15 | stephenfin | elod: Do you mean the first three patches I brought into the series or the changes I made to later patches? | |
| 14:59:52 | elod | stephenfin: for example this one: https://review.opendev.org/#/q/I33d8ac0a1cae0b2d275a21287d5e44c008a68122 | |
| 15:00:17 | openstackgerrit | Lee Yarwood proposed openstack/nova stable/ussuri: Add regression test for bug #1895696 https://review.opendev.org/752485 | |
| 15:00:17 | openstack | bug 1895696 in OpenStack Compute (nova) "unable to boot instance from encrypted volume created from a glance image of an encrypted volume" [High,In progress] https://launchpad.net/bugs/1895696 - Assigned to Lee Yarwood (lyarwood) | |
| 15:00:18 | openstackgerrit | Lee Yarwood proposed openstack/nova stable/ussuri: compute: Skip cinder_encryption_key_id check when booting from volume https://review.opendev.org/752486 | |
| 15:01:02 | openstackgerrit | Lee Yarwood proposed openstack/nova stable/train: Add regression test for bug #1895696 https://review.opendev.org/752487 | |
| 15:01:04 | openstackgerrit | Lee Yarwood proposed openstack/nova stable/train: Create volume attachment during boot from volume in compute https://review.opendev.org/752488 | |
| 15:01:04 | openstackgerrit | Lee Yarwood proposed openstack/nova stable/train: compute: Skip cinder_encryption_key_id check when booting from volume https://review.opendev.org/752489 | |
| 15:01:09 | stephenfin | elod: So the former. I could, but it would involve even more significant rewriting of the tests I'm bringing back plus significant rewrite of any future tests that depend on this feature | |
| 15:01:15 | lyarwood | stephenfin: ^ as requested | |
| 15:01:19 | stephenfin | lyarwood: thanks | |
| 15:02:06 | stephenfin | elod: Given they're test-only (low risk) and avoid merge conflicts for this series and potentially many more tests in the future, I'm personally inclined to think they belong here. | |
| 15:06:52 | elod | stephenfin: the test-only part is good, but still it would mean larger and larger extra refactor (due to conflicts) in older branches which could cause more problems later on maybe | |
| 15:08:16 | stephenfin | elod: Fair point but tbh I'm not sure how much further back we should go. Those tests and the changes themselves are invasive enough that I think they may have to be rewritten if I want to go significantly further back | |
| 15:10:36 | stephenfin | elod: In fact, I don't think we need to go further back. The main issue here was introduced by https://review.opendev.org/#/c/641806/ which was never backported | |
| 15:10:46 | stephenfin | and was merged in train | |
| 15:11:39 | elod | stephenfin: yes, that is another question, how far should a backport go. in general, whether a bugfix worth the backporting effort if it involves so much refactor, hence risks | |
| 15:12:23 | elod | stephenfin: but i understand you are saying this won't go further than train | |
| 15:13:19 | stephenfin | given the nasty side-effects of this race (worst case scenario: doubly pinned instances) I think bringing it back to train makes sense | |
| 15:24:09 | elod | stephenfin: ok, i accept it. (I won't say i'm happy with it, but i understand your point o:)) | |
| 15:28:13 | openstackgerrit | Lee Yarwood proposed openstack/nova stable/train: Create volume attachment during boot from volume in compute https://review.opendev.org/752488 | |
| 15:28:14 | openstackgerrit | Lee Yarwood proposed openstack/nova stable/train: compute: Skip cinder_encryption_key_id check when booting from volume https://review.opendev.org/752489 | |
| 15:37:01 | sean-k-mooney | gibi: have you see error in the fucntional test that look like ValueError: Malformed PCI address 0000:00:03 | |
| 15:37:28 | sean-k-mooney | gibi: your new sriov attach detach test are failing for me when i rebase one of my patches | |
| 15:37:43 | sean-k-mooney | but the code im chanign i dont think should cause that | |
| 15:38:40 | stephenfin | sean-k-mooney: I haven't, but I know those fixtures well enough that I could debug. What test? | |
| 15:38:45 | stephenfin | *what patch? | |
| 15:38:54 | sean-k-mooney | http://paste.openstack.org/show/798018/ | |
| 15:39:21 | sean-k-mooney | nova.tests.functional.libvirt.test_pci_sriov_servers.SRIOVAttachDetachTest.test_detach_macvtap | |
| 15:39:36 | sean-k-mooney | and nova.tests.functional.libvirt.test_pci_sriov_servers.SRIOVAttachDetachTest.test_detach_attach_direct | |
| 15:40:35 | sean-k-mooney | im cherry picking https://review.opendev.org/#/c/602432/16 onto another patch but after the rebase on master those new test are failing for me | |
| 15:40:59 | sean-k-mooney | i could just push what i have it might be simpler to look at | |
| 15:41:48 | gibi | sean-k-mooney: yes please ^^ | |
| 15:41:52 | openstackgerrit | Balazs Gibizer proposed openstack/nova master: Reject HW_CPU_HYPERTHREADING trait in named groups https://review.opendev.org/735947 | |
| 15:41:58 | gibi | sean-k-mooney: I did not remember seeing such | |
| 15:42:00 | gibi | err | |
| 15:43:27 | stephenfin | sean-k-mooney: this is a guess but https://review.opendev.org/#/c/602432/16/nova/tests/unit/virt/libvirt/fakelibvirt.py | |
| 15:46:53 | sean-k-mooney | ya i guess that could be it ill take a look | |
| 15:47:02 | sean-k-mooney | i made fucn be octal | |
| 15:47:13 | sean-k-mooney | func = 0o0 | |
| 15:47:23 | sean-k-mooney | but ya it could be the formating | |
| 15:48:10 | stephenfin | >>> x = 0o1 | |
| 15:48:10 | stephenfin | >>> '%s' % x | |
| 15:48:10 | stephenfin | '1' | |
| 15:48:35 | sean-k-mooney | ok ya so that is proably it | |
| 15:49:21 | sean-k-mooney | cool now i need to look up hex/octal format codes :) | |
| 15:50:17 | sean-k-mooney | so it shoudl be o not s | |
| 15:50:36 | sean-k-mooney | or i guess x would work too for hex | |
| 15:52:10 | gibi | the nova weekly meeting starts in 8 minutes in #openstack-meetings-3 | |
| 15:52:25 | gibi | I mean #openstack-meeting-3 | |