| Posted | Nick | Remark | |
|---|---|---|---|
| #openstack-nova - 2020-08-25 | |||
| 15:46:18 | artom | I guess in that case I mean - not adding stuff to the sdk first | |
| 15:46:37 | artom | If it's supposed to be moving to the sdk, then why are new patches are being added that call novaclient? | |
| 15:47:02 | sean-k-mooney | artom: it just does parsing and passes the args on | |
| 15:47:07 | frickler | artom: mordred should be the right person to talk to about this, now that dtroyer seem to have moved on. sadly he also seems to be gone missing somehow | |
| 15:47:18 | sean-k-mooney | there is little logic in osc beyond that in general | |
| 15:47:52 | sean-k-mooney | thre are some microversion checks and other check to ensure its valid | |
| 15:48:07 | sean-k-mooney | but thats more validation of input then complex logic | |
| 15:48:49 | stephenfin | artom: Is it possible to talk to SDK for nova commands? 'self.app.client_manager.compute' will point to the novaclient client at the moment | |
| 15:49:09 | stephenfin | at least, last I checked | |
| 15:49:10 | artom | stephenfin, would have to look it up | |
| 15:49:11 | sean-k-mooney | stephenfin: you can just import the sdk modules | |
| 15:49:13 | sean-k-mooney | and call that | |
| 15:49:26 | stephenfin | you've have to init the sdk too, I'd imagine | |
| 15:49:51 | sean-k-mooney | proably unless there is a global instance you can use | |
| 15:50:07 | lyarwood | stephenfin: thanks, jsuchome I'll clean things up again unless you want to work through stephenfin's comments? | |
| 15:50:19 | sean-k-mooney | but its like how we use both sdk and keystone authclient and project client in nova | |
| 15:50:24 | sean-k-mooney | you can mix and match | |
| 15:51:23 | jsuchome | lyarwood: I'm changing those hard requests (doc + file handle), I would rather not go down the rabbit hole of new refactoring though | |
| 15:52:26 | artom | stephenfin, frickler, I'm asking selfishly in the context of https://review.opendev.org/#/q/status:open+project:openstack/openstacksdk+branch:master+topic:story/2007929 | |
| 15:52:50 | artom | I'm not going to continue that if nothing of "substance" (sorry openstack-ansible) will ever use the sdk | |
| 15:53:11 | artom | There are plenty of broken things in Nova that I can fix with that time ;) | |
| 15:53:20 | lyarwood | jsuchome: yup np, I can fix up my change once you're done | |
| 15:53:32 | lyarwood | jsuchome: and we can push the other stuff to follow ups hopefully | |
| 15:53:45 | openstackgerrit | Jiri Suchomel proposed openstack/nova master: Add ability to download Glance images into the libvirt image cache via RBD https://review.opendev.org/574301 | |
| 15:54:33 | artom | I just kept hearing "osc is moving to sdk", so I figured catch up 1 thing (the sdk), start requiring the sdk for new API microversion, and then we don't have an ever increasing gap to close wrt to novaclient parity. | |
| 15:54:34 | lyarwood | TIL about http://rst.ninjs.org/ | |
| 15:54:51 | lyarwood | no wonder stephenfin gets his rst correct first time | |
| 15:55:22 | frickler | artom: I'm pretty sure that the idea for OSC would be to use those things from the sdk, but I don't know if anyone commited to actually working on that. but surely a lot of people would approve that | |
| 15:55:24 | stephenfin | artom: TIL (or rather remembered) I have core on sdk | |
| 15:56:04 | frickler | artom: maybe best continue that discussion in #openstack-sdks , also eod for me now | |
| 15:56:28 | artom | frickler, ack. o/ | |
| 15:57:19 | frickler | just as a final comment, OSC and sdk are a single project for a small while now, so in theory there shouldn't be any gap between those | |
| 15:57:34 | stephenfin | jsuchome, lyarwood: Thoughts on https://review.opendev.org/#/c/574301/35/nova/image/glance.py@225 ? | |
| 15:57:48 | stephenfin | Apologies if I've missed some context on that decision (to bring back the deprecated opt) | |
| 15:59:04 | artom | frickler, "in theory" :D | |
| 15:59:40 | lyarwood | stephenfin: I've not heard any plans for support for other support | |
| 15:59:45 | jsuchome | stephenfin: in general, I don't think there's a big chance to expand it ... but well, who knows | |
| 16:00:04 | lyarwood | stephenfin: I'd prefer however that we ruled that out at a later date | |
| 16:01:20 | sean-k-mooney | i could see use adding swift maybe | |
| 16:01:37 | sean-k-mooney | to pull the image drectly from swrift rather then streaming it via glance | |
| 16:01:40 | jsuchome | I think it's already mentioned in the blueprint btw | |
| 16:01:55 | sean-k-mooney | no one has asked for that however | |
| 16:02:39 | sean-k-mooney | but ya swift is the only thing i can think of that we might ever expand it for and even then im not sure it makes sense | |
| 16:02:47 | sean-k-mooney | im jsut thinking off the top of my head | |
| 16:03:20 | sean-k-mooney | the advantage of using the exsiting deprecated option is installer tools whoudl already support it | |
| 16:03:36 | sean-k-mooney | if we use anything else that creates more work for them | |
| 16:03:56 | gibi | o/ | |
| 16:04:05 | sean-k-mooney | o/ enjoy your evening | |
| 16:04:19 | gibi | thanks | |
| 16:05:29 | sean-k-mooney | which nova cores like networking and libvirt :) | |
| 16:06:10 | sean-k-mooney | zuul hasnt finished running yet but i have an old patch that i want to make sure lands before m3 | |
| 16:06:58 | sean-k-mooney | https://review.opendev.org/#/c/602432/ but it does not need to be reviewd right away the neutron dep merged earlier today so i finally got around to rebasing it | |
| 16:11:47 | openstackgerrit | Merged openstack/nova master: [goal] Prepare for job migration to Ubuntu Focal (20.04) https://review.opendev.org/738126 | |
| 17:01:02 | openstackgerrit | Stephen Finucane proposed openstack/nova master: tests: Add helpers for rebuild, cold migrate, and shelve/unshelve https://review.opendev.org/747792 | |
| 17:01:02 | openstackgerrit | Stephen Finucane proposed openstack/nova master: libvirt: Add emulated TPM support to Nova https://review.opendev.org/631363 | |
| 17:01:03 | openstackgerrit | Stephen Finucane proposed openstack/nova master: docs: Add docs for vTPM support https://review.opendev.org/739213 | |
| 17:01:04 | openstackgerrit | Stephen Finucane proposed openstack/nova master: Add type hints to 'nova.compute.manager' https://review.opendev.org/742863 | |
| 17:01:04 | openstackgerrit | Stephen Finucane proposed openstack/nova master: Don't unset Instance.old_flavor, new_flavor until necessary https://review.opendev.org/741995 | |
| 17:01:04 | openstackgerrit | Stephen Finucane proposed openstack/nova master: privsep: Add support for recursive chown, move_tree operations https://review.opendev.org/742864 | |
| 17:01:05 | openstackgerrit | Stephen Finucane proposed openstack/nova master: Add type hints to 'nova.virt.libvirt.utils' https://review.opendev.org/742865 | |
| 17:01:06 | openstackgerrit | Stephen Finucane proposed openstack/nova master: Add support for resize and cold migration of emulated TPM files https://review.opendev.org/639934 | |
| 17:09:17 | openstackgerrit | Merged openstack/nova master: Add reno for deprecated APIs policy changes https://review.opendev.org/747784 | |
| 17:22:30 | gmann | gibi: reno patch is merged you can mark policy-defaults-refresh-deprecated-apis BP completed now. | |
| 18:25:08 | openstackgerrit | Lee Yarwood proposed openstack/nova stable/pike: libvirt: Provide VIR_MIGRATE_PARAM_PERSIST_XML during live migration https://review.opendev.org/747978 | |
| 19:53:00 | openstackgerrit | Jiri Suchomel proposed openstack/nova master: Add ability to download Glance images into the libvirt image cache via RBD https://review.opendev.org/574301 | |
| 20:18:01 | openstackgerrit | Merged openstack/nova master: libvirt: Provide VIR_MIGRATE_PARAM_PERSIST_XML during live migration https://review.opendev.org/747969 | |
| 21:22:44 | lyarwood | melwitt: thanks for the stable reviews, would you also mind looking at https://review.opendev.org/#/c/747357/ https://review.opendev.org/#/c/744553/ https://review.opendev.org/#/c/744550/ https://review.opendev.org/#/c/742706/ & https://review.opendev.org/#/c/729177/ | |
| 21:34:13 | melwitt | ack will do | |
| 21:38:26 | lyarwood | awesome thanks :) | |
| 21:47:52 | openstackgerrit | Elancheran S proposed openstack/nova stable/ussuri: Removes the delta file once image is extracted https://review.opendev.org/748034 | |
| 21:48:45 | openstackgerrit | Elancheran S proposed openstack/nova stable/train: Removes the delta file once image is extracted https://review.opendev.org/748035 | |
| 23:29:50 | openstackgerrit | Merged openstack/nova master: db: fix database migrations when name includes dash https://review.opendev.org/747164 | |
| #openstack-nova - 2020-08-26 | |||
| 00:54:17 | openstackgerrit | Ghanshyam Mann proposed openstack/nova master: Migrate default policy file from JSON to YAML https://review.opendev.org/748059 | |
| 02:51:06 | openstackgerrit | Yingji Sun proposed openstack/nova master: Set different VirtualDevice.key https://review.opendev.org/713565 | |
| 02:55:58 | openstackgerrit | Merged openstack/nova stable/stein: Should not skip volume_size check for bdm.image_id == image_ref case https://review.opendev.org/744553 | |
| 03:38:39 | openstackgerrit | Merged openstack/nova stable/ussuri: compute: Do not allow rescue attempts using volume snapshot images https://review.opendev.org/742706 | |
| 04:14:50 | openstackgerrit | Merged openstack/nova stable/rocky: compute: Allow snapshots to be created from PAUSED volume backed instances https://review.opendev.org/729177 | |
| 04:25:44 | openstackgerrit | Elancheran S proposed openstack/nova stable/ussuri: Removes the delta file once image is extracted https://review.opendev.org/748034 | |
| 04:51:04 | openstackgerrit | Tony Su proposed openstack/nova master: Provider Config File: Functions to merge provider configs to provider tree https://review.opendev.org/676522 | |
| 07:18:04 | openstackgerrit | Keigo Noha proposed openstack/nova master: Change default num_retries for glance to 3 https://review.opendev.org/740389 | |
| 07:35:08 | gibi | gmann: cool. I marked the policy by as implemented | |
| 07:39:48 | brinzhang | gibi: hi, good morning | |
| 07:40:04 | gibi | brinzhang: hi | |
| 07:40:36 | brinzhang | gibi: https://review.opendev.org/#/c/715326/19/nova/compute/manager.py@3654 this you mean, we should add the kwargs['accel_uuids'] to the rebuild() and _rebuild_default_impl() interfact, right? | |
| 07:41:31 | brinzhang | that we should change the virt/driver.py and virt/ironic/driver.py rebuild() functions? | |
| 07:42:37 | gibi | brinzhang: yes, I mean that this parameter should be part of the https://github.com/openstack/nova/blob/master/nova/virt/driver.py#L285 interface | |
| 07:43:31 | brinzhang | gibi: does it need to change the irnic driver? https://github.com/openstack/nova/blob/master/nova/virt/ironic/driver.py#L1669 | |
| 07:43:43 | brinzhang | s/irnic/ironic/ | |
| 07:43:49 | gibi | yes | |
| 07:44:07 | gibi | it will be a parameter that the ironic driver gets but ignores at the moment | |
| 07:46:09 | brinzhang | yeah, we will add this parameter, and send a mail to the ML later ^ | |
| 07:46:15 | brinzhang | gibi: thanks | |
| 07:57:43 | gibi | brinzhang: thanks | |
| 08:01:48 | openstackgerrit | Alexandre Arents proposed openstack/nova master: Add a lock to prevent race during detach/attach of interface https://review.opendev.org/747957 | |
| 08:17:35 | bauzas | gibi: fwiw, I'm starting to sheperd the rest of the provider config series | |
| 08:17:43 | bauzas | shepherd* even | |
| 08:17:52 | gibi | bauzas: thanks. | |
| 08:18:21 | bauzas | it needed me to look back at the spec, but thanks for having started to review the series | |
| 08:21:37 | gibi | unfortunately the implementation changed ownwer couple of times so there are thing that needs (needed) detective work to understand the context | |
| 08:26:43 | rmart04 | Hey All, Apologies if this isn't the right place to ask, but are there any obvious memory limitations gotchas when using dedicated cpu policy? I'm seeing OOM killing off my instances when the host has plenty of memory left :/ (Stein / CentOS7 Packages / KVM / Kolla-Ansible) | |