| Posted | Nick | Remark | |
|---|---|---|---|
| #openstack-nova - 2020-08-26 | |||
| 07:40:36 | brinzhang | gibi: https://review.opendev.org/#/c/715326/19/nova/compute/manager.py@3654 this you mean, we should add the kwargs['accel_uuids'] to the rebuild() and _rebuild_default_impl() interfact, right? | |
| 07:41:31 | brinzhang | that we should change the virt/driver.py and virt/ironic/driver.py rebuild() functions? | |
| 07:42:37 | gibi | brinzhang: yes, I mean that this parameter should be part of the https://github.com/openstack/nova/blob/master/nova/virt/driver.py#L285 interface | |
| 07:43:31 | brinzhang | gibi: does it need to change the irnic driver? https://github.com/openstack/nova/blob/master/nova/virt/ironic/driver.py#L1669 | |
| 07:43:43 | brinzhang | s/irnic/ironic/ | |
| 07:43:49 | gibi | yes | |
| 07:44:07 | gibi | it will be a parameter that the ironic driver gets but ignores at the moment | |
| 07:46:09 | brinzhang | yeah, we will add this parameter, and send a mail to the ML later ^ | |
| 07:46:15 | brinzhang | gibi: thanks | |
| 07:57:43 | gibi | brinzhang: thanks | |
| 08:01:48 | openstackgerrit | Alexandre Arents proposed openstack/nova master: Add a lock to prevent race during detach/attach of interface https://review.opendev.org/747957 | |
| 08:17:35 | bauzas | gibi: fwiw, I'm starting to sheperd the rest of the provider config series | |
| 08:17:43 | bauzas | shepherd* even | |
| 08:17:52 | gibi | bauzas: thanks. | |
| 08:18:21 | bauzas | it needed me to look back at the spec, but thanks for having started to review the series | |
| 08:21:37 | gibi | unfortunately the implementation changed ownwer couple of times so there are thing that needs (needed) detective work to understand the context | |
| 08:26:43 | rmart04 | Hey All, Apologies if this isn't the right place to ask, but are there any obvious memory limitations gotchas when using dedicated cpu policy? I'm seeing OOM killing off my instances when the host has plenty of memory left :/ (Stein / CentOS7 Packages / KVM / Kolla-Ansible) | |
| 08:27:13 | openstackgerrit | Elod Illes proposed openstack/nova stable/queens: compute: Allow snapshots to be created from PAUSED volume backed instances https://review.opendev.org/729178 | |
| 08:30:32 | openstackgerrit | Brin Zhang proposed openstack/nova master: Cyborg evacuate support https://review.opendev.org/715326 | |
| 08:42:43 | stephenfin | lyarwood, gibi: So I've got three series on the go rn. What would I need to pay you to get at least one of them moving? :) | |
| 08:43:01 | gibi | stephenfin: the vpmem is on my menu for today | |
| 08:43:07 | gibi | is that one of the three | |
| 08:43:08 | gibi | ? | |
| 08:43:21 | stephenfin | unless you meant vTPM, no :( | |
| 08:43:27 | gibi | vtpm | |
| 08:43:33 | stephenfin | then yes \o/ | |
| 08:43:35 | gibi | cool | |
| 08:43:36 | stephenfin | hurrah | |
| 08:43:43 | gibi | then you can expect review on that in the coming hours | |
| 08:44:01 | stephenfin | awesome. Thanks, gibi :) | |
| 08:44:22 | gibi | no problemo, it is in the runway slot so it in focus :) | |
| 08:46:14 | openstackgerrit | Stephen Finucane proposed openstack/nova master: Add type hints to 'nova.compute.manager' https://review.opendev.org/742863 | |
| 08:46:14 | openstackgerrit | Stephen Finucane proposed openstack/nova master: Don't unset Instance.old_flavor, new_flavor until necessary https://review.opendev.org/741995 | |
| 08:46:15 | openstackgerrit | Stephen Finucane proposed openstack/nova master: privsep: Add support for recursive chown, move_tree operations https://review.opendev.org/742864 | |
| 08:46:15 | openstackgerrit | Stephen Finucane proposed openstack/nova master: Add type hints to 'nova.virt.libvirt.utils' https://review.opendev.org/742865 | |
| 08:46:16 | openstackgerrit | Stephen Finucane proposed openstack/nova master: Add support for resize and cold migration of emulated TPM files https://review.opendev.org/639934 | |
| 08:54:33 | stephenfin | alex_xu: Can you look at https://review.opendev.org/#/c/744021/ and its predecessor today? You probably have appropriate context | |
| 08:54:49 | stephenfin | alex_xu: I suspect it impacts the mixed CPU work too | |
| 08:58:47 | openstackgerrit | Brin Zhang proposed openstack/nova master: Cyborg evacuate support https://review.opendev.org/715326 | |
| 09:01:18 | stephenfin | rmart04: Using the dedicated CPU policy implies a single-node NUMA topology by default, and using a NUMA topology implies consuming memory from a single host NUMA node for each guest NUMA node | |
| 09:02:44 | stephenfin | rmart04: That's a roundabout way of saying that I suspect you haven't reserved memory on per-node basis and may have allocated something like hugepages unevenly across NUMA nodes | |
| 09:05:08 | stephenfin | rmart04: nova won't let you overcommit against a host NUMA node using nova instances, but it can't account for host processes or huge page allocations consuming memory on that node. You've to do that manually | |
| 09:07:03 | stephenfin | rmart04: There are two config options of value here: 'reserved_host_memory_mb', which is a total amount of memory to reserve across all NUMA nodes, and 'reserved_huge_pages' which is a per-node reservation that applies when you're using explicit pagesizes | |
| 09:07:23 | bauzas | stephenfin: gibi: fwiw, after the provider series, I was heading to review your vTPM series | |
| 09:07:47 | stephenfin | rmart04: I suggest whacking up the first ('reserved_host_memory_mb'). It would be good to inspect idle memory consumption without instances on the host and use that value with some buffer. | |
| 09:08:34 | stephenfin | rmart04: The second is rarely used. Unless you're using explicit page sizes for all instances, I wouldn't worry about it for now | |
| 09:08:43 | stephenfin | rmart04: Hope that helps | |
| 09:08:53 | stephenfin | bauzas: awesome. Thanks :) | |
| 09:13:22 | lyarwood | stephenfin: just catching up with some downstream stuff but I'll get into your reviews after that | |
| 09:16:44 | bauzas | alex_xu: gibi: I have a logging concern with https://review.opendev.org/#/c/693460/36 | |
| 09:17:52 | bauzas | alex_xu: gibi: or we will get a lot of logs if operators don't use this new feature :) | |
| 09:18:21 | gibi | bauzas: you mean https://review.opendev.org/#/c/693460/36/nova/compute/resource_tracker.py@120 ? | |
| 09:18:43 | gibi | bauzas: I see one extra log per compute node at compute service startup | |
| 09:19:29 | gibi | also that config has a default value so it is set even if not specified in the config file | |
| 09:19:41 | bauzas | gibi: correct, this won't be very talkative, but we then try to merge inventories even if the operator doesn't use it | |
| 09:19:59 | bauzas | gibi: https://review.opendev.org/#/c/693460/36/nova/compute/resource_tracker.py@1165 | |
| 09:20:09 | bauzas | and https://review.opendev.org/#/c/676029/51/nova/compute/provider_config.py@391 | |
| 09:20:16 | bauzas | all of this seems not needed | |
| 09:22:09 | bauzas | gibi: I would have preferred a way to avoid calling all of this if no YAML files were there | |
| 09:23:49 | gibi | Can you check from oslo config if the config value is set explicitly by the user or just the default value is applied by oslo? | |
| 09:24:31 | gibi | because current calling down to get_provider_configs is the only way to detect if there are config files | |
| 09:28:38 | gibi | regarding the actual logging: I can see a reasoning to log what provider config files are loaded if any instead of logging if nothing is loaded | |
| 09:39:45 | stephenfin | real trivial patch for the VMWare driver here https://review.opendev.org/#/c/713565/ | |
| 09:41:14 | openstackgerrit | Stephen Finucane proposed openstack/nova master: Move revert resize under semaphore https://review.opendev.org/747746 | |
| 09:41:15 | openstackgerrit | Stephen Finucane proposed openstack/nova master: Cleanup 'drop_move_claim' and '_drop_move_claim' https://review.opendev.org/747747 | |
| 09:41:15 | openstackgerrit | Stephen Finucane proposed openstack/nova master: manager: Address TODO https://review.opendev.org/747748 | |
| 09:41:16 | openstackgerrit | Stephen Finucane proposed openstack/nova master: manager: Move context manager up one level https://review.opendev.org/745674 | |
| 09:41:16 | openstackgerrit | Stephen Finucane proposed openstack/nova master: compute: Add type hints for resize functions https://review.opendev.org/745341 | |
| 09:41:17 | openstackgerrit | Stephen Finucane proposed openstack/nova master: WIP: compute: Add more type hints for resize functions https://review.opendev.org/745675 | |
| 09:42:22 | stephenfin | lyarwood: are you respinning that nova-image-download-via-rbd series again today to add the missing '__init__.py' file etc.? | |
| 09:45:42 | openstackgerrit | Merged openstack/nova stable/ussuri: libvirt: Provide VIR_MIGRATE_PARAM_PERSIST_XML during live migration https://review.opendev.org/747972 | |
| 09:46:35 | gibi | stephenfin: I left a question in https://review.opendev.org/#/c/741995/10/nova/compute/manager.py@a4932 | |
| 09:52:11 | lyarwood | stephenfin: yeah | |
| 09:54:47 | stephenfin | gibi: replied | |
| 09:55:54 | gibi | stephenfin: thanks it is make sense now. | |
| 09:57:20 | bauzas | gibi: sorry, missed your ping | |
| 09:57:22 | stephenfin | gibi: fwiw, that patch is identical to this bug fix for a ResourceTracker race. I just didn't want to make the series depend on each other https://review.opendev.org/#/c/744958/ | |
| 09:57:55 | stephenfin | gibi: Have been bugging melwitt and dansmith for reviews on that though so you're off the hook for reviews there :P | |
| 09:58:15 | gibi | stephenfin: if it is identical then I can add my +2 there :) | |
| 09:59:00 | stephenfin | yup, iirc cherry-picked and change-id modified to mark them as independent | |
| 10:03:17 | bauzas | stephenfin: just saw https://review.opendev.org/#/c/747744/ | |
| 10:03:21 | bauzas | will try to look at it too | |
| 10:04:13 | stephenfin | nice one | |
| 10:06:56 | bauzas | stephenfin: starting to look at the vTPM series but... wow, I need a beer :p | |
| 10:07:31 | gibi | isn't it a bit too early for a beer? ;) | |
| 10:08:05 | lyarwood | blasphemy | |
| 10:08:13 | alex_xu | stephenfin: checking now | |
| 10:08:32 | alex_xu | bauzas: yea, as gibi said, it is just one log at startup, should be ok | |
| 10:08:52 | bauzas | alex_xu: I changed my thoughts | |
| 10:09:08 | bauzas | I don't wanna hold for a nit | |
| 10:09:18 | bauzas | but... this change needs a rebase either way :) | |
| 10:10:42 | bauzas | gibi: technically, it's beer o'time | |
| 10:10:53 | bauzas | ten past nonn | |
| 10:10:56 | bauzas | noon | |
| 10:11:09 | bauzas | if that's too early, then I don't know when | |
| 10:12:45 | alex_xu | bauzas: yea, that is due to tony_su rebase the previous patch, actually it needn't, just just gate failed, he should recheck instead of rebase. | |
| 10:13:40 | bauzas | alex_xu: the branch I see from gerrit pulls the old revision | |
| 10:14:11 | bauzas | alex_xu: what he can do tho is wait for the dependent change to be merged and then indeed a recheck should be fine | |
| 10:16:43 | gibi | bauzas: I rest my case, it is really afternoon now | |
| 10:18:42 | openstackgerrit | Stephen Finucane proposed openstack/nova master: Provider Config File: Enable loading and merging of provider configs https://review.opendev.org/693460 | |