| Posted | Nick | Remark | |
|---|---|---|---|
| #openstack-nova - 2020-08-21 | |||
| 16:19:59 | sean-k-mooney | thanks | |
| 16:39:33 | openstackgerrit | Ghanshyam Mann proposed openstack/nova master: Few todo fixes for API new policies https://review.opendev.org/746610 | |
| 16:40:12 | sean-k-mooney | oh i need to use the libvirt driver in this regression test | |
| 16:40:27 | sean-k-mooney | that explains why its passing wehn it shoudl not be. | |
| 16:40:37 | sean-k-mooney | ok that is still doable | |
| 16:52:49 | openstackgerrit | Artom Lifshitz proposed openstack/nova master: Revert "Handle Neutron errors in _post_live_migration()" https://review.opendev.org/747443 | |
| 16:53:28 | artom | ... which I screwed up. | |
| 16:55:57 | sean-k-mooney | it certenly rivial some of the epics stephenfin has written lately | |
| 16:56:36 | sean-k-mooney | :) http://paste.openstack.org/show/797050/ | |
| 16:56:54 | sean-k-mooney | there we go repoduced it in a functional test | |
| 16:57:10 | stephenfin | not so fast | |
| 16:57:17 | artom | Noice. | |
| 16:57:50 | sean-k-mooney | i feel like im mocking more then i then i need to and could remove some of the fixture im using | |
| 16:57:52 | stephenfin | actually, yeah, that'd make sense for this bug | |
| 16:58:08 | sean-k-mooney | but on the other hand its working so.... | |
| 16:58:16 | stephenfin | was going to say that was failing for me because the NeutronFixture wasn't setting that field like neutron would in real-life | |
| 16:58:32 | stephenfin | but of course it'll only set it if the port-binding extension is present | |
| 16:58:49 | sean-k-mooney | actully that the correct behavior | |
| 16:58:56 | stephenfin | see the changes I made to https://review.opendev.org/#/c/746947/2/nova/conductor/tasks/live_migrate.py | |
| 16:59:10 | sean-k-mooney | currenlty we are setting migrate_data.vif unconditionally | |
| 16:59:15 | sean-k-mooney | im fixint that | |
| 16:59:25 | openstackgerrit | Artom Lifshitz proposed openstack/nova master: Revert "Handle Neutron errors in _post_live_migration()" https://review.opendev.org/747443 | |
| 16:59:25 | stephenfin | already fixed ^ | |
| 16:59:30 | sean-k-mooney | no that is not the fix | |
| 16:59:47 | sean-k-mooney | stephenfin: that code we determined can never be hit | |
| 17:00:03 | sean-k-mooney | the if will always be false | |
| 17:00:21 | artom | sean-k-mooney, that's just an argument to remove it, which stephenfin is doing | |
| 17:00:30 | sean-k-mooney | https://review.opendev.org/#/c/742180/6/nova/compute/manager.py | |
| 17:00:34 | sean-k-mooney | stephenfin: that id the fix | |
| 17:00:40 | sean-k-mooney | artom: ya i know | |
| 17:00:49 | artom | But yeah, they're different things | |
| 17:00:51 | sean-k-mooney | artom: also the do said to remove it in ussurit and its victoria | |
| 17:03:37 | artom | stephenfin, understandable. It took sean-k-mooney and me 2 hours on gmeet to nail it. We considered recording it and just putting the YouTube link in the commit messages. | |
| 17:04:45 | sean-k-mooney | so we coudl say you can trust us or here 2 hours of trailing through the code to fiture it out | |
| 17:07:32 | sean-k-mooney | stephenfin: your patch removing that is not wrong by the way we should do that anyway | |
| 17:11:27 | sean-k-mooney | but lets fix the other issue breaking live migation before merging it i want to try and keep the patches small for backproting | |
| 17:38:18 | openstackgerrit | Artom Lifshitz proposed openstack/nova master: post live migration: don't call Neutron needlessly https://review.opendev.org/747451 | |
| 17:38:42 | artom | I'm pretty sure I broke some unit tests, let's see what CI says. | |
| 17:46:51 | sean-k-mooney | there are a tone of places we saw that could also use the info from the infor case in pre livem migration too right | |
| 17:50:18 | artom | sean-k-mooney, I think they'd have to get double checked one by one... | |
| 17:50:35 | artom | That being said, maybe it wouldn't hurt to do them all in the same patch | |
| 17:50:40 | artom | Or least, more than 1 | |
| 17:50:58 | sean-k-mooney | i would do them in a followup | |
| 17:51:15 | sean-k-mooney | so just replace teh once case in post live migrate in that one | |
| 17:51:33 | sean-k-mooney | and then see if you could replace the other use in pre livemigate in a different patch | |
| 18:02:09 | openstackgerrit | sean mooney proposed openstack/nova master: [WIP] Set migrate_data.vifs only when using multiple port bindings https://review.opendev.org/742180 | |
| 18:02:11 | openstackgerrit | sean mooney proposed openstack/nova master: add functional regression test for bug #188395 https://review.opendev.org/747454 | |
| 18:02:11 | openstack | bug 188395 in pyTD "Strange Behavior of the game.creeps list" [Undecided,Fix released] https://launchpad.net/bugs/188395 | |
| 18:02:45 | sean-k-mooney | i still need to add unit tests and update the commit message but thats the repodcuer and fix | |
| 18:04:13 | sean-k-mooney | as a followup im also thinking of replacing all uses of | |
| 18:04:16 | sean-k-mooney | if 'vifs' in migrate_data and migrate_data.vifs: | |
| 18:04:41 | sean-k-mooney | with "if migrate_data.using_multiple_port_bindings():" | |
| 18:04:55 | artom | Would definitely be more readable, aye | |
| 18:05:15 | sean-k-mooney | i can do it as a property so its technically not an ovo change too | |
| 18:05:20 | sean-k-mooney | if we wanted to backport that | |
| 18:05:26 | sean-k-mooney | but it will be a spereate patch anyway | |
| 18:06:11 | sean-k-mooney | well it is an ovo change but not one that is visable when you serialise so its fine | |
| 18:11:14 | sean-k-mooney | apparently its only there 3 times | |
| 18:11:20 | sean-k-mooney | i tought it was more | |
| 18:11:25 | sean-k-mooney | guess not | |
| 18:11:57 | sean-k-mooney | anyway im going to call it a day o/ | |
| 21:46:06 | openstackgerrit | Merged openstack/nova master: Add new default roles in FIP policies https://review.opendev.org/742030 | |
| 23:16:42 | openstackgerrit | Artom Lifshitz proposed openstack/nova master: post live migration: don't call Neutron needlessly https://review.opendev.org/747451 | |
| #openstack-nova - 2020-08-22 | |||
| 14:35:50 | openstackgerrit | Ghanshyam Mann proposed openstack/nova master: Few todo fixes for API new policies https://review.opendev.org/746610 | |
| #openstack-nova - 2020-08-23 | |||
| 20:47:17 | openstackgerrit | Merged openstack/nova master: Pass the actual target in FIP policy https://review.opendev.org/742570 | |
| #openstack-nova - 2020-08-24 | |||
| 03:36:25 | tony_su | stephenfin: it would be great if you could spare some hours to review provider-config-file patches this week so that I can upgrade them for any comments. | |
| 04:08:15 | openstackgerrit | norman shen proposed openstack/nova stable/ussuri: libvirt:driver:Disallow AIO=native when 'O_DIRECT' is not available https://review.opendev.org/747609 | |
| 04:08:26 | openstackgerrit | norman shen proposed openstack/nova stable/train: libvirt:driver:Disallow AIO=native when 'O_DIRECT' is not available https://review.opendev.org/747610 | |
| 04:08:35 | openstackgerrit | norman shen proposed openstack/nova stable/stein: libvirt:driver:Disallow AIO=native when 'O_DIRECT' is not available https://review.opendev.org/747611 | |
| 04:08:46 | openstackgerrit | norman shen proposed openstack/nova stable/rocky: libvirt:driver:Disallow AIO=native when 'O_DIRECT' is not available https://review.opendev.org/747612 | |
| 08:41:59 | openstackgerrit | Brin Zhang proposed openstack/nova master: Define and catch InstanceAgentNotRunning for set-password failure https://review.opendev.org/661466 | |
| 09:10:53 | openstackgerrit | Luyao Zhong proposed openstack/nova master: Introduce a new driver interface 'cleanup_instance' https://review.opendev.org/714653 | |
| 09:10:53 | openstackgerrit | Luyao Zhong proposed openstack/nova master: Track error migrations in resource tracker https://review.opendev.org/745281 | |
| 09:10:54 | openstackgerrit | Luyao Zhong proposed openstack/nova master: Improve orphans tracking in resource tracker https://review.opendev.org/745282 | |
| 09:15:51 | openstackgerrit | Mark Goddard proposed openstack/nova master: docs: fix aggregate weight multiplier property names https://review.opendev.org/746128 | |
| 09:45:06 | admin0 | how does nova decide ( which field decides) if a hypervisor will use local storage vs ceph ? | |
| 09:48:23 | lyarwood | admin0: depends on the virt driver, for libvirt it's the [libvirt]/images_type configurable | |
| 09:49:02 | lyarwood | admin0: https://github.com/openstack/nova/blob/0d062ac7b6acc769117e77c3094b32a84411fe83/nova/conf/libvirt.py#L899-L916 | |
| 09:50:54 | admin0 | images_type, default/null = local, rbd = ceph | |
| 09:50:57 | admin0 | thanks lyarwood | |
| 09:52:07 | lyarwood | np | |
| 11:19:14 | gibi | lyarwood: thanks for running the nova meetings in the last two weeks | |
| 11:20:50 | lyarwood | gibi: np, hopefully someone found it useful :D | |
| 11:21:10 | gibi | lyarwood: at least I read it ;) | |
| 11:36:52 | openstackgerrit | Merged openstack/nova master: libvirt: Fix indentation in test__video_model_supported https://review.opendev.org/746979 | |
| 11:39:40 | openstackgerrit | Merged openstack/nova master: libvirt: Add libvirt version mocks in test_private_destroy_* tests https://review.opendev.org/746980 | |
| 12:05:28 | jsuchome | lyarwood: hi, I wasn't around for a few days, I'm not sure what's the agreement about https://review.opendev.org/#/c/574301/ - do you want to rework it, or merge soon and continue in followup patches... ? | |
| 12:09:02 | jsuchome | or is any of the remaining requests critical? | |
| 12:11:32 | lyarwood | jsuchome: yeah sorry I just need to clean that up and we should be good to merge, noticed you were offline so wanted to push things along while you were out | |
| 12:24:00 | nightmare_unreal | hello I am trying to run functional test for openstackclient on my devstack machine . I am getting this error ModuleNotFoundError: No module named 'openstackclient.tests.compute' | |
| 12:24:09 | nightmare_unreal | i have not changed anything, just cloned the repo and ran tox | |
| 12:40:33 | lyarwood | we don't have a flavor extra spec or image property to force instances to boot from volume right? | |
| 12:51:39 | gibi | sean-k-mooney: hi! is there any os-vif patch that we desperatly need before the non-client library freeze that will happen next week? | |
| 12:56:22 | sean-k-mooney | gibi: i want to get https://review.opendev.org/#/c/744816/ merged but i need to fix it first | |
| 12:56:50 | sean-k-mooney | i need to make it so we dont initalies the ovsdb python binding unless you try to use them | |
| 12:57:07 | gibi | sean-k-mooney: OK, just ping me if review is needed | |
| 12:57:35 | sean-k-mooney | stephen has some mypy patches too but they can merge after teh freeze if needed | |
| 12:57:44 | sean-k-mooney | im not against merging them before too | |
| 12:58:17 | sean-k-mooney | im not a fan of the style stephen is using but im going to look into addint automated code formating after m3 | |
| 12:59:33 | sean-k-mooney | gibi: those are stephens patches. https://review.opendev.org/#/q/status:open+project:openstack/os-vif+branch:master+topic:mypy-integration not super urgent but if there good to go im not going to block them just because i think the code look ugly | |