Earlier  
Later
New Search
Posted Nick Remark
#openstack-nova - 2020-08-24
12:51:39 gibi sean-k-mooney: hi! is there any os-vif patch that we desperatly need before the non-client library freeze that will happen next week?
12:56:22 sean-k-mooney gibi: i want to get https://review.opendev.org/#/c/744816/ merged but i need to fix it first
12:56:50 sean-k-mooney i need to make it so we dont initalies the ovsdb python binding unless you try to use them
12:57:07 gibi sean-k-mooney: OK, just ping me if review is needed
12:57:35 sean-k-mooney stephen has some mypy patches too but they can merge after teh freeze if needed
12:57:44 sean-k-mooney im not against merging them before too
12:58:17 sean-k-mooney im not a fan of the style stephen is using but im going to look into addint automated code formating after m3
12:59:33 sean-k-mooney gibi: those are stephens patches. https://review.opendev.org/#/q/status:open+project:openstack/os-vif+branch:master+topic:mypy-integration not super urgent but if there good to go im not going to block them just because i think the code look ugly
12:59:43 sean-k-mooney it works and adds type checking which is what matters
13:01:19 gibi sean-k-mooney: ack, I will handle those patches as good-to-have
13:56:53 artom lyarwood, I think we have a policy...? Lemme dig
14:01:12 artom lyarwood, https://bugzilla.redhat.com/show_bug.cgi?id=1826334
14:01:12 openstack bugzilla.redhat.com bug 1826334 in openstack-nova "[rfe] Ability to prevent creation of an instance with Ephemeral disk" [Low,Closed: upstream] - Assigned to nova-maint
14:07:00 lyarwood artom: right, policy to block but that doesn't covert requests into using bfv right?
14:07:09 lyarwood convert*
14:07:15 artom Nooo
14:07:25 lyarwood kk
14:08:01 artom You mean like, --image <funky UUID> gets converted into --block-device-mapping source=image,dest=volume,id=<funky UUID>?
14:09:00 lyarwood yeah
14:09:08 sean-k-mooney lyarwood: we have a config option
14:09:16 sean-k-mooney lyarwood: you can contole the number of local disk
14:09:34 sean-k-mooney https://docs.openstack.org/nova/latest/configuration/config.html#DEFAULT.max_local_block_devices
14:10:03 sean-k-mooney if you set that to 0 then you can only do boot form volume or rbd
14:10:31 artom Still no conversion though
14:10:49 artom But I feel like automagic conversion is a bad idea, unless we significantly change the semantics
14:10:49 sean-k-mooney right
14:11:01 artom User: do X. Nova: lulz no, u get Y.
14:11:09 lyarwood right I'm not suggesting we do this
14:11:11 sean-k-mooney there conversion feacture would be a generic cinder imageges_type backend
14:11:16 lyarwood just checking that it wasn't there somewhere already
14:11:38 artom I love how "it's a stupid idea, lemme just make sure someone else didn't already implement it" is a thing
14:13:26 lyarwood we spoke about it for a while tbh
14:13:40 sean-k-mooney we did
14:13:52 sean-k-mooney im still not against a generic cinder image backend
14:14:01 sean-k-mooney but im not sure that is the same as auto bfv
14:14:12 sean-k-mooney auto bfv would be less work i think
14:14:22 sean-k-mooney but ya not a thing we support right now
14:15:06 sean-k-mooney we would have to default to delete on terminate for the volume if we did auto bfv
14:15:12 sean-k-mooney to get the correct semantics
14:15:28 sean-k-mooney but it could confuse people as to why there cinder quota is being consumed
14:15:43 sean-k-mooney unified limits i guess would change that
14:16:17 sean-k-mooney since we would only have DISK_GB for both right
14:16:44 sean-k-mooney assuming cinder is tracked in placment?
14:16:59 lyarwood I don't think cinder is in placement yet
14:19:01 sean-k-mooney ya i think your right
14:19:16 sean-k-mooney then never added support because sharing resouce provider did not work fully
14:19:21 sean-k-mooney which makes me sad
14:34:52 openstackgerrit Jiri Suchomel proposed openstack/nova master: Bring back allowed_direct_url_schemes in support of RBD image download https://review.opendev.org/728095
14:40:51 openstackgerrit Jiri Suchomel proposed openstack/nova master: rbd: Move rbd_utils out of libvirt driver under nova.storage https://review.opendev.org/746904
14:40:52 openstackgerrit Jiri Suchomel proposed openstack/nova master: Add ability to download Glance images into the libvirt image cache via RBD https://review.opendev.org/574301
14:40:52 openstackgerrit Jiri Suchomel proposed openstack/nova master: Bring back allowed_direct_url_schemes in support of RBD image download https://review.opendev.org/728095
14:42:07 lyarwood jsuchome: thanks for that, just looking at the failing tests now
14:43:41 jsuchome you mean tests for the https://review.opendev.org/#/c/743220/ I assume?
14:45:07 lyarwood jsuchome: no https://review.opendev.org/#/c/574301/33 had some failures in the imagebackend tests that I think are being caused by the way the tests are written
14:46:15 gibi stephenfin: hi! there is an empty slot in the runways and you have the vtpm in the queue. Are you OK with me moving the vtpm to the runway slot?
14:46:31 stephenfin gibi: hey, welcome back. Sure.
14:46:40 gibi thanks. then it is moved :)
14:48:55 lyarwood jsuchome: oh and these failures were due to the changes I made btw
14:49:06 lyarwood jsuchome: so apologies for that, should have them fixed shortly
14:50:53 jsuchome ah, I see, I did not look closely at your changes
14:55:43 openstackgerrit Stephen Finucane proposed openstack/nova master: Don't unset Instance.old_flavor, new_flavor until necessary https://review.opendev.org/744958
14:55:43 openstackgerrit Stephen Finucane proposed openstack/nova master: manager: Move context manager up one level https://review.opendev.org/745674
14:55:44 openstackgerrit Stephen Finucane proposed openstack/nova master: compute: Add type hints for resize functions https://review.opendev.org/745341
14:55:44 openstackgerrit Stephen Finucane proposed openstack/nova master: WIP: compute: Add more type hints for resize functions https://review.opendev.org/745675
14:55:47 openstackgerrit Stephen Finucane proposed openstack/nova master: Add generic reproducer for bug #1879878 https://review.opendev.org/747744
14:55:47 openstack bug 1879878 in OpenStack Compute (nova) "VM become Error after confirming resize with Error info CPUUnpinningInvalid on source node " [Medium,In progress] https://launchpad.net/bugs/1879878 - Assigned to Stephen Finucane (stephenfinucane)
14:55:47 openstackgerrit Stephen Finucane proposed openstack/nova master: Move confirm resize under semaphore https://review.opendev.org/747745
14:55:47 openstackgerrit Stephen Finucane proposed openstack/nova master: Move revert resize under semaphore https://review.opendev.org/747746
14:55:47 openstackgerrit Stephen Finucane proposed openstack/nova master: Cleanup 'drop_move_claim' and '_drop_move_claim' https://review.opendev.org/747747
14:55:47 openstackgerrit Stephen Finucane proposed openstack/nova master: manager: Address TODO https://review.opendev.org/747748
14:56:00 stephenfin alex_xu: Think I've gotten to the bottom of that ^
15:02:44 openstackgerrit Lee Yarwood proposed openstack/nova master: Add ability to download Glance images into the libvirt image cache via RBD https://review.opendev.org/574301
15:02:45 openstackgerrit Lee Yarwood proposed openstack/nova master: Bring back allowed_direct_url_schemes in support of RBD image download https://review.opendev.org/728095
15:02:45 openstackgerrit Lee Yarwood proposed openstack/nova master: DNM zuul: Enable [glance]/allowed_direct_url_schemes within nova-ceph-multistore https://review.opendev.org/743220
15:02:49 lyarwood jsuchome: ^ there you go
15:05:49 openstackgerrit Merged openstack/nova-specs master: Create specs directory for Wallaby https://review.opendev.org/746408
15:12:32 openstackgerrit Stephen Finucane proposed openstack/nova master: functional: Provide default 'host_info' for '_get_connection' https://review.opendev.org/746942
15:12:32 openstackgerrit Stephen Finucane proposed openstack/nova master: functional: Add 'start_compute' helper https://review.opendev.org/746943
15:12:33 openstackgerrit Stephen Finucane proposed openstack/nova master: functional: Use tempdir for CONF.instances_path https://review.opendev.org/746944
15:12:33 openstackgerrit Stephen Finucane proposed openstack/nova master: functional: Clean up PCI tests https://review.opendev.org/746945
15:12:34 openstackgerrit Stephen Finucane proposed openstack/nova master: functional: Add resize tests for PCI servers https://review.opendev.org/746946
15:12:34 openstackgerrit Stephen Finucane proposed openstack/nova master: conductor: Don't use setattr https://review.opendev.org/746947
15:12:35 openstackgerrit Stephen Finucane proposed openstack/nova master: functional: Add test for SR-IOV neutron ports https://review.opendev.org/746948
15:12:35 openstackgerrit Stephen Finucane proposed openstack/nova master: fixtures: Handle binding of first port https://review.opendev.org/746949
15:12:36 openstackgerrit Stephen Finucane proposed openstack/nova master: functional: Add live migration tests for PCI, SR-IOV servers https://review.opendev.org/746950
15:42:18 stephenfin lyarwood: can you hit https://review.opendev.org/#/c/741285/ again? Should unblock 4 patches or so
15:56:43 openstackgerrit Merged openstack/nova master: Few todo fixes for API new policies https://review.opendev.org/746610
15:57:17 gibi gmann: is this ^^ the last patch for the policy work for Victoria? Can I close the bp?
15:57:50 openstackgerrit Balazs Gibizer proposed openstack/nova master: Undeprecate the vmwareapi driver https://review.opendev.org/742407
15:58:06 gmann gibi: i hope so, let me check if any TODO left and confirm you by today
15:58:19 gibi gmann: cool, thanks
16:03:33 lyarwood stephenfin: ack looking
16:06:24 artom lyarwood, stephenfin, so https://review.opendev.org/#/c/747451/ is the Neutron _post_live_migration() patch series we talked about
16:06:42 artom Oh, and I need to update the functional test to assert the vif host
16:07:01 artom Lunch first though, kiddos are getting low-blood-sugar-restless
16:33:48 stephenfin lyarwood: Thanks for that. Have the rebase for later patches lined up locally but I'll wait for those to (hopefully) go through the gate first
16:35:51 stephenfin artom: I see https://review.opendev.org/#/c/747443/2//COMMIT_MSG and raise you https://review.opendev.org/#/c/747745/1//COMMIT_MSG
16:36:42 stephenfin incidentally, something you're probably interested in given your live migration work (I suspect that suffers from a similar issue but I haven't investigated that yet)
16:38:26 openstackgerrit Merged openstack/nova master: resolve ResourceProviderSyncFailed issue https://review.opendev.org/742398
16:40:36 stephenfin dansmith, melwitt: Could I bug you for a review on https://review.opendev.org/#/c/744958/ again. It's now a partial fix, owing to further issues alex_xu spotted. Later patches fix it completely though

Earlier   Later