Earlier  
Later
New Search
Posted Nick Remark
#openstack-nova - 2020-07-28
23:52:50 brinzhang gmann: you are an expert in api, you can do the api change in cyborg too, and we will be very happy to see you improve this ^
#openstack-nova - 2020-07-29
01:56:50 openstackgerrit Tony Su proposed openstack/nova master: Provider Config File: YAML file loading and schema validation https://review.opendev.org/673341
08:01:11 tony_su stephenfin: really appreciate your detailed review and I uploaded the latest patch reflecting the latest comments.
09:15:23 lyarwood stephenfin: https://review.opendev.org/#/q/topic:bug/1889108 updated for your reviewing pleasure btw
09:15:30 stephenfin ta
09:21:24 stephenfin melwitt, dansmith: Haven't investigated yet, but nova-ceph-multistore is failing again on some jobs. Could be nothing but just FYI https://review.opendev.org/#/c/673341/54
09:25:34 lyarwood https://zuul.opendev.org/t/openstack/build/0709ecfb37c54cb8813afb42aefe9097/log/controller/logs/screen-g-api.txt#12286
09:25:49 lyarwood rbd.OSError: [errno 116] error removing image
09:26:05 lyarwood [errno 2] error removing snapshot b'snap' from b'39db07f4-d56b-47f2-b7c2-81d3d4e8707e' Snapshot does not exist.
09:26:09 lyarwood that's a better error
09:32:34 stephenfin lyarwood: done; some comments on the last one but other straight +2s
09:32:42 stephenfin swot
09:34:43 lyarwood https://github.com/openstack/glance_store/blob/100fe260bfb6698795ae5d6fce6aeadecbed1772/glance_store/_drivers/rbd.py#L385-L407 - odd, that should create a snapshot
09:34:47 lyarwood stephenfin: ta
09:36:16 lyarwood yeah I'll address that now
10:02:03 openstackgerrit Lee Yarwood proposed openstack/nova master: func: Add live migration rollback volume attachment tests https://review.opendev.org/743534
10:02:05 openstackgerrit Lee Yarwood proposed openstack/nova master: Add regression tests for bug #1889108 https://review.opendev.org/743289
10:02:05 openstack bug 1889108 in OpenStack Compute (nova) "failures during driver.pre_live_migration remove source attachments during rollback" [High,In progress] https://launchpad.net/bugs/1889108 - Assigned to Lee Yarwood (lyarwood)
10:02:05 openstackgerrit Lee Yarwood proposed openstack/nova master: compute: Don't delete the original attachment during pre LM rollback https://review.opendev.org/743319
10:02:05 openstackgerrit Lee Yarwood proposed openstack/nova master: func: Add CinderFixture to _IntegratedTestBase https://review.opendev.org/743535
10:02:05 openstackgerrit Lee Yarwood proposed openstack/nova master: func: Introduce a server_final_status kwarg to _IntegratedTestBase.live_migrate https://review.opendev.org/743710
10:03:30 openstackgerrit Lee Yarwood proposed openstack/nova master: func: Introduce a server_final_status kwarg to InstanceHelperMixin._live_migrate https://review.opendev.org/743710
10:03:58 lyarwood stephenfin: ^ thanks again
10:06:54 openstackgerrit Lee Yarwood proposed openstack/nova master: func: Introduce a server_final_status kwarg to InstanceHelperMixin._live_migrate https://review.opendev.org/743710
10:34:02 sean-k-mooney anyone know if you can rebuild or resize vms in a shelved state?
10:35:39 sean-k-mooney if the answer was yes for both that would be really helpful.
10:49:53 openstackgerrit Lee Yarwood proposed openstack/nova master: block_device: Use initialize APIs to refresh when reported as idempotent https://review.opendev.org/720769
11:11:58 sean-k-mooney that would be a no :(
11:57:58 openstackgerrit Stephen Finucane proposed openstack/nova master: objects: Don't use generic 'Field' container https://review.opendev.org/738239
11:57:59 openstackgerrit Stephen Finucane proposed openstack/nova master: objects: Remove unnecessary type aliases, exceptions https://review.opendev.org/738240
11:58:00 openstackgerrit Stephen Finucane proposed openstack/nova master: objects: Use imports instead of type aliases https://review.opendev.org/738018
11:58:00 openstackgerrit Stephen Finucane proposed openstack/nova master: objects: Remove wrappers around ovo mixins https://review.opendev.org/738019
11:58:01 openstackgerrit Stephen Finucane proposed openstack/nova master: WIP: objects: Add type hints https://review.opendev.org/738020
12:16:31 openstackgerrit Lee Yarwood proposed openstack/nova master: func: Introduce a server_expected_state kwarg to InstanceHelperMixin._live_migrate https://review.opendev.org/743710
12:20:06 lyarwood Does anyone have any ideas why this https://review.opendev.org/#/c/731506/ never ends up in the gate?
12:20:23 lyarwood I can't rebase it, it isn't in conflict etc
12:25:18 stephenfin lyarwood: possibly a bug in Gerrit? There is no Depends-On but it was based on a patch that has since been abandoned
12:25:35 openstackgerrit Stephen Finucane proposed openstack/nova master: compute: As cellsv1 is no more fold _detach_volume back into detach_volume https://review.opendev.org/731506
12:25:43 stephenfin that should do the trick
12:26:01 stephenfin lyarwood: Can you look at https://review.opendev.org/#/c/731506/ today?
12:26:10 stephenfin Also bauzas, perhaps? https://review.opendev.org/#/c/731506/
12:27:37 lyarwood looking
12:29:01 lyarwood stephenfin: wait, that's the link to my change
12:29:09 lyarwood stephenfin: which review did you want me to look at
12:29:25 stephenfin doh
12:29:27 stephenfin https://review.opendev.org/#/c/743568/
12:29:37 lyarwood stephenfin: and re https://review.opendev.org/731506 yeah I missed that it was still pointing at that change sorry
12:30:50 stephenfin all good
12:36:39 lyarwood stephenfin: done, LGTM, I guess func tests wouldn't make sense here given libvirt is acting up right?
12:36:56 stephenfin lyarwood: yes, that's my thinking too
12:49:43 ralonsoh stephenfin, hi! I you have some time: https://review.opendev.org/#/c/739961/
12:52:31 stephenfin ralonsoh: Could we get some context in the commit message?
12:52:41 stephenfin i.e. what it's for and why it's needed
12:53:07 ralonsoh stephenfin, ok, I'll add this
12:53:14 stephenfin thanks :)
13:00:58 openstackgerrit Rodolfo Alonso Hernandez proposed openstack/os-traits master: Add NUMA affinity policy traits https://review.opendev.org/739961
13:14:28 aarents Hi nova,
13:14:56 aarents lyarwood : When you will have time for this https://review.opendev.org/#/c/696084/4 , I split the change with another: https://review.opendev.org/#/c/743537/ and added a tempest test to reproduce the issue: https://review.opendev.org/#/c/743708/1 (failed as expected in tempest-slow-py3 jobs)
13:17:50 openstackgerrit Takashi Natsume proposed openstack/python-novaclient stable/ussuri: Add a cleanup for a server in a functional test https://review.opendev.org/743756
13:19:00 openstackgerrit Takashi Natsume proposed openstack/python-novaclient stable/train: Add a cleanup for a server in a functional test https://review.opendev.org/743757
13:42:27 openstackgerrit Lee Yarwood proposed openstack/nova master: Use absolute path during qemu img rebase https://review.opendev.org/739246
13:43:50 lyarwood ^ from gibi LGTM now if any other cores have time today
14:52:14 openstackgerrit Merged openstack/nova master: Use compression by default for 'SshDriver' https://review.opendev.org/684393
15:02:10 bauzas stephenfin: sorry, I was on PTO this morning
15:15:45 stephenfin bauzas: np. Any chance you could look at https://review.opendev.org/743568 today?
15:16:01 bauzas ack
15:16:08 stephenfin thanks :)
16:05:49 openstackgerrit Lee Yarwood proposed openstack/nova master: compute: Validate a BDMs disk_bus when provided https://review.opendev.org/724842
16:06:04 lyarwood stephenfin: ^ can you +W that again when you get a chance?
16:06:33 lyarwood https://review.opendev.org/#/c/729596/ and this please
16:07:18 lyarwood melwitt: https://review.opendev.org/#/q/topic:bug/1889108 - would you mind taking a look at this series?
16:16:08 openstackgerrit Sylvain Bauza proposed openstack/nova-specs master: Routed network scheduling spec https://review.opendev.org/733703
16:16:21 bauzas stephenfin: you may be interested in ^
16:16:48 stephenfin bauzas: Opened in a tab. I'll review that first thing in the morning.
16:16:53 bauzas ++
16:17:43 bauzas stephenfin: I guess we couldn't catch https://bugs.launchpad.net/nova/+bug/1889257 on a functional test ?
16:17:43 openstack Launchpad bug 1889257 in OpenStack Compute (nova) "Live migration of realtime instances is broken" [Medium,In progress] - Assigned to Stephen Finucane (stephenfinucane)
16:18:36 bauzas stephenfin: I need to jump straight off the keyboard but I can review decently https://review.opendev.org/#/c/743568/ later tonight
16:18:58 bauzas to be fair, the bug isn't trivial to understand and there are implications on the way we generate the XML
16:19:32 bauzas fortunately, the XML implications are limited to the attribute that is bugged
16:20:11 bauzas stephenfin: but I guess non-realtime users would be impacted by this change too, right?
16:23:18 lyarwood bauzas: I asked about func tests earlier but we'd have to mock out the way libvirt is rewriting the xml etc, we could but I don't think it's required to land this tbh.
16:23:40 lyarwood bauzas: and AFAIK it only impacts realtime LM
16:26:02 lyarwood huh we don't have a regression keyword in launchpad for nova, that might be useful.
16:26:25 bauzas we have but this is release-specific
16:27:09 bauzas lyarwood: so, I need to be absolutely sure that vcpusched is only used by the realtime users
16:28:14 lyarwood bauzas: https://github.com/openstack/nova/blob/49c3ac7dfa7aca5504f9d19958ff82a40e47f5a1/nova/virt/libvirt/driver.py#L5111-L5117
16:28:42 bauzas lyarwood: gosh lord, thank you
16:28:54 lyarwood bauzas: https://github.com/openstack/nova/blob/master/nova/virt/libvirt/driver.py#L8493-L8498
16:29:06 lyarwood artom: ^ did I miss anything btw? ./me thinks you know more about this
16:30:33 bauzas lyarwood: Saint Github tells me that the only reference of LibvirtConfigGuestCPUTuneVCPUSched is https://github.com/openstack/nova/blob/49c3ac7dfa7aca5504f9d19958ff82a40e47f5a1/nova/virt/libvirt/driver.py#L5113
16:30:50 bauzas that's enough for me
16:43:05 melwitt lyarwood: ack will do
16:45:38 lyarwood thanks
16:58:52 openstackgerrit Merged openstack/python-novaclient stable/ussuri: Switch legacy Zuul jobs to native Zuul v3 jobs https://review.opendev.org/740488
17:00:17 openstackgerrit Takashi Natsume proposed openstack/python-novaclient stable/ussuri: Add a cleanup for a server in a functional test https://review.opendev.org/743756
17:06:08 openstackgerrit Stephen Finucane proposed openstack/nova stable/ussuri: Handle multiple 'vcpusched' elements during live migrate https://review.opendev.org/743804
17:10:24 openstackgerrit Stephen Finucane proposed openstack/nova stable/train: Handle multiple 'vcpusched' elements during live migrate https://review.opendev.org/743805
19:31:30 openstackgerrit Merged openstack/nova master: Handle multiple 'vcpusched' elements during live migrate https://review.opendev.org/743568
19:45:32 openstackgerrit Sean McGinnis proposed openstack/nova master: Drop use of legacy encryptor specifiers https://review.opendev.org/743834

Earlier   Later