| Posted | Nick | Remark | |
|---|---|---|---|
| #openstack-nova - 2020-07-29 | |||
| 16:06:33 | lyarwood | https://review.opendev.org/#/c/729596/ and this please | |
| 16:07:18 | lyarwood | melwitt: https://review.opendev.org/#/q/topic:bug/1889108 - would you mind taking a look at this series? | |
| 16:16:08 | openstackgerrit | Sylvain Bauza proposed openstack/nova-specs master: Routed network scheduling spec https://review.opendev.org/733703 | |
| 16:16:21 | bauzas | stephenfin: you may be interested in ^ | |
| 16:16:48 | stephenfin | bauzas: Opened in a tab. I'll review that first thing in the morning. | |
| 16:16:53 | bauzas | ++ | |
| 16:17:43 | bauzas | stephenfin: I guess we couldn't catch https://bugs.launchpad.net/nova/+bug/1889257 on a functional test ? | |
| 16:17:43 | openstack | Launchpad bug 1889257 in OpenStack Compute (nova) "Live migration of realtime instances is broken" [Medium,In progress] - Assigned to Stephen Finucane (stephenfinucane) | |
| 16:18:36 | bauzas | stephenfin: I need to jump straight off the keyboard but I can review decently https://review.opendev.org/#/c/743568/ later tonight | |
| 16:18:58 | bauzas | to be fair, the bug isn't trivial to understand and there are implications on the way we generate the XML | |
| 16:19:32 | bauzas | fortunately, the XML implications are limited to the attribute that is bugged | |
| 16:20:11 | bauzas | stephenfin: but I guess non-realtime users would be impacted by this change too, right? | |
| 16:23:18 | lyarwood | bauzas: I asked about func tests earlier but we'd have to mock out the way libvirt is rewriting the xml etc, we could but I don't think it's required to land this tbh. | |
| 16:23:40 | lyarwood | bauzas: and AFAIK it only impacts realtime LM | |
| 16:26:02 | lyarwood | huh we don't have a regression keyword in launchpad for nova, that might be useful. | |
| 16:26:25 | bauzas | we have but this is release-specific | |
| 16:27:09 | bauzas | lyarwood: so, I need to be absolutely sure that vcpusched is only used by the realtime users | |
| 16:28:14 | lyarwood | bauzas: https://github.com/openstack/nova/blob/49c3ac7dfa7aca5504f9d19958ff82a40e47f5a1/nova/virt/libvirt/driver.py#L5111-L5117 | |
| 16:28:42 | bauzas | lyarwood: gosh lord, thank you | |
| 16:28:54 | lyarwood | bauzas: https://github.com/openstack/nova/blob/master/nova/virt/libvirt/driver.py#L8493-L8498 | |
| 16:29:06 | lyarwood | artom: ^ did I miss anything btw? ./me thinks you know more about this | |
| 16:30:33 | bauzas | lyarwood: Saint Github tells me that the only reference of LibvirtConfigGuestCPUTuneVCPUSched is https://github.com/openstack/nova/blob/49c3ac7dfa7aca5504f9d19958ff82a40e47f5a1/nova/virt/libvirt/driver.py#L5113 | |
| 16:30:50 | bauzas | that's enough for me | |
| 16:43:05 | melwitt | lyarwood: ack will do | |
| 16:45:38 | lyarwood | thanks | |
| 16:58:52 | openstackgerrit | Merged openstack/python-novaclient stable/ussuri: Switch legacy Zuul jobs to native Zuul v3 jobs https://review.opendev.org/740488 | |
| 17:00:17 | openstackgerrit | Takashi Natsume proposed openstack/python-novaclient stable/ussuri: Add a cleanup for a server in a functional test https://review.opendev.org/743756 | |
| 17:06:08 | openstackgerrit | Stephen Finucane proposed openstack/nova stable/ussuri: Handle multiple 'vcpusched' elements during live migrate https://review.opendev.org/743804 | |
| 17:10:24 | openstackgerrit | Stephen Finucane proposed openstack/nova stable/train: Handle multiple 'vcpusched' elements during live migrate https://review.opendev.org/743805 | |
| 19:31:30 | openstackgerrit | Merged openstack/nova master: Handle multiple 'vcpusched' elements during live migrate https://review.opendev.org/743568 | |
| 19:45:32 | openstackgerrit | Sean McGinnis proposed openstack/nova master: Drop use of legacy encryptor specifiers https://review.opendev.org/743834 | |
| 21:37:19 | openstackgerrit | melanie witt proposed openstack/nova master: WIP Add option to sync instance power states during shutdown https://review.opendev.org/743848 | |
| 22:31:30 | openstackgerrit | Merged openstack/nova stable/train: objects: Update keypairs when saving an instance https://review.opendev.org/742709 | |
| 22:31:36 | openstackgerrit | Merged openstack/nova master: Replace assertItemsEqual with assertCountEqual https://review.opendev.org/740575 | |
| #openstack-nova - 2020-07-30 | |||
| 01:20:06 | openstackgerrit | Tony Su proposed openstack/nova master: Provider Config File: YAML file loading and schema validation https://review.opendev.org/673341 | |
| 02:44:13 | openstackgerrit | Brin Zhang proposed openstack/nova master: Optimize _create_and_bind_arqs logic in conducor https://review.opendev.org/726564 | |
| 02:44:13 | openstackgerrit | Brin Zhang proposed openstack/nova master: cyborg evacuate support https://review.opendev.org/715326 | |
| 03:48:41 | openstackgerrit | Tony Su proposed openstack/nova master: Provider Config File: Function to further validate and retrieve configs https://review.opendev.org/676029 | |
| 07:39:30 | openstackgerrit | Tony Su proposed openstack/nova master: Provider Config File: YAML file loading and schema validation https://review.opendev.org/673341 | |
| 07:39:31 | openstackgerrit | Tony Su proposed openstack/nova master: Provider Config File: Function to further validate and retrieve configs https://review.opendev.org/676029 | |
| 07:51:56 | bauzas | stephenfin: not sure you got a chance to see my comment https://review.opendev.org/#/c/743568/1/nova/virt/libvirt/migration.py@128 | |
| 07:53:24 | tony_su | stephenfin: the first patch is uploaded and in almost-completed phase, and the second patch is ready for a new round of review. | |
| 08:24:44 | brinzhang0 | sean-k-mooney: please see https://review.opendev.org/#/c/715326/15/nova/compute/manager.py@3233, I agree with gibi, can we remove the eventlet.timeout.Timeout Exception? | |
| 08:55:40 | openstackgerrit | Alexandre Arents proposed openstack/nova master: Rebase qcow2 images when unshelving an instance https://review.opendev.org/696084 | |
| 08:59:41 | openstackgerrit | Jie Li proposed openstack/nova-specs master: add volume backed server rebuild spec https://review.opendev.org/739349 | |
| 10:12:48 | sean-k-mooney | brinzhang0: i am not sure, i think it could be raised form any https request but if we remove it and it is raised it will still be caught by the generic Exception | |
| 10:13:01 | sean-k-mooney | specifier | |
| 10:13:10 | sean-k-mooney | so it wont change behavior to remove it | |
| 10:13:19 | sean-k-mooney | so we could for brevity | |
| 11:01:31 | openstackgerrit | Harshavardhan Metla proposed openstack/nova master: Removed the host FQDN from the exception message https://review.opendev.org/743950 | |
| 12:19:39 | gibi_pto | dansmith: I've did a quick cleanup on the todays meeting agenda on the wiki for you | |
| 13:23:20 | dansmith | gibi_pto: roger, thanks, I was just going to look at it this morning | |
| 13:30:09 | openstackgerrit | Andrew Bonney proposed openstack/nova master: Fix misleading documentation for live_migration_inbound_addr https://review.opendev.org/741473 | |
| 13:34:02 | bauzas | dansmith: I guess you'll handle the v-2 tag ? | |
| 13:34:20 | dansmith | bauzas: apparently there's nothing to do, we worked that out last week I think | |
| 13:34:31 | bauzas | mmmm really ? | |
| 13:34:37 | bauzas | lemme doublecheck | |
| 13:34:49 | dansmith | according to smcginnis, but if he tells me to do something I'll do it | |
| 13:36:01 | bauzas | dansmith: can't see any nova proposed change in the releases repo | |
| 13:36:08 | bauzas | for victoria-2 I mean | |
| 13:37:36 | bauzas | actually, nevermind | |
| 13:37:41 | dansmith | let's wait for smcginnis to respond | |
| 13:37:50 | bauzas | can't see any service project change for victoria-1 either | |
| 13:37:56 | bauzas | so I guess it changed | |
| 13:38:54 | bauzas | yeah, that changed and I now remember ttx's email on openstack-discuss https://releases.openstack.org/reference/release_models.html#cycle-with-milestones | |
| 13:39:09 | bauzas | we no longer produce milestones, only rcs | |
| 13:41:02 | bauzas | ... and confirmed here https://releases.openstack.org/reference/process.html#milestone-2 | |
| 14:04:44 | smcginnis | Yep, no release needed now unless you know there is some downstream need for it. | |
| 14:09:27 | kashyap | fungi++ | |
| 14:10:04 | fungi | am i now an object-oriented compiled language? | |
| 14:11:05 | fungi | fungi99 was more flexible, even if you wound up with a lot more templating and boilerplate | |
| 14:11:41 | fungi | though my heart still belongs to classic k&r fungi | |
| 14:47:53 | ralonsoh | stephenfin, hi again | |
| 14:47:54 | ralonsoh | https://review.opendev.org/#/c/739961/ | |
| 14:48:03 | ralonsoh | if you have a bit of time | |
| 14:52:09 | openstackgerrit | Ghanshyam Mann proposed openstack/nova master: DNM: testing tempest copy-image test https://review.opendev.org/742547 | |
| 14:55:41 | openstackgerrit | Ghanshyam Mann proposed openstack/nova master: DNM: testing tempest copy-image test https://review.opendev.org/742547 | |
| 14:59:11 | stephenfin | ralonsoh: How do you plan to use these traits? That's still not entirely clear to me | |
| 14:59:41 | ralonsoh | stephenfin, if needed, that will be enforced in the port info | |
| 14:59:41 | sean-k-mooney | stephenfin: we will need nova changes next cycle to report the traits | |
| 14:59:48 | stephenfin | what resource providers will they be reported on, and who sets them? | |
| 14:59:54 | ralonsoh | let me check where exactly | |
| 15:00:30 | sean-k-mooney | stephenfin: initally they will be reported on the compute node root rp if either sriov is enabled or numa vswitches | |
| 15:00:56 | ralonsoh | stephenfin, https://review.opendev.org/#/c/740011/4/specs/victoria/port-numa-affinity-policy.rst@70 | |
| 15:01:03 | sean-k-mooney | stephenfin: if we start tracking pci device in plamcnet then it will be on the pci device RP | |
| 15:01:03 | ralonsoh | is this what you are asking? | |
| 15:01:08 | stephenfin | ah, there's a spec. That's what I was looking for | |
| 15:02:21 | ralonsoh | but yes, we are not pointing to any specific RP | |
| 15:04:12 | stephenfin | this doesn't feel like a trait or something you'd want to report | |
| 15:04:42 | ralonsoh | stephenfin, ? | |
| 15:04:52 | stephenfin | so with this feature, we're saying you'll be able to state whether NUMA affinity is important or not on a port-by-port basis | |
| 15:05:05 | sean-k-mooney | yes | |
| 15:05:06 | ralonsoh | yes | |
| 15:05:10 | stephenfin | cool, so what do we need the trait for | |
| 15:05:21 | ralonsoh | to specify the policy | |
| 15:05:22 | sean-k-mooney | to select host that supprot numa affinity | |
| 15:06:02 | stephenfin | that's a single trait, not three | |
| 15:06:05 | sean-k-mooney | stephenfin: its mostly required for numa_vswitchs | |
| 15:06:14 | stephenfin | SUPPORTS_CONFIGURABLE_NUMA_AFFINITY | |
| 15:06:20 | stephenfin | or something like that | |