Earlier  
Later
New Search
Posted Nick Remark
#openstack-nova - 2020-07-21
15:07:24 stephenfin Yeah, I don't know how that's supposed to work tbh
15:07:48 stephenfin bauzas: looking
15:08:44 openstackgerrit Balazs Gibizer proposed openstack/nova master: DNM: Test the state of VMware NSX 3pp CI https://review.opendev.org/734114
15:18:09 openstackgerrit Merged openstack/nova-specs master: template: consider openstack client besides novaclient https://review.opendev.org/717722
15:20:41 openstackgerrit Merged openstack/nova-specs master: Support SRIOV interface attach and detach https://review.opendev.org/741601
15:20:54 stephenfin bauzas: replied on https://review.opendev.org/#/c/733703/
15:21:41 stephenfin I think I'm lacking the background knowledge to review this properly at the moment, but I hope my questions aren't too dumb
15:23:06 bauzas stephenfin: okay, will write a new rev
15:28:27 artom melwitt, could you revisit https://review.opendev.org/#/c/729763/4 when you get a chance?
15:45:12 elod lyarwood: btw, I don't have +2+W right @ openstackclient repo o:)
15:46:18 openstackgerrit Takashi Natsume proposed openstack/nova master: objects: Update keypairs when saving an instance https://review.opendev.org/683043
15:46:20 elod lyarwood: also, I had another type of fix for the same issue that melwitt's patch solves, which I guess now can be abandoned - https://review.opendev.org/#/c/713865/
15:48:46 openstackgerrit Sylvain Bauza proposed openstack/nova-specs master: Routed network scheduling spec https://review.opendev.org/733703
15:49:01 bauzas stephenfin: fer your plezure ^
15:49:09 bauzas ++
15:55:43 artom bauzas, grah, left comments on PS4 just as you uploaded PS5
15:58:21 gibi o/
16:57:30 melwitt artom: sure, will do
16:58:15 melwitt lyarwood: I lost +Ws on this patch and the one above it bc of rebase if you could please revisit later https://review.opendev.org/691459
17:06:26 openstackgerrit Stephen Finucane proposed openstack/nova master: libvirt: Re-enable live snapshot for paused instances https://review.opendev.org/740334
17:06:26 openstackgerrit Stephen Finucane proposed openstack/nova master: libvirt: Remove workaround for really old QEMU https://review.opendev.org/740335
17:06:27 openstackgerrit Stephen Finucane proposed openstack/nova master: libvirt: Use better variable names, types for '_create_guest' https://review.opendev.org/740945
17:06:27 openstackgerrit Stephen Finucane proposed openstack/nova master: WIP: Attempt to restore some sanity to snapshot https://review.opendev.org/740336
17:31:43 openstackgerrit Merged openstack/nova stable/stein: Remove stale nested backport from InstancePCIRequests https://review.opendev.org/738199
17:34:30 openstackgerrit Merged openstack/nova stable/stein: zuul: remove legacy-tempest-dsvm-neutron-dvr-multinode-full https://review.opendev.org/742113
17:34:44 openstackgerrit Merged openstack/nova master: libvirt: apply mixed instance CPU policy https://review.opendev.org/728481
17:39:45 openstackgerrit Luigi Toscano proposed openstack/nova stable/rocky: zuul: remove legacy-tempest-dsvm-neutron-dvr-multinode-full https://review.opendev.org/742258
20:59:56 openstackgerrit Jiri Suchomel proposed openstack/nova master: Add ability to download Glance images into the libvirt image cache via RBD https://review.opendev.org/574301
21:04:22 openstackgerrit melanie witt proposed openstack/nova master: libvirt: Handle VIR_ERR_DEVICE_MISSING when detaching devices https://review.opendev.org/741561
21:06:23 lyarwood melwitt: thanks for that review and update, really appreciated and apologies for not spelling this out in the change itself.
21:07:20 melwitt lyarwood: np, sorry for all the grief on this one. I was just not understanding the second test scenario fully, it wasn't you, it was me
21:08:53 melwitt some of the original comments in the test were written by me the first time I learned that code, so I had a preexisting idea of the test in my head and had trouble processing the new changes 😝
21:22:43 lyarwood melwitt: yeah this flow is really really awkward at the moment, I'd really like to break it down and simplify things in master after this if I can
21:23:15 lyarwood melwitt: I'm thinking of looking up which config the device is actually listed in before calling for the detach
21:23:44 lyarwood melwitt: so we always use the correct flags and hopefully avoid getting this error code
21:31:41 melwitt lyarwood: ack
21:32:16 melwitt lyarwood: also I dunno if you saw earlier but I need +W back on these two patches pls https://review.opendev.org/691459 after the rebases
21:32:29 lyarwood melwitt: ah sorry I missed that ./me looks
21:32:48 melwitt thanks. hopefully it is just easy
21:33:01 lyarwood yup ACK'd
21:33:11 lyarwood thanks for fixing the func tests :)
21:33:57 melwitt thank you! and np, took me a comically long time to find the already-done change on stable/rocky
21:34:11 melwitt glad it worked on queens
21:37:26 lyarwood ah the joys of stable maint
21:38:24 lyarwood zomg this thing is broken! ./me spends 3 days fixing it ; oh look Matt fixed and backported this to the branch above this a year ago
21:39:17 lyarwood ^ that happened all the damn time when I started working on Nova, thankfully it's not that often now.
21:40:26 melwitt lol, thanks for making me feel better 😆
21:42:11 lyarwood haha sorry yeah that does come across wrong
21:42:50 lyarwood it has definietly happened to me on the older branches recently FWIW
21:42:50 melwitt no, it's ok :) I know what you meant
21:43:02 lyarwood the nova-live-migration job stuff was super fun >.<
21:44:52 melwitt yeah that looked impossible. kudos for getting through it
22:50:15 openstackgerrit Ghanshyam Mann proposed openstack/nova master: Add new default roles in FIP policies https://review.opendev.org/742030
23:00:46 openstackgerrit Alex Deiter proposed openstack/nova master: Detach is broken for multi-attached fs-based volumes https://review.opendev.org/741712
23:36:45 openstackgerrit Ghanshyam Mann proposed openstack/nova master: Add test coverage of multinic policies https://review.opendev.org/742315
23:46:34 openstackgerrit Merged openstack/nova master: Validate CPU pinning configuration for mixed instance https://review.opendev.org/716268
23:46:42 openstackgerrit Merged openstack/nova master: Calculate the CPU usage for mixed instance https://review.opendev.org/716269
23:50:29 openstackgerrit Merged openstack/nova master: scheduler: mixed instance CPU resource translating https://review.opendev.org/728482
23:50:35 openstackgerrit Merged openstack/nova master: compute: bump nova-compute version and check in API https://review.opendev.org/740933
#openstack-nova - 2020-07-22
00:01:03 openstackgerrit Ghanshyam Mann proposed openstack/nova master: Fix multinic policy for admin_or_owner https://review.opendev.org/742317
00:01:22 openstackgerrit Ghanshyam Mann proposed openstack/nova master: Add test coverage of multinic policies https://review.opendev.org/742315
01:36:32 openstackgerrit Ghanshyam Mann proposed openstack/nova master: Add test coverage of multinic policies https://review.opendev.org/742315
01:40:53 openstackgerrit Ghanshyam Mann proposed openstack/nova master: Introduce scope_types in multinic policy https://review.opendev.org/742328
01:53:59 openstackgerrit Ghanshyam Mann proposed openstack/nova master: Add new default roles in multinic policies https://review.opendev.org/742330
02:09:14 openstackgerrit Merged openstack/nova master: Remove broken legacy zuul jobs https://review.opendev.org/741603
02:12:03 openstackgerrit Brin Zhang proposed openstack/nova master: Delete ARQs by UUID if Cyborg ARQ bind fails. https://review.opendev.org/716186
02:17:55 openstackgerrit Ghanshyam Mann proposed openstack/nova master: Add test coverage of multinic policies https://review.opendev.org/742315
02:18:02 openstackgerrit Ghanshyam Mann proposed openstack/nova master: Introduce scope_types in multinic policy https://review.opendev.org/742328
02:22:34 openstackgerrit Merged openstack/nova master: Reduce gen conflict in COMPUTE_STATUS_DISABLED handling https://review.opendev.org/704866
02:23:02 openstackgerrit Ghanshyam Mann proposed openstack/nova master: Add new default roles in multinic policies https://review.opendev.org/742330
02:46:27 openstackgerrit Merged openstack/nova master: Make our ceph job test with glance in multistore mode https://review.opendev.org/734184
03:23:38 openstackgerrit Merged openstack/nova stable/stein: Create instance action when burying in cell0 https://review.opendev.org/729531
03:32:43 tony_su gibi: alex_xu: Thanks for your reviewing and comments. I will check them and update patches accordingly. In any way I have to change patches as there is merging conflict.
06:39:54 openstackgerrit Adit Sarfaty proposed openstack/nova master: Set different VirtualDevice.key https://review.opendev.org/713565
07:33:40 gibi stephenfin: hi! you vtpm patches are the next for a runway slot, but if I understood correctly the main feature patches are in merge conflict.
07:33:56 gibi stephenfin: if you have a set of ready patches then I can pull that into a slot
07:34:16 gibi stephenfin: do you have a clear bottom that is ready?
07:46:05 openstackgerrit Sergey Galas' proposed openstack/nova master: fixes broken shared live migration of a vm with a vif aka Bug #1888395 https://review.opendev.org/742180
07:46:05 openstack bug 1888395 in OpenStack Compute (nova) "shared live migration of a vm with a vif is broken in train" [Undecided,New] https://launchpad.net/bugs/1888395 - Assigned to Sergey Galas' (shrike742)
07:53:05 openstackgerrit Sergey Galas' proposed openstack/nova master: fixes broken shared live migration of a vm with a vif aka Bug #1888395 https://review.opendev.org/742180
07:53:05 openstack bug 1888395 in OpenStack Compute (nova) "shared live migration of a vm with a vif is broken in train" [Undecided,New] https://launchpad.net/bugs/1888395 - Assigned to Sergey Galas' (shrike742)
08:01:55 kleini What means a cpu_allocation_ratio of zero actually in placement or scheduler?
08:07:15 gibi kleini: have you seen the Note in this doc ? https://docs.openstack.org/nova/latest/configuration/config.html#DEFAULT.cpu_allocation_ratio
08:07:56 kleini Yes, but it confuses me more, than it clarifies behavior for me.
08:09:05 gibi kleini: OK, then the next piece of doc is https://docs.openstack.org/nova/latest/admin/configuration/schedulers.html#allocation-ratios
08:09:58 kleini That clarifies the defaults. Many thanks!
08:11:11 kleini I was already on the same page but did not read past compute filters *facepalm*
08:11:12 gibi you are welcome
08:14:06 gibi kleini: don't be hard on yourself, allocation ratios is confusing
08:15:36 kleini yes, a whole OpenStack is huge and maintenance sometimes gives headaches but it always resolves somehow after some time of research.
08:33:20 openstackgerrit Lee Yarwood proposed openstack/nova master: libvirt: Handle VIR_ERR_DEVICE_MISSING when detaching devices https://review.opendev.org/741561
08:48:41 stephenfin gibi: I can rebase, but I was hoping lyarwood might be able to hit some of the lower ones that you've already looked at before I did
08:49:21 lyarwood stephenfin: vtpm?
08:51:20 lyarwood stephenfin: I'll take a look this morning once I've woken up a little more, had a long night :|
08:51:59 stephenfin lyarwood: yup and sure, no problem :D
08:52:08 lyarwood stephenfin / gibi ; https://review.opendev.org/#/c/741561/ should be ready for reviews now btw now that melwitt++ has updated the comments
08:59:32 kashyap lyarwood: I appreciate the commit message with informative (non-null) pointers -- https://review.opendev.org/#/c/741561/. Good sleuthing :-)
09:04:41 lyarwood I thought you might :)
09:06:19 gibi stephenfin: OK. we can put the lower ones into a slot
09:09:18 gibi lyarwood: approved https://review.opendev.org/#/c/741561/

Earlier   Later