Earlier  
Later
New Search
Posted Nick Remark
#openstack-nova - 2020-07-22
01:36:32 openstackgerrit Ghanshyam Mann proposed openstack/nova master: Add test coverage of multinic policies https://review.opendev.org/742315
01:40:53 openstackgerrit Ghanshyam Mann proposed openstack/nova master: Introduce scope_types in multinic policy https://review.opendev.org/742328
01:53:59 openstackgerrit Ghanshyam Mann proposed openstack/nova master: Add new default roles in multinic policies https://review.opendev.org/742330
02:09:14 openstackgerrit Merged openstack/nova master: Remove broken legacy zuul jobs https://review.opendev.org/741603
02:12:03 openstackgerrit Brin Zhang proposed openstack/nova master: Delete ARQs by UUID if Cyborg ARQ bind fails. https://review.opendev.org/716186
02:17:55 openstackgerrit Ghanshyam Mann proposed openstack/nova master: Add test coverage of multinic policies https://review.opendev.org/742315
02:18:02 openstackgerrit Ghanshyam Mann proposed openstack/nova master: Introduce scope_types in multinic policy https://review.opendev.org/742328
02:22:34 openstackgerrit Merged openstack/nova master: Reduce gen conflict in COMPUTE_STATUS_DISABLED handling https://review.opendev.org/704866
02:23:02 openstackgerrit Ghanshyam Mann proposed openstack/nova master: Add new default roles in multinic policies https://review.opendev.org/742330
02:46:27 openstackgerrit Merged openstack/nova master: Make our ceph job test with glance in multistore mode https://review.opendev.org/734184
03:23:38 openstackgerrit Merged openstack/nova stable/stein: Create instance action when burying in cell0 https://review.opendev.org/729531
03:32:43 tony_su gibi: alex_xu: Thanks for your reviewing and comments. I will check them and update patches accordingly. In any way I have to change patches as there is merging conflict.
06:39:54 openstackgerrit Adit Sarfaty proposed openstack/nova master: Set different VirtualDevice.key https://review.opendev.org/713565
07:33:40 gibi stephenfin: hi! you vtpm patches are the next for a runway slot, but if I understood correctly the main feature patches are in merge conflict.
07:33:56 gibi stephenfin: if you have a set of ready patches then I can pull that into a slot
07:34:16 gibi stephenfin: do you have a clear bottom that is ready?
07:46:05 openstackgerrit Sergey Galas' proposed openstack/nova master: fixes broken shared live migration of a vm with a vif aka Bug #1888395 https://review.opendev.org/742180
07:46:05 openstack bug 1888395 in OpenStack Compute (nova) "shared live migration of a vm with a vif is broken in train" [Undecided,New] https://launchpad.net/bugs/1888395 - Assigned to Sergey Galas' (shrike742)
07:53:05 openstackgerrit Sergey Galas' proposed openstack/nova master: fixes broken shared live migration of a vm with a vif aka Bug #1888395 https://review.opendev.org/742180
07:53:05 openstack bug 1888395 in OpenStack Compute (nova) "shared live migration of a vm with a vif is broken in train" [Undecided,New] https://launchpad.net/bugs/1888395 - Assigned to Sergey Galas' (shrike742)
08:01:55 kleini What means a cpu_allocation_ratio of zero actually in placement or scheduler?
08:07:15 gibi kleini: have you seen the Note in this doc ? https://docs.openstack.org/nova/latest/configuration/config.html#DEFAULT.cpu_allocation_ratio
08:07:56 kleini Yes, but it confuses me more, than it clarifies behavior for me.
08:09:05 gibi kleini: OK, then the next piece of doc is https://docs.openstack.org/nova/latest/admin/configuration/schedulers.html#allocation-ratios
08:09:58 kleini That clarifies the defaults. Many thanks!
08:11:11 kleini I was already on the same page but did not read past compute filters *facepalm*
08:11:12 gibi you are welcome
08:14:06 gibi kleini: don't be hard on yourself, allocation ratios is confusing
08:15:36 kleini yes, a whole OpenStack is huge and maintenance sometimes gives headaches but it always resolves somehow after some time of research.
08:33:20 openstackgerrit Lee Yarwood proposed openstack/nova master: libvirt: Handle VIR_ERR_DEVICE_MISSING when detaching devices https://review.opendev.org/741561
08:48:41 stephenfin gibi: I can rebase, but I was hoping lyarwood might be able to hit some of the lower ones that you've already looked at before I did
08:49:21 lyarwood stephenfin: vtpm?
08:51:20 lyarwood stephenfin: I'll take a look this morning once I've woken up a little more, had a long night :|
08:51:59 stephenfin lyarwood: yup and sure, no problem :D
08:52:08 lyarwood stephenfin / gibi ; https://review.opendev.org/#/c/741561/ should be ready for reviews now btw now that melwitt++ has updated the comments
08:59:32 kashyap lyarwood: I appreciate the commit message with informative (non-null) pointers -- https://review.opendev.org/#/c/741561/. Good sleuthing :-)
09:04:41 lyarwood I thought you might :)
09:06:19 gibi stephenfin: OK. we can put the lower ones into a slot
09:09:18 gibi lyarwood: approved https://review.opendev.org/#/c/741561/
09:12:32 lyarwood gibi: thanks
09:15:56 stephenfin I really wish Gerrit had notifications a lá GitHub. Would save me parsing the emails every morning :-\
09:21:34 openstackgerrit Lee Yarwood proposed openstack/nova master: Detach is broken for multi-attached fs-based volumes https://review.opendev.org/741712
09:37:33 openstackgerrit Merged openstack/nova master: hardware: Enable 'hw:cpu_dedicated_mask' for creating a mixed instance https://review.opendev.org/714706
10:00:26 tony_su gibi: just status update for provider-config-file patches. I have updated the first two patches and is now working on the 3rd patch.
10:13:18 gibi tony_su: thanks. i will try to get back those patches soon
10:15:37 openstackgerrit Yingji Sun proposed openstack/nova master: Set different VirtualDevice.key https://review.opendev.org/713565
10:17:19 stephenfin lyarwood: Could you also re-add https://review.opendev.org/742383 to your list?
10:24:42 lyarwood stephenfin: ack
10:27:17 stephenfin ta
10:30:33 stephenfin bauzas: Got an old, pretty trivial patch for you here if you've got time today? https://review.opendev.org/#/c/684393/
10:32:11 bauzas stephenfin: I can take a look
10:42:16 stephenfin bauzas: thanks!
10:43:03 openstackgerrit Stephen Finucane proposed openstack/nova stable/stein: libvirt: Mark e1000e VIF as supported https://review.opendev.org/742390
10:43:23 openstackgerrit Stephen Finucane proposed openstack/nova stable/stein: libvirt: Mark e1000e VIF as supported https://review.opendev.org/742390
11:27:21 openstackgerrit Alex Deiter proposed openstack/nova master: Detach is broken for multi-attached fs-based volumes https://review.opendev.org/741712
11:37:46 openstackgerrit Yingji Sun proposed openstack/nova master: resolve ResourceProviderSyncFailed issue https://review.opendev.org/742398
12:15:24 openstackgerrit Takashi Natsume proposed openstack/nova master: Remove six.PY2 and six.PY3 https://review.opendev.org/726512
12:15:44 openstackgerrit Takashi Natsume proposed openstack/nova master: Remove six.add_metaclass https://review.opendev.org/726565
12:16:01 openstackgerrit Takashi Natsume proposed openstack/nova master: Remove six.reraise https://review.opendev.org/726898
12:16:23 openstackgerrit Takashi Natsume proposed openstack/nova master: Remove six.moves https://review.opendev.org/727224
12:16:43 openstackgerrit Takashi Natsume proposed openstack/nova master: Remove six.iteritems/itervalues/iterkeys https://review.opendev.org/727757
12:16:57 openstackgerrit Takashi Natsume proposed openstack/nova master: Remove six.byte2int/int2byte https://review.opendev.org/727777
12:17:13 openstackgerrit Takashi Natsume proposed openstack/nova master: Remove six.binary_type/integer_types/string_types https://review.opendev.org/728094
12:23:15 openstackgerrit Balazs Gibizer proposed openstack/nova master: Undeprecate the vmwareapi driver https://review.opendev.org/742407
12:26:35 openstackgerrit Balazs Gibizer proposed openstack/nova master: Undeprecate the vmwareapi driver https://review.opendev.org/742407
12:28:14 openstackgerrit Takashi Natsume proposed openstack/nova master: Remove six.text_type (1/2) https://review.opendev.org/728109
12:28:51 openstackgerrit Takashi Natsume proposed openstack/nova master: Remove six.text_type (2/2) https://review.opendev.org/728117
12:29:20 openstackgerrit Takashi Natsume proposed openstack/nova master: objects: Update keypairs when saving an instance https://review.opendev.org/683043
12:39:15 openstackgerrit Merged openstack/nova master: libvirt: Re-enable live snapshot for paused instances https://review.opendev.org/740334
12:41:40 stephenfin gibi: Could you stick https://review.opendev.org/#/c/683043/ on your review queue, please? :)
12:42:32 gibi stephenfin: ack, enqueued
12:52:56 openstackgerrit Merged openstack/nova master: libvirt: Handle VIR_ERR_DEVICE_MISSING when detaching devices https://review.opendev.org/741561
13:06:45 openstackgerrit Lee Yarwood proposed openstack/nova stable/ussuri: libvirt: Handle VIR_ERR_DEVICE_MISSING when detaching devices https://review.opendev.org/742414
13:07:23 openstackgerrit Lee Yarwood proposed openstack/nova stable/train: libvirt: Handle VIR_ERR_DEVICE_MISSING when detaching devices https://review.opendev.org/742415
13:07:44 openstackgerrit Lee Yarwood proposed openstack/nova stable/stein: libvirt: Handle VIR_ERR_DEVICE_MISSING when detaching devices https://review.opendev.org/742416
13:08:05 openstackgerrit Lee Yarwood proposed openstack/nova stable/rocky: libvirt: Handle VIR_ERR_DEVICE_MISSING when detaching devices https://review.opendev.org/742417
13:12:36 openstackgerrit Lee Yarwood proposed openstack/nova stable/queens: libvirt: Remove reference to transient domain when detaching devices https://review.opendev.org/608186
13:12:37 openstackgerrit Lee Yarwood proposed openstack/nova stable/queens: sync_guest_time: use the proper errno https://review.opendev.org/742423
13:12:37 openstackgerrit Lee Yarwood proposed openstack/nova stable/queens: libvirt: Handle VIR_ERR_DEVICE_MISSING when detaching devices https://review.opendev.org/742424
13:21:04 lyarwood bauzas: https://review.opendev.org/#/c/729595/ - would you mind hitting this again?
13:21:14 bauzas ack
13:21:56 lyarwood https://review.opendev.org/#/c/729261/ could also use some additional core review if anyone has bandwidth
13:22:51 lyarwood and https://review.opendev.org/#/c/724842/ both are pretty simple
13:27:35 gibi lyarwood: added to my queue but I will focus on the sriov attach this afternoon so I can get to your patches tomorrow
13:29:21 bauzas lyarwood: stephenfin: gibi: others, honestly, I'd be super happy if we could just provide a commit tag for py3-only changes
13:29:30 bauzas something like "Py3-only"
13:29:41 bauzas so, stable cores looking at it would see it
13:29:56 bauzas I know how this can be difficult to do it every time
13:30:20 bauzas but if people don't think about py3 styling, then I'm pretty sure we will get bugs in say one year
13:30:38 bauzas context https://review.opendev.org/#/c/729595/6/nova/virt/libvirt/guest.py@868
13:30:51 bauzas I totally understand that people want to use py3 styling
13:31:17 bauzas but honestly, if you want to do it, think about backports
13:31:35 gibi bauzas: I would expect that such thing is caught by the unit test on the backported patch
13:31:36 lyarwood stable cores would see this, py2 jobs would bork due to this.
13:32:12 lyarwood also, the py3 style boat has sailed
13:32:20 bauzas gibi: well, for https://review.opendev.org/#/c/729595/6/nova/virt/libvirt/guest.py@868 we don't test it, right?
13:32:23 lyarwood stephenfin has been landing stuff for most of the cycle already
13:32:51 bauzas lyarwood: I don't see how CI can see it : https://review.opendev.org/#/c/729595/6/nova/virt/libvirt/guest.py@868
13:32:53 lyarwood bauzas: that's a DEBUG log in a codepath we hit loads in our tempest tests so that would definitley catch it
13:32:54 bauzas with py3

Earlier   Later