Posted	Nick	Remark
#openstack-nova - 2020-07-21
12:14:52	gibi	devfaz: I have no idea. Have you tried asking the networking guys about it on #openstack-neutron ?
12:18:21	devfaz	gibi: thx a lot for your quick answer. I think I found a global masq-rule.. having to take a look.
12:19:11	devfaz	just someone else runs into this - if im true, there is an issue with docker-default-network and the masq-rule it creates. I will analyse and report back.
12:35:06	openstackgerrit	Stephen Finucane proposed openstack/nova master: rpc: Rework 'get_notifier', 'wrap_exception' https://review.opendev.org/741663
12:35:07	openstackgerrit	Stephen Finucane proposed openstack/nova master: mypy: Add type annotations to top-level modules https://review.opendev.org/705658
12:35:07	openstackgerrit	Stephen Finucane proposed openstack/nova master: WIP: Expand type hints for nova.block_device https://review.opendev.org/742170
12:36:53	stephenfin	alex_xu: done
12:56:56	alex_xu	stephenfin: thanks
13:00:23	openstackgerrit	Sergey Galas' proposed openstack/nova master: fixes broken shared live migration of a vm with a vif aka Bug #1888395 https://review.opendev.org/742180
13:00:23	openstack	bug 1888395 in OpenStack Compute (nova) "shared live migration of a vm with a vif is broken in train" [Undecided,New] https://launchpad.net/bugs/1888395 - Assigned to Sergey Galas' (shrike742)
13:01:28	openstackgerrit	Sasha Andonov proposed openstack/nova stable/pike: libvirt: Do not reraise DiskNotFound exceptions during resize https://review.opendev.org/742181
13:02:22	lyarwood	stephenfin: https://review.opendev.org/#/c/710861/ - so reading https://review.opendev.org/#/c/715406/ back you suggested we DON'T want to backport this correct?
13:11:40	openstackgerrit	Sergey Galas' proposed openstack/nova master: fixes broken shared live migration of a vm with a vif aka Bug #1888395 https://review.opendev.org/742180
13:11:40	openstack	bug 1888395 in OpenStack Compute (nova) "shared live migration of a vm with a vif is broken in train" [Undecided,New] https://launchpad.net/bugs/1888395 - Assigned to Sergey Galas' (shrike742)
13:38:36	openstackgerrit	Huaqiang Wang proposed openstack/nova master: metadata: export the vCPU IDs that are pinning on the host CPUs https://review.opendev.org/688936
13:38:37	openstackgerrit	Huaqiang Wang proposed openstack/nova master: release note: add new features introduces by use-pcpu-and-vcpu-in-one-instance https://review.opendev.org/736997
13:38:37	openstackgerrit	Huaqiang Wang proposed openstack/nova master: test: add some notes and new tests for mixed instance https://review.opendev.org/741395
13:57:35	openstackgerrit	Merged openstack/nova stable/queens: fix scsi disk unit number of the attaching volume when cdrom bus is scsi https://review.opendev.org/730313
13:57:41	openstackgerrit	Merged openstack/nova master: Switch from unittest2 compat methods to Python 3.x methods https://review.opendev.org/737511
13:58:35	stephenfin	lyarwood: Oh, I think it was more a case of I didn't think it was backportable that shouldn't be backported
14:07:00	openstackgerrit	Merged openstack/nova master: Remove unnecessary retrieval of Migration object https://review.opendev.org/730351
14:07:07	openstackgerrit	Merged openstack/nova master: Remove unused function parameters https://review.opendev.org/730352
14:22:15	openstackgerrit	Merged openstack/nova master: Move image verification and writing out of download method https://review.opendev.org/738738
14:22:21	openstackgerrit	Merged openstack/nova master: Repro gen conflict in COMPUTE_STATUS_DISABLED handling https://review.opendev.org/704865
14:38:21	bauzas	stephenfin, other cores : you could be interested in https://review.opendev.org/#/c/733703/
14:38:30	bauzas	tl:dr: routed networks spec
14:39:21	nightmare_unreal	hello I am trying to implement 'nova migration-list' cmd for osc cli. I have implemented most part but I am not able to understand from where the values are coming for certain fields like UUID, project_ID and user_id
14:41:04	stephenfin	nightmare_unreal: can you give us an example?
14:43:21	openstackgerrit	Elod Illes proposed openstack/nova stable/pike: Check cherry-pick hashes in pep8 tox target https://review.opendev.org/742212
14:44:29	openstackgerrit	Stephen Finucane proposed openstack/nova master: Remove support for Intel CMT events https://review.opendev.org/740922
14:47:31	openstackgerrit	Balazs Gibizer proposed openstack/nova-specs master: Support SRIOV interface attach and detach https://review.opendev.org/741601
14:47:48	gibi	bauzas: fixed up the spec ^^
14:49:55	bauzas	gibi: +2/+w
14:49:57	nightmare_unreal	sure stephenfin . if you run 'nova migration-list' you get this output. I am not able to get where it gets UUID, project_id and user_id . https://usercontent.irccloud-cdn.com/file/Ypg9cDNc/migration-list.png
14:50:20	nightmare_unreal	Looking at the source code here : https://github.com/openstack/python-novaclient/blob/master/novaclient/v2/migrations.py , I can't see those fields
14:52:48	stephenfin	nightmare_unreal: https://docs.openstack.org/api-ref/compute/?expanded=list-migrations-detail
14:53:12	stephenfin	that's the API it's using, and the docs describe the various fields in the response
14:53:25	gibi	bauzas: thansk
14:53:28	gibi	thanks even
14:53:52	stephenfin	nightmare_unreal: looks like they were introduced in microversions, which might be why you're not seeing them in your own response
14:53:54	stephenfin	*s
14:54:16	nightmare_unreal	thanks stephenfin . I will go through it. Thing that was bothering me was migration object has only these attributes : ['__add__', '__class__', '__contains__', '__delattr__', '__delitem__', '__dict__', '__dir__', '__doc__', '__eq__', '__format__', '__ge__', '__getattribute__', '__getitem__', '__gt__', '__hash__', '__iadd__', '__imul__', '__init__', '__init_subclass__', '__iter__', '__le__', '__len__',
14:54:16	nightmare_unreal	'__lt__', '__module__', '__mul__', '__ne__', '__new__', '__reduce__', '__reduce_ex__', '__repr__', '__reversed__', '__rmul__', '__setattr__', '__setitem__', '__sizeof__', '__str__', '__subclasshook__', '__weakref__', '_append_request_id', 'append', 'append_request_ids', 'clear', 'copy', 'count', 'extend', 'index', 'insert', 'pop', 'remove', 'request_ids', 'request_ids_setup', 'reverse', 'sort',
14:54:16	nightmare_unreal	'x_openstack_request_ids']
14:54:36	nightmare_unreal	and it does not contain the fields I mentioned
14:55:00	nightmare_unreal	stephenfin: yeah microversions can be the thing to look at too
14:55:08	stephenfin	That doesn't look like a migration object
14:55:40	stephenfin	Though that depends on what you mean by object
15:01:35	nightmare_unreal	hmm
15:01:49	nightmare_unreal	i was running compute_client.migrations.list() command
15:01:55	openstackgerrit	Elod Illes proposed openstack/nova stable/stein: compute: Allow snapshots to be created from PAUSED volume backed instances https://review.opendev.org/729176
15:07:15	stephenfin	ah, you mean Migration from novaclient
15:07:24	stephenfin	Yeah, I don't know how that's supposed to work tbh
15:07:48	stephenfin	bauzas: looking
15:08:44	openstackgerrit	Balazs Gibizer proposed openstack/nova master: DNM: Test the state of VMware NSX 3pp CI https://review.opendev.org/734114
15:18:09	openstackgerrit	Merged openstack/nova-specs master: template: consider openstack client besides novaclient https://review.opendev.org/717722
15:20:41	openstackgerrit	Merged openstack/nova-specs master: Support SRIOV interface attach and detach https://review.opendev.org/741601
15:20:54	stephenfin	bauzas: replied on https://review.opendev.org/#/c/733703/
15:21:41	stephenfin	I think I'm lacking the background knowledge to review this properly at the moment, but I hope my questions aren't too dumb
15:23:06	bauzas	stephenfin: okay, will write a new rev
15:28:27	artom	melwitt, could you revisit https://review.opendev.org/#/c/729763/4 when you get a chance?
15:45:12	elod	lyarwood: btw, I don't have +2+W right @ openstackclient repo o:)
15:46:18	openstackgerrit	Takashi Natsume proposed openstack/nova master: objects: Update keypairs when saving an instance https://review.opendev.org/683043
15:46:20	elod	lyarwood: also, I had another type of fix for the same issue that melwitt's patch solves, which I guess now can be abandoned - https://review.opendev.org/#/c/713865/
15:48:46	openstackgerrit	Sylvain Bauza proposed openstack/nova-specs master: Routed network scheduling spec https://review.opendev.org/733703
15:49:01	bauzas	stephenfin: fer your plezure ^
15:49:09	bauzas	++
15:55:43	artom	bauzas, grah, left comments on PS4 just as you uploaded PS5
15:58:21	gibi	o/
16:57:30	melwitt	artom: sure, will do
16:58:15	melwitt	lyarwood: I lost +Ws on this patch and the one above it bc of rebase if you could please revisit later https://review.opendev.org/691459
17:06:26	openstackgerrit	Stephen Finucane proposed openstack/nova master: libvirt: Re-enable live snapshot for paused instances https://review.opendev.org/740334
17:06:26	openstackgerrit	Stephen Finucane proposed openstack/nova master: libvirt: Remove workaround for really old QEMU https://review.opendev.org/740335
17:06:27	openstackgerrit	Stephen Finucane proposed openstack/nova master: libvirt: Use better variable names, types for '_create_guest' https://review.opendev.org/740945
17:06:27	openstackgerrit	Stephen Finucane proposed openstack/nova master: WIP: Attempt to restore some sanity to snapshot https://review.opendev.org/740336
17:31:43	openstackgerrit	Merged openstack/nova stable/stein: Remove stale nested backport from InstancePCIRequests https://review.opendev.org/738199
17:34:30	openstackgerrit	Merged openstack/nova stable/stein: zuul: remove legacy-tempest-dsvm-neutron-dvr-multinode-full https://review.opendev.org/742113
17:34:44	openstackgerrit	Merged openstack/nova master: libvirt: apply mixed instance CPU policy https://review.opendev.org/728481
17:39:45	openstackgerrit	Luigi Toscano proposed openstack/nova stable/rocky: zuul: remove legacy-tempest-dsvm-neutron-dvr-multinode-full https://review.opendev.org/742258
20:59:56	openstackgerrit	Jiri Suchomel proposed openstack/nova master: Add ability to download Glance images into the libvirt image cache via RBD https://review.opendev.org/574301
21:04:22	openstackgerrit	melanie witt proposed openstack/nova master: libvirt: Handle VIR_ERR_DEVICE_MISSING when detaching devices https://review.opendev.org/741561
21:06:23	lyarwood	melwitt: thanks for that review and update, really appreciated and apologies for not spelling this out in the change itself.
21:07:20	melwitt	lyarwood: np, sorry for all the grief on this one. I was just not understanding the second test scenario fully, it wasn't you, it was me
21:08:53	melwitt	some of the original comments in the test were written by me the first time I learned that code, so I had a preexisting idea of the test in my head and had trouble processing the new changes 😝
21:22:43	lyarwood	melwitt: yeah this flow is really really awkward at the moment, I'd really like to break it down and simplify things in master after this if I can
21:23:15	lyarwood	melwitt: I'm thinking of looking up which config the device is actually listed in before calling for the detach
21:23:44	lyarwood	melwitt: so we always use the correct flags and hopefully avoid getting this error code
21:31:41	melwitt	lyarwood: ack
21:32:16	melwitt	lyarwood: also I dunno if you saw earlier but I need +W back on these two patches pls https://review.opendev.org/691459 after the rebases
21:32:29	lyarwood	melwitt: ah sorry I missed that ./me looks
21:32:48	melwitt	thanks. hopefully it is just easy
21:33:01	lyarwood	yup ACK'd
21:33:11	lyarwood	thanks for fixing the func tests :)
21:33:57	melwitt	thank you! and np, took me a comically long time to find the already-done change on stable/rocky
21:34:11	melwitt	glad it worked on queens
21:37:26	lyarwood	ah the joys of stable maint
21:38:24	lyarwood	zomg this thing is broken! ./me spends 3 days fixing it ; oh look Matt fixed and backported this to the branch above this a year ago
21:39:17	lyarwood	^ that happened all the damn time when I started working on Nova, thankfully it's not that often now.
21:40:26	melwitt	lol, thanks for making me feel better 😆
21:42:11	lyarwood	haha sorry yeah that does come across wrong

Earlier   Later