| Posted | Nick | Remark | |
|---|---|---|---|
| #openstack-nova - 2020-07-16 | |||
| 12:18:38 | gibi | seem equivalent, yes | |
| 12:18:48 | stephenfin | So my series is gaining yet another tech debt reduction patch \o/ | |
| 12:18:51 | stephenfin | every. damn. time. | |
| 12:19:18 | sean-k-mooney | you could pretend you did not see it :P | |
| 12:19:29 | sean-k-mooney | also this seams backwards to me | |
| 12:20:00 | sean-k-mooney | i would have had instance.image_meta just call utils.get_image_from_system_metadata(sysmeta) | |
| 12:20:24 | gibi | stephenfin: you are a hero removing those depts | |
| 12:20:28 | gibi | debts | |
| 12:20:36 | sean-k-mooney | and had image_meta.from_instance(instance) return instance.image_meta | |
| 12:21:20 | stephenfin | fair point | |
| 12:21:23 | stephenfin | much of a muchness | |
| 12:21:38 | stephenfin | worth noting the 'ImageMeta.from_instance' also handles multiple different ways of storing system_metadata in the instance object | |
| 12:21:41 | sean-k-mooney | there are extra db queries curently | |
| 12:21:43 | stephenfin | if indeed instance is an object | |
| 12:22:18 | stephenfin | I've no idea if that call to 'utils.instance_sys_meta' is necessary, vs. just using 'instance.system_metadata' | |
| 12:22:45 | sean-k-mooney | it should not bey system_metadata is always loaded by default | |
| 12:23:14 | sean-k-mooney | https://github.com/openstack/nova/blob/master/nova/objects/instance.py#L70-L71 | |
| 12:23:15 | stephenfin | An it's a 'DictOfNullableStringsField' type field | |
| 12:23:23 | stephenfin | so it couldn't be anything *except* a dict | |
| 12:23:51 | stephenfin | so this check seems like garbage https://github.com/openstack/nova/blob/master/nova/utils.py#L547-L549 | |
| 12:23:57 | sean-k-mooney | ya it might be empty but it will be a dict | |
| 12:24:24 | stephenfin | yup, undefined or a dict. Nothing else since it's not nullable | |
| 12:24:51 | sean-k-mooney | well i dont know it might be there for some reason in the past | |
| 12:25:00 | stephenfin | pre-o.vo, most likely | |
| 12:25:33 | sean-k-mooney | https://github.com/openstack/nova/commit/96164cecc6b7bf447d06896f723dab416e63ee06 | |
| 12:25:53 | openstackgerrit | Merged openstack/nova stable/rocky: Reject boot request for unsupported images https://review.opendev.org/708608 | |
| 12:26:46 | sean-k-mooney | so ya it was part of the ovo migration | |
| 12:27:06 | sean-k-mooney | its proably not needed 7 years later. | |
| 13:35:57 | artom | gibi, how did you notice https://bugs.launchpad.net/nova/+bug/1887799 ? | |
| 13:35:57 | openstack | Launchpad bug 1887799 in OpenStack Compute (nova) "interface metadata is not regenerated after interface detach" [Low,In progress] - Assigned to Balazs Gibizer (balazs-gibizer) | |
| 13:36:04 | artom | Code inspection, or "real life"? | |
| 13:36:14 | artom | Because... we *do* update device metadata on restart | |
| 13:36:17 | artom | Just no in the driver | |
| 13:36:21 | artom | Lemme comment on the patch | |
| 13:36:44 | gibi | artom: working on the SRIOV interface attach feature and during detach I see that there is metadata left in the database | |
| 13:36:52 | gibi | then I inspected the code | |
| 13:37:34 | artom | gibi, something else is going on then: https://opendev.org/openstack/nova/src/branch/master/nova/network/neutron.py#L1755 | |
| 13:37:35 | sean-k-mooney | gibi: your actully workign on that | |
| 13:38:14 | sean-k-mooney | gibi: do you have any patches up | |
| 13:38:17 | gibi | sean-k-mooney: I've spent two day on it and I have a WIP patch, now writin a small spec | |
| 13:38:27 | sean-k-mooney | gibi: cool | |
| 13:38:34 | gibi | sean-k-mooney: https://review.opendev.org/#/c/740995/ | |
| 13:38:42 | gibi | sean-k-mooney: it works in devstack already | |
| 13:39:03 | artom | gibi, shot in the dark, but maybe your bug is related to https://review.opendev.org/#/c/670593/ ? | |
| 13:39:09 | sean-k-mooney | the code is more or less already there in regards to actully doing the attach. all that was missing was the claim which wew can do form the api using the new rpc calls added for live migration | |
| 13:39:42 | gibi | artom: thanks for the pointers I wil dig | |
| 13:40:03 | gibi | sean-k-mooney: yes, I needed to put together the pieces | |
| 13:40:12 | gibi | but most of the pieces exist | |
| 13:40:35 | sean-k-mooney | yep we say that when we filed the bug a few year ago but it was too close to code freeze to get it in | |
| 13:40:49 | sean-k-mooney | it was deemed to need a spec and we were past m2 | |
| 13:41:17 | sean-k-mooney | so the curent api check was added but we never went and fixed it. that was pre sriov migration so it was more work then | |
| 13:42:32 | jsuchome | gibi: thanks for your +2, what/who do we need for starting the workflow? | |
| 13:43:10 | sean-k-mooney | gibi: ill try an test out your change today or tomorow im currently working on the fucntial test for my pci device lookup patches but ill test yours when i test that on real hardware | |
| 14:07:45 | gibi | jsuchome: you need one more +2 . But I also suggest that pull this back to the original series so that the reviewers of the original series will see it and review it | |
| 14:08:11 | gibi | sean-k-mooney: thanks. any test is useful | |
| 14:08:28 | gibi | sean-k-mooney: I now have access with a physical machine with SRIOV card | |
| 14:13:51 | jsuchome | lyarwood: hi, could you please take a look at https://review.opendev.org/#/c/738738/ ? that's a new prerequisite to direct-rbd-download to make things more readable | |
| 14:14:31 | lyarwood | jsuchome: ack queued, might not get to it today however | |
| 14:14:46 | jsuchome | great, thanks! | |
| 14:34:40 | huaqiang | hi, I have a question, do we support specify such flavor and image metadata conbination：vcpus=4, hw:cpu_realtime=yes, hw_cpu_policy=dedicated , hw_cpu_realtime_mask=^0 | |
| 14:35:58 | huaqiang | I don't the general rule using extra_specs with image properties | |
| 14:36:28 | openstackgerrit | Artom Lifshitz proposed openstack/nova master: Add regression test for bug 1879787 https://review.opendev.org/741230 | |
| 14:36:28 | openstack | bug 1879787 in OpenStack Compute (nova) "post_live_migration does not handle Neutron errors" [Medium,In progress] https://launchpad.net/bugs/1879787 - Assigned to Artom Lifshitz (notartom) | |
| 14:36:28 | openstackgerrit | Artom Lifshitz proposed openstack/nova master: Handle Neutron errors in _post_live_migration() https://review.opendev.org/729763 | |
| 14:37:02 | huaqiang | s/"I don't"/"I don't find'"/ | |
| 14:44:20 | sean-k-mooney | gibi: sorry was on a call but ya having sriov capably hardware is both a blessing and a curse | |
| 14:45:18 | sean-k-mooney | vcpus=4 is not a valid extraspc | |
| 14:45:50 | sean-k-mooney | but yes the rest would be valid | |
| 14:46:25 | sean-k-mooney | we can only assert that the realtime requireemtn for a mask are fullfiled when we have both the flavor and image | |
| 14:46:42 | sean-k-mooney | so we cant use the current flavor validation feature to asset it its correct | |
| 14:47:01 | sean-k-mooney | and if you use the flavor with hw:cpu_realtime=yes | |
| 14:47:22 | sean-k-mooney | with a flavor that does not declare the cpu policy and mask it will be an error | |
| 14:49:12 | sean-k-mooney | huaqiang: https://github.com/openstack/nova/blob/057891ac247fadfb9637d3e834f8b1ef3e39bc27/nova/compute/api.py#L598 is where the requiremtn will be checked | |
| 14:50:06 | sean-k-mooney | for realtime it validated here https://github.com/openstack/nova/blob/057891ac247fadfb9637d3e834f8b1ef3e39bc27/nova/virt/hardware.py#L1719 | |
| 14:52:24 | huaqiang | sean-k-mooney: I think the combination I listed is allowed by code | |
| 14:52:31 | huaqiang | but looks ugly | |
| 14:52:57 | huaqiang | hw_cpu_policy=dedicated , hw_cpu_realtime_mask=^0 | |
| 14:53:27 | huaqiang | the cpu policy and realtime mask are set in iamge | |
| 14:53:48 | huaqiang | but realtime switch is in flavor :hw:cpu_realtime=yes | |
| 14:54:00 | openstackgerrit | Andrew Bonney proposed openstack/nova master: Fix misleading documentation for live_migration_inbound_addr https://review.opendev.org/741473 | |
| 14:54:15 | sean-k-mooney | yes it is allow | |
| 14:54:38 | sean-k-mooney | and yes we would generall recommend that you set all 3 in the falvor | |
| 14:54:48 | sean-k-mooney | and then ovrride the mask in the image if needed | |
| 14:54:48 | bauzas | gibi: I won't be around tonight for the team meeting | |
| 14:55:06 | bauzas | gibi: nothing to report but aarents's ask for reviews in https://etherpad.opendev.org/p/nova-libvirt-subteam | |
| 14:55:16 | bauzas | (for the libvirt subteam) | |
| 14:55:53 | bauzas | gibi: also, we are now 2 weeks close to the Victoria-2 milestone and we only have 10 approved specs | |
| 14:56:14 | bauzas | ah shit, netsplit | |
| 14:58:53 | huaqiang | sean-k-mooney: That's recommendation, but code must cope with any corner case | |
| 14:59:32 | sean-k-mooney | huaqiang: correct because we wanted to suppot both explcitly in the spec | |
| 14:59:38 | sean-k-mooney | this is working as desigined | |
| 14:59:51 | sean-k-mooney | we do handel the corner cases in the code already | |
| 14:59:53 | huaqiang | clear now. Thanks | |
| 15:00:31 | huaqiang | I need to deal with another such case in rebuild | |
| 15:00:59 | sean-k-mooney | ah no | |
| 15:01:07 | sean-k-mooney | in rebuild this shoudl not change | |
| 15:01:38 | huaqiang | rebuild from realtime-dedicated instance to realtime-mixed instance | |
| 15:01:41 | sean-k-mooney | there should already be a check that compares the numa toplogy objects with the flavor and old image vs flavor and new image | |
| 15:01:48 | sean-k-mooney | huaqiang: that is not allowed | |
| 15:02:08 | sean-k-mooney | rebuild are not allowed to change resouce allocattions | |