Earlier  
Later
New Search
Posted Nick Remark
#openstack-nova - 2020-07-16
14:59:38 sean-k-mooney this is working as desigined
14:59:51 sean-k-mooney we do handel the corner cases in the code already
14:59:53 huaqiang clear now. Thanks
15:00:31 huaqiang I need to deal with another such case in rebuild
15:00:59 sean-k-mooney ah no
15:01:07 sean-k-mooney in rebuild this shoudl not change
15:01:38 huaqiang rebuild from realtime-dedicated instance to realtime-mixed instance
15:01:41 sean-k-mooney there should already be a check that compares the numa toplogy objects with the flavor and old image vs flavor and new image
15:01:48 sean-k-mooney huaqiang: that is not allowed
15:02:08 sean-k-mooney rebuild are not allowed to change resouce allocattions
15:02:20 sean-k-mooney going form dedicated to mixed changes that
15:02:36 sean-k-mooney the current cod ei added for numa rebuidl should block that
15:02:56 bauzas gibi: so, you're back from the netsplit
15:03:12 bauzas retelling my story
15:03:16 bauzas gibi: I won't be around tonight for the team meeting
15:03:19 bauzas gibi: nothing to report but aarents's ask for reviews in https://etherpad.opendev.org/p/nova-libvirt-subteam
15:03:23 bauzas (for the libvirt subteam)
15:03:26 sean-k-mooney huaqiang: https://github.com/openstack/nova/blob/057891ac247fadfb9637d3e834f8b1ef3e39bc27/nova/compute/api.py#L3538-L3578
15:03:27 bauzas gibi: also, we are now 2 weeks close to the Victoria-2 milestone and we only have 10 approved specs
15:03:39 bauzas gibi: should we do a Spec review day ?
15:04:11 gibi ohh I was away?
15:04:35 gibi bauzas: do you see open specs that needs our focus?
15:04:58 gibi if there are open specs that are ready for review then sure we can have a spec review day
15:05:30 bauzas gibi: I have a pretty short specs dashboard
15:06:20 sean-k-mooney huaqiang: i have functional test that assert the correct behavior here https://github.com/openstack/nova/blob/master/nova/tests/functional/libvirt/test_numa_servers.py#L1051
15:06:55 sean-k-mooney i am not modifying cpu policy but that shoudl also be blocked by that code
15:07:39 sean-k-mooney it should be trivial to add a functional test to assert that it does not change
15:08:11 sean-k-mooney or rather that an attepmt to rebuild form dedicated to mixed will be rejected
15:08:29 gibi bauzas: I will ask the others on the meeting about a spec review day
15:08:35 gibi bauzas: next week is good for you?
15:08:51 bauzas yup
15:09:09 gibi cool
15:09:09 bauzas anyway, it's just a question, since we don't have a lot of open specs
15:09:27 bauzas https://review.opendev.org/#/q/project:openstack/nova-specs+is:open
15:09:29 gibi at most it won't be a super busy day :)
15:09:46 bauzas this said, I'll create a new spec for the reshape tool
15:09:49 sean-k-mooney its proably good to do before m2 in either case
15:09:58 gibi bauzas: and I will push one for SRIOV attach
15:10:12 bauzas ack, all good
15:10:15 gibi :)
15:10:54 bauzas gibi: I'd also write a spec for GPU NUMA affinity using the NUMA topology in placement, but it's more for discussing about it this cycle, not wanting to merge it
15:11:15 sean-k-mooney gibi: im proably going to try an add support for sriov PF detach as a bug fix this cycle too
15:11:27 sean-k-mooney im not sure if it would make sense to add it to your spec or not
15:12:01 huaqiang sean-k-mooney: I need time to digest your code.
15:12:18 sean-k-mooney gibi: when vnic_type=direct-physical was added detach was never updated
15:12:46 sean-k-mooney it tries to find the nic by its mac but we dont have a mac in this case
15:12:59 gibi sean-k-mooney: before you go into that check my detach code if that solves your case too ro not
15:13:02 gibi bauzas: ack
15:13:25 sean-k-mooney gibi: it might we just need to fine the device by its pci address not it mac
15:14:07 sean-k-mooney since we use a <hostdev> element instead of <interface type=hostdev> for pfs
15:15:08 sean-k-mooney sriov detach works for vnic_type=direct|macvtap|virtio-forwarder today just not direct-physical
15:15:42 gibi sean-k-mooney: works and removes the pci claim too?
15:16:22 sean-k-mooney gibi: ill admit i cant rememebr i think so but we dont currently block it because it complete succefully
15:16:43 sean-k-mooney so its updateing the neuton port and removing the port form the virtual interfaces table
15:17:00 gibi sean-k-mooney: I had to add https://review.opendev.org/#/c/740995/2/nova/compute/manager.py@7416 to make the pci device freed
15:17:05 sean-k-mooney i belive it free the device but it might be "working" but not doing the right thing
15:17:31 gibi but it can be that some periodic would free that
15:17:39 dansmith melwitt: the last dependency for this is about to merge in the gate.. wanna send it? https://review.opendev.org/#/c/734184/
15:17:53 sean-k-mooney gibi: ya i think the periodic is what we rely on
15:18:40 sean-k-mooney doing it premtivly is better but i think we get back into a consitent state
15:18:55 sean-k-mooney ill test it before i apply your patch and let you know
15:20:03 gibi sean-k-mooney: cool
15:25:50 sean-k-mooney gibi: by the way if i confim that we did not free the pci device do we want to backport a fix to block detach the same way we backported a patch to block attach for older releases?
15:26:08 sean-k-mooney i.e. if the periodic does not fix it
15:29:42 gibi sean-k-mooney: I'm not sure. If people using it then blocking it would be bad
15:30:12 sean-k-mooney it cloud be done vai a conig option i guess like numa live migration
15:30:25 sean-k-mooney we can cross that bridge when we come to it
15:30:29 gibi yeah
15:45:31 gibi nova meeting starts in 15 minutes on #openstack-meeting-3
16:30:55 artom Hey, if we set a bug as incomplete, can the reporter then switch it back once they come back with new logs?
16:31:35 artom My thinking is: to avoid other people looking at it needlessly, set it as incomplete, and let the reporter come back with the info. Is that how we do i?
16:31:38 artom it
16:31:40 gibi artom: they can switch it back
16:31:55 gibi just ask them to set it back to New
16:32:47 openstackgerrit Elod Illes proposed openstack/nova stable/rocky: Check cherry-pick hashes in pep8 tox target https://review.opendev.org/741492
16:44:24 artom Is (anti-)affinity in placement a thing we track?
16:44:33 sean-k-mooney artom: no
16:45:03 artom Context: https://bugs.launchpad.net/nova/+bug/1886160 looks like ye olde "the late anti-affinity check on the host is super racy" problem
16:45:03 openstack Launchpad bug 1886160 in OpenStack Compute (nova) "Anti-affinity instance creation failed and the scheduling node was incorrect." [Undecided,New]
16:45:11 artom So I'm looking for something to tell them other than "tough luck"
16:45:43 sean-k-mooney how about dont use multi create if you also use numa or sriov
16:46:31 sean-k-mooney the fact we now precompute a series of alternate host insead of rescudling on retry actully makes anti affinity worse
16:53:57 artom Right, we're < 30 untriaged, and I need lunch
17:04:28 openstackgerrit Stephen Finucane proposed openstack/nova master: libvirt: Simplify '_create_domain' function https://review.opendev.org/739208
17:04:28 openstackgerrit Stephen Finucane proposed openstack/nova master: libvirt: Add vTPM config support https://review.opendev.org/739209
17:04:29 openstackgerrit Stephen Finucane proposed openstack/nova master: scheduler: Request vTPM trait based on flavor or image https://review.opendev.org/739210
17:04:29 openstackgerrit Stephen Finucane proposed openstack/nova master: crypto: Add support for creating, destroying vTPM secrets https://review.opendev.org/739211
17:04:30 openstackgerrit Stephen Finucane proposed openstack/nova master: manager: Prevent compute startup on invalid vTPM config https://review.opendev.org/739212
17:04:30 openstackgerrit Stephen Finucane proposed openstack/nova master: tests: Rename tests for '_create_guest_with_network' https://review.opendev.org/740464
17:04:31 openstackgerrit Stephen Finucane proposed openstack/nova master: tests: Move single use constants to their callers https://review.opendev.org/741280
17:04:31 openstackgerrit Stephen Finucane proposed openstack/nova master: tests: Define constants in '_IntegratedTestBase' https://review.opendev.org/741281
17:04:32 openstackgerrit Stephen Finucane proposed openstack/nova master: tests: Remove 'test_servers.ServersTestBase' https://review.opendev.org/741282
17:04:32 openstackgerrit Stephen Finucane proposed openstack/nova master: tests: Add 'PlacementHelperMixin', 'PlacementInstanceHelperMixin' https://review.opendev.org/741283
17:04:33 openstackgerrit Stephen Finucane proposed openstack/nova master: tests: Make '_IntegratedTestBase' subclass 'PlacementInstanceHelperMixin' https://review.opendev.org/741284
17:04:33 openstackgerrit Stephen Finucane proposed openstack/nova master: tests: Add helpers for suspend, resume and reboot of server https://review.opendev.org/741285
17:04:34 openstackgerrit Stephen Finucane proposed openstack/nova master: libvirt: Pass context, instance to '_create_domain' https://review.opendev.org/741286
17:04:34 openstackgerrit Stephen Finucane proposed openstack/nova master: libvirt: Add emulated TPM support to Nova https://review.opendev.org/631363
17:04:35 openstackgerrit Stephen Finucane proposed openstack/nova master: WIP: Add support for resize and cold migration of emulated TPM files https://review.opendev.org/639934
17:04:35 openstackgerrit Stephen Finucane proposed openstack/nova master: docs: Add docs for vTPM support https://review.opendev.org/739213
17:04:40 openstackgerrit Stephen Finucane proposed openstack/nova master: api: Reject non-spawn operations for vTPM https://review.opendev.org/741500

Earlier   Later