Earlier  
Later
New Search
Posted Nick Remark
#openstack-nova - 2020-07-06
13:05:07 sean-k-mooney i would prefer to abandon it but its written so im fine with merging it
13:06:03 bauzas okay, thanks
13:06:36 sean-k-mooney if ye can weigh in on https://review.opendev.org/#/c/739131/1/nova/virt/libvirt/host.py@1181
13:07:06 sean-k-mooney i could technically move the typeing chnage into a third patch but i think that sets a bad precident
13:07:22 sean-k-mooney we talkabout this in the past with some of stephens patches too.
13:07:48 sean-k-mooney if pepole want me to split that i can but that is the only open question im aware of
13:09:49 sean-k-mooney bauzas: im not really sure why i could not get the unit test you asked for working on firday but i started from scratch this morning and it worked fine so i obvioulys was doing something dumb before
13:10:59 bauzas sean-k-mooney: honestly, I'm on the same page with melwitt about py3 typing
13:11:12 bauzas but I already said that here :)
13:11:43 sean-k-mooney bauzas: ya so i really dont want to set the percident that we dont use typing just because we are going to backport a patch
13:12:15 sean-k-mooney if i must i can split it but i will then be backportin that to ussuri but not to train
13:12:31 sean-k-mooney lyarwood: any input form a stable point of view ^
13:12:36 bauzas well, I'm not opiniated
13:13:23 lyarwood sean-k-mooney: yup that's fine from a stable / downstream point of view
13:13:44 sean-k-mooney lyarwood: which is. removing the typing annotation on backport
13:13:57 bauzas but honestly the balance in between risks and benefits is a a bit small
13:14:11 bauzas and I don't understand why we would *have to* provide types
13:14:21 bauzas but if someone wants to do it, then meh
13:14:23 sean-k-mooney we dont but i think we should
13:14:27 lyarwood sean-k-mooney: oh I missed that
13:14:38 openstackgerrit Merged openstack/nova master: libvirt: ensure disk_over_commit is not negative https://review.opendev.org/719008
13:14:40 lyarwood sean-k-mooney: I thought you were just talking about the direct downstream backport part
13:15:08 sean-k-mooney well input on that is fine too. that is more based on time constraints downstream
13:15:19 sean-k-mooney normally i would just do it upstream
13:32:54 sean-k-mooney gibi: thanks :)
13:33:03 sean-k-mooney ill brb going to grab lunch
13:41:00 openstackgerrit Lee Yarwood proposed openstack/nova stable/ussuri: libvirt: Mark e1000e VIF as supported https://review.opendev.org/736957
13:53:36 openstackgerrit Dan Smith proposed openstack/nova master: DNM: Try to make a glance multistore job https://review.opendev.org/734184
15:09:41 openstackgerrit Balazs Gibizer proposed openstack/nova master: Prevent starting controller with older than N-1 computes https://review.opendev.org/738482
15:24:03 openstackgerrit Balazs Gibizer proposed openstack/nova master: Prevent starting controller with older than N-1 computes https://review.opendev.org/738482
15:31:04 openstackgerrit Dan Smith proposed openstack/nova master: DNM: Try to make a glance multistore job https://review.opendev.org/734184
16:11:18 openstackgerrit Ghanshyam Mann proposed openstack/nova master: Fix mock for 'autospec' and 'new' together https://review.opendev.org/739333
16:29:44 openstackgerrit Balazs Gibizer proposed openstack/nova master: Prevent starting controller with older than N-1 computes https://review.opendev.org/738482
16:30:45 openstackgerrit Lin Yang proposed openstack/nova master: Add traits for new AVX512 CPU feature https://review.opendev.org/731288
16:31:38 gibi dansmith, melwitt, alex_xu: Thanks for the feedback in https://review.opendev.org/#/c/738482 (N-1 compute support). I've updated the patch and now it has tests too
17:28:26 dansmith gibi: I would be +2 except for this question: https://review.opendev.org/#/c/738482/4/nova/conductor/manager.py
17:28:30 dansmith am I missing why we still need that?
17:30:40 dansmith gibi: also, the max-concurrent-snapshots stuff is all merged I think, so it can come off of the runway list
17:48:10 openstackgerrit Merged openstack/nova master: catch libvirt exception when nodedev not found. https://review.opendev.org/739017
17:50:19 openstackgerrit Merged openstack/nova stable/ussuri: libvirt: Mark e1000e VIF as supported https://review.opendev.org/736957
19:21:05 openstackgerrit sean mooney proposed openstack/nova stable/ussuri: catch libvirt exception when nodedev not found. https://review.opendev.org/739593
20:08:24 gmann dansmith: melwitt can you please check this easy review to make tests happy with oslotest 4.4.0 - https://review.opendev.org/#/c/739333/
20:14:42 dansmith gmann: got it
20:15:55 gmann thanks
21:22:24 openstackgerrit Lee Yarwood proposed openstack/nova stable/rocky: Add functional test for bug 1550919 https://review.opendev.org/732707
21:22:24 openstack bug 1550919 in OpenStack Compute (nova) rocky "[Libvirt]Evacuate fail may cause disk image be deleted" [Medium,In progress] https://launchpad.net/bugs/1550919 - Assigned to Lee Yarwood (lyarwood)
21:22:24 openstackgerrit Lee Yarwood proposed openstack/nova stable/rocky: libvirt: Don't delete disks on shared storage during evacuate https://review.opendev.org/732708
21:22:24 openstackgerrit Lee Yarwood proposed openstack/nova stable/rocky: nova-live-migration: Fix OS detection during Ceph tests https://review.opendev.org/739608
21:23:31 openstackgerrit Lee Yarwood proposed openstack/nova stable/rocky: Make greande jobs n-v for EM and oldest stable https://review.opendev.org/739020
21:32:41 openstackgerrit Lee Yarwood proposed openstack/nova stable/rocky: Make greande jobs n-v for EM and oldest stable https://review.opendev.org/739020
21:32:41 openstackgerrit Lee Yarwood proposed openstack/nova stable/rocky: nova-live-migration: Fix OS detection during Ceph tests https://review.opendev.org/739608
21:32:43 openstackgerrit Lee Yarwood proposed openstack/nova stable/rocky: Add functional test for bug 1550919 https://review.opendev.org/732707
21:32:43 openstack bug 1550919 in OpenStack Compute (nova) rocky "[Libvirt]Evacuate fail may cause disk image be deleted" [Medium,In progress] https://launchpad.net/bugs/1550919 - Assigned to Lee Yarwood (lyarwood)
21:32:43 openstackgerrit Lee Yarwood proposed openstack/nova stable/rocky: libvirt: Don't delete disks on shared storage during evacuate https://review.opendev.org/732708
21:32:46 lyarwood ^ okay that should work now, grenade and nova-live-migration disabled, nova-live-migration fixed, other changes landing on top.
21:32:58 lyarwood \o
21:36:46 openstackgerrit Merged openstack/nova master: Fix mock for 'autospec' and 'new' together https://review.opendev.org/739333
21:50:12 openstackgerrit Lee Yarwood proposed openstack/nova stable/rocky: Make greande jobs n-v for EM and oldest stable https://review.opendev.org/739020
21:50:13 openstackgerrit Lee Yarwood proposed openstack/nova stable/rocky: nova-live-migration: Fix OS detection during Ceph tests https://review.opendev.org/739608
21:50:16 openstackgerrit Lee Yarwood proposed openstack/nova stable/rocky: Add functional test for bug 1550919 https://review.opendev.org/732707
21:50:16 openstack bug 1550919 in OpenStack Compute (nova) rocky "[Libvirt]Evacuate fail may cause disk image be deleted" [Medium,In progress] https://launchpad.net/bugs/1550919 - Assigned to Lee Yarwood (lyarwood)
21:50:16 openstackgerrit Lee Yarwood proposed openstack/nova stable/rocky: libvirt: Don't delete disks on shared storage during evacuate https://review.opendev.org/732708
23:22:51 openstackgerrit Merged openstack/nova stable/stein: Revert "Make greande jobs n-v for EM and oldest stable" https://review.opendev.org/739464
#openstack-nova - 2020-07-07
02:11:34 openstackgerrit Merged openstack/nova master: Add traits for new AVX512 CPU feature https://review.opendev.org/731288
03:58:19 openstackgerrit Jie Li proposed openstack/nova-specs master: add volume backed server rebuild spec https://review.opendev.org/739349
06:01:47 openstackgerrit Tony Su proposed openstack/nova master: Provider Config File: YAML file loading and schema validation https://review.opendev.org/673341
06:01:47 openstackgerrit Tony Su proposed openstack/nova master: Provider Config File: Function to further validate and retrieve configs https://review.opendev.org/676029
06:01:48 openstackgerrit Tony Su proposed openstack/nova master: Provider Config File: Functions to merge provider configs to provider tree https://review.opendev.org/676522
06:01:48 openstackgerrit Tony Su proposed openstack/nova master: Provider Config File: Enable loading and merging of provider configs https://review.opendev.org/693460
06:56:06 openstackgerrit Balazs Gibizer proposed openstack/nova master: DNM: test mypy https://review.opendev.org/739663
06:56:51 openstackgerrit Johannes Kulik proposed openstack/nova master: vmware: Handle exception in destroy with attached volumes https://review.opendev.org/738416
06:59:03 gibi stephenfin: hi! have you sent out a mail about of this virt driver change https://review.opendev.org/#/c/730382/6/nova/virt/driver.py@891 ?
07:07:31 openstackgerrit Balazs Gibizer proposed openstack/nova master: WIP: Sanity check for NumInstancesFilter https://review.opendev.org/529866
07:08:09 openstackgerrit Balazs Gibizer proposed openstack/nova master: WIP: Sanity check for NumInstancesFilter https://review.opendev.org/529866
07:20:54 openstackgerrit Huaqiang Wang proposed openstack/nova master: compute: bump nova-compute service version for mixed instance https://review.opendev.org/716271
07:20:54 openstackgerrit Huaqiang Wang proposed openstack/nova master: hardware: create 'mixed' instance for realtime and shared CPUs https://review.opendev.org/728485
07:20:55 openstackgerrit Huaqiang Wang proposed openstack/nova master: libvirt/hardware: refactor numa_get_constraints https://review.opendev.org/718294
07:20:55 openstackgerrit Huaqiang Wang proposed openstack/nova master: metadata: export the vCPU IDs that are pinning on the host CPUs https://review.opendev.org/688936
07:20:56 openstackgerrit Huaqiang Wang proposed openstack/nova master: release note: add new features introduces by use-pcpu-and-vcpu-in-one-instance https://review.opendev.org/736997
07:25:12 gibi dansmith: thanks for the headsup. Cleaned up the runway slot after max-concurrent-snapshots
07:40:59 openstackgerrit Akhil Gudise proposed openstack/nova master: Moved all calls from _ENFORCER.authorize to a separate _authorize method https://review.opendev.org/739460
09:11:03 sapd1 Hi everyone, I'm using Openstack Train. My environment has 2000 instances. when I list all servers in a server. It takes 3 seconds to call to the endpoint "/v2.1/17a1c3c952c84b3e84a82ddd48364938/servers/detail"
10:04:06 openstackgerrit Lee Yarwood proposed openstack/nova stable/rocky: nova-live-migration: Fix OS detection during Ceph tests https://review.opendev.org/739608
10:05:21 lyarwood ^ this is fun
10:12:42 lyarwood huh grenade is passing between queens and rocky now?
10:13:19 lyarwood https://zuul.opendev.org/t/openstack/builds?job_name=neutron-grenade%20&branch=stable%2Frocky yup my bad
10:17:24 openstackgerrit Lee Yarwood proposed openstack/nova stable/rocky: Fix os_CODENAME detection and repo refresh during ceph tests https://review.opendev.org/739608
10:17:30 lyarwood elod: ^ okay lets try that to fix the ceph stuff on stable/rocky
10:17:32 elod lyarwood: queens will pass as soon as devstack / Pike is fixed - with this patch https://review.opendev.org/#/c/735616/
10:17:40 lyarwood elod: ack thanks, sorry for missing that
10:18:51 elod lyarwood: looking. thanks for working on the ceph issue, I am waaay behind with it than you :)
10:19:09 elod your findings look promising
10:20:08 lyarwood always fun brushing up on my debian/ubuntu skills tbh :)
10:20:41 elod :D
10:35:02 gibi stephenfin: fyi, I still don't fully get the mypy behavior https://review.opendev.org/#/c/739663/
10:55:49 openstackgerrit Akhil Gudise proposed openstack/nova master: Moved all calls from _ENFORCER.authorize to a separate _authorize method https://review.opendev.org/739460
12:07:17 openstackgerrit Jie Li proposed openstack/nova-specs master: add volume backed server rebuild spec https://review.opendev.org/739349
12:10:32 gibi I need some opinion about returning http 500 from the nova API here https://review.opendev.org/#/c/739157/2/nova/compute/api.py@5074
12:46:08 bauzas gibi: hola, /me looks
12:51:48 bauzas gibi: well, please no

Earlier   Later