Earlier  
Later
New Search
Posted Nick Remark
#openstack-nova - 2020-07-07
10:05:21 lyarwood ^ this is fun
10:12:42 lyarwood huh grenade is passing between queens and rocky now?
10:13:19 lyarwood https://zuul.opendev.org/t/openstack/builds?job_name=neutron-grenade%20&branch=stable%2Frocky yup my bad
10:17:24 openstackgerrit Lee Yarwood proposed openstack/nova stable/rocky: Fix os_CODENAME detection and repo refresh during ceph tests https://review.opendev.org/739608
10:17:30 lyarwood elod: ^ okay lets try that to fix the ceph stuff on stable/rocky
10:17:32 elod lyarwood: queens will pass as soon as devstack / Pike is fixed - with this patch https://review.opendev.org/#/c/735616/
10:17:40 lyarwood elod: ack thanks, sorry for missing that
10:18:51 elod lyarwood: looking. thanks for working on the ceph issue, I am waaay behind with it than you :)
10:19:09 elod your findings look promising
10:20:08 lyarwood always fun brushing up on my debian/ubuntu skills tbh :)
10:20:41 elod :D
10:35:02 gibi stephenfin: fyi, I still don't fully get the mypy behavior https://review.opendev.org/#/c/739663/
10:55:49 openstackgerrit Akhil Gudise proposed openstack/nova master: Moved all calls from _ENFORCER.authorize to a separate _authorize method https://review.opendev.org/739460
12:07:17 openstackgerrit Jie Li proposed openstack/nova-specs master: add volume backed server rebuild spec https://review.opendev.org/739349
12:10:32 gibi I need some opinion about returning http 500 from the nova API here https://review.opendev.org/#/c/739157/2/nova/compute/api.py@5074
12:46:08 bauzas gibi: hola, /me looks
12:51:48 bauzas gibi: well, please no
12:51:55 bauzas it's an evacuate action
13:09:57 gibi bauzas: sorry, I'm on call, will look back
13:11:20 bauzas gibi: no worries, provided my thoughts in the change
14:53:46 stephenfin gibi: Very long answer at https://review.opendev.org/#/c/730382/
15:13:25 openstackgerrit Sean McGinnis proposed openstack/nova master: Use unittest.mock instead of third party mock https://review.opendev.org/714676
15:15:40 openstackgerrit Sean McGinnis proposed openstack/nova master: hacking: force explicit import of python's mock https://review.opendev.org/708768
15:19:03 openstackgerrit Sean McGinnis proposed openstack/nova master: hacking: force explicit import of python's mock https://review.opendev.org/708768
15:22:59 openstackgerrit Stephen Finucane proposed openstack/nova master: virt: Add 'context', drop 'network_info' parameters for 'unrescue' https://review.opendev.org/730382
15:22:59 openstackgerrit Stephen Finucane proposed openstack/nova master: crypto: Add type hints https://review.opendev.org/739207
15:23:00 openstackgerrit Stephen Finucane proposed openstack/nova master: libvirt: Split '_create_domain' function https://review.opendev.org/739208
15:23:00 openstackgerrit Stephen Finucane proposed openstack/nova master: libvirt: Add vTPM config support https://review.opendev.org/739209
15:23:01 openstackgerrit Stephen Finucane proposed openstack/nova master: scheduler: Request vTPM trait based on flavor or image https://review.opendev.org/739210
15:23:01 openstackgerrit Stephen Finucane proposed openstack/nova master: crypto: Add support for creating, destroying vTPM secrets https://review.opendev.org/739211
15:23:02 openstackgerrit Stephen Finucane proposed openstack/nova master: manager: Prevent compute startup on invalid vTPM config https://review.opendev.org/739212
15:23:03 openstackgerrit Stephen Finucane proposed openstack/nova master: Add emulated TPM support to Nova https://review.opendev.org/631363
15:23:03 openstackgerrit Stephen Finucane proposed openstack/nova master: docs: Add docs for vTPM support https://review.opendev.org/739213
15:23:03 openstackgerrit Stephen Finucane proposed openstack/nova master: Add support for resize and cold migration of emulated TPM files https://review.opendev.org/639934
15:42:57 gibi bauzas: thanks for the reply
15:43:59 gibi bauzas: so basically you suggest to put the instance to ERROR but then what http return code should be emit? still 500 as the error is on the server side as the db is become inconsistent?
15:45:30 bauzas gibi: good question
15:45:42 bauzas maybe a 50x error yes
15:45:45 bauzas but not a 500
15:47:00 gibi I don't see any appropriate 50x code
15:51:10 bauzas honestly, it's a bikeshed and I need to go off
15:51:23 bauzas gibi: let's discuss it tomorrow morning if you want
15:51:31 bauzas I will think about that this evening
15:51:34 gibi bauzas: sure, I will ping you
15:54:12 openstackgerrit Dan Smith proposed openstack/nova master: DNM: Try to make a glance multistore job https://review.opendev.org/734184
16:02:57 openstackgerrit Balazs Gibizer proposed openstack/nova master: DNM: test mypy https://review.opendev.org/739663
16:08:09 openstackgerrit Balazs Gibizer proposed openstack/nova master: DNM: test mypy https://review.opendev.org/739663
16:12:12 gmann gibi: bauzas we do raise 404 for mapping not founds for other server actions from APi controller
16:12:31 gmann same we can do for evacuate too.
16:22:58 gibi gmann: good point I see the example in nova.api.openstack.compute.servers.ServersController._get_instance now
16:24:15 gibi stephenfin: thanks for the answer in https://review.opendev.org/#/c/730382/
16:24:38 stephenfin No problem. Was good to get that cleared up in my own head
16:24:58 stephenfin Bring on more questions. This stuff is all pretty new to me too
16:26:31 gibi I think I will have question in the future too. Best would be to allocate some of my time to play with mypy in a sandbox. Today I learned from you that the interperte and mypy handles type annotations differently
16:29:25 gmann gibi: yeah, we do same for server tag also
16:30:28 gmann https://github.com/openstack/nova/blob/545c92db15ed2fe318aca7bf5e439dd32cd05df5/nova/api/openstack/compute/server_tags.py#L40
16:31:00 gmann though that is getting the project_id in much fast way
16:31:20 gmann but we do return 404 in mapping not founds
16:31:29 gmann found
19:03:51 openstackgerrit Doug Hellmann proposed openstack/python-novaclient master: use stevedore to load extensions https://review.opendev.org/739331
22:29:48 dansmith melwitt: did you tell me one time that policy.json is always read on every request?
22:29:59 melwitt yes
22:30:21 dansmith and that's an oslo.policy thing not a nova thing?
22:30:48 melwitt afaik yes, but not I could be wrong
22:30:52 melwitt -not
22:31:09 melwitt at first I was going to say "not totally sure"
22:31:26 bnemec I think we fixed that. I could also be wrong though.
22:32:18 melwitt it's been awhile since I have experimented with it, but I have tweaked policy.json in my devstack env and didn't have to restart anything to reflect the new policy
22:32:42 melwitt twas kind of nice and I didn't realize that was ever considered a bug
22:32:55 bnemec Oh, yeah there's some sort of check if the file has changed.
22:33:05 melwitt ah k
22:33:18 melwitt so maybe it's not literally read each time dansmith ^
22:33:33 dansmith okay
22:33:40 bnemec There was some bad behavior at one point where we were reparsing all of the rules every time or something, which I think is now fixed.
22:33:47 dansmith well, I don't actually see it logging the check I'm expecting either
22:33:49 dansmith but I see some other
22:33:51 dansmith s
#openstack-nova - 2020-07-08
03:22:27 openstackgerrit Jie Li proposed openstack/nova-specs master: add volume backed server rebuild spec https://review.opendev.org/739349
08:12:56 openstackgerrit Merged openstack/nova stable/ussuri: libvirt: Don't allow "reserving" file-backed memory https://review.opendev.org/736219
09:24:32 openstackgerrit Balazs Gibizer proposed openstack/python-novaclient master: [WIP] Switch legacy Zuul jobs to native Zuul v3 jobs https://review.opendev.org/725163
09:27:58 openstackgerrit Elod Illes proposed openstack/python-novaclient master: Add ensure-tox to novaclient-dsvm-functional https://review.opendev.org/739940
09:52:20 openstackgerrit Lee Yarwood proposed openstack/nova stable/rocky: Fix os_CODENAME detection and repo refresh during ceph tests https://review.opendev.org/739608
10:08:09 stephenfin gibi: These are the kind of circular references I was talking about in that long reply yesterday https://zuul.opendev.org/t/openstack/build/d1ef9d3def9f4b689edcbbb1321f408b/log/controller/logs/screen-n-cond-cell1.txt
10:11:45 gibi stephenfin: I see. and yes I was able to reproduce that problem locally too
10:25:05 openstackgerrit Andrey Kurilin proposed openstack/python-novaclient master: [WIP] Switch legacy Zuul jobs to native Zuul v3 jobs https://review.opendev.org/725163
10:34:44 gibi andreykurilin: thanks for that ^^
10:51:45 andreykurilin gibi: hope the change will help :)
10:52:56 gibi fingers crossed
10:59:43 stephenfin lyarwood: You've seen https://review.opendev.org/#/c/736758/ I assume?
11:03:34 andreykurilin gibi: it failed :(
11:10:10 gibi I see
11:10:13 gibi :/
11:18:20 lyarwood stephenfin: yeah I have it open, discussed it yesterday with sean-k-mooney, I still think an easier workaround would be to install ceph-common on the overcloud image ;)
11:21:23 openstackgerrit Andrey Kurilin proposed openstack/python-novaclient master: [WIP] Switch legacy Zuul jobs to native Zuul v3 jobs https://review.opendev.org/725163
11:47:17 openstackgerrit Huaqiang Wang proposed openstack/nova master: test_hardware: code formating for multiline construct https://review.opendev.org/728793
11:47:17 openstackgerrit Huaqiang Wang proposed openstack/nova master: objects: Introduce 'pcpuset' field for InstanceNUMACell https://review.opendev.org/714658
11:47:18 openstackgerrit Huaqiang Wang proposed openstack/nova master: notifications: add the pcpuset info to instance numa cell payload https://review.opendev.org/728480
11:47:18 openstackgerrit Huaqiang Wang proposed openstack/nova master: objects: Introduce the 'CPUAllocationPolicy.MIXED' enum https://review.opendev.org/716267
11:47:19 openstackgerrit Huaqiang Wang proposed openstack/nova master: libvirt: apply mixed instance CPU policy https://review.opendev.org/728481
11:47:19 openstackgerrit Huaqiang Wang proposed openstack/nova master: Validate CPU pinning configuration for mixed instance https://review.opendev.org/716268

Earlier   Later