| Posted | Nick | Remark | |
|---|---|---|---|
| #openstack-nova - 2020-07-03 | |||
| 12:30:32 | sean-k-mooney | bauzas: im debating if i should abandon https://review.opendev.org/#/c/739017/1 and just go with https://review.opendev.org/#/c/739131/2 | |
| 12:31:57 | sean-k-mooney | bauzas: what do you think? i cant easily test raising the excption as the a fakelibivt.libvirtError will not be caught correctly and i cant mock raising libvirt.libvirtError without adding libvirt-python as a test dep | |
| 12:33:13 | sean-k-mooney | hum altough this works for some reason https://review.opendev.org/#/c/739131/2/nova/tests/unit/virt/libvirt/test_host.py@1200 | |
| 12:44:52 | sean-k-mooney | damb i have a bug.. | |
| 12:57:29 | bauzas | sean-k-mooney: sorry, was not looking at the chan | |
| 12:58:26 | sean-k-mooney | i need to figure out what the function is renamed too but basically im wondering if there si any point doing the incomplete fix when i more or less have the correct fix written | |
| 12:58:29 | bauzas | sean-k-mooney: well, it's a bit larger | |
| 12:58:58 | sean-k-mooney | right but we will be backporting both in either case | |
| 13:01:24 | sean-k-mooney | virConnectListAllNodeDevices becomes listAllDevices | |
| 13:02:38 | sean-k-mooney | i guess it makes sense but still kind of wish the python bindings had docs that were actully useful | |
| 13:27:30 | openstackgerrit | sean mooney proposed openstack/nova master: lookup nic feature by pci address https://review.opendev.org/739131 | |
| 14:23:53 | openstackgerrit | Lucio Seki proposed openstack/nova master: Implement extend_volume for libvirt NFS volume driver https://review.opendev.org/739077 | |
| 14:34:13 | gmann | priteau gibi yeah, servers_policies.NETWORK_ATTACH_EXTERNAL, is the only policy which is enforced outside API service. May be we can move that to API layer and pass the info via parameter. | |
| 14:34:52 | gmann | but until you are not overriding it, you do not need the policy file and just reply on default polocy in code. | |
| 14:34:56 | gmann | policy | |
| 14:35:28 | gmann | also, let me try to move that to API side. | |
| 14:41:04 | openstackgerrit | Balazs Gibizer proposed openstack/nova master: Use absolute path during qemu img rebase https://review.opendev.org/739246 | |
| 15:58:30 | openstackgerrit | sean mooney proposed openstack/nova master: lookup nic feature by pci address https://review.opendev.org/739131 | |
| 16:10:19 | sean-k-mooney | bauzas: ok ^ should work now | |
| 21:22:32 | openstackgerrit | Ghanshyam Mann proposed openstack/python-novaclient master: DNM: testing novaclient gate on ubuntu focal https://review.opendev.org/739285 | |
| #openstack-nova - 2020-07-04 | |||
| 19:12:09 | openstackgerrit | Doug Hellmann proposed openstack/python-novaclient master: use stevedore to load extensions https://review.opendev.org/739331 | |
| 20:21:23 | openstackgerrit | Marcin Juszkiewicz proposed openstack/nova master: libvirt: check for AMD SEV only on x86-64 https://review.opendev.org/714425 | |
| 20:30:42 | prometheanfire | nova fails with oslotest===4.4.0 :( | |
| 22:48:33 | gmann | prometheanfire: checking.. | |
| 22:49:02 | prometheanfire | cool, need to go bother ironic about jsonschema next | |
| 22:50:03 | prometheanfire | gmann: https://zuul.opendev.org/t/openstack/build/843ec446c2a24a2b9e86a569e0c2e49d | |
| #openstack-nova - 2020-07-05 | |||
| 00:21:00 | openstackgerrit | Ghanshyam Mann proposed openstack/nova master: Fix mock for 'autospec' and 'new' together https://review.opendev.org/739333 | |
| 00:21:41 | gmann | prometheanfire: ^^, tested locally with oslotest 4.4.0 | |
| 00:25:18 | prometheanfire | :D | |
| 01:51:02 | openstackgerrit | Ghanshyam Mann proposed openstack/nova master: migrate testing to ubuntu focal https://review.opendev.org/738126 | |
| 09:33:03 | openstackgerrit | Jie Li proposed openstack/nova-specs master: add volume backed server rebuild spec https://review.opendev.org/739349 | |
| #openstack-nova - 2020-07-06 | |||
| 03:10:05 | openstackgerrit | Jie Li proposed openstack/nova-specs master: add volume backed server rebuild spec https://review.opendev.org/739349 | |
| 07:48:54 | bauzas | good morning Nova | |
| 08:17:38 | openstackgerrit | Sylvain Bauza proposed openstack/nova-specs master: Routed network scheduling spec https://review.opendev.org/733703 | |
| 10:19:17 | openstackgerrit | Merged openstack/nova master: Snapshot: offload glance upload in a native thread https://review.opendev.org/734776 | |
| 10:25:14 | openstackgerrit | Akhil Gudise proposed openstack/nova master: Moved all calls from _ENFORCER.authorize to a separate _authorize method https://review.opendev.org/739460 | |
| 10:38:41 | openstackgerrit | Lee Yarwood proposed openstack/nova stable/stein: Reserve DISK_GB resource for the image cache https://review.opendev.org/732529 | |
| 10:38:49 | openstackgerrit | Lee Yarwood proposed openstack/nova stable/stein: Add admin doc information about image cache resource accounting https://review.opendev.org/732542 | |
| 11:15:17 | openstackgerrit | Elod Illes proposed openstack/nova stable/stein: Revert "Make greande jobs n-v for EM and oldest stable" https://review.opendev.org/739464 | |
| 11:24:36 | aarents | lyarwood: When you will have time, can you confirm this one is ok for you: https://review.opendev.org/#/c/719008 thks ! | |
| 11:31:58 | lyarwood | aarents: looking | |
| 11:33:57 | vinay_m | hi can anyone help me in how to reproduce this bug: https://bugs.launchpad.net/nova/+bug/1740320 | |
| 11:33:57 | openstack | Launchpad bug 1740320 in OpenStack Compute (nova) "nova-scheduler does not honor max_instances_per_host set to a host aggregate" [Undecided,Confirmed] - Assigned to vinay harsha mitta (vinay7) | |
| 11:36:33 | lyarwood | aarents: ack'd | |
| 11:52:27 | aarents | lyarwood: thks | |
| 12:19:43 | openstackgerrit | Merged openstack/nova stable/stein: libvirt: Don't delete disks on shared storage during evacuate https://review.opendev.org/732696 | |
| 12:20:58 | openstackgerrit | Balazs Gibizer proposed openstack/nova master: Repro gen conflict in COMPUTE_STATUS_DISABLED handling https://review.opendev.org/704865 | |
| 12:22:08 | openstackgerrit | Balazs Gibizer proposed openstack/nova master: Reduce gen conflict in COMPUTE_STATUS_DISABLED handling https://review.opendev.org/704866 | |
| 12:23:52 | openstackgerrit | Balazs Gibizer proposed openstack/nova master: Repro gen conflict in COMPUTE_STATUS_DISABLED handling https://review.opendev.org/704865 | |
| 12:23:52 | openstackgerrit | Balazs Gibizer proposed openstack/nova master: Reduce gen conflict in COMPUTE_STATUS_DISABLED handling https://review.opendev.org/704866 | |
| 12:29:58 | gibi | lyarwood: ^ I've moved the regression test to the regression directory and reported a bug | |
| 12:30:53 | lyarwood | gibi: ack thanks, I'll take a look this afternoon | |
| 12:31:07 | gibi | thanks | |
| 12:33:58 | openstackgerrit | Balazs Gibizer proposed openstack/nova master: DNM: Test the state of VMware NSX 3pp CI https://review.opendev.org/734114 | |
| 12:36:35 | lseki | Hi folks, are CI jobs `nova-next` and `nova-multi-cell` unstable? They're failing more often than not in my patch, but sometimes they pass... | |
| 12:39:19 | sean-k-mooney | lseki: in general no they are not | |
| 12:39:45 | sean-k-mooney | the ci has been a little unstable for the last week or so | |
| 12:39:57 | sean-k-mooney | but those jobs are generaly stable | |
| 12:43:53 | lseki | sean-k-mooney: thanks, I'll trigger a couple more times | |
| 12:44:04 | sean-k-mooney | which patch is it | |
| 12:44:19 | sean-k-mooney | did you chekc why they failed? | |
| 12:44:34 | sean-k-mooney | you technically are ment to do that when you recheck | |
| 12:44:51 | lseki | https://review.opendev.org/#/c/739077/ | |
| 12:45:15 | lseki | the last time `tempest.api.compute.admin.test_volume_swap.TestVolumeSwap` failed by timeout | |
| 12:45:33 | lseki | so I guess it's something intermittent | |
| 12:46:25 | sean-k-mooney | the multi cell failure was with swap volume | |
| 12:47:30 | sean-k-mooney | ya so since you are modifying the volume extention code we need to be carful that its not related | |
| 12:49:10 | lseki | I believe it's not, because I modified nfs driver, and those jobs are using LVM | |
| 12:53:17 | sean-k-mooney | yep its unlikely | |
| 12:53:51 | sean-k-mooney | it looks like there are some issue with lvm currenlyt the nova lvm job failed with Details: {'code': 404, 'message': 'Image not found.'} | |
| 12:54:28 | sean-k-mooney | and the swap volume one has been failing intermitently although that is in a few jobs | |
| 12:54:56 | sean-k-mooney | normally we would add an elastic rechk query for the swap volume issue and file a bug | |
| 12:57:14 | openstackgerrit | sean mooney proposed openstack/nova master: catch libvirt exception when nodedev not found. https://review.opendev.org/739017 | |
| 12:57:14 | openstackgerrit | sean mooney proposed openstack/nova master: lookup nic feature by pci address https://review.opendev.org/739131 | |
| 13:00:18 | sean-k-mooney | bauzas: lyarwood ^ can ye take a look stephenfin are you around today? | |
| 13:00:44 | bauzas | sean-k-mooney: sure, already did this morning, can you please explain me what is the current consensus ? | |
| 13:00:58 | sean-k-mooney | aroud which? | |
| 13:01:31 | sean-k-mooney | you wanted to have both so i added the unit test you wanted and shortened the try catch | |
| 13:02:35 | sean-k-mooney | i plan to backport both patches to train upstream and downstream | |
| 13:03:27 | sean-k-mooney | ill do a direct backport to 16.1 downstream and then do the normal upstrem backport process | |
| 13:04:03 | bauzas | sean-k-mooney: you told me on Friday that you wanted to abandon https://review.opendev.org/#/c/739017/ but given my thoughts, you are okay with merging it ? | |
| 13:04:41 | openstackgerrit | Merged openstack/nova stable/ussuri: Fix cherry-pick check for merge patch https://review.opendev.org/739176 | |
| 13:04:42 | sean-k-mooney | i never wanted to do that first patch but i wrote it because you and gibi seam to think it was sufficent | |
| 13:05:07 | sean-k-mooney | i would prefer to abandon it but its written so im fine with merging it | |
| 13:06:03 | bauzas | okay, thanks | |
| 13:06:36 | sean-k-mooney | if ye can weigh in on https://review.opendev.org/#/c/739131/1/nova/virt/libvirt/host.py@1181 | |
| 13:07:06 | sean-k-mooney | i could technically move the typeing chnage into a third patch but i think that sets a bad precident | |
| 13:07:22 | sean-k-mooney | we talkabout this in the past with some of stephens patches too. | |
| 13:07:48 | sean-k-mooney | if pepole want me to split that i can but that is the only open question im aware of | |
| 13:09:49 | sean-k-mooney | bauzas: im not really sure why i could not get the unit test you asked for working on firday but i started from scratch this morning and it worked fine so i obvioulys was doing something dumb before | |
| 13:10:59 | bauzas | sean-k-mooney: honestly, I'm on the same page with melwitt about py3 typing | |
| 13:11:12 | bauzas | but I already said that here :) | |
| 13:11:43 | sean-k-mooney | bauzas: ya so i really dont want to set the percident that we dont use typing just because we are going to backport a patch | |
| 13:12:15 | sean-k-mooney | if i must i can split it but i will then be backportin that to ussuri but not to train | |
| 13:12:31 | sean-k-mooney | lyarwood: any input form a stable point of view ^ | |
| 13:12:36 | bauzas | well, I'm not opiniated | |
| 13:13:23 | lyarwood | sean-k-mooney: yup that's fine from a stable / downstream point of view | |
| 13:13:44 | sean-k-mooney | lyarwood: which is. removing the typing annotation on backport | |
| 13:13:57 | bauzas | but honestly the balance in between risks and benefits is a a bit small | |
| 13:14:11 | bauzas | and I don't understand why we would *have to* provide types | |