| Posted | Nick | Remark | |
|---|---|---|---|
| #openstack-nova - 2020-06-26 | |||
| 09:20:34 | zigo | checking ... | |
| 09:21:03 | zigo | Yeah, that's correct. | |
| 09:21:09 | openstackgerrit | Elod Illes proposed openstack/nova stable/ussuri: libvirt: Mark e1000e VIF as supported https://review.opendev.org/736957 | |
| 09:21:58 | gibi | hm the ValueError is coming from here https://github.com/openstack/oslo.utils/blame/master/oslo_utils/fixture.py#L82 but that piece of code is 2 years old | |
| 09:22:15 | zigo | Oh ... | |
| 09:23:40 | zigo | Indeed, I was missreading the logs. | |
| 09:24:26 | openstackgerrit | Stephen Finucane proposed openstack/nova stable/train: libvirt: Mark e1000e VIF as supported https://review.opendev.org/736962 | |
| 09:24:39 | openstackgerrit | Stephen Finucane proposed openstack/nova stable/train: libvirt: Mark e1000e VIF as supported https://review.opendev.org/736962 | |
| 09:24:41 | zigo | gibi: Do you think it'd have any consequence if we were to remove the underscore check? | |
| 09:26:27 | gibi | zigo: as far as I understand the logs this fails in the test code part of the test case so I think it is save to gut that check temporarly | |
| 09:26:39 | gibi | s/save/safe/ | |
| 09:28:57 | gibi | looking more to the stacktrace I suspect this is some kind of mock autospecing issue. So far the same test passes for me locally in py38 | |
| 09:29:50 | zigo | gibi: The full log with what version of each component is here: qa-logs.debian.net/2020/06/20/nova_21.0.0-2_unstable.log | |
| 09:29:56 | gibi | zigo: thanks | |
| 09:36:57 | zigo | gibi: The easiest way is probably to run Debian Sid, and do "apt-get build-dep nova" then pip freeze, then compare the output with your venv. | |
| 09:37:10 | zigo | gibi: I can do the sid part send send it somewhere if you want. | |
| 09:38:00 | gibi | zigo: yeah please provide that info for me | |
| 09:39:16 | sean-k-mooney | gibi: oh your right it was --availabity-zone <az> <server name> | |
| 09:40:01 | zigo | I'm installing a fresh sid machine. | |
| 09:40:27 | gibi | thanks | |
| 09:50:07 | masterpe | Hi, I have a question about a upgrade from Rocky to Stein. | |
| 09:50:28 | openstackgerrit | Alexandre Arents proposed openstack/nova master: Limit the number of concurrent snapshots https://review.opendev.org/736169 | |
| 09:51:48 | gibi | zigo: need to join a call for the next two hours, but I continue looking at the issue you see | |
| 09:51:59 | zigo | Thanks. | |
| 09:52:06 | zigo | I'm nearly done with the sid box. | |
| 09:52:16 | zigo | (well, VM actually...) | |
| 09:55:44 | zigo | gibi: output of pip freeze for me: | |
| 09:55:44 | zigo | http://paste.openstack.org/show/795248/ | |
| 09:55:54 | gibi | thanks | |
| 09:56:10 | gibi | I've spotted some differences already but so far no luck reproducing the issue | |
| 09:58:22 | masterpe | I try to upgrade a compute node from Rocky to Stein as a first step I upgraded a empty compute node and also libvirt and qemu to version 5.0.0-1~cloud0 and 1:3.1+dfsg-2ubuntu3.7~cloud0 on a ubuntu bionic system | |
| 10:06:12 | zigo | gibi: With the test removed from oslo.utils, now I only got a single failure which seems to be an unrelated broken test (which I'm ok to just disable): http://paste.openstack.org/show/795250/ | |
| 10:06:47 | gibi | zigo: OK. I will let you know if I found something on my side | |
| 10:21:11 | gibi | zigo: there are different versions in http://paste.openstack.org/show/795248/ and in qa-logs.debian.net/2020/06/20/nova_21.0.0-2_unstable.log | |
| 10:21:23 | gibi | like oslo.utils is 4.1.1 in http://paste.openstack.org/show/795248/ | |
| 10:22:00 | openstackgerrit | Alexandre Arents proposed openstack/nova master: Snapshot: offload glance upload in a native thread https://review.opendev.org/734776 | |
| 10:22:10 | gibi | zigo: never mind a looked at the wrong file | |
| 10:23:50 | gibi | zigo: I found the problem | |
| 10:23:57 | zigo | :) | |
| 10:24:04 | gibi | zigo: you have mock==4.0.2 if I install that then I have the same failure | |
| 10:24:50 | zigo | Ok. | |
| 10:25:00 | gibi | zigo: openstack pins that to 3.0.5 | |
| 10:25:01 | gibi | https://github.com/openstack/requirements/blob/master/upper-constraints.txt#L168 | |
| 10:29:41 | zigo | gibi: Any idea how to solve the problem with this new mock version then? | |
| 10:29:50 | zigo | I obviously can't get the sid package to downgrade ... | |
| 10:30:04 | zigo | I'll get in touch with the package maintainer still though. | |
| 10:30:27 | gibi | zigo: that is a good question, right now I don't | |
| 10:46:42 | gibi | zigo: this seems related https://github.com/testing-cabal/mock/issues/487 | |
| 10:49:32 | gibi | reading that it seems it is an issue in the python standard mock lib | |
| 10:55:10 | zigo | Thanks for the investigations. | |
| 11:23:04 | openstackgerrit | Elod Illes proposed openstack/nova stable/stein: DNM: debug check-cherry-picks.sh on gate https://review.opendev.org/738189 | |
| 11:24:03 | aarents | gibi: I just read meeting minutes, I added bp/max-concurrent-snapshots in runways, Thanks! | |
| 11:56:22 | gibi | zigo: looking at the python reference __getattr__ should raise AttributeError instead of ValueError if the attribute is not found on the object. So https://github.com/openstack/oslo.utils/blob/master/oslo_utils/fixture.py#L82 is wrong. If I change the exception type to AttributeError then the problem is gone | |
| 11:56:31 | gibi | aarents: ack. I will look at it | |
| 11:57:53 | zigo | gibi: I'll do that in the oslo.utils package then ! | |
| 12:00:23 | gibi | zigo: I will file a bug to oslo.utils to fix this | |
| 12:05:19 | openstackgerrit | Takashi Natsume proposed openstack/nova master: Remove six.text_type (2/2) https://review.opendev.org/728117 | |
| 12:43:47 | jsuchome | gibi: Hi, thanks for the review! However, the part about splitting somerefactoring into another the patch ... the first versions of the patch did not include the refactoring and it is only included as it was requested by someone else... | |
| 12:45:00 | jsuchome | I mean it's hard to please everyone... | |
| 12:50:32 | sean-k-mooney | jsuchome: well you could do the refactoring first then the functional chagne as the second patch right that would keep both happy | |
| 12:50:47 | sean-k-mooney | jsuchome: not actully sure what patch you are refering too but just a suggestion | |
| 12:51:47 | jsuchome | the direct-rbd download one... | |
| 12:51:55 | jsuchome | https://review.opendev.org/#/c/574301/ | |
| 12:54:50 | sean-k-mooney | ah i see. i can kind of see why gibi asked for them to be seperate | |
| 12:55:04 | stephenfin | bauzas: Care to look at https://review.opendev.org/#/c/730865/ and the following two patches? Trivial cleanup | |
| 12:55:15 | bauzas | stephenfin: ack, sure | |
| 12:55:22 | sean-k-mooney | the content of _verify_and_write looks very similar to the previous cod ebut its not clear if the differences are due to the refactor or the patch | |
| 12:55:31 | stephenfin | ignore the failing test - it's not an issue (see the following patch) | |
| 12:56:12 | sean-k-mooney | jsuchome: at least not at a 30 second glance i could figure it out if i reviewed it properly just more mental load | |
| 12:58:35 | jsuchome | sean-k-mooney: I can understand that. It's only because I've seen it hundred times it does not seem weird to me | |
| 12:58:38 | openstackgerrit | Stephen Finucane proposed openstack/nova stable/train: Remove stale nested backport from InstancePCIRequests https://review.opendev.org/725932 | |
| 12:59:05 | stephenfin | elod: I rebased https://review.opendev.org/#/c/725932/ to drop lyarwood's -W. Care to +W again? | |
| 12:59:55 | openstackgerrit | Stephen Finucane proposed openstack/nova stable/stein: Remove stale nested backport from InstancePCIRequests https://review.opendev.org/738199 | |
| 13:01:00 | elod | stephenfin: thanks, yes, let's +W it :] | |
| 13:02:04 | elod | there it is | |
| 13:02:33 | stephenfin | ta | |
| 13:03:37 | elod | np | |
| 13:04:59 | openstackgerrit | Stephen Finucane proposed openstack/nova master: objects: Remove custom comparison methods https://review.opendev.org/472285 | |
| 13:12:15 | openstackgerrit | Merged openstack/nova master: hardware: Don't consider overhead CPUs for unpinned instances https://review.opendev.org/714698 | |
| 13:12:22 | openstackgerrit | Merged openstack/nova master: hardware: Remove handling of pre-Train compute nodes https://review.opendev.org/714699 | |
| 13:12:40 | openstackgerrit | Elod Illes proposed openstack/nova stable/stein: DNM: debug check-cherry-picks.sh on gate https://review.opendev.org/738189 | |
| 13:39:35 | gibi | zigo: bug https://bugs.launchpad.net/oslo.utils/+bug/1885281 bugfix https://review.opendev.org/#/c/738207/ | |
| 13:39:35 | openstack | Launchpad bug 1885281 in oslo.utils "uuidsentinel does not follow __getattr__ protocol" [Undecided,In progress] - Assigned to Balazs Gibizer (balazs-gibizer) | |
| 13:42:28 | openstackgerrit | Merged openstack/nova master: Make libvirt able to trigger a backend image copy when needed https://review.opendev.org/656998 | |
| 13:50:44 | zigo | gibi: Super cool ! :) | |
| 13:54:00 | itandops | hi all, I'm installing openstack with openstack-ansible and get this error during nova install http://paste.openstack.org/show/795265/ | |
| 13:54:47 | itandops | Is it required to have Placement API or any suggestion to solve this please ? | |
| 14:00:26 | gibi | aarents: thanks for adding max-concurrent-snapshots into the runway etherpad. Just a note, next time please add your patches to the Queue section, then I will make the move to the runway slot | |
| 14:01:06 | aarents | gibi: noted | |
| 14:02:18 | gibi | jsuchome: as sean-k-mooney put it, it would be nice to have the refactoring in the first patch and then the feature implementation in another patch on top of the refactor | |
| 14:19:38 | melwitt | elod: I think you're likely right that the cherry pick check only works if the hash being looked for is in the local branch, I'm wondering if we need to add '-r' to the --contains command here https://github.com/openstack/nova/blob/4ae5b61c4f9819e26c13c147b46ab2344bd3cc3a/tools/check-cherry-picks.sh#L11 https://git-scm.com/docs/git-branch#Documentation/git-branch.txt--r cc gmann | |
| 14:27:47 | elod | melwitt: it seems that even the 'git show --format='%b' --quiet $1' gives empty result back | |
| 14:28:38 | melwitt | elod: oh... sorry I didn't realize that's what it's failing on. I'm stumped about that then : | |
| 14:28:42 | melwitt | :/ | |
| 14:29:24 | elod | melwitt: https://zuul.opendev.org/t/openstack/build/490f4df6fc384d48ba895af3a9cf9862/log/job-output.txt#865-866 | |
| 14:31:48 | elod | melwitt: might be that the way how the repo is cloned causes the weirdness: https://opendev.org/openstack/project-config/src/branch/master/roles/use-cached-repos/tasks/main.yaml | |
| 14:32:32 | melwitt | hrm | |
| 14:33:02 | elod | only the .git is there I guess | |
| 14:37:00 | elod | maybe if the patch is not on the top of the branch then it can just see a merge patch ( like http://paste.openstack.org/show/795267/ ) | |
| 14:38:26 | elod | i've pushed a dummy patch to see what's there exactly: https://review.opendev.org/738189 | |