| Posted | Nick | Remark | |
|---|---|---|---|
| #openstack-nova - 2020-06-26 | |||
| 13:02:04 | elod | there it is | |
| 13:02:33 | stephenfin | ta | |
| 13:03:37 | elod | np | |
| 13:04:59 | openstackgerrit | Stephen Finucane proposed openstack/nova master: objects: Remove custom comparison methods https://review.opendev.org/472285 | |
| 13:12:15 | openstackgerrit | Merged openstack/nova master: hardware: Don't consider overhead CPUs for unpinned instances https://review.opendev.org/714698 | |
| 13:12:22 | openstackgerrit | Merged openstack/nova master: hardware: Remove handling of pre-Train compute nodes https://review.opendev.org/714699 | |
| 13:12:40 | openstackgerrit | Elod Illes proposed openstack/nova stable/stein: DNM: debug check-cherry-picks.sh on gate https://review.opendev.org/738189 | |
| 13:39:35 | gibi | zigo: bug https://bugs.launchpad.net/oslo.utils/+bug/1885281 bugfix https://review.opendev.org/#/c/738207/ | |
| 13:39:35 | openstack | Launchpad bug 1885281 in oslo.utils "uuidsentinel does not follow __getattr__ protocol" [Undecided,In progress] - Assigned to Balazs Gibizer (balazs-gibizer) | |
| 13:42:28 | openstackgerrit | Merged openstack/nova master: Make libvirt able to trigger a backend image copy when needed https://review.opendev.org/656998 | |
| 13:50:44 | zigo | gibi: Super cool ! :) | |
| 13:54:00 | itandops | hi all, I'm installing openstack with openstack-ansible and get this error during nova install http://paste.openstack.org/show/795265/ | |
| 13:54:47 | itandops | Is it required to have Placement API or any suggestion to solve this please ? | |
| 14:00:26 | gibi | aarents: thanks for adding max-concurrent-snapshots into the runway etherpad. Just a note, next time please add your patches to the Queue section, then I will make the move to the runway slot | |
| 14:01:06 | aarents | gibi: noted | |
| 14:02:18 | gibi | jsuchome: as sean-k-mooney put it, it would be nice to have the refactoring in the first patch and then the feature implementation in another patch on top of the refactor | |
| 14:19:38 | melwitt | elod: I think you're likely right that the cherry pick check only works if the hash being looked for is in the local branch, I'm wondering if we need to add '-r' to the --contains command here https://github.com/openstack/nova/blob/4ae5b61c4f9819e26c13c147b46ab2344bd3cc3a/tools/check-cherry-picks.sh#L11 https://git-scm.com/docs/git-branch#Documentation/git-branch.txt--r cc gmann | |
| 14:27:47 | elod | melwitt: it seems that even the 'git show --format='%b' --quiet $1' gives empty result back | |
| 14:28:38 | melwitt | elod: oh... sorry I didn't realize that's what it's failing on. I'm stumped about that then : | |
| 14:28:42 | melwitt | :/ | |
| 14:29:24 | elod | melwitt: https://zuul.opendev.org/t/openstack/build/490f4df6fc384d48ba895af3a9cf9862/log/job-output.txt#865-866 | |
| 14:31:48 | elod | melwitt: might be that the way how the repo is cloned causes the weirdness: https://opendev.org/openstack/project-config/src/branch/master/roles/use-cached-repos/tasks/main.yaml | |
| 14:32:32 | melwitt | hrm | |
| 14:33:02 | elod | only the .git is there I guess | |
| 14:37:00 | elod | maybe if the patch is not on the top of the branch then it can just see a merge patch ( like http://paste.openstack.org/show/795267/ ) | |
| 14:38:26 | elod | i've pushed a dummy patch to see what's there exactly: https://review.opendev.org/738189 | |
| 14:48:45 | elod | but correct me if I'm on a wrong track or poking the obvious :] | |
| 15:03:43 | gmann | melwitt: elod : it is still issue, rebasing patches on top of script merged one works fine | |
| 15:03:57 | gmann | * it is still issue? | |
| 15:10:11 | elod | gmann: it is still an issue :( see, e.g.: https://review.opendev.org/#/c/736957/ | |
| 15:11:21 | gmann | elod: its is working fine on 736957 right? | |
| 15:12:12 | gmann | as it got rebased on top of ussuri lates code which has script changes, script got all the hashes correctly. | |
| 15:13:30 | elod | gmann: it works fine when it is rebased | |
| 15:13:36 | gmann | yeah | |
| 15:14:12 | gmann | same like stable/train changes we rebased yesterday. | |
| 15:15:59 | elod | gmann: but currently it seems to me that the script works only if the patch is on top of the given branch | |
| 15:16:32 | elod | i might be wrong though | |
| 15:17:34 | gmann | elod: oh is it? or on top of where script merged. | |
| 15:18:22 | gmann | that I have not tested. do we have any such change on stable where it is on top of script-merged-change but not on latest branch changes | |
| 15:18:40 | elod | gmann: I've created this dummy patch: https://review.opendev.org/#/c/738189/ | |
| 15:19:19 | elod | but it is on stein, where the script is not even merged yet | |
| 15:19:53 | gmann | yeah | |
| 15:20:46 | gmann | we can wait for either of these merge and then recheck on other before rebase - https://review.opendev.org/#/q/status:open+project:openstack/nova+branch:stable/ussuri | |
| 15:23:23 | elod | my thinking is what I wrote here: http://eavesdrop.openstack.org/irclogs/%23openstack-nova/%23openstack-nova.2020-06-26.log.html#t2020-06-26T14:33:02 | |
| 15:24:22 | elod | but that's also a good check what you are saying | |
| 16:07:37 | openstackgerrit | Elod Illes proposed openstack/nova stable/stein: DNM: debug check-cherry-picks.sh on gate https://review.opendev.org/738189 | |
| 16:08:09 | stephenfin | bauzas: Got another one for you https://review.opendev.org/#/c/706013/ | |
| 16:17:56 | itandops | hello folks any suggestion about my error ? | |
| 16:37:34 | stephenfin | gibi: comment on https://review.opendev.org/#/c/736167/ | |
| 16:38:38 | openstackgerrit | Stephen Finucane proposed openstack/nova master: objects: Use imports instead of type aliases https://review.opendev.org/738018 | |
| 16:38:38 | openstackgerrit | Stephen Finucane proposed openstack/nova master: objects: Remove wrappers around ovo mixins https://review.opendev.org/738019 | |
| 16:38:39 | openstackgerrit | Stephen Finucane proposed openstack/nova master: objects: Add type hints https://review.opendev.org/738020 | |
| 16:38:39 | openstackgerrit | Stephen Finucane proposed openstack/nova master: objects: Don't use generic 'Field' container https://review.opendev.org/738239 | |
| 16:38:40 | openstackgerrit | Stephen Finucane proposed openstack/nova master: objects: Remove unnecessary type aliases, exceptions https://review.opendev.org/738240 | |
| 16:39:37 | stephenfin | itandops: That looks like placement isn't registered in the service catalog https://docs.openstack.org/keystone/latest/contributor/service-catalog.html | |
| 16:40:08 | stephenfin | Placement is mandatory from OSP 13 or so | |
| 16:40:10 | stephenfin | Sorry, Newton | |
| 16:48:34 | openstackgerrit | Merged openstack/os-traits master: Fix hacking min version to 3.0.1 https://review.opendev.org/727559 | |
| 17:40:36 | openstackgerrit | Merged openstack/nova master: Update interop repo link https://review.opendev.org/735427 | |
| 19:40:45 | openstackgerrit | Merged openstack/nova master: Delete resource provider in tree by top-down traversable order https://review.opendev.org/719163 | |
| 19:52:23 | openstackgerrit | Elod Illes proposed openstack/nova master: Fix cherry-pick check for merge patch https://review.opendev.org/738271 | |
| 20:02:22 | elod | melwitt dansmith gmann : ^^^^ I've tested it locally, but will do some testing on my DNM patch in zuul as well | |
| 20:02:51 | dansmith | elod: ah, makes sense | |
| 20:02:56 | melwitt | elod: awesome, thanks for tackling it | |
| 20:03:02 | dansmith | I dunno why we're on a merge and sometimes not, but probably good to account for that | |
| 20:05:12 | melwitt | it's something about how zuul applies the patch in CI | |
| 20:06:05 | elod | if patch's parent is not the latest patch on stable/xxxxx then zuul rebases it, to see if the patch works with the latest state | |
| 20:06:23 | elod | yes, as melwitt says :) | |
| 20:13:36 | dansmith | ah, zuul not git or gerrit? | |
| 20:20:10 | elod | i think so | |
| 20:26:55 | openstackgerrit | Elod Illes proposed openstack/nova stable/stein: DNM: debug check-cherry-picks.sh on gate https://review.opendev.org/738189 | |
| 20:50:56 | openstackgerrit | Merged openstack/nova stable/train: Remove stale nested backport from InstancePCIRequests https://review.opendev.org/725932 | |
| 21:01:15 | openstackgerrit | Elod Illes proposed openstack/nova stable/stein: DNM: debug check-cherry-picks.sh on gate https://review.opendev.org/738189 | |
| 23:29:22 | openstackgerrit | Merged openstack/nova stable/ussuri: Guard against missing image cache directory https://review.opendev.org/737990 | |
| #openstack-nova - 2020-06-27 | |||
| 00:44:30 | openstackgerrit | sean mooney proposed openstack/nova master: add special function to ProviderTree and _Provier https://review.opendev.org/737594 | |
| 01:47:31 | openstackgerrit | sean mooney proposed openstack/nova master: add special function to ProviderTree and _Provier https://review.opendev.org/737594 | |
| 02:43:22 | openstackgerrit | Brin Zhang proposed openstack/nova master: Define and catch InstanceAgentNotRunning for set-password failure https://review.opendev.org/661466 | |
| 05:31:11 | openstackgerrit | Merged openstack/nova master: Fix aggregate placement sync issue https://review.opendev.org/726201 | |
| 08:57:33 | openstackgerrit | Merged openstack/nova master: hardware: Rework 'get_realtime_constraint' https://review.opendev.org/714700 | |
| #openstack-nova - 2020-06-28 | |||
| 05:03:43 | openstackgerrit | Hao Sun proposed openstack/nova master: Add checks for volume status when rebuilding https://review.opendev.org/734734 | |
| 07:21:21 | openstackgerrit | Hao Sun proposed openstack/nova master: Add checks for volume status when rebuilding https://review.opendev.org/734734 | |
| 07:32:23 | openstackgerrit | Hao Sun proposed openstack/nova master: Add checks for volume status when rebuilding https://review.opendev.org/734734 | |
| 09:08:29 | brinzhang_ | gibi: hello | |
| 09:10:03 | brinzhang_ | gibi: Do we add a judgment condition to control "continue" when instance.state=BUILDING, otherwise continue execution? https://opendev.org/openstack/nova/src/branch/master/nova/compute/resource_tracker.py#L1499-L1500 | |
| 09:11:53 | brinzhang_ | s/otherwise continue execution/ otherwise continue do below code logical | |
| 09:38:32 | brinzhang_ | gibi: I am sorry you are in weekend ^^ | |
| #openstack-nova - 2020-06-29 | |||
| 07:53:53 | bauzas | good morning Nova | |
| 08:37:36 | gibi | bauzas: good morning | |
| 08:37:52 | bauzas | gibi: any spec you'd like me to review ? | |
| 08:38:08 | gibi | bauzas: let me check the list | |
| 08:41:31 | gibi | bauzas: I only see a spec update from dansmith https://review.opendev.org/#/c/728778/ | |
| 08:41:54 | gibi | bauzas: sorry mixed up the link | |
| 08:42:06 | gibi | bauzas: this is a spec update https://review.opendev.org/#/c/735192 | |
| 08:42:30 | gibi | bauzas: https://review.opendev.org/#/c/728778/ is a re-propose | |
| 08:43:08 | bauzas | gibi: okay, I'll look | |
| 08:44:33 | gibi | thanks | |
| 08:49:24 | gibi | brinzhang_: did you hit the archiving case described in the comment https://opendev.org/openstack/nova/src/branch/master/nova/compute/resource_tracker.py#L1499-L1500 ? | |
| 09:03:58 | brinzhang_ | gibi: yes | |
| 09:04:00 | brinzhang_ | gibi: we meet the case that the RequestSpec data of instance isnot exist, but the allocations data still exist, maybe it is migration operation causes this scence, but i am not sure. | |
| 09:09:06 | openstackgerrit | Merged openstack/nova-specs master: Support volume local cache https://review.opendev.org/728778 | |