Earlier  
Posted Nick Remark
#openstack-nova - 2020-05-21
16:14:28 dansmith I need to coin some sort of term that conveys the common practice of getting lost in following gerrit topic links between branches
16:14:54 dansmith maybe I'm the only one, but I forget which alternate 1985 I'm in pretty easily when following that circular loop
16:15:43 openstackgerrit Dan Smith proposed openstack/nova stable/stein: Make quotas respect instance_list_per_project_cells https://review.opendev.org/729088
16:19:00 artom minmax(manhours, beerhours) ftw
16:37:11 openstackgerrit Lee Yarwood proposed openstack/nova master: compute: Do not allow rescue attempts using volume snapshot images https://review.opendev.org/729261
17:05:38 openstackgerrit Merged openstack/nova master: [Trivial]Add missing white spaces between words in log messages https://review.opendev.org/729880
18:41:41 dansmith can someone help sync me up with where we are on like servicey tokeny things?
18:42:04 dansmith when we're talking to glance, are we using the user's token exclusively still?
18:42:27 dansmith and if we have the servicey tokeny thing, I assume that just helps us for the case where the user
18:42:56 dansmith token has expired, but doesn't give us any other permissions?
18:43:03 dansmith do/can we talk to glance with a more authoritative token specifically, like to look at tasks, which are admin-only?
20:19:51 melwitt dansmith: I don't know the answer to your question but here's a relatively recent change we made to our neutron interaction in a case where we changed to use admin to get specific info that wasn't available to non-admin, in case that is helpful https://github.com/openstack/nova/commit/aab4b7a0e2504c04e08389145bcb1414dea63631
20:22:05 dansmith melwitt: if you had used fewer words, you'd have sounded like an irc bot :)
20:22:25 dansmith melwitt: that's relevant-adjacent I think.. I need glance specifically and I'm sure we could be doing each service N+1 different ways
20:23:03 dansmith BUT, it looks like glance exposes a minor amount of information about the task I'm concerned with to the regular users, so at least at the moment I think I can get away without hitting the task api and thus I can put off having to learn the answer to my question for a while longer :D
20:24:01 melwitt I do sound like a bot. words are hard
20:24:26 melwitt ah, ok. yeah I was thinking if you're looking to elevate the token for certain APIs you need, that's an example of where we've done that before
20:24:55 dansmith okay, yeah, then probably relevant
20:25:13 dansmith but if I can avoid elevation, then that's probably better and it looks like I can, at least at the moment
20:25:21 melwitt yeah, for sure
20:32:40 openstackgerrit Dan Smith proposed openstack/nova master: WIP: Make libvirt able to trigger a backend image copy when needed https://review.opendev.org/656998
21:11:29 openstackgerrit Dan Smith proposed openstack/nova-specs master: Add rbd-glance-multistore spec https://review.opendev.org/730126
21:57:02 openstackgerrit melanie witt proposed openstack/nova stable/stein: Make quotas respect instance_list_per_project_cells https://review.opendev.org/729088
#openstack-nova - 2020-05-22
02:40:00 openstackgerrit zhangboye proposed openstack/nova-specs master: Fix hacking min version to 3.0.1 https://review.opendev.org/730162
03:12:50 openstackgerrit zhaoleilc proposed openstack/nova master: Fix an erroneous grammar in explanatory notes https://review.opendev.org/730176
05:43:39 openstackgerrit Wenping Song proposed openstack/nova master: cyborg evacuate support https://review.opendev.org/715326
06:07:49 openstackgerrit junbo proposed openstack/nova master: use dpdk interface type for ovs dpdk representor port https://review.opendev.org/729874
08:48:03 openstackgerrit Balazs Gibizer proposed openstack/nova stable/queens: Clean up allocation if unshelve fails due to neutron https://review.opendev.org/729540
08:56:29 openstackgerrit Balazs Gibizer proposed openstack/nova stable/queens: Reproduce bug 1862633 https://review.opendev.org/729539
08:56:29 openstack bug 1862633 in OpenStack Compute (nova) "unshelve leak allocation if update port fails" [Medium,Fix released] https://launchpad.net/bugs/1862633 - Assigned to Balazs Gibizer (balazs-gibizer)
08:56:29 openstackgerrit Balazs Gibizer proposed openstack/nova stable/queens: Clean up allocation if unshelve fails due to neutron https://review.opendev.org/729540
09:00:08 openstackgerrit Wenping Song proposed openstack/nova master: WIP: Cyborg shelve/unshelve support https://review.opendev.org/729563
09:24:45 openstackgerrit Merged openstack/nova-specs master: re-propose numa with placement https://review.opendev.org/728009
09:32:10 gibi stephenfin: hi! I'm not sure about your suggestion in https://review.opendev.org/#/c/729924/1/nova/compute/manager.py@a280
09:34:15 stephenfin gibi: Ah, I'm wrong then. I was searching for Migration._from_db_object since it was a static method
09:34:38 gibi stephenfin: ack
09:49:42 openstackgerrit Balazs Gibizer proposed openstack/nova master: Remove inject_file from compute manager and virt driver https://review.opendev.org/729934
09:50:24 elod lyarwood: any reason holding up the +W here: https://review.opendev.org/#/c/729530/ ?
09:51:16 gibi stephenfin: also yesterday I collected some cleanups for after RPC 6.0 here https://etherpad.opendev.org/p/compute-rpc-6.0 If you see more just plug it there
09:54:08 lyarwood elod: no, I likely had the tab open prior to your review, apologies.
09:54:23 lyarwood +W'd
09:59:31 gibi thanks guys!
10:06:29 sean-k-mooney oh we are finally removing file injection
10:06:54 gibi it was dead code
10:06:54 sean-k-mooney that been deprecated almost as long as nova networks
10:07:07 sean-k-mooney gibi: was it not used for the vm personalities
10:07:15 openstackgerrit Balazs Gibizer proposed openstack/nova master: Remove compatibility check from migrate_data https://review.opendev.org/729949
10:07:49 gibi sean-k-mooney: the RPC method was removed in compute RPC 3.18
10:08:01 gibi and there was no other usage for the driver call too
10:08:03 elod lyarwood: ok, thanks! I just thought that we should wait for something and was curious :]
10:08:18 sean-k-mooney ah ok
10:16:39 sean-k-mooney gibi: ah so you are just removing the function not the file inject capablity
10:17:14 gibi sean-k-mooney: is there another way to inject_files other than inject_file virt driver method?
10:17:22 sean-k-mooney yes
10:18:14 sean-k-mooney via the deprecated personality server atibute
10:19:09 sean-k-mooney although i dont know if that ends up calling that function or not
10:19:22 sean-k-mooney you have not removed any fo the personality code
10:19:31 sean-k-mooney gibi: like this https://github.com/openstack/nova/blob/c6218428e9b29a2c52808ec7d27b4b21aadc0299/nova/api/openstack/compute/helpers.py#L106-L116
10:21:26 gibi sean-k-mooney: thanks. looking
10:21:29 sean-k-mooney gibi: we pass the injected files to build_instance
10:22:01 sean-k-mooney so i dont think we use a dedicated rpc call
10:25:06 gibi sean-k-mooney: yeah I just checked the driver.spawn() also take injected_files argument so I think server create and rebuild still inject_files
10:25:17 sean-k-mooney yep
10:25:42 sean-k-mooney so we stoped using the dedicated rpc and move to passing it as part of create or rebuild
10:26:00 sean-k-mooney but only when using the de
10:26:09 sean-k-mooney deprecated personality attibute
10:28:52 sean-k-mooney gibi: anyway i think the code you pointed too is still dead code so it should be fine to remove
10:29:58 gibi sean-k-mooney: yepp. and removing personalities attribute wasn't my goal. I was actually collected what can be deleted after RPC 6.0 when I found that this can already be deleted
10:30:20 sean-k-mooney ack
11:41:07 openstackgerrit Merged openstack/nova stable/ussuri: Add admin doc information about image cache resource accounting https://review.opendev.org/729853
11:41:19 openstackgerrit Merged openstack/nova master: hardware: Raise useful error for invalid mempage size https://review.opendev.org/729967
11:41:32 openstackgerrit Merged openstack/nova stable/stein: Reproduce bug 1869050 https://review.opendev.org/729530
11:41:32 openstack bug 1869050 in OpenStack Compute (nova) stein "migration of anti-affinity server fails due to stale scheduler instance info" [Low,In progress] https://launchpad.net/bugs/1869050 - Assigned to Elod Illes (elod-illes)
11:43:53 openstackgerrit Balazs Gibizer proposed openstack/nova master: Remove compatibility check from migrate_data https://review.opendev.org/729949
11:55:51 sean-k-mooney oh i found a bug yesteraday, rememebr the patch that change how we recaulate the next avaiable slot on a disk bus
11:56:07 sean-k-mooney it does not take account of the fact the bus might be empty
11:56:33 sean-k-mooney so if you boot a vm from an iso you cant add a data volume to install too
11:59:02 sean-k-mooney http://paste.openstack.org/show/793880/
11:59:56 gibi uups
12:00:58 sean-k-mooney if i boot a ubuntu imagae with local sotorage and then try to do a rescue it also fails
12:01:00 sean-k-mooney 2020-05-22 00:28:20.355 6 ERROR nova.compute.manager [req-a5b97168-4a74-4314-ba7f-9b1af4a8508d 0eb84fc371204ddb8c1dd829464d9284 468fb37037924eaeaf7104b34c4c077d - default default] [instance: 8cfaf7ce-13ae-4b50-9bd8-20c957a8dfb5] Failed to attach 858fdfc4-632d-47d3-bc60-d7f6aa76dc7b at /dev/sdb: libvirt.libvirtError: internal error: child reported (status=125): unable to open /dev/sdg: No such device
12:01:02 sean-k-mooney or address
12:01:04 sean-k-mooney 2020-05-22 00:28:20.355 6 ERROR nova.compute.manager [instance: 8cfaf7ce-13ae-4b50-9bd8-20c957a8dfb5] Traceback (most recent call last):
12:01:06 sean-k-mooney 2020-05-22 00:28:20.355 6 ERROR nova.compute.manager [instance: 8cfaf7ce-13ae-4b50-9bd8-20c957a8dfb5] File "/var/lib/kolla/venv/lib/python3.6/site-packages/nova/compute/manager.py", line 6915, in _attach_volume
12:01:08 sean-k-mooney 2020-05-22 00:28:20.355 6 ERROR nova.compute.manager [instance: 8cfaf7ce-13ae-4b50-9bd8-20c957a8dfb5] do_driver_attach=True)
12:01:10 sean-k-mooney 2020-05-22 00:28:20.355 6 ERROR nova.compute.manager [instance: 8cfaf7ce-13ae-4b50-9bd8-20c957a8dfb5] File "/var/lib/kolla/venv/lib/python3.6/site-packages/nova/virt/block_device.py", line 46, in wrapped
12:01:12 sean-k-mooney 2020-05-22 00:28:20.355 6 ERROR nova.compute.manager [instance: 8cfaf7ce-13ae-4b50-9bd8-20c957a8dfb5] ret_val = method(obj, context, *args, **kwargs)
12:01:14 sean-k-mooney 2020-05-22 00:28:20.355 6 ERROR nova.compute.manager [instance: 8cfaf7ce-13ae-4b50-9bd8-20c957a8dfb5] File "/var/lib/kolla/venv/lib/python3.6/site-packages/nova/virt/block_device.py", line 673, in attach
12:01:16 sean-k-mooney 2020-05-22 00:28:20.355 6 ERROR nova.compute.manager [instance: 8cfaf7ce-13ae-4b50-9bd8-20c957a8dfb5] virt_driver, do_driver_attach)
12:01:18 sean-k-mooney 2020-05-22 00:28:20.355 6 ERROR nova.compute.manager [instance: 8cfaf7ce-13ae-4b50-9bd8-20c957a8dfb5] File "/var/lib/kolla/venv/lib/python3.6/site-packages/nova/virt/block_device.py", line 660, in _do_attach
12:01:20 sean-k-mooney 2020-05-22 00:28:20.355 6 ERROR nova.compute.manager [instance: 8cfaf7ce-13ae-4b50-9bd8-20c957a8dfb5] do_driver_attach)
12:01:22 sean-k-mooney 2020-05-22 00:28:20.355 6 ERROR nova.compute.manager [instance: 8cfaf7ce-13ae-4b50-9bd8-20c957a8dfb5] File "/var/lib/kolla/venv/lib/python3.6/site-packages/nova/virt/block_device.py", line 607, in _volume_attach
12:01:24 sean-k-mooney 2020-05-22 00:28:20.355 6 ERROR nova.compute.manager [instance: 8cfaf7ce-13ae-4b50-9bd8-20c957a8dfb5] attachment_id)
12:01:26 sean-k-mooney 2020-05-22 00:28:20.355 6 ERROR nova.compute.manager [instance: 8cfaf7ce-13ae-4b50-9bd8-20c957a8dfb5] File "/var/lib/kolla/venv/lib/python3.6/site-packages/oslo_utils/excutils.py", line 220, in __exit__
12:01:28 sean-k-mooney 2020-05-22 00:28:20.355 6 ERROR nova.compute.manager [instance: 8cfaf7ce-13ae-4b50-9bd8-20c957a8dfb5] self.force_reraise()
12:01:30 sean-k-mooney 2020-05-22 00:28:20.355 6 ERROR nova.compute.manager [instance: 8cfaf7ce-13ae-4b50-9bd8-20c957a8dfb5] File "/var/lib/kolla/venv/lib/python3.6/site-packages/oslo_utils/excutils.py", line 196, in force_reraise
12:01:32 sean-k-mooney 2020-05-22 00:28:20.355 6 ERROR nova.compute.manager [instance: 8cfaf7ce-13ae-4b50-9bd8-20c957a8dfb5] six.reraise(self.type_, self.value, self.tb)
12:01:34 sean-k-mooney 2020-05-22 00:28:20.355 6 ERROR nova.compute.manager [instance: 8cfaf7ce-13ae-4b50-9bd8-20c957a8dfb5] File "/usr/lib/python3.6/site-packages/six.py", line 703, in reraise
12:01:36 sean-k-mooney 2020-05-22 00:28:20.355 6 ERROR nova.compute.manager [instance: 8cfaf7ce-13ae-4b50-9bd8-20c957a8dfb5] raise value
12:01:38 sean-k-mooney 2020-05-22 00:28:20.355 6 ERROR nova.compute.manager [instance: 8cfaf7ce-13ae-4b50-9bd8-20c957a8dfb5] File "/var/lib/kolla/venv/lib/python3.6/site-packages/nova/virt/block_device.py", line 598, in _volume_attach

Earlier   Later