Earlier  
Posted Nick Remark
#openstack-nova - 2020-05-22
10:06:54 gibi it was dead code
10:06:54 sean-k-mooney that been deprecated almost as long as nova networks
10:07:07 sean-k-mooney gibi: was it not used for the vm personalities
10:07:15 openstackgerrit Balazs Gibizer proposed openstack/nova master: Remove compatibility check from migrate_data https://review.opendev.org/729949
10:07:49 gibi sean-k-mooney: the RPC method was removed in compute RPC 3.18
10:08:01 gibi and there was no other usage for the driver call too
10:08:03 elod lyarwood: ok, thanks! I just thought that we should wait for something and was curious :]
10:08:18 sean-k-mooney ah ok
10:16:39 sean-k-mooney gibi: ah so you are just removing the function not the file inject capablity
10:17:14 gibi sean-k-mooney: is there another way to inject_files other than inject_file virt driver method?
10:17:22 sean-k-mooney yes
10:18:14 sean-k-mooney via the deprecated personality server atibute
10:19:09 sean-k-mooney although i dont know if that ends up calling that function or not
10:19:22 sean-k-mooney you have not removed any fo the personality code
10:19:31 sean-k-mooney gibi: like this https://github.com/openstack/nova/blob/c6218428e9b29a2c52808ec7d27b4b21aadc0299/nova/api/openstack/compute/helpers.py#L106-L116
10:21:26 gibi sean-k-mooney: thanks. looking
10:21:29 sean-k-mooney gibi: we pass the injected files to build_instance
10:22:01 sean-k-mooney so i dont think we use a dedicated rpc call
10:25:06 gibi sean-k-mooney: yeah I just checked the driver.spawn() also take injected_files argument so I think server create and rebuild still inject_files
10:25:17 sean-k-mooney yep
10:25:42 sean-k-mooney so we stoped using the dedicated rpc and move to passing it as part of create or rebuild
10:26:00 sean-k-mooney but only when using the de
10:26:09 sean-k-mooney deprecated personality attibute
10:28:52 sean-k-mooney gibi: anyway i think the code you pointed too is still dead code so it should be fine to remove
10:29:58 gibi sean-k-mooney: yepp. and removing personalities attribute wasn't my goal. I was actually collected what can be deleted after RPC 6.0 when I found that this can already be deleted
10:30:20 sean-k-mooney ack
11:41:07 openstackgerrit Merged openstack/nova stable/ussuri: Add admin doc information about image cache resource accounting https://review.opendev.org/729853
11:41:19 openstackgerrit Merged openstack/nova master: hardware: Raise useful error for invalid mempage size https://review.opendev.org/729967
11:41:32 openstackgerrit Merged openstack/nova stable/stein: Reproduce bug 1869050 https://review.opendev.org/729530
11:41:32 openstack bug 1869050 in OpenStack Compute (nova) stein "migration of anti-affinity server fails due to stale scheduler instance info" [Low,In progress] https://launchpad.net/bugs/1869050 - Assigned to Elod Illes (elod-illes)
11:43:53 openstackgerrit Balazs Gibizer proposed openstack/nova master: Remove compatibility check from migrate_data https://review.opendev.org/729949
11:55:51 sean-k-mooney oh i found a bug yesteraday, rememebr the patch that change how we recaulate the next avaiable slot on a disk bus
11:56:07 sean-k-mooney it does not take account of the fact the bus might be empty
11:56:33 sean-k-mooney so if you boot a vm from an iso you cant add a data volume to install too
11:59:02 sean-k-mooney http://paste.openstack.org/show/793880/
11:59:56 gibi uups
12:00:58 sean-k-mooney if i boot a ubuntu imagae with local sotorage and then try to do a rescue it also fails
12:01:00 sean-k-mooney 2020-05-22 00:28:20.355 6 ERROR nova.compute.manager [req-a5b97168-4a74-4314-ba7f-9b1af4a8508d 0eb84fc371204ddb8c1dd829464d9284 468fb37037924eaeaf7104b34c4c077d - default default] [instance: 8cfaf7ce-13ae-4b50-9bd8-20c957a8dfb5] Failed to attach 858fdfc4-632d-47d3-bc60-d7f6aa76dc7b at /dev/sdb: libvirt.libvirtError: internal error: child reported (status=125): unable to open /dev/sdg: No such device
12:01:02 sean-k-mooney or address
12:01:04 sean-k-mooney 2020-05-22 00:28:20.355 6 ERROR nova.compute.manager [instance: 8cfaf7ce-13ae-4b50-9bd8-20c957a8dfb5] Traceback (most recent call last):
12:01:06 sean-k-mooney 2020-05-22 00:28:20.355 6 ERROR nova.compute.manager [instance: 8cfaf7ce-13ae-4b50-9bd8-20c957a8dfb5] File "/var/lib/kolla/venv/lib/python3.6/site-packages/nova/compute/manager.py", line 6915, in _attach_volume
12:01:08 sean-k-mooney 2020-05-22 00:28:20.355 6 ERROR nova.compute.manager [instance: 8cfaf7ce-13ae-4b50-9bd8-20c957a8dfb5] do_driver_attach=True)
12:01:10 sean-k-mooney 2020-05-22 00:28:20.355 6 ERROR nova.compute.manager [instance: 8cfaf7ce-13ae-4b50-9bd8-20c957a8dfb5] File "/var/lib/kolla/venv/lib/python3.6/site-packages/nova/virt/block_device.py", line 46, in wrapped
12:01:12 sean-k-mooney 2020-05-22 00:28:20.355 6 ERROR nova.compute.manager [instance: 8cfaf7ce-13ae-4b50-9bd8-20c957a8dfb5] ret_val = method(obj, context, *args, **kwargs)
12:01:14 sean-k-mooney 2020-05-22 00:28:20.355 6 ERROR nova.compute.manager [instance: 8cfaf7ce-13ae-4b50-9bd8-20c957a8dfb5] File "/var/lib/kolla/venv/lib/python3.6/site-packages/nova/virt/block_device.py", line 673, in attach
12:01:16 sean-k-mooney 2020-05-22 00:28:20.355 6 ERROR nova.compute.manager [instance: 8cfaf7ce-13ae-4b50-9bd8-20c957a8dfb5] virt_driver, do_driver_attach)
12:01:18 sean-k-mooney 2020-05-22 00:28:20.355 6 ERROR nova.compute.manager [instance: 8cfaf7ce-13ae-4b50-9bd8-20c957a8dfb5] File "/var/lib/kolla/venv/lib/python3.6/site-packages/nova/virt/block_device.py", line 660, in _do_attach
12:01:20 sean-k-mooney 2020-05-22 00:28:20.355 6 ERROR nova.compute.manager [instance: 8cfaf7ce-13ae-4b50-9bd8-20c957a8dfb5] do_driver_attach)
12:01:22 sean-k-mooney 2020-05-22 00:28:20.355 6 ERROR nova.compute.manager [instance: 8cfaf7ce-13ae-4b50-9bd8-20c957a8dfb5] File "/var/lib/kolla/venv/lib/python3.6/site-packages/nova/virt/block_device.py", line 607, in _volume_attach
12:01:24 sean-k-mooney 2020-05-22 00:28:20.355 6 ERROR nova.compute.manager [instance: 8cfaf7ce-13ae-4b50-9bd8-20c957a8dfb5] attachment_id)
12:01:26 sean-k-mooney 2020-05-22 00:28:20.355 6 ERROR nova.compute.manager [instance: 8cfaf7ce-13ae-4b50-9bd8-20c957a8dfb5] File "/var/lib/kolla/venv/lib/python3.6/site-packages/oslo_utils/excutils.py", line 220, in __exit__
12:01:28 sean-k-mooney 2020-05-22 00:28:20.355 6 ERROR nova.compute.manager [instance: 8cfaf7ce-13ae-4b50-9bd8-20c957a8dfb5] self.force_reraise()
12:01:30 sean-k-mooney 2020-05-22 00:28:20.355 6 ERROR nova.compute.manager [instance: 8cfaf7ce-13ae-4b50-9bd8-20c957a8dfb5] File "/var/lib/kolla/venv/lib/python3.6/site-packages/oslo_utils/excutils.py", line 196, in force_reraise
12:01:32 sean-k-mooney 2020-05-22 00:28:20.355 6 ERROR nova.compute.manager [instance: 8cfaf7ce-13ae-4b50-9bd8-20c957a8dfb5] six.reraise(self.type_, self.value, self.tb)
12:01:34 sean-k-mooney 2020-05-22 00:28:20.355 6 ERROR nova.compute.manager [instance: 8cfaf7ce-13ae-4b50-9bd8-20c957a8dfb5] File "/usr/lib/python3.6/site-packages/six.py", line 703, in reraise
12:01:36 sean-k-mooney 2020-05-22 00:28:20.355 6 ERROR nova.compute.manager [instance: 8cfaf7ce-13ae-4b50-9bd8-20c957a8dfb5] raise value
12:01:38 sean-k-mooney 2020-05-22 00:28:20.355 6 ERROR nova.compute.manager [instance: 8cfaf7ce-13ae-4b50-9bd8-20c957a8dfb5] File "/var/lib/kolla/venv/lib/python3.6/site-packages/nova/virt/block_device.py", line 598, in _volume_attach
12:01:40 sean-k-mooney 2020-05-22 00:28:20.355 6 ERROR nova.compute.manager [instance: 8cfaf7ce-13ae-4b50-9bd8-20c957a8dfb5] device_type=self['device_type'], encryption=encryption)
12:01:42 sean-k-mooney 2020-05-22 00:28:20.355 6 ERROR nova.compute.manager [instance: 8cfaf7ce-13ae-4b50-9bd8-20c957a8dfb5] File "/var/lib/kolla/venv/lib/python3.6/site-packages/nova/virt/libvirt/driver.py", line 1763, in attach_volume
12:01:44 sean-k-mooney 2020-05-22 00:28:20.355 6 ERROR nova.compute.manager [instance: 8cfaf7ce-13ae-4b50-9bd8-20c957a8dfb5] encryption=encryption)
12:01:46 sean-k-mooney 2020-05-22 00:28:20.355 6 ERROR nova.compute.manager [instance: 8cfaf7ce-13ae-4b50-9bd8-20c957a8dfb5] File "/var/lib/kolla/venv/lib/python3.6/site-packages/oslo_utils/excutils.py", line 220, in __exit__
12:01:48 sean-k-mooney 2020-05-22 00:28:20.355 6 ERROR nova.compute.manager [instance: 8cfaf7ce-13ae-4b50-9bd8-20c957a8dfb5] self.force_reraise()
12:01:50 sean-k-mooney 2020-05-22 00:28:20.355 6 ERROR nova.compute.manager [instance: 8cfaf7ce-13ae-4b50-9bd8-20c957a8dfb5] File "/var/lib/kolla/venv/lib/python3.6/site-packages/oslo_utils/excutils.py", line 196, in force_reraise
12:01:52 sean-k-mooney 2020-05-22 00:28:20.355 6 ERROR nova.compute.manager [instance: 8cfaf7ce-13ae-4b50-9bd8-20c957a8dfb5] six.reraise(self.type_, self.value, self.tb)
12:01:54 gibi ups again :)
12:01:54 sean-k-mooney 2020-05-22 00:28:20.355 6 ERROR nova.compute.manager [instance: 8cfaf7ce-13ae-4b50-9bd8-20c957a8dfb5] File "/usr/lib/python3.6/site-packages/six.py", line 703, in reraise
12:01:56 sean-k-mooney 2020-05-22 00:28:20.355 6 ERROR nova.compute.manager [instance: 8cfaf7ce-13ae-4b50-9bd8-20c957a8dfb5] raise value
12:01:58 sean-k-mooney 2020-05-22 00:28:20.355 6 ERROR nova.compute.manager [instance: 8cfaf7ce-13ae-4b50-9bd8-20c957a8dfb5] File "/var/lib/kolla/venv/lib/python3.6/site-packages/nova/virt/libvirt/driver.py", line 1736, in attach_volume
12:02:00 sean-k-mooney 2020-05-22 00:28:20.355 6 ERROR nova.compute.manager [instance: 8cfaf7ce-13ae-4b50-9bd8-20c957a8dfb5] guest.attach_device(conf, persistent=True, live=live)
12:02:02 sean-k-mooney 2020-05-22 00:28:20.355 6 ERROR nova.compute.manager [instance: 8cfaf7ce-13ae-4b50-9bd8-20c957a8dfb5] File "/var/lib/kolla/venv/lib/python3.6/site-packages/nova/virt/libvirt/guest.py", line 293, in attach_device
12:02:04 sean-k-mooney 2020-05-22 00:28:20.355 6 ERROR nova.compute.manager [instance: 8cfaf7ce-13ae-4b50-9bd8-20c957a8dfb5] self._domain.attachDeviceFlags(device_xml, flags=flags)
12:02:06 sean-k-mooney 2020-05-22 00:28:20.355 6 ERROR nova.compute.manager [instance: 8cfaf7ce-13ae-4b50-9bd8-20c957a8dfb5] File "/var/lib/kolla/venv/lib/python3.6/site-packages/eventlet/tpool.py", line 190, in doit
12:02:08 sean-k-mooney 2020-05-22 00:28:20.355 6 ERROR nova.compute.manager [instance: 8cfaf7ce-13ae-4b50-9bd8-20c957a8dfb5] result = proxy_call(self._autowrap, f, *args, **kwargs)
12:02:10 sean-k-mooney 2020-05-22 00:28:20.355 6 ERROR nova.compute.manager [instance: 8cfaf7ce-13ae-4b50-9bd8-20c957a8dfb5] File "/var/lib/kolla/venv/lib/python3.6/site-packages/eventlet/tpool.py", line 148, in proxy_call
12:02:12 sean-k-mooney 2020-05-22 00:28:20.355 6 ERROR nova.compute.manager [instance: 8cfaf7ce-13ae-4b50-9bd8-20c957a8dfb5] rv = execute(f, *args, **kwargs)
12:02:14 sean-k-mooney 2020-05-22 00:28:20.355 6 ERROR nova.compute.manager [instance: 8cfaf7ce-13ae-4b50-9bd8-20c957a8dfb5] File "/var/lib/kolla/venv/lib/python3.6/site-packages/eventlet/tpool.py", line 129, in execute
12:02:16 sean-k-mooney 2020-05-22 00:28:20.355 6 ERROR nova.compute.manager [instance: 8cfaf7ce-13ae-4b50-9bd8-20c957a8dfb5] six.reraise(c, e, tb)
12:02:18 sean-k-mooney 2020-05-22 00:28:20.355 6 ERROR nova.compute.manager [instance: 8cfaf7ce-13ae-4b50-9bd8-20c957a8dfb5] File "/usr/lib/python3.6/site-packages/six.py", line 703, in reraise
12:02:20 sean-k-mooney 2020-05-22 00:28:20.355 6 ERROR nova.compute.manager [instance: 8cfaf7ce-13ae-4b50-9bd8-20c957a8dfb5] raise value
12:02:22 sean-k-mooney 2020-05-22 00:28:20.355 6 ERROR nova.compute.manager [instance: 8cfaf7ce-13ae-4b50-9bd8-20c957a8dfb5] File "/var/lib/kolla/venv/lib/python3.6/site-packages/eventlet/tpool.py", line 83, in tworker
12:02:24 sean-k-mooney 2020-05-22 00:28:20.355 6 ERROR nova.compute.manager [instance: 8cfaf7ce-13ae-4b50-9bd8-20c957a8dfb5] rv = meth(*args, **kwargs)
12:02:26 sean-k-mooney 2020-05-22 00:28:20.355 6 ERROR nova.compute.manager [instance: 8cfaf7ce-13ae-4b50-9bd8-20c957a8dfb5] File "/usr/lib64/python3.6/site-packages/libvirt.py", line 614, in attachDeviceFlags
12:02:28 sean-k-mooney 2020-05-22 00:28:20.355 6 ERROR nova.compute.manager [instance: 8cfaf7ce-13ae-4b50-9bd8-20c957a8dfb5] if ret == -1: raise libvirtError ('virDomainAttachDeviceFlags() failed', dom=self)
12:02:30 sean-k-mooney 2020-05-22 00:28:20.355 6 ERROR nova.compute.manager [instance: 8cfaf7ce-13ae-4b50-9bd8-20c957a8dfb5] libvirt.libvirtError: internal error: child reported (status=125): unable to open /dev/sdg: No such device or address
12:02:32 sean-k-mooney ops
12:02:34 sean-k-mooney http://paste.openstack.org/show/793881/
12:02:36 sean-k-mooney ment to past the link
12:02:38 sean-k-mooney lyarwood: are you still working on stable rescue?
12:02:50 gibi I think stable rescue was finished in ussuri
12:03:06 sean-k-mooney this might be related or might not. i have different disk_bus and cdrom_bus image proterties set in my orginal image and the rescue image
12:03:51 sean-k-mooney i might do an upgrade of my cloud and see if the issue still exists. i have a random commit off master deployed
12:06:12 lyarwood sean-k-mooney: finished in U, what's up?
12:06:51 sean-k-mooney if we use q35 i have found at least two cases where attach volume is broken
12:06:58 sean-k-mooney one is when you boot form an iso
12:07:10 sean-k-mooney the other is if you try to use an iso for rescue
12:07:29 lyarwood sean-k-mooney: in both cases is it trying to use an IDE bus?
12:07:40 sean-k-mooney no
12:08:05 sean-k-mooney the iso image is using sata
12:08:18 sean-k-mooney i set cdrom_bus=sata in the image meta
12:09:19 openstackgerrit Lee Yarwood proposed openstack/nova master: DNM: Test m1.nano flavor with 96MB to avoid tmpfs exhaustion https://review.opendev.org/730308

Earlier   Later