| Posted | Nick | Remark | |
|---|---|---|---|
| #openstack-nova - 2020-05-14 | |||
| 09:43:07 | bauzas | they were asking me for teaching only for 1 hour | |
| 09:43:30 | bauzas | now, it's 9am-11.30am and then 1.30pm-4.30pm | |
| 09:43:39 | bauzas | :( | |
| 09:53:01 | openstackgerrit | sean mooney proposed openstack/nova master: cyborg evacuate support https://review.opendev.org/715326 | |
| 09:55:27 | sean-k-mooney | gibi: brinzhang_ filed https://blueprints.launchpad.net/nova/+spec/cyborg-rebuild-and-evacuate | |
| 09:56:09 | sean-k-mooney | ill add it to the meeting adgenda but im hoping we are all fine with proceeding with that as a specless blueprint since i have already implemented it | |
| 09:57:09 | gibi | sean-k-mooney: thanks | |
| 09:58:55 | sean-k-mooney | bauzas: im going to update the numa in placmenet spec for the victoria templeate and resubmit it now. that ok with you? | |
| 09:59:34 | brinzhang_ | sean-k-mooney: got it, thanks, I will register suspend/resume and shelve/unshelve as the same rebuild/evacuate | |
| 10:00:11 | brinzhang_ | sean-k-mooney, gibi: and there is also another blueprint need to be done, https://blueprints.launchpad.net/nova/+spec/define-cyborg-arq-binding-notification-event | |
| 10:01:09 | gibi | stephenfin: do you mean merging https://review.opendev.org/#/c/727898/ is not needed if we merging https://review.opendev.org/#/c/727898/ and doing a version bump? | |
| 10:01:13 | brinzhang_ | I write poc code, but there is not time to add UT, when I have free time, I will summit a WIP patch for this | |
| 10:01:45 | gibi | stephenfin: I mean merging your patch https://review.opendev.org/#/c/727992/ | |
| 10:03:58 | gibi | brinzhang_: could you write one sentence in that bp about what you need implemented? | |
| 10:04:50 | brinzhang_ | gibi: ok | |
| 10:04:53 | gibi | thanks | |
| 10:07:37 | stephenfin | gibi: Yeah, exactly | |
| 10:08:29 | gibi | stephenfin: if we can merge that quickly then I'm OK to wait for the better solution | |
| 10:09:06 | openstackgerrit | sean mooney proposed openstack/nova-specs master: re-propose numa with placement https://review.opendev.org/728009 | |
| 10:09:42 | brinzhang_ | gibi: I modified https://blueprints.launchpad.net/nova/+spec/define-cyborg-arq-binding-notification-event description in simple, is it ok? | |
| 10:11:35 | gibi | brinzhang_: what you have to add regarding "accelerators binding notifications." ? | |
| 10:11:44 | gibi | what you have to add to nova | |
| 10:12:41 | sean-k-mooney | gmann: when you have time could you weigh in on https://review.opendev.org/#/c/702394/ i think it likely should have a specless blueprint or a spec since its technicall changing api behavior by cause the event api to force refresh the netwrok info cache. that is an internal detail however so im not sure it should have a micro version bump as form a normal user perspecitive that should not be visable | |
| 10:12:43 | sean-k-mooney | but it would be good to get your input. | |
| 10:16:18 | brinzhang_ | gibi: updated, I think it's the clear I can write in | |
| 10:16:36 | brinzhang_ | stephenfin: what do you think of https://review.opendev.org/#/c/727589/ ? | |
| 10:17:16 | brinzhang_ | I saw you were abandoned https://review.opendev.org/#/c/727140/, would you like to continue that patch? | |
| 10:18:23 | openstackgerrit | Lee Yarwood proposed openstack/nova master: compute: Allow snapshots to be created from PAUSED volume backed instances https://review.opendev.org/728011 | |
| 10:18:23 | openstackgerrit | Lee Yarwood proposed openstack/nova master: compute: Remove snapshot quiesce tests for STOPPED and SUSPENDED instances https://review.opendev.org/728012 | |
| 10:18:47 | lyarwood | ^ simple fix if anyone has time | |
| 10:18:50 | stephenfin | brinzhang_: hacking 3.1.0 will bump the version of flake8 supported so it would probably make more sense to wait for that to be released | |
| 10:20:13 | stephenfin | brinzhang_: I'm okay for you to take over that work | |
| 10:20:16 | brinzhang_ | yeah, I know, I mean do we need to correct these code style, after we bump hacking>=3.0.1 | |
| 10:21:02 | gibi | brinzhang_: I'm still confused. Nova does not have versioned notification for neutron port binding during nova server create. So I don't see why nova would emit versioned notifications for ARQ binding | |
| 10:21:31 | brinzhang_ | stephenfin: thanks, I want to say when I submit this patch, I have not check your patch | |
| 10:23:12 | brinzhang_ | gibi: this Blueprint comes from https://bugs.launchpad.net/nova/+bug/1865549, when I saw this bug, I just only think define-cyborg-arq-binding-notification-event is what I should do, or I missed something? | |
| 10:23:12 | openstack | Launchpad bug 1865549 in OpenStack Compute (nova) " Define Cyborg ARQ binding notification event." [Wishlist,Confirmed] - Assigned to Brin Zhang (zhangbailin) | |
| 10:23:44 | brinzhang_ | OTW, this is an invalid bug? | |
| 10:23:45 | gibi | brinzhang_: this is a doc bug | |
| 10:24:05 | stephenfin | brinzhang_: all good :) | |
| 10:24:13 | gibi | generated automatically due to DocImpact in the commit message | |
| 10:24:31 | gibi | so the question is what doc needs to be updated due to https://review.opendev.org/692707 | |
| 10:26:02 | brinzhang_ | gibi: that should do DocImpact: Adds new version to doc/api_samples/versions/. ? | |
| 10:27:46 | gibi | as far as I see that patch itself added such doc change | |
| 10:27:53 | brinzhang_ | stephenfin: thanks ^ | |
| 10:27:53 | brinzhang_ | gibi:I am sorry, I am confusing.. | |
| 10:28:17 | gibi | so I think that bug is Invalid we don't need to change anything due to taht | |
| 10:28:33 | brinzhang_ | yeah, I think so. | |
| 10:28:53 | gibi | bauzas: do you agree that bug https://bugs.launchpad.net/nova/+bug/1865549 is invalid? ^^ | |
| 10:28:53 | openstack | Launchpad bug 1865549 in OpenStack Compute (nova) " Define Cyborg ARQ binding notification event." [Wishlist,Confirmed] - Assigned to Brin Zhang (zhangbailin) | |
| 10:28:56 | brinzhang_ | thanks gibi. | |
| 10:38:59 | brinzhang_ | stephenfin: your comment hacking version is 3.1.0, you mean 3.0.1, right? | |
| 10:39:27 | stephenfin | no, 3.1.0, which isn't released yet (I've proposed the release though) | |
| 10:40:52 | brinzhang_ | stephenfin: I saw gmann submit 3.0.1 to many project, if the 3.1.0 released, that has need to be changed again? | |
| 10:41:14 | brinzhang_ | I will update your comments after 3.1.0 released ^ | |
| 10:41:51 | stephenfin | yes and no. The 3.0.1 bump is necessary to ensure the correct version flake8 is installed. The 3.1.0 bump should be done but it wouldn't be as urgent | |
| 10:43:22 | brinzhang_ | ok, thank for your explain | |
| 10:56:55 | openstackgerrit | Harshavardhan Metla proposed openstack/nova master: [Nova] Add reference to Placement installation guide https://review.opendev.org/726936 | |
| 10:57:38 | openstackgerrit | Brin Zhang proposed openstack/nova master: DNM: Add ARQs binding notification https://review.opendev.org/728027 | |
| 11:36:40 | openstackgerrit | sean mooney proposed openstack/os-vif master: update tox envs and support pdf docs https://review.opendev.org/728037 | |
| 11:37:39 | sean-k-mooney | stephenfin: by the way wasnt pdf docs a goal at some point. | |
| 11:45:08 | openstackgerrit | Lee Yarwood proposed openstack/nova master: Add functional test for bug 1550919 https://review.opendev.org/631294 | |
| 11:45:08 | openstack | bug 1550919 in OpenStack Compute (nova) "[Libvirt]Evacuate fail may cause disk image be deleted" [Medium,In progress] https://launchpad.net/bugs/1550919 - Assigned to Lee Yarwood (lyarwood) | |
| 11:45:08 | openstackgerrit | Lee Yarwood proposed openstack/nova master: libvirt: Don't delete disks on shared storage during evacuate https://review.opendev.org/578846 | |
| 11:57:12 | jsuchome | lyarwood: Hi. Shouldn't https://review.opendev.org/#/c/727225/ be rebuilt automatically when I pushed new changes to the depends-on patch? | |
| 12:00:03 | sean-k-mooney | jsuchome: no | |
| 12:00:11 | sean-k-mooney | you have to manually recheck | |
| 12:01:01 | sean-k-mooney | jsuchome: just leave a "recheck" comment on https://review.opendev.org/#/c/727225/ and it will run again | |
| 12:06:44 | openstackgerrit | sean mooney proposed openstack/nova stable/ussuri: Silence amqp heartbeat warning https://review.opendev.org/728054 | |
| 12:08:03 | bauzas | sean-k-mooney: sure, either you or me can repropose the spec, but let's do it | |
| 12:08:07 | bauzas | if you want | |
| 12:08:19 | sean-k-mooney | bauzas: i did it while you were away | |
| 12:08:19 | bauzas | gibi: looking | |
| 12:08:31 | sean-k-mooney | https://review.opendev.org/#/c/728009/ | |
| 12:08:56 | bauzas | sean-k-mooney: ack, clicking | |
| 12:10:38 | bauzas | gibi: I triaged it as wishlist | |
| 12:10:53 | bauzas | gibi: it's a doc thingies, right? | |
| 12:10:58 | bauzas | https://bugs.launchpad.net/nova/+bug/1865549 | |
| 12:10:58 | openstack | Launchpad bug 1865549 in OpenStack Compute (nova) " Define Cyborg ARQ binding notification event." [Wishlist,Confirmed] - Assigned to Brin Zhang (zhangbailin) | |
| 12:11:30 | gibi | bauzas: it seems to me that that the original patch added DocImpact tag in the commit message, and that triggered the bug creation automaticaly. But as far as I see the original patch did the documentation | |
| 12:11:48 | bauzas | gibi: oh my bad then, I haven't looked at the doc | |
| 12:11:54 | openstackgerrit | sean mooney proposed openstack/nova stable/ussuri: remove support of oslo.messaging 9.8.0 warning message https://review.opendev.org/728055 | |
| 12:11:56 | bauzas | gibi: feel free to close it then | |
| 12:12:22 | gibi | bauzas: thanks. closing it | |
| 12:13:15 | openstackgerrit | sean mooney proposed openstack/nova stable/ussuri: remove support of oslo.messaging 9.8.0 warning message https://review.opendev.org/728055 | |
| 12:15:54 | jsuchome | sean-k-mooney: ok thanks (still don't know why it is failing, let's see if it behaves differently with new patch) | |
| 12:18:33 | openstackgerrit | sean mooney proposed openstack/nova stable/train: Silence amqp heartbeat warning https://review.opendev.org/728057 | |
| 12:18:34 | openstackgerrit | sean mooney proposed openstack/nova stable/train: remove support of oslo.messaging 9.8.0 warning message https://review.opendev.org/728058 | |
| 12:20:33 | openstackgerrit | sean mooney proposed openstack/nova stable/stein: Silence amqp heartbeat warning https://review.opendev.org/728059 | |
| 12:21:56 | sean-k-mooney | jsuchome: test_volume_crud_with_volume_type_and_extra_specs is what failed but that seams unrelated to your change | |
| 12:24:27 | lyarwood | jsuchome / sean-k-mooney ; yeah that was unrelated but I didn't see any DEBUG lines from your change in n-cpu FWIW | |
| 12:24:51 | lyarwood | jsuchome: I'll play around with things on a local env after a call | |
| 12:26:14 | openstackgerrit | Ivaylo Mitev proposed openstack/nova master: Faults from cell DB missing in GET /servers/detail https://review.opendev.org/699176 | |
| 12:27:15 | jsuchome | lyarwood: yeah, i did not seem them either ... it actually should be INFO line ("Successfully transferred using")... | |
| 12:27:58 | jsuchome | I would also be surprised if that volume test were related... | |
| 12:28:04 | bauzas | sean-k-mooney: fwiw, changed the topic name of https://review.opendev.org/#/c/728009/ since there was a typo | |
| 12:28:16 | bauzas | (just in case you need to update the change) | |
| 12:28:45 | sean-k-mooney | no worries i use git review to download my patches before i update them | |
| 12:29:04 | sean-k-mooney | i ussuall keep the local patch too but it should preserve the topic | |
| 12:31:17 | sean-k-mooney | bauzas: i have a few small bugfixes im planning to rebase but ill proably start creating a poc of the numa change on monday or tuesday | |