Earlier  
Later
New Search
Posted Nick Remark
#openstack-nova - 2020-05-14
12:00:11 sean-k-mooney you have to manually recheck
12:01:01 sean-k-mooney jsuchome: just leave a "recheck" comment on https://review.opendev.org/#/c/727225/ and it will run again
12:06:44 openstackgerrit sean mooney proposed openstack/nova stable/ussuri: Silence amqp heartbeat warning https://review.opendev.org/728054
12:08:03 bauzas sean-k-mooney: sure, either you or me can repropose the spec, but let's do it
12:08:07 bauzas if you want
12:08:19 sean-k-mooney bauzas: i did it while you were away
12:08:19 bauzas gibi: looking
12:08:31 sean-k-mooney https://review.opendev.org/#/c/728009/
12:08:56 bauzas sean-k-mooney: ack, clicking
12:10:38 bauzas gibi: I triaged it as wishlist
12:10:53 bauzas gibi: it's a doc thingies, right?
12:10:58 bauzas https://bugs.launchpad.net/nova/+bug/1865549
12:10:58 openstack Launchpad bug 1865549 in OpenStack Compute (nova) " Define Cyborg ARQ binding notification event." [Wishlist,Confirmed] - Assigned to Brin Zhang (zhangbailin)
12:11:30 gibi bauzas: it seems to me that that the original patch added DocImpact tag in the commit message, and that triggered the bug creation automaticaly. But as far as I see the original patch did the documentation
12:11:48 bauzas gibi: oh my bad then, I haven't looked at the doc
12:11:54 openstackgerrit sean mooney proposed openstack/nova stable/ussuri: remove support of oslo.messaging 9.8.0 warning message https://review.opendev.org/728055
12:11:56 bauzas gibi: feel free to close it then
12:12:22 gibi bauzas: thanks. closing it
12:13:15 openstackgerrit sean mooney proposed openstack/nova stable/ussuri: remove support of oslo.messaging 9.8.0 warning message https://review.opendev.org/728055
12:15:54 jsuchome sean-k-mooney: ok thanks (still don't know why it is failing, let's see if it behaves differently with new patch)
12:18:33 openstackgerrit sean mooney proposed openstack/nova stable/train: Silence amqp heartbeat warning https://review.opendev.org/728057
12:18:34 openstackgerrit sean mooney proposed openstack/nova stable/train: remove support of oslo.messaging 9.8.0 warning message https://review.opendev.org/728058
12:20:33 openstackgerrit sean mooney proposed openstack/nova stable/stein: Silence amqp heartbeat warning https://review.opendev.org/728059
12:21:56 sean-k-mooney jsuchome: test_volume_crud_with_volume_type_and_extra_specs is what failed but that seams unrelated to your change
12:24:27 lyarwood jsuchome / sean-k-mooney ; yeah that was unrelated but I didn't see any DEBUG lines from your change in n-cpu FWIW
12:24:51 lyarwood jsuchome: I'll play around with things on a local env after a call
12:26:14 openstackgerrit Ivaylo Mitev proposed openstack/nova master: Faults from cell DB missing in GET /servers/detail https://review.opendev.org/699176
12:27:15 jsuchome lyarwood: yeah, i did not seem them either ... it actually should be INFO line ("Successfully transferred using")...
12:27:58 jsuchome I would also be surprised if that volume test were related...
12:28:04 bauzas sean-k-mooney: fwiw, changed the topic name of https://review.opendev.org/#/c/728009/ since there was a typo
12:28:16 bauzas (just in case you need to update the change)
12:28:45 sean-k-mooney no worries i use git review to download my patches before i update them
12:29:04 sean-k-mooney i ussuall keep the local patch too but it should preserve the topic
12:31:17 sean-k-mooney bauzas: i have a few small bugfixes im planning to rebase but ill proably start creating a poc of the numa change on monday or tuesday
12:33:18 sean-k-mooney as much as i want to jump into the code i might actully start with a functional test but i need to see how you and stephenfin handeled the functional tests for the exsiting reshapes
12:34:19 sean-k-mooney getting it working for a new deployment would be simpler but im going to have to deal with the upgrade case eventurally
12:36:47 bauzas sean-k-mooney: I have written reshapes for vGPUs, you can look at i t
12:39:20 sean-k-mooney yep but i dont want to context switch to that until next week
12:59:29 openstackgerrit Ivaylo Mitev proposed openstack/nova master: VMware: Attach volumes using adapter type from instance https://review.opendev.org/616599
13:29:53 kashyap "a utility for easily configuring networking on a linux system"
13:51:25 sean-k-mooney kashyap: ya it became the default in ubuntu 18.04
13:52:28 kashyap I see; yet another abstraction.
13:53:02 sean-k-mooney it was intoduced to make bridging ot systemd-networkd simpler over time.
13:53:41 sean-k-mooney there a a few neche thing it does not support but in general i thikn its an impovement
14:05:52 artom stephenfin, hey, comment on https://review.opendev.org/#/c/714698/8
14:06:05 artom stephenfin, I hesitate to -1 because of it, tell me what you think
14:06:15 gmann brinzhang_: gibi replied on pep8 fix patch. let me release new hacking 4.0.0 which will have new checks and then we can fix and bump version in same patch to verify all work fine.
14:06:21 openstackgerrit Takashi Natsume proposed openstack/nova master: Remove six.binary_type/integer_types/string_types https://review.opendev.org/728094
14:07:40 gmann sean-k-mooney: sure, I will check
14:09:42 openstackgerrit Jiri Suchomel proposed openstack/nova master: Bring back allowed_direct_url_schemes in support of RBD image download https://review.opendev.org/728095
14:12:12 stephenfin artom: replied
14:12:44 stephenfin artom: tl;dr: I'd suggest blindly approving that and focusing your efforts on https://review.opendev.org/#/c/714703/ instead :P
14:15:35 artom stephenfin, hehe - yeah, I'm slowly making my way up the stack.
14:16:12 stephenfin gmann: Before you do any work on it, I already have a hacking 3.1.0 proposed https://review.opendev.org/#/c/728016/
14:17:47 stephenfin Using semver for hacking (or flake8 and its ilk) is weird. On one hand, you normally think of minor versions as "not breaking anything" and that entails ensuring changes are purely additive, but for hacking a change can be purely additive and still break stuff
14:21:13 stephenfin gmann: in any case, I've opted for 3.1.0 because the release doesn't remove anything (so it's correct in a literal semver sense) and bumping the major version every time we add something new to hacking (or get it for free via flake8) seems insane
14:32:47 stephenfin lyarwood: Do you think you'd be able to take a look at the bottom of this series at some point? https://review.opendev.org/#/q/topic:bp/use-pcpu-and-vcpu-in-one-instance+status:open
14:34:10 stephenfin The bottom patches are almost all cleanup and shuffling of code. Things only get interesting higher up (currently in merge conflict) and I'm happy to review those ones
14:34:28 lyarwood stephenfin: yup but likely not today
14:34:40 stephenfin oh yeah, just at some point
14:34:58 lyarwood ack added
14:35:32 lyarwood gerrit really doesn't like long series like that
14:35:42 lyarwood it took a few clicks to work out where the bottom of the series actually was
14:38:14 gmann stephenfin: i see, thanks. I was waiting for hacking patch to merge before release. i agree on versioning things, it is difficult to make it consistent with other as per its nature of breaking things. 3.1.0 is ok for me.
14:41:46 gmann stephenfin: thanks you pinged me, i was about to push my local patch to release it :)
14:42:00 stephenfin heh, no problem :)
14:48:16 lyarwood weirdness, I'm getting the following in a functional test despite using microversion = 'latest'
14:48:18 lyarwood nova.tests.functional.api.client.OpenStackApiException: Unexpected status code: {"badRequest": {"code": 400, "message": "'host' is a required property"}}
14:49:16 lyarwood self.admin_api.put_service(test_compute0_service_id, {"forced_down": True}) <- from that, looks like it's using an earlier microversion but I can't see any obvious reason why, has anyone seen this before?
14:51:01 gmann lyarwood: which test. 'despite using microversion = 'latest'' you mean particular test right not overall for all request
14:51:48 lyarwood gmann: all requests, self.admin_api.microversion == 'latest'
14:53:55 gmann lyarwood: that might not work as test are written per microversion cap they would(might) not run for 'latest'.
14:55:17 lyarwood gmann: you're talking about https://github.com/openstack/nova/blob/ef3b5707328f460d0d03759061c01b1a20f28743/nova/api/openstack/compute/services.py#L380-L383 right?
14:55:26 lyarwood gmann: so you have to use 2.53 to use this?
14:55:34 gibi dansmith: hi! one complication of the cache bug is that the cache management is virt driver specific but the placement resource management is up in the compute manager. So for the fix I need to pass new information through the virt driver interface, either by returning disc occupancy from manage_image_cache() or by adding some new get method to the virt interface
14:57:23 gmann lyarwood: yes, but i am saying if you run all the func test with 'latest' then it would not work. or you are running only update service tests ?
14:57:58 dansmith gibi: yeah, I was saying to sean-k-mooney yesterday how it's kinda split between them in an unhelpful way
14:58:02 lyarwood gmann: ah sorry no this is a specific test class that's set to 'latest'
14:58:29 dansmith gibi: doing it during manage_image_cache() means the allocations will lag reality, which isn't going to work well I think
14:58:43 dansmith gibi: IIRC, that runs very slowly, like every 24h or something
14:58:48 dansmith (by default)
14:59:06 dansmith gibi: unfortunately, I think it kinda has to happen synchronously during boot to really be effective
14:59:07 openstackgerrit Takashi Natsume proposed openstack/nova master: Remove six.text_type (1/2) https://review.opendev.org/728109
14:59:53 gibi dansmith: yeah for the boot I need a sync approach. for the periodicy resynchronization I'm thinking of reusing manage_image_cache()
15:00:08 dansmith gibi: sure
15:00:43 gibi dansmith: OK so we agree that a virt interface impact is unavoidable
15:00:45 gmann lyarwood: ohk, then it is taking old 2.1 schema which need host. i think we read 'latest' correctly in code- https://github.com/openstack/nova/blob/ef3b5707328f460d0d03759061c01b1a20f28743/nova/api/openstack/compute/schemas/services.py#L46
15:01:05 dansmith gibi: yeah I dunno how else you would do it.. like I had to add driver.cache_image() for my thing
15:01:39 dansmith gibi: and probably some signaling about the filesystem same-ness
15:03:03 gibi dansmith: OK, I will continue working through this path then
15:04:36 lyarwood gmann: ah got it thanks
15:04:45 lyarwood gmann: I was missing api_major_version = 'v2.1'
15:06:08 gmann lyarwood: ohk, and it was microversion request with 2.0 so ignored
15:08:18 lyarwood gmann: yeah that wasn't at all obvious, thanks again :)
15:26:56 openstackgerrit Takashi Natsume proposed openstack/nova master: Remove six.text_type (2/2) https://review.opendev.org/728117
15:28:24 lyarwood stephenfin / artom: random question, do either of you recall how nova.tests.functional.libvirt.base.ServersTestBase stops the instance directories from being created?
15:29:00 artom lyarwood, I'd have to go digging - there's a presumably a mock/monkeypatch somewhere
15:29:04 stephenfin lyarwood: Not off the top of my head, unfortunately
15:29:10 lyarwood I've stopped applying ImageBackendFixture and the other obvious file_open fixtures etc but it's still not happy
15:29:17 lyarwood ack np

Earlier   Later