| Posted | Nick | Remark | |
|---|---|---|---|
| #openstack-nova - 2020-05-04 | |||
| 09:13:03 | bauzas | lemme see if creating a ussuri.rst file would help | |
| 09:14:21 | gibi | bauzas: thanks for helping, I'm sitting on a meeting | |
| 09:14:31 | bauzas | ok, we have https://github.com/openstack/nova/blob/master/releasenotes/source/ussuri.rst | |
| 09:14:34 | bauzas | in master | |
| 09:14:43 | bauzas | which is normal | |
| 09:14:53 | bauzas | gibi: np | |
| 09:15:09 | bauzas | gibi: i think I have some potential findings but I need to test | |
| 09:15:25 | bauzas | and it takes a while to generate the relnotes locally as it scans all my branches | |
| 09:16:10 | gibi | yeah it is slow | |
| 09:16:46 | bauzas | interesting | |
| 09:16:53 | bauzas | it did worked fine on my box | |
| 09:18:05 | bauzas | interestingly, my current branch is ussuri when i'm testing on a local stable/ussuro | |
| 09:18:19 | bauzas | which is not the case with the job https://zuul.opendev.org/t/openstack/build/9c4f698044dc4af2b5bcb326b6a3e823/log/job-output.txt | |
| 09:20:12 | gibi | yeah, I also cannot reproduce the problem locally | |
| 09:35:16 | bauzas | gibi: maybe a job issue | |
| 09:36:55 | gibi | bauzas: interestingly the job tries to generate reno for stable/ussuri the local tox target does not try that for me | |
| 09:38:51 | gibi | locally I get | |
| 09:38:51 | gibi | scanning /home/gibizer/upstream/git/nova/releasenotes/notes for current branch release notes | |
| 09:38:54 | gibi | got versions [] | |
| 09:39:06 | gibi | in the job | |
| 09:39:07 | gibi | 2020-05-04 07:58:23.877287 | ubuntu-bionic | scanning /home/zuul/src/opendev.org/openstack/nova/releasenotes/notes for current branch release notes | |
| 09:39:11 | gibi | 2020-05-04 07:59:02.632023 | ubuntu-bionic | got versions ['21.0.0.0rc1-16'] | |
| 09:39:14 | gibi | 2020-05-04 07:59:02.664924 | ubuntu-bionic | reading sources... [100%] ussuri | |
| 09:39:17 | gibi | 2020-05-04 07:59:02.670555 | ubuntu-bionic | scanning /home/zuul/src/opendev.org/openstack/nova/releasenotes/notes for stable/ussuri release notes | |
| 09:39:20 | gibi | 2020-05-04 08:00:13.350874 | ubuntu-bionic | got versions ['21.0.0.0rc1-5', '21.0.0.0rc1'] | |
| 09:41:22 | bauzas | lemme doublecheck mine | |
| 09:41:42 | gibi | are these versions '21.0.0.0rc1-5' are git tags? | |
| 09:41:46 | gibi | I only have 21.0.0.0rc1 tag | |
| 09:42:13 | bauzas | gibi: that's my env http://paste.openstack.org/show/793033/ | |
| 09:42:34 | bauzas | gibi: I branched stable/ussuri and cherry-picked the change into it | |
| 09:43:10 | bauzas | gibi: yup, AFAIR, reno works with git commits and tags | |
| 09:43:12 | gibi | it is pretty similar to mine except you have got versions ['21.0.0.0rc1-5'] | |
| 09:43:47 | bauzas | which is expected | |
| 09:44:04 | bauzas | gibi: if I tag my branch as 21.0.1 per se | |
| 09:44:10 | bauzas | gibi: then you'll be seeing it | |
| 09:44:40 | bauzas | gibi: see https://docs.openstack.org/project-team-guide/release-management.html#how-to-preview-release-notes-at-rc-time | |
| 09:45:10 | bauzas | gibi: remember that reno tries to see which tags are related to which releasenotes | |
| 09:45:40 | bauzas | once you tag a .z version, then you'll see it | |
| 09:46:57 | gibi | bauzas: does it mean that the gate job temporarly tag the repo and then generate the notes? | |
| 09:47:09 | bauzas | I don't think so | |
| 09:47:27 | gibi | OK. I'm lost :) | |
| 09:48:03 | bauzas | and see whether reno finds it | |
| 09:48:08 | gibi | ok | |
| 09:48:44 | bauzas | we need dhellmann or someone else from the reno team IMHO | |
| 09:49:37 | bauzas | gibi: what's not normal is that we scan both the current branch and the stable/ussuri one | |
| 09:50:01 | bauzas | (against a stable/ussuri change) | |
| 09:50:07 | bauzas | because both are identical | |
| 09:50:26 | bauzas | gibi: you understand this ? | |
| 09:50:54 | gibi | I accept this as a probable problem. I just blocked by the fact that I cannot reproduce the result locally | |
| 09:50:57 | bauzas | https://zuul.opendev.org/t/openstack/build/9c4f698044dc4af2b5bcb326b6a3e823/log/job-output.txt#1415 and https://zuul.opendev.org/t/openstack/build/9c4f698044dc4af2b5bcb326b6a3e823/log/job-output.txt#1418 generate the same | |
| 09:51:05 | bauzas | gibi: yeah, me too | |
| 09:54:47 | bauzas | gibi: what we could do is trying to avoid to present the upgrade note in master | |
| 09:54:58 | bauzas | gibi: I can try to provide a DNM for testing | |
| 09:55:30 | bauzas | gibi: actually, the upgrade note is invalid for Victoria, right ? | |
| 09:56:27 | bauzas | gibi: see what happens when you tag locally : http://paste.openstack.org/show/793034/ | |
| 09:57:27 | bauzas | gibi: and by looking at my html build, I see the note, yeepee | |
| 09:57:39 | bauzas | (marked against my fake 21.0.1) | |
| 09:57:42 | gibi | so locally it is still not generate notes for stable/ussuri | |
| 09:57:50 | bauzas | it does | |
| 09:58:00 | bauzas | but as 'unreleased' | |
| 09:58:23 | bauzas | see https://docs.openstack.org/releasenotes/nova/unreleased.html | |
| 09:58:39 | bauzas | gibi: this is bad ^ | |
| 09:58:56 | bauzas | because the upgrade issue is when you upgrade from Train to Ussuri, right? | |
| 09:58:59 | gibi | bauzas: so we have to remove the reno from master (V)? | |
| 09:59:08 | bauzas | gibi: we'll ignore it | |
| 09:59:33 | bauzas | https://docs.openstack.org/project-team-guide/release-management.html#updating-stable-branch-release-notes | |
| 10:00:12 | bauzas | gibi: I'm just forging a :ignore-notes: directive | |
| 10:00:22 | gibi | ahh | |
| 10:00:23 | gibi | thanks | |
| 10:01:08 | gibi | so we need the ignore-notes patch on master? | |
| 10:01:16 | bauzas | I *think* | |
| 10:01:33 | bauzas | gibi: we wrote it for the T->U upgrade, right? | |
| 10:01:38 | gibi | right | |
| 10:01:52 | bauzas | ok, so let's ignore it or it will appear in the 22.0.0 relnotes | |
| 10:01:54 | gibi | we just merged it first on master | |
| 10:02:02 | gibi | and then backport | |
| 10:02:06 | bauzas | gibi: sure, i understood but reno files are different | |
| 10:02:14 | gibi | yeah, I get to feel that | |
| 10:02:15 | gibi | :) | |
| 10:02:17 | bauzas | gibi: see the warnings in the reno docs :) | |
| 10:02:43 | bauzas | if you wanna fix some specific reno file on a stable branch, you need to make it a stable-only change | |
| 10:03:15 | bauzas | my reno skills are rusty and I forgot to warn this | |
| 10:03:16 | gibi | so the good first solution would have been not to add reno for the policy upgrade check on master just in the backport to stable/ussuri | |
| 10:03:23 | bauzas | gibi: yup | |
| 10:03:37 | bauzas | May 1st killed my productivity | |
| 10:04:01 | bauzas | gibi: and tbc, git deleting a YAML file is bad | |
| 10:04:47 | gibi | bauzas: you mean that we should not fix the issue with a partial revert on master that would delete the reno file but use ignore-notes instead | |
| 10:04:56 | bauzas | gibi: yep | |
| 10:05:56 | bauzas | gibi: I can't remember why this is bad, but I think it's because reno walks above every commit and generates | |
| 10:28:42 | openstackgerrit | Sylvain Bauza proposed openstack/nova master: Don't show upgr note for policy validation in V https://review.opendev.org/725226 | |
| 10:29:17 | bauzas | gibi: ^ | |
| 10:29:28 | gibi | looking | |
| 10:29:31 | bauzas | hopefully it should fix the issue | |
| 10:29:45 | bauzas | I tested locally and the note isn't appearing | |
| 10:30:02 | bauzas | then we should recheck | |
| 10:30:12 | bauzas | the stable/ussuri change | |
| 10:31:41 | gibi | bauzas: so we merge your ignore patch then recheck the stable/ussuri backport | |
| 10:31:51 | bauzas | we can try at least | |
| 10:31:59 | bauzas | if you feel brave enough to fast approve it... | |
| 10:32:19 | gibi | does lyarwood off today too? | |