| Posted | Nick | Remark | |
|---|---|---|---|
| #openstack-nova - 2020-05-04 | |||
| 09:57:27 | bauzas | gibi: and by looking at my html build, I see the note, yeepee | |
| 09:57:39 | bauzas | (marked against my fake 21.0.1) | |
| 09:57:42 | gibi | so locally it is still not generate notes for stable/ussuri | |
| 09:57:50 | bauzas | it does | |
| 09:58:00 | bauzas | but as 'unreleased' | |
| 09:58:23 | bauzas | see https://docs.openstack.org/releasenotes/nova/unreleased.html | |
| 09:58:39 | bauzas | gibi: this is bad ^ | |
| 09:58:56 | bauzas | because the upgrade issue is when you upgrade from Train to Ussuri, right? | |
| 09:58:59 | gibi | bauzas: so we have to remove the reno from master (V)? | |
| 09:59:08 | bauzas | gibi: we'll ignore it | |
| 09:59:33 | bauzas | https://docs.openstack.org/project-team-guide/release-management.html#updating-stable-branch-release-notes | |
| 10:00:12 | bauzas | gibi: I'm just forging a :ignore-notes: directive | |
| 10:00:22 | gibi | ahh | |
| 10:00:23 | gibi | thanks | |
| 10:01:08 | gibi | so we need the ignore-notes patch on master? | |
| 10:01:16 | bauzas | I *think* | |
| 10:01:33 | bauzas | gibi: we wrote it for the T->U upgrade, right? | |
| 10:01:38 | gibi | right | |
| 10:01:52 | bauzas | ok, so let's ignore it or it will appear in the 22.0.0 relnotes | |
| 10:01:54 | gibi | we just merged it first on master | |
| 10:02:02 | gibi | and then backport | |
| 10:02:06 | bauzas | gibi: sure, i understood but reno files are different | |
| 10:02:14 | gibi | yeah, I get to feel that | |
| 10:02:15 | gibi | :) | |
| 10:02:17 | bauzas | gibi: see the warnings in the reno docs :) | |
| 10:02:43 | bauzas | if you wanna fix some specific reno file on a stable branch, you need to make it a stable-only change | |
| 10:03:15 | bauzas | my reno skills are rusty and I forgot to warn this | |
| 10:03:16 | gibi | so the good first solution would have been not to add reno for the policy upgrade check on master just in the backport to stable/ussuri | |
| 10:03:23 | bauzas | gibi: yup | |
| 10:03:37 | bauzas | May 1st killed my productivity | |
| 10:04:01 | bauzas | gibi: and tbc, git deleting a YAML file is bad | |
| 10:04:47 | gibi | bauzas: you mean that we should not fix the issue with a partial revert on master that would delete the reno file but use ignore-notes instead | |
| 10:04:56 | bauzas | gibi: yep | |
| 10:05:56 | bauzas | gibi: I can't remember why this is bad, but I think it's because reno walks above every commit and generates | |
| 10:28:42 | openstackgerrit | Sylvain Bauza proposed openstack/nova master: Don't show upgr note for policy validation in V https://review.opendev.org/725226 | |
| 10:29:17 | bauzas | gibi: ^ | |
| 10:29:28 | gibi | looking | |
| 10:29:31 | bauzas | hopefully it should fix the issue | |
| 10:29:45 | bauzas | I tested locally and the note isn't appearing | |
| 10:30:02 | bauzas | then we should recheck | |
| 10:30:12 | bauzas | the stable/ussuri change | |
| 10:31:41 | gibi | bauzas: so we merge your ignore patch then recheck the stable/ussuri backport | |
| 10:31:51 | bauzas | we can try at least | |
| 10:31:59 | bauzas | if you feel brave enough to fast approve it... | |
| 10:32:19 | gibi | does lyarwood off today too? | |
| 10:34:31 | bauzas | gibi: he's a bit off and on | |
| 10:36:46 | bauzas | stephenfin: if you mind approving this one quickly https://review.opendev.org/#/c/725226/1 | |
| 10:37:19 | bauzas | we need it in order to unfuck https://review.opendev.org/#/c/725146/ which is holding RC2 | |
| 11:00:50 | zigo | My PR here is not good. I've been asked to add a functional test, I tried copying it from the Keystone one but failed. Can anyone help ? | |
| 11:00:50 | zigo | https://review.opendev.org/724684 | |
| 11:00:54 | zigo | bauzas: ^ | |
| 11:00:58 | zigo | :) | |
| 11:01:58 | zigo | IMO, it's in the wrong place (he: where CORS is tested), and not doing the right thing. My intention is that it only checks the HTTP 200 return, which is the only thing that should be tested... | |
| 11:02:16 | zigo | I'd love to have a easy way to functional test this that I could copy in all projects later on. | |
| 12:06:16 | bauzas | zigo: I'm not a paste specialist, but maybe you should add it to https://review.opendev.org/#/c/724684/5/etc/nova/api-paste.ini@L78 | |
| 12:10:26 | zigo | bauzas: The issue is only the functional test, not the api-paste.ini which i tested. | |
| 12:13:51 | bauzas | zigo: then I guess requests is not using parse | |
| 12:15:50 | bauzas | ahah, we have an APIPasteFixture object :) | |
| 12:16:20 | bauzas | bingo | |
| 12:16:22 | bauzas | zigo: ^ | |
| 12:17:10 | bauzas | zigo: look at this https://github.com/openstack/nova/blob/master/nova/tests/functional/api_paste_fixture.py#L51-L59 | |
| 12:25:42 | bauzas | zigo: you should probably pdb the fixture to see what you get as paste.ini | |
| 12:26:24 | zigo | Ok. | |
| 12:49:09 | bauzas | oh but today is a bank holiday in Ireland | |
| 12:49:12 | bauzas | stephenfin: my bad | |
| 12:50:34 | bauzas | stephenfin: my badhttps://review.opendev.org/#/c/725226/ ? | |
| 12:50:37 | bauzas | I can +W it | |
| 12:50:56 | bauzas | lyarwood: around maybe ? | |
| 13:01:35 | bauzas | zigo: fwiw, pdb'ing 724684 | |
| 13:33:41 | bauzas | zigo: ah, I think I found the problem | |
| 13:33:56 | zigo | :) | |
| 13:34:28 | bauzas | zigo: http://paste.openstack.org/show/793050/ | |
| 13:34:53 | bauzas | looks like it tries to call a /v2 endpoint | |
| 13:34:57 | zigo | Oh ! :) | |
| 13:35:11 | zigo | It should be just /healthcheck indeed... | |
| 13:35:29 | zigo | And probably without any auth as well. | |
| 13:38:30 | openstackgerrit | François Palin proposed openstack/nova stable/rocky: Add retry to cinder API calls related to volume detach https://review.opendev.org/725272 | |
| 13:38:30 | openstackgerrit | François Palin proposed openstack/nova stable/rocky: Add retry to cinder API calls related to volume detach https://review.opendev.org/725272 | |
| 13:48:32 | zigo | bauzas: What's the way to make it not prefix the URL then? | |
| 13:48:49 | bauzas | again, I'm not an API specialist unfortunately | |
| 13:49:06 | bauzas | I can't really answer why we transform this URL | |
| 13:49:21 | bauzas | but lemme try something | |
| 13:51:12 | bauzas | ahah found | |
| 13:51:13 | bauzas | https://github.com/openstack/nova/blob/master/nova/tests/functional/api/client.py#L147 | |
| 13:52:23 | zigo | strip_version=True and I'm good to go? | |
| 13:54:37 | bauzas | zigo: fwiw, I just tested to call 'http://728dd5ee-0231-4919-b991-a21cae822084:80/healthcheck' and I got a 200 :) | |
| 13:54:47 | bauzas | just trying strip_version | |
| 13:54:51 | zigo | :) | |
| 13:54:52 | zigo | Thanks. | |
| 13:54:54 | zigo | Trying. | |
| 13:55:29 | bauzas | got a 300 | |
| 13:55:40 | bauzas | that's... fun :) | |
| 13:55:56 | openstackgerrit | Thomas Goirand proposed openstack/nova master: Add a /healthcheck URL https://review.opendev.org/724684 | |
| 13:56:43 | bauzas | zigo: hold your change | |
| 13:56:47 | bauzas | it won't work (yet) | |
| 13:58:10 | bauzas | ahah ! | |
| 13:58:19 | bauzas | > /home/sbauza/git/openstack/nova/nova/tests/functional/api/client.py(172)api_request() | |
| 13:58:20 | bauzas | -> response = self.request(full_uri, **kwargs) | |
| 13:58:20 | bauzas | (Pdb) full_uri | |
| 13:58:20 | bauzas | 'http://94193b57-ca75-4e13-9d4c-2cc961eeaf5b:80/6f70656e737461636b20342065766572//healthcheck' | |