| Posted | Nick | Remark | |
|---|---|---|---|
| #openstack-nova - 2020-04-09 | |||
| 11:05:59 | sean-k-mooney | yep what you have is correct | |
| 11:06:04 | stephenfin | r'[A-Z0-9_]+' applies to trait | |
| 11:06:13 | bauzas | my only concern is with traits | |
| 11:06:27 | sean-k-mooney | bauzas: line 65 handels that | |
| 11:06:35 | sean-k-mooney | and that is correct | |
| 11:06:36 | bauzas | of what ? | |
| 11:06:47 | sean-k-mooney | https://review.opendev.org/#/c/718461/4/nova/api/validation/extra_specs/traits.py@65 | |
| 11:07:08 | sean-k-mooney | stephenfin: although i think bauzas was originally not talking about your validation stuff | |
| 11:07:16 | stephenfin | bauzas: replied | |
| 11:07:23 | bauzas | yeah, again my concern is just abotu https://review.opendev.org/#/c/718461/4/nova/tests/unit/api/validation/extra_specs/test_validators.py@33 | |
| 11:07:32 | openstackgerrit | Balazs Gibizer proposed openstack/python-novaclient master: Microversion 2.86 - Extra spec validation https://review.opendev.org/718057 | |
| 11:07:32 | openstackgerrit | Balazs Gibizer proposed openstack/python-novaclient master: Microversion 2.87 - Stable device boot from volume rescue https://review.opendev.org/714956 | |
| 11:07:36 | stephenfin | I think you're mixing up the {group} and {trait} parts of the validator | |
| 11:07:42 | bauzas | oh man | |
| 11:07:48 | bauzas | I'm getting headache | |
| 11:08:31 | sean-k-mooney | bauzas that is the list of namespaces | |
| 11:08:38 | sean-k-mooney | so the partern ther is the group name | |
| 11:08:40 | bauzas | yup, turned up my vote | |
| 11:08:47 | bauzas | anyway, lunch | |
| 11:08:50 | sean-k-mooney | stephenfin: could you use constnts for this | |
| 11:09:05 | sean-k-mooney | so in the test you can just refer to the constnat | |
| 11:09:25 | sean-k-mooney | that might make it clearer? | |
| 11:09:37 | sean-k-mooney | im not going to -1 over that but it might help | |
| 11:09:41 | stephenfin | Not really, because we "build" the regex so I have proper groups | |
| 11:10:04 | stephenfin | Also, I'm always reluctant to use constants in unit tests, because if you've a mistake in the constant then you propagate the mistake | |
| 11:10:49 | sean-k-mooney | ya that is a factor although i have seen many typos in unit test where the typo was not important | |
| 11:11:00 | sean-k-mooney | untill you change something | |
| 11:11:23 | sean-k-mooney | ok im going to go re review the vgpu stuff | |
| 11:12:24 | sean-k-mooney | oh lyarwood changes are on top of yours i was wondering why the validation serires was suddenly much longer | |
| 11:14:48 | lyarwood | yeah microversion fun | |
| 11:15:18 | gibi | bauzas: after your lunch, could you check and upgrade your vote on https://review.opendev.org/#/c/700812 ? | |
| 11:16:31 | sean-k-mooney | lyarwood: its still not as bad as last cycle when we were trying to land numa live migration, pcpus in plamcnet and vpmem all at once | |
| 11:17:02 | sean-k-mooney | they were ligitametly conflciting at the code level too | |
| 11:17:32 | lyarwood | ouch yeah that must have been fun | |
| 11:19:04 | sean-k-mooney | we ended up doing the same ting stacking it all into one big chain | |
| 11:27:51 | openstackgerrit | Balazs Gibizer proposed openstack/python-novaclient master: Microversion 2.86 - Extra spec validation https://review.opendev.org/718057 | |
| 11:27:52 | openstackgerrit | Balazs Gibizer proposed openstack/python-novaclient master: Microversion 2.87 - Stable device boot from volume rescue https://review.opendev.org/714956 | |
| 11:40:21 | openstackgerrit | Merged openstack/nova master: Correct server shelve policy check_str https://review.opendev.org/717542 | |
| 11:46:12 | openstackgerrit | Takashi Natsume proposed openstack/python-novaclient master: Microversion 2.86 - Extra spec validation https://review.opendev.org/718057 | |
| 11:54:49 | openstackgerrit | Takashi Natsume proposed openstack/python-novaclient master: Microversion 2.87 - Stable device boot from volume rescue https://review.opendev.org/714956 | |
| 12:14:55 | openstackgerrit | Alexandre arents proposed openstack/nova master: libvirt: Calculate disk_over_committed for raw instances https://review.opendev.org/717037 | |
| 12:14:57 | bauzas | gibi: back there | |
| 12:15:53 | bauzas | gibi: just upped to +2 https://review.opendev.org/#/c/700812/22 do you want to +W ? | |
| 12:16:04 | gibi | bauzas: no, go ahead with +W | |
| 12:16:12 | gibi | and thanks | |
| 12:38:59 | sean-k-mooney | artom: just noticed you had https://review.opendev.org/#/c/672127/1 for https://bugs.launchpad.net/nova/train/+bug/1836389 | |
| 12:39:00 | openstack | Launchpad bug 1836389 in OpenStack Compute (nova) ussuri "Device role tagging doesn't work for SRIOV PF" [Medium,In progress] - Assigned to Artom Lifshitz (notartom) | |
| 12:39:29 | sean-k-mooney | i just went and triaged the bug but are you actully planning to pick that back up since its been 9 months | |
| 12:40:18 | sean-k-mooney | it would be good to fix it but not sure if you will have time between now and rc1 | |
| 12:51:52 | artom | sean-k-mooney, we had another downstream bug for that downstream, I can try to find the link | |
| 12:52:04 | artom | sean-k-mooney, yeah, I guess I can try and get that in before RC | |
| 12:53:48 | sean-k-mooney | you had the link in the upstream bug | |
| 12:54:25 | artom | sean-k-mooney, ah ok - I wonder why that stalled out | |
| 12:55:08 | sean-k-mooney | you proably got pulled into something else that was on fire | |
| 12:56:38 | sean-k-mooney | from the looks of it the bug was filed by the nfv dfg as they were trying to use the device role tagging for configuring the trex trafic generator | |
| 12:57:22 | sean-k-mooney | i would guess they just worked around it manually | |
| 13:25:28 | stephenfin | bauzas: comments from sean-k-mooney and I on https://review.opendev.org/#/c/715490/ | |
| 13:38:24 | bauzas | stephenfin: sean-k-mooney: yup, sorry, I was off for my kids | |
| 13:40:32 | bauzas | will provide a new patchset | |
| 13:59:48 | openstackgerrit | Kevin Zhao proposed openstack/nova master: Fix ut error on Aarch64(And other non-x86 platform) https://review.opendev.org/713163 | |
| 14:00:53 | lyarwood | hmm did the gate just get reset? | |
| 14:02:56 | lyarwood | actually nvm I don't think it did | |
| 14:03:14 | gmann | gibi ping | |
| 14:14:04 | bauzas | stephenfin: gibi: sean-k-mooney: new patch for https://review.opendev.org/#/c/715490/ is on its way | |
| 14:15:48 | sean-k-mooney | cool ill review it when its ready | |
| 14:17:21 | bauzas | just running tests locally | |
| 14:17:34 | bauzas | sean-k-mooney: you left a -1 but I didn't understand exacly why | |
| 14:20:05 | gibi | gmann: ping | |
| 14:20:27 | sean-k-mooney | it was for the fact we skiped creating the mdev if the could not instead of failing to start the agent | |
| 14:21:32 | gmann | gibi: i will be requesting the FFE for policy things as few are still need to be merged and I am thinking to do for deprecated APIs also | |
| 14:21:37 | sean-k-mooney | bauzas: so this comment https://review.opendev.org/#/c/715490/10/nova/virt/libvirt/driver.py@814 | |
| 14:21:47 | stephenfin | same comment for me | |
| 14:22:11 | gmann | gibi: I will request on ML. my question is for cycle highlights - https://review.opendev.org/#/c/712498/2/deliverables/ussuri/nova.yaml@25 | |
| 14:23:00 | bauzas | sean-k-mooney: okay, fixed by the rev I'm testing | |
| 14:23:22 | bauzas | need to adapt a few more tests than planned, but fair enough | |
| 14:23:25 | gmann | should we include policy things in highlights because amending later might not be acceptable (or at least might get missed by various other forum ) | |
| 14:23:28 | bauzas | won't be a FUP | |
| 14:24:12 | gibi | gmann: hm, let's try to grant FFE for policy bp on the today's meeting and if nobody is against that then I can add info about it to the cyclehighlight | |
| 14:24:20 | gibi | gmann: but I would need some doc I can link to | |
| 14:26:07 | gmann | gibi: ok. then let me work on doc part and release notes first. thanks. | |
| 14:26:16 | gibi | gmann: thanks | |
| 14:26:44 | gmann | gibi: you want me to send FFE on ML and then discuss in meeting or directly in meeting ? | |
| 14:27:18 | gibi | gmann: let's have a mail about the FFE but it is OK to send the mail after the meeting | |
| 14:27:39 | gmann | i see. let's wait for meeting. | |
| 14:27:41 | gibi | my point is to let's discuss that today | |
| 14:27:50 | gmann | sure | |
| 14:28:04 | openstackgerrit | Sylvain Bauza proposed openstack/nova master: Support different vGPU types per pGPU https://review.opendev.org/715490 | |
| 14:28:05 | openstackgerrit | Sylvain Bauza proposed openstack/nova master: Functional test with pGPUs https://review.opendev.org/717975 | |
| 14:30:28 | bauzas | gibi: stephenfin: sean-k-mooney: last revision, based on your feedback, hardstopping if two types are provided but only one is having PCI devices | |
| 14:31:01 | gibi | bauzas: ack, will look shortly | |
| 14:31:10 | bauzas | how can I help now ? | |
| 14:31:28 | bauzas | gibi: my time is free, so maybe time for you to handover some reviews if you want | |
| 14:32:55 | gibi | bauzas: are you familiar with gmann's policy changes? he just pinged me about an FFE request, so we could speed that series up with some review | |
| 14:33:06 | sean-k-mooney | bauzas: we get a company day in ireland for good friday and then monday is a public holiday | |
| 14:33:20 | sean-k-mooney | bauzas: so stephenfin and i wont be around until tuesday | |
| 14:33:42 | bauzas | gibi: I was knowing a bit, but I can look | |
| 14:33:56 | gibi | bauzas: cool, that would help | |
| 14:34:02 | bauzas | sean-k-mooney: yup, I know, also UK, Germany, Hungary and other EU countries AFAICU | |
| 14:34:09 | gibi | yepp, me too ^^ | |
| 14:34:30 | bauzas | some US states aren't working too | |