Earlier  
Later
New Search
Posted Nick Remark
#openstack-nova - 2020-03-25
11:40:35 openstackgerrit Merged openstack/nova stable/pike: Remove exp legacy-tempest-dsvm-full-devstack-plugin-nfs https://review.opendev.org/702061
11:41:07 lyarwood well well well
11:41:17 lyarwood looks like we got some faster CI nodes on that run
11:55:04 luyao lyarwood: Hi, thanks for your quick comments on 'do_cleanup' flag bug-fix https://review.opendev.org/#/c/714593
12:00:19 lyarwood luyao: np, I agree this needs cleaning up, I just don't think setting do_cleanup to True is the correct way of doing it for now.
12:01:42 openstackgerrit Balazs Gibizer proposed openstack/nova master: [Community goal] Update contributor documentation https://review.opendev.org/712420
12:02:14 luyao lyarwood: it's what I want to ask, I'm confusing about that, do you mean I need another cleanup method to do the cleanup? not invoking driver.cleanup directly or rollback_live_migration_at_destination
12:04:11 lyarwood luyao: yes, I think something like live_migration_cleanup_source and live_migration_cleanup_destination would be better instead of overloading cleanup itself
12:05:24 lyarwood elod: fun, we can't limit the regex used by the tempest-full jobs as they are using this tox env to run the commands - https://github.com/openstack/tempest/blob/51fe1ae61bed5d62c18864748520db25144f6db9/tox.ini#L103-L116
12:05:51 luyao lyarwood: thingking.....what's the difference between the new cleanup methed and the existing one
12:07:10 lyarwood luyao: the existing one duplicates lots of cleanup already handled during the live migration flow
12:07:22 lyarwood luyao: we already unplug VIFs, disconnect volumes etc on success
12:07:29 lyarwood luyao: and depending on the failure we also do it there
12:08:07 lyarwood luyao: IMHO we should break up the cleanup method into smaller private methods that handle each aspect of this and use them only when required during the LM flows
12:09:24 elod lyarwood: :-/ anyway, at least a couple of patch got merged. so maybe recheck is enough for now as we don't have that many pike patches...
12:10:51 lyarwood I'll post a change removing it so if it does end up blocking things we can still remove it
12:11:19 openstackgerrit Lee Yarwood proposed openstack/nova stable/pike: zuul: Remove tempest-full from the gate due to bug #1796708 https://review.opendev.org/714915
12:11:20 openstack bug 1796708 in Cinder "VolumesExtendTest.test_volume_extend_when_volume_has_snapshot intermittently fails with "Extend volume failed.: VolumeNotDeactivated: Volume volume-5514a6ad-abbb-46b3-a464-d73cc67e55af was not deactivated in time."" [Medium,Confirmed] https://launchpad.net/bugs/1796708
12:11:20 elod lyarwood: sounds like a plan :)
12:13:39 openstackgerrit Marcin Juszkiewicz proposed openstack/nova master: fix typo in wrong cpu_model message https://review.opendev.org/714928
12:16:10 luyao lyarwood: OK, got it, I'll look into the code and reply you in more detail on that patch, thanks :)
12:20:36 hrw morning
12:38:55 openstackgerrit Merged openstack/nova stable/train: nova-live-migration: Ensure subnode is fenced during evacuation testing https://review.opendev.org/713961
12:40:06 openstackgerrit Lee Yarwood proposed openstack/nova master: libvirt: Use virDomainBlockCopy to swap volumes when using -blockdev https://review.opendev.org/696834
12:40:43 lyarwood ^ gibi / kashyap / stephenfin ; rebased with a bug created and referenced for tracking if you have time to review.
12:41:14 kashyap lyarwood: Will look. Trying to investigate a different bug I was thrown at elsewhere
12:58:32 hrw kevinz: thanks for https://review.opendev.org/#/c/709494 - finally booted VM in qemu TCG
12:59:30 kevinz hrw: np, good to hear that :-D
13:00:08 hrw kevinz: I wonder how many aarch64 changes done in nova should be redone in libvirt ;d
13:00:23 hrw but then still would stay due to desync between projects
13:02:58 kevinz hrw: hope not so many, we just tweak tweak and tweak
13:04:02 hrw kevinz: -M virt as default feels like something for libvirt ;D
13:04:18 hrw no, it is default there. it's qemu where it is not
13:04:54 sean-k-mooney do we still have the cpu feature flag check disabled for aarch64
13:05:03 kevinz yes, there are some methods in libvirt regarding with CPU are not implemented on aarch64
13:05:37 sean-k-mooney so its not safe to use max as the default model if we want to support livemigration
13:05:51 hrw sean-k-mooney: anything around cpu features/model/passthrough on aarch64 is like walking on minefield
13:05:56 sean-k-mooney well in an upgrade case at least
13:06:02 kevinz sean-k-mooney: yes, I know that Kevin Zheng from Huawei is working on libvirt side to make that happen
13:06:10 sean-k-mooney hrw: well we have the info in /sys
13:06:13 brinzhang_ sean-k-mooney: did you look at https://review.opendev.org/#/c/694430/ and https://review.opendev.org/#/c/699669/3, gmann want you can check that ^^
13:06:19 sean-k-mooney libvirt is just not reading it
13:06:40 sean-k-mooney brinzhang_: no but ill look now
13:06:48 kevinz so hopefully live migration will works well on arm64 soon
13:06:54 hrw sean-k-mooney: can you remind me /sys path?
13:07:17 brinzhang_ sean-k-mooney: yeah, thanks. I think we need the new policy
13:07:21 sean-k-mooney hrw: actully its in /proc/cpuinfo
13:07:47 sean-k-mooney hrw: the "flags" filed is "Flags" on aarch64
13:07:56 sean-k-mooney which prevents libvirt reading it
13:08:11 sean-k-mooney the model is also available
13:08:11 hrw /proc/cpuinfo... file which should just die
13:08:24 sean-k-mooney hrw it really should not
13:08:39 sean-k-mooney hrw: its the standard interface to report this info
13:08:51 hrw it is far from standard
13:08:55 hrw each arch has own way
13:09:07 sean-k-mooney yes but at least its a common location
13:09:39 sean-k-mooney otherwise you have to use more arcane cpuid checks and model specific registers
13:10:21 hrw yep
13:17:43 kashyap gibi: Yeah, the bitwise OR and logical OR of flags is always a bit confusing for me too; they look reasonable, see my comment: https://review.opendev.org/#/c/696834/12/nova/virt/libvirt/guest.py@773
13:43:51 gibi kashyap, lyarwood: thanks. I'm +2
13:44:59 lyarwood gibi: many thanks!
13:48:17 dansmith brinzhang_: I did, but I didn't understand what any of that had to do with why we need to use patch
14:23:39 openstackgerrit Maciej Kucia proposed openstack/nova master: SR-IOV passthrough: Check PF only if VF is enabled https://review.opendev.org/476642
14:25:03 openstackgerrit Merged openstack/nova master: ksa auth conf and client for Cyborg access https://review.opendev.org/631242
14:29:20 openstackgerrit Lee Yarwood proposed openstack/python-novaclient master: Microversion 2.83 - Stable device boot from volume rescue https://review.opendev.org/714956
14:29:53 openstackgerrit Lee Yarwood proposed openstack/nova master: virt: Provide block_device_info during rescue https://review.opendev.org/700811
14:29:54 openstackgerrit Lee Yarwood proposed openstack/nova master: libvirt: Add support for stable device rescue https://review.opendev.org/700812
14:29:54 openstackgerrit Lee Yarwood proposed openstack/nova master: compute: Report COMPUTE_RESCUE_BFV and check during rescue https://review.opendev.org/701429
14:29:55 openstackgerrit Lee Yarwood proposed openstack/nova master: compute: Extract _get_bdm_image_metadata into nova.utils https://review.opendev.org/705212
14:29:55 openstackgerrit Lee Yarwood proposed openstack/nova master: libvirt: Support boot from volume stable device instance rescue https://review.opendev.org/701431
14:29:56 openstackgerrit Lee Yarwood proposed openstack/nova master: api: Introduce microverion 2.83 allowing boot from volume rescue https://review.opendev.org/701430
14:29:56 openstackgerrit Lee Yarwood proposed openstack/nova master: DNM - Test stable device rescue tests with BFV instances https://review.opendev.org/710050
14:33:08 huaqiang hello. I see many '_from_dict' method in some NobaObject based classes, but not all classes,
14:33:23 huaqiang should I make it work for new field?
14:34:33 openstackgerrit Luigi Toscano proposed openstack/nova stable/ocata: Remove exp legacy-tempest-dsvm-full-devstack-plugin-nfs https://review.opendev.org/714958
14:36:25 nightmare_unreal hey, how can one overwrite allocation for instance
14:38:53 huaqiang nightmare_unreal: cool name :D
14:39:36 nightmare_unreal huaqiang: thanks :D , it's just a nick I registered when I was more into gaming haha
14:42:25 mriedem nightmare_unreal: why do you want/need to?
14:42:45 nightmare_unreal working on this : https://bugs.launchpad.net/nova/+bug/1868997
14:42:47 openstack Launchpad bug 1868997 in OpenStack Compute (nova) "option to overwrite allocations for instances" [Undecided,New] - Assigned to jayaditya gupta (jayssj11)
14:43:32 mriedem is that referring to the heal_allocations CLI? https://docs.openstack.org/nova/latest/cli/nova-manage.html#placement
14:43:51 mriedem we don't really need to track todos in the code with bug reports...so i'm not sure why someone opened that bug
14:43:59 mriedem or is that someone you? :)
14:45:26 nightmare_unreal yes that's me :)
14:46:02 mriedem ok https://github.com/openstack/nova/blob/master/nova/cmd/manage.py#L216 doesn't refer to a todo
14:46:19 mriedem oh wrong line, 2126
14:46:37 mriedem https://github.com/openstack/nova/blob/master/nova/cmd/manage.py#L2126
14:46:54 nightmare_unreal yup that one
14:47:35 nightmare_unreal I also did the --cell one : https://review.opendev.org/#/c/714459/
14:47:39 nightmare_unreal but it needs review
14:47:57 mriedem are you on belmiro's team at cern?
14:48:29 nightmare_unreal yup
14:48:38 nightmare_unreal new joinee
14:49:00 gibi nightmare_unreal: I will get back to https://review.opendev.org/#/c/714459/ hopefully tomorrow
14:49:09 nightmare_unreal thanks gibi
14:49:10 mriedem cool. welcome. i can leave some quick comments on ^
14:49:24 nightmare_unreal sure
14:50:15 gibi mriedem: thanks!
14:51:01 gibi mriedem: do you miss reviewing nova code ? :)

Earlier   Later