| Posted | Nick | Remark | |
|---|---|---|---|
| #openstack-nova - 2020-03-25 | |||
| 12:20:36 | hrw | morning | |
| 12:38:55 | openstackgerrit | Merged openstack/nova stable/train: nova-live-migration: Ensure subnode is fenced during evacuation testing https://review.opendev.org/713961 | |
| 12:40:06 | openstackgerrit | Lee Yarwood proposed openstack/nova master: libvirt: Use virDomainBlockCopy to swap volumes when using -blockdev https://review.opendev.org/696834 | |
| 12:40:43 | lyarwood | ^ gibi / kashyap / stephenfin ; rebased with a bug created and referenced for tracking if you have time to review. | |
| 12:41:14 | kashyap | lyarwood: Will look. Trying to investigate a different bug I was thrown at elsewhere | |
| 12:58:32 | hrw | kevinz: thanks for https://review.opendev.org/#/c/709494 - finally booted VM in qemu TCG | |
| 12:59:30 | kevinz | hrw: np, good to hear that :-D | |
| 13:00:08 | hrw | kevinz: I wonder how many aarch64 changes done in nova should be redone in libvirt ;d | |
| 13:00:23 | hrw | but then still would stay due to desync between projects | |
| 13:02:58 | kevinz | hrw: hope not so many, we just tweak tweak and tweak | |
| 13:04:02 | hrw | kevinz: -M virt as default feels like something for libvirt ;D | |
| 13:04:18 | hrw | no, it is default there. it's qemu where it is not | |
| 13:04:54 | sean-k-mooney | do we still have the cpu feature flag check disabled for aarch64 | |
| 13:05:03 | kevinz | yes, there are some methods in libvirt regarding with CPU are not implemented on aarch64 | |
| 13:05:37 | sean-k-mooney | so its not safe to use max as the default model if we want to support livemigration | |
| 13:05:51 | hrw | sean-k-mooney: anything around cpu features/model/passthrough on aarch64 is like walking on minefield | |
| 13:05:56 | sean-k-mooney | well in an upgrade case at least | |
| 13:06:02 | kevinz | sean-k-mooney: yes, I know that Kevin Zheng from Huawei is working on libvirt side to make that happen | |
| 13:06:10 | sean-k-mooney | hrw: well we have the info in /sys | |
| 13:06:13 | brinzhang_ | sean-k-mooney: did you look at https://review.opendev.org/#/c/694430/ and https://review.opendev.org/#/c/699669/3, gmann want you can check that ^^ | |
| 13:06:19 | sean-k-mooney | libvirt is just not reading it | |
| 13:06:40 | sean-k-mooney | brinzhang_: no but ill look now | |
| 13:06:48 | kevinz | so hopefully live migration will works well on arm64 soon | |
| 13:06:54 | hrw | sean-k-mooney: can you remind me /sys path? | |
| 13:07:17 | brinzhang_ | sean-k-mooney: yeah, thanks. I think we need the new policy | |
| 13:07:21 | sean-k-mooney | hrw: actully its in /proc/cpuinfo | |
| 13:07:47 | sean-k-mooney | hrw: the "flags" filed is "Flags" on aarch64 | |
| 13:07:56 | sean-k-mooney | which prevents libvirt reading it | |
| 13:08:11 | sean-k-mooney | the model is also available | |
| 13:08:11 | hrw | /proc/cpuinfo... file which should just die | |
| 13:08:24 | sean-k-mooney | hrw it really should not | |
| 13:08:39 | sean-k-mooney | hrw: its the standard interface to report this info | |
| 13:08:51 | hrw | it is far from standard | |
| 13:08:55 | hrw | each arch has own way | |
| 13:09:07 | sean-k-mooney | yes but at least its a common location | |
| 13:09:39 | sean-k-mooney | otherwise you have to use more arcane cpuid checks and model specific registers | |
| 13:10:21 | hrw | yep | |
| 13:17:43 | kashyap | gibi: Yeah, the bitwise OR and logical OR of flags is always a bit confusing for me too; they look reasonable, see my comment: https://review.opendev.org/#/c/696834/12/nova/virt/libvirt/guest.py@773 | |
| 13:43:51 | gibi | kashyap, lyarwood: thanks. I'm +2 | |
| 13:44:59 | lyarwood | gibi: many thanks! | |
| 13:48:17 | dansmith | brinzhang_: I did, but I didn't understand what any of that had to do with why we need to use patch | |
| 14:23:39 | openstackgerrit | Maciej Kucia proposed openstack/nova master: SR-IOV passthrough: Check PF only if VF is enabled https://review.opendev.org/476642 | |
| 14:25:03 | openstackgerrit | Merged openstack/nova master: ksa auth conf and client for Cyborg access https://review.opendev.org/631242 | |
| 14:29:20 | openstackgerrit | Lee Yarwood proposed openstack/python-novaclient master: Microversion 2.83 - Stable device boot from volume rescue https://review.opendev.org/714956 | |
| 14:29:53 | openstackgerrit | Lee Yarwood proposed openstack/nova master: virt: Provide block_device_info during rescue https://review.opendev.org/700811 | |
| 14:29:54 | openstackgerrit | Lee Yarwood proposed openstack/nova master: libvirt: Add support for stable device rescue https://review.opendev.org/700812 | |
| 14:29:54 | openstackgerrit | Lee Yarwood proposed openstack/nova master: compute: Report COMPUTE_RESCUE_BFV and check during rescue https://review.opendev.org/701429 | |
| 14:29:55 | openstackgerrit | Lee Yarwood proposed openstack/nova master: compute: Extract _get_bdm_image_metadata into nova.utils https://review.opendev.org/705212 | |
| 14:29:55 | openstackgerrit | Lee Yarwood proposed openstack/nova master: libvirt: Support boot from volume stable device instance rescue https://review.opendev.org/701431 | |
| 14:29:56 | openstackgerrit | Lee Yarwood proposed openstack/nova master: api: Introduce microverion 2.83 allowing boot from volume rescue https://review.opendev.org/701430 | |
| 14:29:56 | openstackgerrit | Lee Yarwood proposed openstack/nova master: DNM - Test stable device rescue tests with BFV instances https://review.opendev.org/710050 | |
| 14:33:08 | huaqiang | hello. I see many '_from_dict' method in some NobaObject based classes, but not all classes, | |
| 14:33:23 | huaqiang | should I make it work for new field? | |
| 14:34:33 | openstackgerrit | Luigi Toscano proposed openstack/nova stable/ocata: Remove exp legacy-tempest-dsvm-full-devstack-plugin-nfs https://review.opendev.org/714958 | |
| 14:36:25 | nightmare_unreal | hey, how can one overwrite allocation for instance | |
| 14:38:53 | huaqiang | nightmare_unreal: cool name :D | |
| 14:39:36 | nightmare_unreal | huaqiang: thanks :D , it's just a nick I registered when I was more into gaming haha | |
| 14:42:25 | mriedem | nightmare_unreal: why do you want/need to? | |
| 14:42:45 | nightmare_unreal | working on this : https://bugs.launchpad.net/nova/+bug/1868997 | |
| 14:42:47 | openstack | Launchpad bug 1868997 in OpenStack Compute (nova) "option to overwrite allocations for instances" [Undecided,New] - Assigned to jayaditya gupta (jayssj11) | |
| 14:43:32 | mriedem | is that referring to the heal_allocations CLI? https://docs.openstack.org/nova/latest/cli/nova-manage.html#placement | |
| 14:43:51 | mriedem | we don't really need to track todos in the code with bug reports...so i'm not sure why someone opened that bug | |
| 14:43:59 | mriedem | or is that someone you? :) | |
| 14:45:26 | nightmare_unreal | yes that's me :) | |
| 14:46:02 | mriedem | ok https://github.com/openstack/nova/blob/master/nova/cmd/manage.py#L216 doesn't refer to a todo | |
| 14:46:19 | mriedem | oh wrong line, 2126 | |
| 14:46:37 | mriedem | https://github.com/openstack/nova/blob/master/nova/cmd/manage.py#L2126 | |
| 14:46:54 | nightmare_unreal | yup that one | |
| 14:47:35 | nightmare_unreal | I also did the --cell one : https://review.opendev.org/#/c/714459/ | |
| 14:47:39 | nightmare_unreal | but it needs review | |
| 14:47:57 | mriedem | are you on belmiro's team at cern? | |
| 14:48:29 | nightmare_unreal | yup | |
| 14:48:38 | nightmare_unreal | new joinee | |
| 14:49:00 | gibi | nightmare_unreal: I will get back to https://review.opendev.org/#/c/714459/ hopefully tomorrow | |
| 14:49:09 | nightmare_unreal | thanks gibi | |
| 14:49:10 | mriedem | cool. welcome. i can leave some quick comments on ^ | |
| 14:49:24 | nightmare_unreal | sure | |
| 14:50:15 | gibi | mriedem: thanks! | |
| 14:51:01 | gibi | mriedem: do you miss reviewing nova code ? :) | |
| 14:54:41 | openstackgerrit | Lee Yarwood proposed openstack/nova master: WIP libvirt: Break up get_disk_mapping within blockinfo https://review.opendev.org/714962 | |
| 14:57:21 | mriedem | gibi: heal_allocations started as my baby so i'm partial | |
| 15:00:05 | gibi | :) | |
| 15:00:43 | mriedem | nightmare_unreal: ok comments inline | |
| 15:00:56 | nightmare_unreal | thanks :) | |
| 15:01:03 | mriedem | gibi: it's also nice to review something outside of github too | |
| 15:01:58 | brinzhang | sean-k-mooney: gmann: If we re-using the os-isntance-actions: events policy, we want to expose noValidHost and other information to the non-admin, which cannot be changed by modifying the policy, is it? | |
| 15:02:25 | mriedem | nightmare_unreal: as to your original question, this put_allocations method is the one that overwrites the allocations for an instance https://github.com/openstack/nova/blob/master/nova/cmd/manage.py#L1948 | |
| 15:02:27 | brinzhang | we dont want to expose the traceback to the non-admin user | |
| 15:02:28 | gibi | mriedem: I don't have too much experience with github but I imagine gerrit is a nicser interface | |
| 15:02:33 | gibi | nicer | |
| 15:02:43 | mriedem | gibi: just...different | |
| 15:03:02 | mriedem | unified diff in github reviews isn't terrible | |
| 15:03:12 | nightmare_unreal | new to gerrit though | |
| 15:03:31 | nightmare_unreal | thanks mriedem , I will work on it and submit again. | |
| 15:03:54 | mriedem | err i should say split diff i guess to be like how i used gerrit | |
| 15:05:05 | mriedem | nightmare_unreal: so the way heal_allocations works is we determine if an instance needs healing and the conditional for that is here https://github.com/openstack/nova/blob/master/nova/cmd/manage.py#L1922 | |
| 15:05:08 | gmann | brinzhang: os-isntance-actions: events policy is admin by default | |
| 15:05:21 | mriedem | bypassing that is essentially a --force option or something like that | |
| 15:05:22 | sean-k-mooney | i prefer gerrit for revew also. im not really a fan of the pull request workflow but its still beter then doing things by email | |
| 15:05:27 | gmann | so it would not expose those info to non-admin. until override to do so | |