Earlier  
Later
New Search
Posted Nick Remark
#openstack-nova - 2020-03-16
21:39:46 mriedem in the bug i linked in logs where the things were happening so it's not really a question of where the race is
21:39:57 mriedem though those log links are going to be dead by now
21:40:11 mriedem unshelve has the same issue
21:40:39 mriedem 1. bind to new host triggers async network-vif-plugged event, 2. driver.spawn plugs vifs which sets up the callback handler
21:40:47 mriedem if you get the event before 2 you're stuck
21:40:55 melwitt right, ok
21:41:42 sean-k-mooney mriedem: in the unsevle case you could argue that when we go to shevle offloaded teh status of the port shoudl be down
21:42:08 sean-k-mooney which woudl prevent the event being sent in the ovs case atleast until its plugged in the driver
21:42:13 mriedem yup, i opened an old bug for that as well
21:42:32 sean-k-mooney but we would need to sitll use the bind_time vs plugtime thing to check
21:43:13 sean-k-mooney is the state of the port something we can contol from nova?
21:43:26 sean-k-mooney or rather are we allowed to set it
21:43:38 sean-k-mooney if so we could set it to down when we do an evaucate
21:44:34 melwitt well, I'll try looking at it, see how it goes
21:47:28 mriedem this is the thing i was thinking about for a shelve related bug https://github.com/openstack/nova/blob/stable/stein/nova/network/neutronv2/api.py#L3332
21:47:55 mriedem looks like i updated that as part of the cross-cell series https://github.com/openstack/nova/blob/master/nova/network/neutron.py#L3339
21:48:43 mriedem https://review.opendev.org/#/c/697162/
21:48:46 mriedem it's all coming back to me
21:48:53 sean-k-mooney so in that function we would jsut set the binding host to None
21:49:00 sean-k-mooney which would unbind it
21:49:18 sean-k-mooney and the status should go to down as a result
21:50:19 mriedem yeah like how _unbind_ports works
21:50:38 mriedem except you can't clear the device_owner on the port when shelve offloading
21:50:45 mriedem the nova instance needs to continue to "own" the port
21:51:09 sean-k-mooney we need to keep device_id which is the nova instance uuid too but ya
21:51:43 mriedem let us *shelve* this discussion for 6 months from now when it comes up again :)
21:51:56 sean-k-mooney :)
21:51:57 mriedem o/
21:57:20 sean-k-mooney melwitt: so calling self.network_api.cleanup_instance_network_on_host on the source node durign an evacuate might allow us to use the bind vs plug time evnet code to determin when to wait in the evacuate case too
21:57:50 sean-k-mooney melwitt: it is currently only called for cross cell resize
21:58:37 sean-k-mooney but ya we should be doing that definetly during shelve offload to fix the shelve case
22:01:43 melwitt sean-k-mooney: so does that mean that you think evacuate is pretty "easy" but shelve will be more difficult? or are they a similar level of complexity
22:02:50 sean-k-mooney shelve shoudl be easy evaucate might be more difficutly but i think we just need to call cleanup_instance_network_on_host in the right place
22:03:03 sean-k-mooney so in shevel case we shoudl be calling it in shelve offload
22:03:24 sean-k-mooney and in evauate we need to do it before we call spawn on the dest host
22:03:31 sean-k-mooney so pretty early on
22:04:00 sean-k-mooney that will put the port into an unbound state which will set the port status to down
22:04:24 melwitt ok. just saying it sounds like the utilities are available, just have to leverage them
22:04:43 melwitt with the model bind_time stuff
22:04:47 sean-k-mooney they were not in place until recently
22:05:12 melwitt I'm not saying they were, just trying to understand what's the landscape today
22:05:26 sean-k-mooney yep
22:05:45 sean-k-mooney i think they were both added last cycle so they are there form train on
22:06:05 sean-k-mooney they should be backportable too i think
22:08:17 melwitt ok
22:31:26 openstackgerrit Merged openstack/nova stable/train: Unplug VIFs as part of cleanup of networks https://review.opendev.org/711251
22:38:03 openstackgerrit sean mooney proposed openstack/nova master: [WIP] unbind port before evacuate and shelve offload https://review.opendev.org/713342
22:39:20 sean-k-mooney melwitt: im not sure if ^ will work but i think it would be something like that, at least as a start
22:39:48 melwitt cool thanks sean-k-mooney
#openstack-nova - 2020-03-17
00:55:27 openstackgerrit Huaqiang Wang proposed openstack/nova master: metadata: export the vCPU IDs that are pinning on the host CPUs https://review.opendev.org/688936
00:55:28 openstackgerrit Huaqiang Wang proposed openstack/nova master: Refine and introduce correct parameters for test_get_guest_config_numa_host_instance_topo_cpu_pinning https://review.opendev.org/713351
00:55:28 openstackgerrit Huaqiang Wang proposed openstack/nova master: scheduler: Introduce 'dedicated' and 'sharing' CPUs for InstanceNUMACell https://review.opendev.org/713352
00:55:29 openstackgerrit Huaqiang Wang proposed openstack/nova master: Derive 'cpu_pinning_requested' property from cpu_policy https://review.opendev.org/713353
00:55:29 openstackgerrit Huaqiang Wang proposed openstack/nova master: Introduce 'MIXED' CPU allocation policy for instance https://review.opendev.org/713354
00:55:30 openstackgerrit Huaqiang Wang proposed openstack/nova master: Introduce the interface of creating 'MIXED' policy instance through 'PCPU' and 'VCPU' https://review.opendev.org/713355
01:23:08 openstackgerrit melanie witt proposed openstack/nova master: DNM: try to get some debug info for bug 1844929 https://review.opendev.org/701478
01:23:08 openstack bug 1844929 in OpenStack Compute (nova) "grenade jobs failing due to "Timed out waiting for response from cell" in scheduler" [High,Confirmed] https://launchpad.net/bugs/1844929
01:27:53 openstackgerrit melanie witt proposed openstack/nova master: DNM: try to get some debug info for bug 1844929 https://review.opendev.org/701478
01:27:53 openstack bug 1844929 in OpenStack Compute (nova) "grenade jobs failing due to "Timed out waiting for response from cell" in scheduler" [High,Confirmed] https://launchpad.net/bugs/1844929
02:25:35 openstackgerrit Merged openstack/nova master: Use fair locks in resource tracker https://review.opendev.org/711528
02:25:41 openstackgerrit Merged openstack/nova master: Ensures that COMPUTE_RESOURCE_SEMAPHORE usage is fair https://review.opendev.org/712674
02:57:40 openstackgerrit Kevin Zhao proposed openstack/nova master: Add default cpu model for aarch64 https://review.opendev.org/709494
04:20:24 openstackgerrit Abhishek Kekane proposed openstack/nova master: DNM: Add reproducer for subunit parser error https://review.opendev.org/700522
05:50:36 openstackgerrit Kevin Zhao proposed openstack/nova master: Add default cpu model for aarch64 https://review.opendev.org/709494
07:47:58 openstackgerrit Kevin Zhao proposed openstack/nova master: fix scsi disk unit number of the attaching volume when cdrom bus is scsi https://review.opendev.org/712607
08:45:58 lyarwood elod: https://review.opendev.org/#/c/713035/ - btw is finally stable, once on master I'll backport to stable/pike to hopefully resolve the issues with the LM job we've been seeing there.
08:46:30 lyarwood ^ any non-RH core reviews would be appreicated btw so we can fix a few of the stable branches
08:46:46 lyarwood doesn't appear to fail often on master but I'm assuming we get better test nodes somehow?
08:46:57 lyarwood s/better/faster/g
08:54:13 elod lyarwood: thanks! looking!
08:54:31 elod gibi: can you also review that? ^^^
08:58:49 lyarwood thanks both!
09:02:50 gibi lyarwood: thanks for working on that
09:11:03 openstackgerrit Balazs Gibizer proposed openstack/nova stable/train: Fix intermittently failing regression case https://review.opendev.org/713384
09:20:38 openstackgerrit Brin Zhang proposed openstack/nova master: Add new default roles in os-instance-actions policies https://review.opendev.org/706470
09:20:39 openstackgerrit Brin Zhang proposed openstack/nova master: Make serialize_args handle exception messages safely https://review.opendev.org/712697
09:20:39 openstackgerrit Brin Zhang proposed openstack/nova master: Store instance action event exc_val fault details https://review.opendev.org/694428
09:20:40 openstackgerrit Brin Zhang proposed openstack/nova master: Expose instance action event details out of the API https://review.opendev.org/694430
09:20:40 openstackgerrit Brin Zhang proposed openstack/nova master: Add instance actions v283 samples test https://review.opendev.org/706251
09:21:54 gibi elod, lyarwood: stable backport of a fix for a recent bugfix regression test https://review.opendev.org/#/c/713384/
09:22:15 gibi needs to properly unblock (other than recheck) https://review.opendev.org/#/c/713196/
09:38:29 brinzhang_ gibi: Hi, the bp/action-event-fault-details is ready to review https://review.opendev.org/#/q/status:open+project:openstack/nova+branch:master+topic:bp/action-event-fault-details
09:44:29 gibi brinzhang_: ack, I will try
09:44:32 gibi to look at ti
09:44:33 gibi it
09:44:44 brinzhang_ gibi: cool, thanks
09:45:40 brinzhang_ gibi: and about the bp/destroy-instance-with-datavolume feature, I hope you can add your list too, it's ready to review too. https://review.opendev.org/#/q/status:open+project:openstack/nova+branch:master+topic:bp/destroy-instance-with-datavolume
09:45:42 openstackgerrit Luyao Zhong proposed openstack/nova master: address specific resources cleanup issue https://review.opendev.org/713388
09:47:01 openstackgerrit Luyao Zhong proposed openstack/nova master: bug-fix: Reject live migration with vpmem https://review.opendev.org/708110
09:47:01 openstackgerrit Luyao Zhong proposed openstack/nova master: support live migration with vpmems https://review.opendev.org/687856
09:47:02 openstackgerrit Luyao Zhong proposed openstack/nova master: Track orphan instances and error migrations in resource tracker https://review.opendev.org/678451
09:48:34 gibi brinzhang_: I can add but it will take time to get there
09:48:51 openstackgerrit Elod Illes proposed openstack/nova stable/train: Fix intermittently failing regression case https://review.opendev.org/713384
09:49:34 brinzhang_ gibi: yeah, I know, and it's ready too long, while you are free pls review :)
09:50:24 gibi brinzhang_: could you try to ping others too? :)
09:50:35 brinzhang_ and I will also ask stephenfin, sean-k-mooney, alex_xu, melwitt, lyarwood too.
09:53:17 brinzhang_ gibi: I dont know who can help me to review? I am not sure whether troulbes them :)
09:54:59 lyarwood gibi: ack sorry I'll check that shortly
09:55:09 lyarwood brinzhang_: ack working my way towards it :)
09:55:16 lyarwood downstream--

Earlier   Later