| Posted | Nick | Remark | |
|---|---|---|---|
| #openstack-nova - 2020-03-17 | |||
| 09:48:51 | openstackgerrit | Elod Illes proposed openstack/nova stable/train: Fix intermittently failing regression case https://review.opendev.org/713384 | |
| 09:49:34 | brinzhang_ | gibi: yeah, I know, and it's ready too long, while you are free pls review :) | |
| 09:50:24 | gibi | brinzhang_: could you try to ping others too? :) | |
| 09:50:35 | brinzhang_ | and I will also ask stephenfin, sean-k-mooney, alex_xu, melwitt, lyarwood too. | |
| 09:53:17 | brinzhang_ | gibi: I dont know who can help me to review? I am not sure whether troulbes them :) | |
| 09:54:59 | lyarwood | gibi: ack sorry I'll check that shortly | |
| 09:55:09 | lyarwood | brinzhang_: ack working my way towards it :) | |
| 09:55:16 | lyarwood | downstream-- | |
| 09:55:46 | brinzhang_ | lyarwood: thanks | |
| 09:56:25 | brinzhang_ | bp/destroy-instance-with-datavolume https://review.opendev.org/#/q/status:open+project:openstack/nova+branch:master+topic:bp/destroy-instance-with-datavolume | |
| 09:56:38 | brinzhang_ | bp/action-event-fault-details https://review.opendev.org/#/q/status:open+project:openstack/nova+branch:master+topic:bp/action-event-fault-details | |
| 10:47:40 | openstackgerrit | Lee Yarwood proposed openstack/nova master: libvirt: Use virDomainBlockCopy to swap volumes when using -blockdev https://review.opendev.org/696834 | |
| 10:55:53 | openstackgerrit | mashuting proposed openstack/nova master: Revert "Deprecate the vmwareapi driver" https://review.opendev.org/713401 | |
| 11:01:31 | kashyap | lyarwood: Hi, what do you mean "Done" for the comment on line-1811? -- https://review.opendev.org/#/c/696834/8..9/nova/virt/libvirt/driver.py | |
| 11:02:12 | lyarwood | kashyap: gah sorry miss click | |
| 11:02:45 | kashyap | NP. | |
| 11:03:21 | lyarwood | kashyap: there's no concept of a destination host in swap_volume, everything is confined to a single host. | |
| 11:03:58 | lyarwood | kashyap: is that what you're referring to? | |
| 11:04:31 | kashyap | lyarwood: Yeah, would be good to add a note of it, if you have a reason to respin | |
| 11:05:04 | lyarwood | kashyap: for what? | |
| 11:05:39 | lyarwood | kashyap: there comment is pretty clear, I don't understand what your point is. | |
| 11:06:17 | kashyap | lyarwood: Well, "remote disks" imply storage is non-local | |
| 11:06:27 | kashyap | So it isn't entirely evident for everyone reading the code. | |
| 11:07:59 | lyarwood | kashyap: eh, so what would that have to do with a host check? | |
| 11:08:01 | kashyap | But thanks for the remidner on swap_volume() being local; not sure what I was thinking there. | |
| 11:08:12 | lyarwood | kashyap: sorry I'm still failing to see your point here :) | |
| 11:08:47 | kashyap | lyarwood: You're right in that, you answered my question of the host check being irrelvant in this case. And then I proceeded to comment on the comment :D | |
| 11:09:01 | kashyap | Only adjust if you have a need to respin | |
| 11:09:06 | lyarwood | kashyap: np ack thanks | |
| 11:48:43 | gibi | lyarwood, stephenfin: went through both of the luksv1 patch series. I +2d most of it. but I don't feel confident about https://review.opendev.org/#/c/708029 | |
| 11:49:37 | gibi | you can convince me to +A it by having some other cores review it thoroughly | |
| 11:56:05 | lyarwood | gibi: ack thanks, I'll try to pull some folks in on the RH side today | |
| 12:20:55 | gibi | sean-k-mooney: I have questions in https://review.opendev.org/#/c/666915/ | |
| 13:09:42 | openstackgerrit | Brin Zhang proposed openstack/nova master: Switching new default roles in os-volumes-attachments policies https://review.opendev.org/710190 | |
| 13:21:37 | lyarwood | stephenfin / melwitt: would you be able to review https://review.opendev.org/#/c/708030 & https://review.opendev.org/#/c/708029/ when you have a chance today? | |
| 13:45:10 | openstackgerrit | Kevin Zhao proposed openstack/nova master: Add default cpu model for aarch64 https://review.opendev.org/709494 | |
| 13:47:00 | openstackgerrit | Lee Yarwood proposed openstack/nova master: libvirt: FUP I41b7c1653c6a887ee4b08e588c5d422409aebfba https://review.opendev.org/711262 | |
| 13:47:10 | lyarwood | ^ trivial fup is anyone has time | |
| 13:52:42 | openstackgerrit | Lee Yarwood proposed openstack/nova master: images: Make JSON the default output format of calls to qemu-img info https://review.opendev.org/711679 | |
| 13:53:16 | openstackgerrit | Lee Yarwood proposed openstack/nova master: virt: Provide block_device_info during rescue https://review.opendev.org/700811 | |
| 13:53:16 | openstackgerrit | Lee Yarwood proposed openstack/nova master: libvirt: Add support for stable device rescue https://review.opendev.org/700812 | |
| 13:53:17 | openstackgerrit | Lee Yarwood proposed openstack/nova master: compute: Report COMPUTE_RESCUE_BFV and check during rescue https://review.opendev.org/701429 | |
| 13:53:17 | openstackgerrit | Lee Yarwood proposed openstack/nova master: api: Introduce microverion 2.83 allowing boot from volume rescue https://review.opendev.org/701430 | |
| 13:53:18 | openstackgerrit | Lee Yarwood proposed openstack/nova master: compute: Extract _get_bdm_image_metadata into nova.utils https://review.opendev.org/705212 | |
| 13:53:18 | openstackgerrit | Lee Yarwood proposed openstack/nova master: libvirt: Support boot from volume stable device instance rescue https://review.opendev.org/701431 | |
| 13:53:19 | openstackgerrit | Lee Yarwood proposed openstack/nova master: DNM - Test stable device rescue tests with BFV instances https://review.opendev.org/710050 | |
| 14:02:05 | dansmith | does anyone know if that third party CI status page is still up anywhere? I don't seem to be able to find it | |
| 14:02:15 | dansmith | looks like zvm CI has been off the rails for a while as well | |
| 14:02:21 | dansmith | failing changes and the logs are 404 | |
| 14:35:02 | openstackgerrit | Brin Zhang proposed openstack/nova master: Add PATCH volume attachments api to os-volume_attachments https://review.opendev.org/693828 | |
| 14:35:02 | openstackgerrit | Brin Zhang proposed openstack/nova master: Add new policy to PATCH update volume API https://review.opendev.org/711194 | |
| 14:35:03 | openstackgerrit | Brin Zhang proposed openstack/nova master: Add functional tests for PATCH volume attachments API https://review.opendev.org/710965 | |
| 14:35:51 | bauzas | dansmith: you meant tritri something ? | |
| 14:36:04 | dansmith | bauzas: yeah | |
| 14:36:42 | brinzhang_ | lyarwood: https://review.opendev.org/#/c/710965/8/nova/tests/functional/api_sample_tests/test_volumes.py I think this is not necessary, and I cannot get the response too. | |
| 14:38:06 | brinzhang_ | lyarwood: In https://review.opendev.org/#/c/693828/19/nova/tests/unit/api/openstack/compute/test_volumes.py@1179 I update the unit test case, and assert the delete_on_termination after bdm.save(), I think it's enough, what do you think? | |
| 14:38:47 | bauzas | dansmith: AFAIR it moved recently, trying to find the link | |
| 14:40:16 | bauzas | it was something like [[local|localrc]] | |
| 14:40:17 | bauzas | ADMIN_PASSWORD=secret | |
| 14:40:17 | bauzas | DATABASE_PASSWORD=$ADMIN_PASSWORD | |
| 14:40:17 | bauzas | RABBIT_PASSWORD=$ADMIN_PASSWORD | |
| 14:40:17 | bauzas | SERVICE_PASSWORD=$ADMIN_PASSWORD | |
| 14:40:19 | bauzas | oh shit | |
| 14:40:21 | bauzas | openstack-ci.tintri.com | |
| 14:40:35 | bauzas | dansmith: but it's no longer responding | |
| 14:41:08 | dansmith | ack, yeah | |
| 14:45:43 | lyarwood | bauzas: just updated with a comment, we should be able to get the updated attachment from the fixture | |
| 14:45:53 | lyarwood | ah sorry | |
| 14:45:58 | lyarwood | brinzhang_: ^ tab-- | |
| 14:47:00 | brinzhang_ | lyarwood: I will check again | |
| 14:47:06 | lyarwood | brinzhang_: actually ignore that this isn't a fixture, it's n-api. | |
| 14:47:14 | lyarwood | brinzhang_: we should be able to test this directly | |
| 14:49:50 | brinzhang_ | lyarwood: yeas, I think I know what should I do, will update ^^ | |
| 14:50:01 | lyarwood | brinzhang_: excellent thanks | |
| 14:50:22 | brinzhang_ | lyarwood: np, thanks too. | |
| 14:56:22 | openstackgerrit | Merged openstack/nova master: Clarify fitting hugepages log message https://review.opendev.org/702981 | |
| 15:04:21 | openstackgerrit | Merged openstack/python-novaclient master: Microversion 2.82 - nova cyborg interaction https://review.opendev.org/712700 | |
| 15:05:03 | openstackgerrit | Brin Zhang proposed openstack/nova master: Add functional tests for PATCH volume attachments API https://review.opendev.org/710965 | |
| 15:08:00 | brinzhang_ | lyarwood: done. Can you check is that rirht? | |
| 15:11:44 | lyarwood | brinzhang_: yup LGTM now, tested locally and it's passing. | |
| 15:12:38 | brinzhang_ | lyarwood: thanks ^^ | |
| 15:15:01 | brinzhang_ | lyarwood: do you know Andrey Kurilin's irc name ? | |
| 15:15:49 | brinzhang_ | lyarwood: I donot think we should add @api_versions.wraps("2.83") to https://review.opendev.org/#/c/712651/4/novaclient/v2/volumes.py@127 | |
| 15:16:51 | brinzhang_ | lyarwood: the patch_server_volume() function is only one, is it need to add the @api_versions.wraps("2.83") to limit? | |
| 15:17:18 | lyarwood | brinzhang_: I don't sorry | |
| 15:18:10 | lyarwood | brinzhang_: yeah I thought you had done it correctly | |
| 15:18:31 | lyarwood | brinzhang_: however create_server_volume appears to do it | |
| 15:19:11 | bauzas | lyarwood: brinzhang_: https://launchpad.net/~andreykurilin | |
| 15:19:39 | brinzhang_ | lyarwood: create_server_volume appears is there are some microversion added in it, so that need to add the api_version_wraps to limit it's microversion | |
| 15:20:26 | lyarwood | ah I see | |
| 15:21:03 | brinzhang_ | lyarwood: And the patch volume api just the only one to do, if there is another microversion need to add in the future, I think that add the wrap is ok | |
| 15:22:02 | brinzhang_ | so I will keep it not limit by api_version_wraps, unless andreykurilin insists. | |
| 15:22:15 | brinzhang_ | bauzas: thanks | |
| 15:28:07 | brinzhang_ | andreykurilin: are you around? | |
| 15:39:02 | openstackgerrit | Brin Zhang proposed openstack/python-novaclient master: Microversion 2.83: Add volume-patch CLI https://review.opendev.org/712651 | |
| 15:43:50 | mriedem | oh wow nova's first PATCH API https://review.opendev.org/#/c/693828/ | |
| 16:09:46 | dansmith | hmm, we had a discussion recently about whether or not to add a PATCH API and I thought the agreement was to not | |
| 16:11:41 | lyarwood | I wanted to move swap_volume out from under the UPDATE API but IIRC it was eventually agreed in the spec to go with PUT | |
| 16:11:58 | lyarwood | https://review.opendev.org/#/c/580336/ yeah | |
| 16:12:49 | openstackgerrit | Brin Zhang proposed openstack/python-novaclient master: Microversion 2.83: Add volume-attachment-update CLI https://review.opendev.org/712651 | |