| Posted | Nick | Remark | |
|---|---|---|---|
| #openstack-nova - 2020-03-06 | |||
| 01:23:21 | openstackgerrit | Ghanshyam Mann proposed openstack/nova master: Add new default roles in os-deferred_delete policies https://review.opendev.org/707485 | |
| 01:26:45 | openstackgerrit | Ghanshyam Mann proposed openstack/nova master: Add test coverage of existing console_output policies https://review.opendev.org/706724 | |
| 01:27:01 | openstackgerrit | Ghanshyam Mann proposed openstack/nova master: Introduce scope_types in os-console-output https://review.opendev.org/707040 | |
| 01:28:11 | openstackgerrit | Ghanshyam Mann proposed openstack/nova master: Add test coverage of existing console_output policies https://review.opendev.org/706724 | |
| 01:28:34 | openstackgerrit | Ghanshyam Mann proposed openstack/nova master: Introduce scope_types in os-console-output https://review.opendev.org/707040 | |
| 01:29:37 | openstackgerrit | Ghanshyam Mann proposed openstack/nova master: Introduce scope_types in os-console-output https://review.opendev.org/707040 | |
| 01:29:51 | openstackgerrit | Ghanshyam Mann proposed openstack/nova master: Add new default roles in os-console-output policies https://review.opendev.org/707041 | |
| 01:36:44 | openstackgerrit | Ghanshyam Mann proposed openstack/nova master: Add new default roles in os-console-output policies https://review.opendev.org/707041 | |
| 01:38:13 | openstackgerrit | Ghanshyam Mann proposed openstack/nova master: Add test coverage of existing create_backup policies https://review.opendev.org/706726 | |
| 01:38:56 | openstackgerrit | Ghanshyam Mann proposed openstack/nova master: Fix os-create-backup policy to be admin_or_owner https://review.opendev.org/706727 | |
| 01:39:03 | openstackgerrit | Ghanshyam Mann proposed openstack/nova master: Fix os-create-backup policy to be admin_or_owner https://review.opendev.org/706727 | |
| 01:39:23 | openstackgerrit | Ghanshyam Mann proposed openstack/nova master: Add test coverage of existing create_backup policies https://review.opendev.org/706726 | |
| 01:39:35 | openstackgerrit | Ghanshyam Mann proposed openstack/nova master: Introduce scope_types in os-create-backup https://review.opendev.org/707038 | |
| 01:40:54 | openstackgerrit | Ghanshyam Mann proposed openstack/nova master: Introduce scope_types in os-create-backup https://review.opendev.org/707038 | |
| 01:41:09 | openstackgerrit | Ghanshyam Mann proposed openstack/nova master: Add new default roles in os-create-backup policies https://review.opendev.org/707039 | |
| 01:45:52 | openstackgerrit | Ghanshyam Mann proposed openstack/nova master: Add new default roles in os-create-backup policies https://review.opendev.org/707039 | |
| 02:48:34 | brinzhang | damsmith: as mriedem said in https://review.opendev.org/#/c/694428/4, I think this issue was triggered when I modified the os-instance-actions APIs default policy [1]. I am not particularly familiar with @serialize_args. Can you suggest or submit some fixes? | |
| 02:50:15 | brinzhang | dansmith: [1]https://review.opendev.org/#/c/706470/7, it's functional error report https://storage.bhs.cloud.ovh.net/v1/AUTH_dcaab5e32b234d56b626f72581e3644c/zuul_opendev_logs_5a7/706179/6/check/openstack-tox-py36/5a7826b/testr_results.html | |
| 02:53:17 | brinzhang | damsmith: when microversion > 2.51, we can show the instance action events for a server, but now the non-admin can get the ['host', 'traceback'], that should belong to admin role, this validates mriedem's comment. | |
| 02:58:02 | openstackgerrit | norman shen proposed openstack/nova stable/rocky: Relex python3 version for pep8 https://review.opendev.org/711577 | |
| 03:10:54 | brinzhang | dansmith: I was said maybe be not correct, I am not sure they are the same issue, please check. | |
| 03:18:37 | openstackgerrit | Eric Xie proposed openstack/nova master: Catch exception when use invalid architecture of image https://review.opendev.org/711363 | |
| 03:22:47 | brinzhang | dansmith: bug 1866292 mainly trace for non-admin can get the 'traceback' | |
| 03:22:47 | openstack | bug 1866292 in OpenStack Compute (nova) "non-admin shouldn't get the ['host', 'traceback'] of os-instance-actions's events" [Undecided,New] https://launchpad.net/bugs/1866292 | |
| 03:30:09 | openstackgerrit | Merged openstack/nova stable/train: libvirt: Ignore DiskNotFound during update_available_resource https://review.opendev.org/711276 | |
| 03:49:45 | openstackgerrit | Brin Zhang proposed openstack/nova master: Add SYSTEM_READER role to servers actions API https://review.opendev.org/706179 | |
| 08:37:00 | openstackgerrit | Balazs Gibizer proposed openstack/nova stable/train: Reproduce bug 1862633 https://review.opendev.org/709166 | |
| 08:37:00 | openstack | bug 1862633 in OpenStack Compute (nova) "unshelve leak allocation if update port fails" [Medium,Fix released] https://launchpad.net/bugs/1862633 - Assigned to Balazs Gibizer (balazs-gibizer) | |
| 08:37:15 | openstackgerrit | Balazs Gibizer proposed openstack/nova stable/train: Clean up allocation if unshelve fails due to neutron https://review.opendev.org/709167 | |
| 08:38:01 | gibi | elod, lyarwood: ^^ updated the commit message on the bottom backport patch as requested | |
| 08:57:30 | lyarwood | gibi: ack done, thanks | |
| 08:57:48 | lyarwood | elod: https://review.opendev.org/#/c/709167/ LGTM to me also now. | |
| 09:01:46 | elod | lyarwood: thanks, +W'd :] | |
| 09:19:00 | gibi | lyarwood, elod: thanks a bunch | |
| 09:19:26 | openstackgerrit | Brin Zhang proposed openstack/nova master: Fix os-volumes-attachments policy to be admin_or_owner https://review.opendev.org/709955 | |
| 09:19:26 | openstackgerrit | Brin Zhang proposed openstack/nova master: Add test coverage of existing os-volumes-attachments policies https://review.opendev.org/709929 | |
| 09:19:27 | openstackgerrit | Brin Zhang proposed openstack/nova master: Introduce scope_types in os-volumes-attachments policy https://review.opendev.org/709388 | |
| 09:19:27 | openstackgerrit | Brin Zhang proposed openstack/nova master: Add new default roles in os-volumes-attachments policies https://review.opendev.org/710190 | |
| 09:19:28 | openstackgerrit | Brin Zhang proposed openstack/nova master: Add PATCH volume attachments api to os-volume_attachments https://review.opendev.org/693828 | |
| 09:19:28 | openstackgerrit | Brin Zhang proposed openstack/nova master: Add new policy to PATCH update volume API https://review.opendev.org/711194 | |
| 09:19:29 | openstackgerrit | Brin Zhang proposed openstack/nova master: Add functional tests for PATCH volume attachments API https://review.opendev.org/710965 | |
| 09:33:02 | openstackgerrit | Merged openstack/nova stable/train: Reproduce bug 1862633 https://review.opendev.org/709166 | |
| 09:33:02 | openstack | bug 1862633 in OpenStack Compute (nova) "unshelve leak allocation if update port fails" [Medium,Fix released] https://launchpad.net/bugs/1862633 - Assigned to Balazs Gibizer (balazs-gibizer) | |
| 09:35:23 | brinzhang_ | gibi: Do you have time to check this functional failed? https://review.opendev.org/#/c/706470/ | |
| 09:36:05 | brinzhang_ | gibi: I am not sure whether is it a bug, I create a bug in launchpad, for bug 1866292 | |
| 09:36:05 | openstack | bug 1866292 in OpenStack Compute (nova) "non-admin shouldn't get the ['host', 'traceback'] of os-instance-actions's events" [Undecided,New] https://launchpad.net/bugs/1866292 | |
| 09:41:11 | gibi | brinzhang_: I will check.. | |
| 09:41:30 | brinzhang_ | gibi: thanks ^^ | |
| 09:57:22 | gibi | brinzhang_: I cannot reproduce the issue in devstack with demo user | |
| 09:57:25 | gibi | brinzhang_: http://paste.openstack.org/show/790383/ | |
| 09:57:46 | gibi | brinzhang_: so I think it could be a specific problem in the func test en | |
| 09:57:49 | gibi | env | |
| 09:58:58 | brinzhang_ | gibi: yes, I was changed it's default policy, I think caused by the new policy | |
| 09:59:26 | gibi | I can pull down your patch in my devstack to see if it changes the behavior | |
| 09:59:51 | brinzhang_ | gibi: I debuged in my devstack, and it has the same issue with that CI result | |
| 10:00:00 | brinzhang_ | gibi: cool, thanks | |
| 10:02:25 | openstackgerrit | John Garbutt proposed openstack/nova master: Introduce scope_types in os-aggregates policy https://review.opendev.org/701652 | |
| 10:02:40 | lyarwood | does anyone recall where the legacy zuul migration guide lives now? I'm getting 404's for the links I'm finding. | |
| 10:03:16 | lyarwood | https://docs.openstack.org/devstack/latest/zuul_ci_jobs_migration.html ah ha! | |
| 10:03:43 | brinzhang_ | lyarwood: can you provide the old.. cool, let me try | |
| 10:04:22 | brinzhang_ | lyarwood: ignore above word^^ | |
| 10:06:25 | lyarwood | brinzhang_: https://docs.openstack.org/infra/manual/zuulv3.html | |
| 10:06:30 | lyarwood | brinzhang_: returns a 404 now | |
| 10:06:40 | lyarwood | brinzhang_: still cached by Google apparently | |
| 10:07:31 | brinzhang_ | lyarwood: https://docs.openstack.org/devstack/latest/zuul_ci_jobs_migration.html this is not what would you want to get? | |
| 10:08:08 | lyarwood | brinzhang_: yes sorry that's what I was looking for | |
| 10:08:48 | brinzhang_ | lyarwood: ^^ | |
| 10:12:40 | stephenfin | bauzas, gibi: Could you guys close out these remaining nova-network patches today so I can mark the blueprint finished? https://review.opendev.org/#/q/status:open+project:openstack/nova+branch:master+topic:bp/remove-nova-network-ussuri | |
| 10:14:00 | stephenfin | they're mostly removals of code, so should be easy to use | |
| 10:15:40 | johnthetubaguy | brinzhang_: I may have accidentally spotted why your tests are filing for this patch: https://review.opendev.org/#/c/706470/7/nova/policies/instance_actions.py | |
| 10:16:51 | kashyap | lyarwood: Hey, once the fixed libgrypt packages trickle down to distributions, we will eventually deprecate and remove the workaround, yeah? -- https://review.opendev.org/#/c/708030/3 | |
| 10:16:58 | brinzhang_ | johnthetubaguy: let me try.. | |
| 10:18:33 | lyarwood | kashyap: I'd leave it in place tbh, migration from the workaround is simple and it could be useful if anything like this ever happened again. | |
| 10:18:57 | lyarwood | kashyap: migration being actual live or cold migration to a host where the workaround is diabled | |
| 10:19:01 | lyarwood | disabled* | |
| 10:19:30 | lyarwood | I had an AI to check that we generate the correct XML for the domain in that case but I'm 99.9% sure we would | |
| 10:21:37 | johnthetubaguy | stephenfin: is there are reason you don't just delete the squalchmy models, does it break the db migration testing or something? | |
| 10:21:57 | stephenfin | johnthetubaguy: dansmith told me not to | |
| 10:22:06 | stephenfin | I chose not to argue :) | |
| 10:23:32 | johnthetubaguy | so I thought we have to delete the sql alchemy objects before we can drop stuff in the DB a release later, but its been a while since we did that, no totally sure we ever have | |
| 10:23:47 | brinzhang_ | johnthetubaguy: no, I removed your point, but it has the same issue, you can see http://paste.openstack.org/show/790386/ | |
| 10:25:00 | stephenfin | johnthetubaguy: I've no idea. FWIW though, this is the same thing I did for the cells v1 removal. I have a separate series up now to remove those models | |
| 10:25:45 | johnthetubaguy | stephenfin: sounds like we are being consistent, which is all good | |
| 10:26:44 | kashyap | lyarwood: Yeah, we can leave it in place, but also have to note explicitly that "updating to this new version of libgcrypt" == you don't need the workaround. | |
| 10:29:34 | johnthetubaguy | brinzhang_: i suspect the context object getting into your method for an admin call doesn't have the scope in it, or something like that | |
| 10:30:06 | johnthetubaguy | brinzhang_: I think gmann did see some similar errors, but hasn't fixed those yet either | |
| 10:32:20 | brinzhang_ | johnthetubaguy: Oh yeah, i didn't pay attention to this, the scope of the context object has a problem, can you know which field it is | |
| 10:32:27 | johnthetubaguy | brinzhang_: try adding the system_scope=all here: https://github.com/openstack/nova/blob/f176ffe6e57e21c4c5d9f33a3c9e47476d10acc9/nova/tests/fixtures.py#L916 | |
| 10:32:47 | johnthetubaguy | not totally sure... but I think that is the place | |
| 10:32:49 | brinzhang_ | johnthetubaguy: ok, let me try | |
| 10:38:05 | brinzhang_ | johnthetubaguy: do you point here https://opendev.org/openstack/nova/src/branch/master/nova/tests/fixtures.py#L916? we can not open github fastly | |
| 10:38:47 | gibi | stephenfin: I will try to look at those today | |
| 10:39:09 | johnthetubaguy | brinzhang_: yeah, sorry, that is where I meant, it is created a fake object, line 948 is what that code is matching on | |
| 10:39:13 | stephenfin | Thanks. Let me know if anything isn't immediately obvious :) | |
| 10:39:14 | brinzhang_ | johnthetubaguy: That changed to "is_admin = user_id == 'admin and system_scope=all'"? | |
| 10:39:39 | stephenfin | gibi: Also, all hail the new leader 👑 | |
| 10:39:39 | stephenfin | gibi: Also, all hail the new leader 👑 | |
| 10:39:58 | johnthetubaguy | ah, no, I think you need to add system_scope='all' into the kwargs when user_id == 'admin' | |
| 10:40:17 | johnthetubaguy | basically, so it looks like we get a new style admin | |
| 10:40:45 | brinzhang_ | johnthetubaguy: sure | |