Earlier  
Later
New Search
Posted Nick Remark
#openstack-nova - 2020-03-06
09:41:30 brinzhang_ gibi: thanks ^^
09:57:22 gibi brinzhang_: I cannot reproduce the issue in devstack with demo user
09:57:25 gibi brinzhang_: http://paste.openstack.org/show/790383/
09:57:46 gibi brinzhang_: so I think it could be a specific problem in the func test en
09:57:49 gibi env
09:58:58 brinzhang_ gibi: yes, I was changed it's default policy, I think caused by the new policy
09:59:26 gibi I can pull down your patch in my devstack to see if it changes the behavior
09:59:51 brinzhang_ gibi: I debuged in my devstack, and it has the same issue with that CI result
10:00:00 brinzhang_ gibi: cool, thanks
10:02:25 openstackgerrit John Garbutt proposed openstack/nova master: Introduce scope_types in os-aggregates policy https://review.opendev.org/701652
10:02:40 lyarwood does anyone recall where the legacy zuul migration guide lives now? I'm getting 404's for the links I'm finding.
10:03:16 lyarwood https://docs.openstack.org/devstack/latest/zuul_ci_jobs_migration.html ah ha!
10:03:43 brinzhang_ lyarwood: can you provide the old.. cool, let me try
10:04:22 brinzhang_ lyarwood: ignore above word^^
10:06:25 lyarwood brinzhang_: https://docs.openstack.org/infra/manual/zuulv3.html
10:06:30 lyarwood brinzhang_: returns a 404 now
10:06:40 lyarwood brinzhang_: still cached by Google apparently
10:07:31 brinzhang_ lyarwood: https://docs.openstack.org/devstack/latest/zuul_ci_jobs_migration.html this is not what would you want to get?
10:08:08 lyarwood brinzhang_: yes sorry that's what I was looking for
10:08:48 brinzhang_ lyarwood: ^^
10:12:40 stephenfin bauzas, gibi: Could you guys close out these remaining nova-network patches today so I can mark the blueprint finished? https://review.opendev.org/#/q/status:open+project:openstack/nova+branch:master+topic:bp/remove-nova-network-ussuri
10:14:00 stephenfin they're mostly removals of code, so should be easy to use
10:15:40 johnthetubaguy brinzhang_: I may have accidentally spotted why your tests are filing for this patch: https://review.opendev.org/#/c/706470/7/nova/policies/instance_actions.py
10:16:51 kashyap lyarwood: Hey, once the fixed libgrypt packages trickle down to distributions, we will eventually deprecate and remove the workaround, yeah? -- https://review.opendev.org/#/c/708030/3
10:16:58 brinzhang_ johnthetubaguy: let me try..
10:18:33 lyarwood kashyap: I'd leave it in place tbh, migration from the workaround is simple and it could be useful if anything like this ever happened again.
10:18:57 lyarwood kashyap: migration being actual live or cold migration to a host where the workaround is diabled
10:19:01 lyarwood disabled*
10:19:30 lyarwood I had an AI to check that we generate the correct XML for the domain in that case but I'm 99.9% sure we would
10:21:37 johnthetubaguy stephenfin: is there are reason you don't just delete the squalchmy models, does it break the db migration testing or something?
10:21:57 stephenfin johnthetubaguy: dansmith told me not to
10:22:06 stephenfin I chose not to argue :)
10:23:32 johnthetubaguy so I thought we have to delete the sql alchemy objects before we can drop stuff in the DB a release later, but its been a while since we did that, no totally sure we ever have
10:23:47 brinzhang_ johnthetubaguy: no, I removed your point, but it has the same issue, you can see http://paste.openstack.org/show/790386/
10:25:00 stephenfin johnthetubaguy: I've no idea. FWIW though, this is the same thing I did for the cells v1 removal. I have a separate series up now to remove those models
10:25:45 johnthetubaguy stephenfin: sounds like we are being consistent, which is all good
10:26:44 kashyap lyarwood: Yeah, we can leave it in place, but also have to note explicitly that "updating to this new version of libgcrypt" == you don't need the workaround.
10:29:34 johnthetubaguy brinzhang_: i suspect the context object getting into your method for an admin call doesn't have the scope in it, or something like that
10:30:06 johnthetubaguy brinzhang_: I think gmann did see some similar errors, but hasn't fixed those yet either
10:32:20 brinzhang_ johnthetubaguy: Oh yeah, i didn't pay attention to this, the scope of the context object has a problem, can you know which field it is
10:32:27 johnthetubaguy brinzhang_: try adding the system_scope=all here: https://github.com/openstack/nova/blob/f176ffe6e57e21c4c5d9f33a3c9e47476d10acc9/nova/tests/fixtures.py#L916
10:32:47 johnthetubaguy not totally sure... but I think that is the place
10:32:49 brinzhang_ johnthetubaguy: ok, let me try
10:38:05 brinzhang_ johnthetubaguy: do you point here https://opendev.org/openstack/nova/src/branch/master/nova/tests/fixtures.py#L916? we can not open github fastly
10:38:47 gibi stephenfin: I will try to look at those today
10:39:09 johnthetubaguy brinzhang_: yeah, sorry, that is where I meant, it is created a fake object, line 948 is what that code is matching on
10:39:13 stephenfin Thanks. Let me know if anything isn't immediately obvious :)
10:39:14 brinzhang_ johnthetubaguy: That changed to "is_admin = user_id == 'admin and system_scope=all'"?
10:39:39 stephenfin gibi: Also, all hail the new leader 👑
10:39:39 stephenfin gibi: Also, all hail the new leader 👑
10:39:58 johnthetubaguy ah, no, I think you need to add system_scope='all' into the kwargs when user_id == 'admin'
10:40:17 johnthetubaguy basically, so it looks like we get a new style admin
10:40:45 brinzhang_ johnthetubaguy: sure
10:41:06 johnthetubaguy ... having said that, it does suggest the deprecation rules are not quite working as expected, I would ask gmann for more info
10:43:43 openstackgerrit Stephen Finucane proposed openstack/nova master: Use neutronclient's port binding APIs https://review.opendev.org/706295
10:47:03 brinzhang_ johnthetubaguy: it seems not correct, the failed test case is fot non-admin, if we add system_scope='admin' if is_admin=True, that we just change the admin's context, the non-admin context also same as before
10:47:12 brinzhang_ and it has the same issue
10:47:44 johnthetubaguy ah, OK, I missed that
10:47:59 johnthetubaguy curious
10:47:59 brinzhang_ http://paste.openstack.org/show/790390/ this is my change, and the test result alos same before
10:48:26 brinzhang_ and I think the if always False.
11:05:26 openstackgerrit Lee Yarwood proposed openstack/nova master: WIP/DNM zuul: Attempt to migrate and break up the nova-live-migration job https://review.opendev.org/711604
11:37:21 openstackgerrit Merged openstack/nova stable/train: Clean up allocation if unshelve fails due to neutron https://review.opendev.org/709167
11:37:43 openstackgerrit Qiu Fossen proposed openstack/nova master: The instance is volume backed and power state is PAUSED，shelve the instance failed https://review.opendev.org/711609
11:37:43 openstackgerrit Qiu Fossen proposed openstack/nova master: The instance is volume backed and power state is PAUSED，shelve the instance failed https://review.opendev.org/711609
11:46:43 openstackgerrit Johannes Kulik proposed openstack/nova master: Validate id as integer for os-aggregates https://review.opendev.org/710214
11:49:54 openstackgerrit Merged openstack/nova master: Remove old policy enforcement in attach_interfaces https://review.opendev.org/705127
11:49:59 openstackgerrit Merged openstack/nova master: Add test coverage of existing attach_interfaces policies https://review.opendev.org/705126
11:50:07 openstackgerrit Merged openstack/nova master: Introduce scope_types in os-attach-interfaces https://review.opendev.org/705799
11:50:16 openstackgerrit Merged openstack/nova master: Introduce scope_types in os-console-auth-tokens https://review.opendev.org/706688
11:54:01 happyhemant stephenfin: hey hi stephenfin any idea about spoo checking caus it suppose to be ON. https://www.irccloud.com/pastebin/FHzoKqNc/
11:55:31 happyhemant stephenfin: i tried to enable it but this is what am i getting on computes https://www.irccloud.com/pastebin/weWf4L2z/
11:55:38 happyhemant what could be wrong here ?
11:57:07 gibi brinzhang: sorry, I did not see what is wrong with that functional test. I hope johnthetubaguy can help
12:28:00 brinzhang gibi: yeah, thanks. I think johnthethubaguy and gmann can help, they may need to talk something of that failed, that when I will join.
12:44:41 openstackgerrit Merged openstack/nova master: Correct the actual target in os-instance-actions policy https://review.opendev.org/710411
12:44:47 openstackgerrit Merged openstack/nova master: Add test coverage of existing os-instance-actions policies https://review.opendev.org/707777
12:44:54 openstackgerrit Merged openstack/nova master: Introduce scope_types in os-admin-password https://review.opendev.org/701630
12:45:01 openstackgerrit Merged openstack/nova master: Add new default roles in os-admin-password policies https://review.opendev.org/701639
12:45:08 openstackgerrit Merged openstack/nova master: Add a tests to check when legacy access is removed https://review.opendev.org/710813
12:45:24 openstackgerrit Merged openstack/nova master: Add test coverage of existing console_output policies https://review.opendev.org/706724
12:53:41 openstackgerrit Brin Zhang proposed openstack/nova master: Introduce scope_types in os-instance-action policy https://review.opendev.org/707751
12:55:22 brinzhang stephenfin: can you +A again, I was reabseed because of the conflict https://review.opendev.org/#/c/707751/
12:56:23 openstackgerrit Brin Zhang proposed openstack/nova master: Add new default roles in os-instance-actions policies https://review.opendev.org/706470
12:56:36 openstackgerrit Brin Zhang proposed openstack/nova master: Add SYSTEM_READER role to servers actions API https://review.opendev.org/706179
13:13:39 gibi stephenfin: I'm +2 all the way up in the nova-net patches
13:29:37 openstackgerrit Merged openstack/nova master: Introduce scope_types in os-console-output https://review.opendev.org/707040
13:32:10 openstackgerrit Merged openstack/nova master: Add new default roles in os-console-output policies https://review.opendev.org/707041
13:32:15 openstackgerrit Merged openstack/nova master: Fix os-volumes-attachments policy to be admin_or_owner https://review.opendev.org/709955
13:32:24 openstackgerrit Merged openstack/nova master: Add test coverage of existing os-volumes-attachments policies https://review.opendev.org/709929
13:36:38 openstackgerrit Merged openstack/nova master: Introduce scope_types in os-volumes-attachments policy https://review.opendev.org/709388
13:36:51 openstackgerrit Merged openstack/nova master: Introduce scope_types in os-aggregates policy https://review.opendev.org/701652
13:48:57 openstackgerrit Lee Yarwood proposed openstack/nova master: WIP/DNM zuul: Attempt to migrate and break up the nova-live-migration job https://review.opendev.org/711604
13:53:54 gmann brinzhang: getting coffee. I will check the error. is it instance action one ?
14:02:46 brinzhang gmann: yes, it's the failed patch https://review.opendev.org/#/c/706470/
14:05:00 brinzhang gmann: the failed is the non-admin expected response is not match the actual response, and the 'traceback' in the actual response, it's should return when the user is non-admin
14:05:22 brinzhang gmann: thanks for your check.
14:06:27 gmann ok
14:06:42 brinzhang johnthetubaguy: thanks +A for that rebase patch
14:10:22 kashyap bauzas: stephenfin: Heya, for allocating huge pages, have we already considered the existing libvirt API allocPages()? (I don't see it in the source from a lazy `grep`)

Earlier   Later