Earlier  
Later
New Search
Posted Nick Remark
#openstack-nova - 2020-03-05
17:12:13 artom I thought shared storage was just the disk
17:12:24 artom Everything else lives on the compute host directly
17:12:27 artom No?
17:12:37 melwitt lyarwood halp
17:13:10 melwitt I guess I don't know anymore. I feel like I used to, but maybe that was a dream
17:14:16 kashyap artom: Yes, shared storage means: just the disk, in general ...
17:14:39 kashyap (Only memory and device state will be live-migrated in shared storage setup.)
17:15:17 kashyap On changing the VIFs, I'm not 100% sure, I also feel like melwitt :D
17:15:39 artom luyao, maybe you could tell us what behaviour you're seeing that you think is a bug
17:16:04 artom melwitt, my comment is only there because I added the instance.refresh() call
17:16:09 artom Everything else predates me
17:16:10 melwitt kashyap: heh
17:16:27 melwitt nicely played
17:16:42 kashyap `git shortlog --nse /path/to/file/name` is your weapon, luyao
17:16:54 kashyap (And pick the top three or four members to harass)
17:17:11 luyao artom: I think do_cleanup is just a flag to tell if we need cleanup instance file during migration right?
17:17:37 kashyap (Or even a fine-grained one: `git blame -C -M -L line-$x:line-$y /path/to/file/name/`)
17:18:18 artom luyao, the way it's set, yeah
17:18:27 artom luyao, but it could be used for other things, but still be correct
17:18:49 artom The code is kinda messy, but if it works, it works
17:18:54 luyao but in the code path, if do_cleanup is false, the whole driver.cleanup will not be invoked, but except for instance files cleanup ,we also have other things like undefine domain and unplug vifs
17:19:18 artom luyao, which is why I'm asking if there's a specific behaviour/error you're asking about
17:19:41 artom Because debating the code itself is kinda pointless. There are years and years of multiple people doing multiple things, all for valid reasons
17:19:55 artom To end up with the mess with have now :)
17:20:18 luyao artom: no, I write my own patch ,and alex_xu comment at this, we are both not sure of this
17:20:38 artom luyao, link the patch please :)
17:20:49 luyao https://review.opendev.org/#/c/687856/10/nova/compute/manager.py@8623
17:20:59 artom Tbh, I won't able to look now because I'm running on very little sleep, but I'll try to look later
17:21:36 openstackgerrit Ghanshyam Mann proposed openstack/nova master: Introduce scope_types in os-admin-password https://review.opendev.org/701630
17:22:37 luyao artom: OK, thanks. It's too late for me so I'm going to sleep too. :D
17:22:48 artom luyao, ack :)
17:24:09 lyarwood melwitt: sorry was afk, reading
17:24:37 openstackgerrit Ghanshyam Mann proposed openstack/nova master: Add new default roles in os-admin-password policies https://review.opendev.org/701639
17:25:09 tosky checking a pending patch on stable/pike - it seems that nova-live-migration has still some issues there, and other patches are blocked too
17:26:07 tosky I think we already discussed about this, are there any updates?
17:28:25 melwitt tosky: we did, no updates yet sorry. sean-k-mooney had been trying to get time to do a bit of debugging but afaik they didn't get to it yet
17:29:03 tosky oki, np
17:29:39 lyarwood luyao: we unplug VIFS regardless of that value in post_live_migration_at_source https://github.com/openstack/nova/blob/19cbbbebddadb125b8123ce0350b7146b29a59c6/nova/virt/libvirt/driver.py#L9260-L9267
17:29:52 tosky it's not the most important thing (in the long run, I just want to remove a legacy job from openstack-zuul-jobs :)
17:30:56 lyarwood luyao: iirc Libvirt itself handles the removal of the domain
17:31:56 lyarwood luyao: https://github.com/openstack/nova/blob/19cbbbebddadb125b8123ce0350b7146b29a59c6/nova/virt/libvirt/driver.py#L909-L911 yeah it does
17:32:28 melwitt tosky: yeah, it's odd that it fails so much more on pike than on master. that's part of why digging in will be hard, find what's happening and what's different. I see occasional failures on master but obvious pike is failing nearly all the time last I saw
17:32:43 melwitt *obviously
17:38:09 melwitt lyarwood++
17:40:34 openstackgerrit Merged openstack/nova master: Stop using PlacementDirect https://review.opendev.org/640887
17:44:28 luyao lyarwood: before rollback live migration at destination ，it also check the do_cleanup flag，in this case，i think we need destroy the domain at target host manually right?
17:45:48 lyarwood luyao: just looking at the review now, I didn't get that we were talking about rollback sorry
17:46:26 lyarwood luyao: it depends on the failure tbh, we ask Libvirt to persist the domain but only on a successful migration
17:47:02 lyarwood https://github.com/openstack/nova/blob/19cbbbebddadb125b8123ce0350b7146b29a59c6/nova/virt/libvirt/driver.py#L913-L915
17:47:05 lyarwood https://github.com/openstack/nova/blob/19cbbbebddadb125b8123ce0350b7146b29a59c6/nova/virt/libvirt/guest.py#L609-L611
17:50:51 luyao lyarwood: I understand it may not trigger error in real env, but do_cleanup flag setting and the code path it controls is a little confusing
17:52:18 luyao since do_cleanup is just tell if the instance path file is shared
17:52:31 lyarwood luyao: yeah very, I've added a comment, I think we could look into calling rollback_live_migration_at_destination regardless of that value in a seperate change
17:52:54 lyarwood luyao: I don't know if that's going to break assumptions in other drivers that support LM
17:58:21 luyao lyarwood: thanks for your comments I’ll go into it further tomorrow :)
18:22:53 openstackgerrit Jason Anderson proposed openstack/nova master: Use fair locks in resource tracker https://review.opendev.org/711528
19:58:13 openstackgerrit Victor Coutellier proposed openstack/nova master: Non-Admin user can filter their instances by more filters https://review.opendev.org/701609
20:22:21 mloza I'm trying to do a live migrate on a instance between computes and both have same model but different processor series. I'm getting this error
20:22:24 mloza Live Migration failure: operation failed: guest CPU doesn't match specification: missing features: virt-ssbd: libvirtError: operation failed: guest CPU doesn't match specification: missing features: virt-ssbd
20:35:44 mriedem mloza: https://docs.openstack.org/nova/latest/admin/configuration/hypervisor-kvm.html#specify-the-cpu-model-of-kvm-guests might be helpful
21:25:12 mloza mriedem: tahnsk
21:25:15 mloza thanks*
21:33:00 openstackgerrit Merged openstack/nova master: Fix os-console-output policy to be admin_or_owner https://review.opendev.org/706725
23:28:18 mloza I specified cpu_mode = custom and cpu_models = EPYC-IBRS but I can't turn on the instance
23:28:23 mloza I get this error ': Invalid: Config requested a custom CPU model, but no model name was provided'
23:29:24 mloza I have x86_EPYC-IBRS.xml in /usr/share/libvirt/cpu_map/
23:49:43 openstackgerrit Ghanshyam Mann proposed openstack/nova master: Add a tests to check when legacy access is removed https://review.opendev.org/710813
#openstack-nova - 2020-03-06
00:55:47 openstackgerrit Ghanshyam Mann proposed openstack/nova master: Introduce scope_types in os-deferred_delete https://review.opendev.org/707476
00:59:54 openstackgerrit Brin Zhang proposed openstack/nova master: Correct the actual target in os-instance-actions policy https://review.opendev.org/710411
00:59:55 openstackgerrit Brin Zhang proposed openstack/nova master: Add test coverage of existing os-instance-actions policies https://review.opendev.org/707777
01:05:50 openstackgerrit Ghanshyam Mann proposed openstack/nova master: Introduce scope_types in os-admin-password https://review.opendev.org/701630
01:06:04 openstackgerrit Ghanshyam Mann proposed openstack/nova master: Add new default roles in os-admin-password policies https://review.opendev.org/701639
01:06:18 openstackgerrit Ghanshyam Mann proposed openstack/nova master: Add a tests to check when legacy access is removed https://review.opendev.org/710813
01:06:32 openstackgerrit Ghanshyam Mann proposed openstack/nova master: Introduce scope_types in os-deferred_delete https://review.opendev.org/707476
01:06:44 openstackgerrit Ghanshyam Mann proposed openstack/nova master: Add new default roles in os-deferred_delete policies https://review.opendev.org/707485
01:09:25 openstackgerrit Ghanshyam Mann proposed openstack/nova master: Introduce scope_types in os-deferred_delete https://review.opendev.org/707476
01:09:37 openstackgerrit Ghanshyam Mann proposed openstack/nova master: Add new default roles in os-deferred_delete policies https://review.opendev.org/707485
01:23:21 openstackgerrit Ghanshyam Mann proposed openstack/nova master: Add new default roles in os-deferred_delete policies https://review.opendev.org/707485
01:26:45 openstackgerrit Ghanshyam Mann proposed openstack/nova master: Add test coverage of existing console_output policies https://review.opendev.org/706724
01:27:01 openstackgerrit Ghanshyam Mann proposed openstack/nova master: Introduce scope_types in os-console-output https://review.opendev.org/707040
01:28:11 openstackgerrit Ghanshyam Mann proposed openstack/nova master: Add test coverage of existing console_output policies https://review.opendev.org/706724
01:28:34 openstackgerrit Ghanshyam Mann proposed openstack/nova master: Introduce scope_types in os-console-output https://review.opendev.org/707040
01:29:37 openstackgerrit Ghanshyam Mann proposed openstack/nova master: Introduce scope_types in os-console-output https://review.opendev.org/707040
01:29:51 openstackgerrit Ghanshyam Mann proposed openstack/nova master: Add new default roles in os-console-output policies https://review.opendev.org/707041
01:36:44 openstackgerrit Ghanshyam Mann proposed openstack/nova master: Add new default roles in os-console-output policies https://review.opendev.org/707041
01:38:13 openstackgerrit Ghanshyam Mann proposed openstack/nova master: Add test coverage of existing create_backup policies https://review.opendev.org/706726
01:38:56 openstackgerrit Ghanshyam Mann proposed openstack/nova master: Fix os-create-backup policy to be admin_or_owner https://review.opendev.org/706727
01:39:03 openstackgerrit Ghanshyam Mann proposed openstack/nova master: Fix os-create-backup policy to be admin_or_owner https://review.opendev.org/706727
01:39:23 openstackgerrit Ghanshyam Mann proposed openstack/nova master: Add test coverage of existing create_backup policies https://review.opendev.org/706726
01:39:35 openstackgerrit Ghanshyam Mann proposed openstack/nova master: Introduce scope_types in os-create-backup https://review.opendev.org/707038
01:40:54 openstackgerrit Ghanshyam Mann proposed openstack/nova master: Introduce scope_types in os-create-backup https://review.opendev.org/707038
01:41:09 openstackgerrit Ghanshyam Mann proposed openstack/nova master: Add new default roles in os-create-backup policies https://review.opendev.org/707039
01:45:52 openstackgerrit Ghanshyam Mann proposed openstack/nova master: Add new default roles in os-create-backup policies https://review.opendev.org/707039
02:48:34 brinzhang damsmith: as mriedem said in https://review.opendev.org/#/c/694428/4, I think this issue was triggered when I modified the os-instance-actions APIs default policy [1]. I am not particularly familiar with @serialize_args. Can you suggest or submit some fixes?
02:50:15 brinzhang dansmith: [1]https://review.opendev.org/#/c/706470/7, it's functional error report https://storage.bhs.cloud.ovh.net/v1/AUTH_dcaab5e32b234d56b626f72581e3644c/zuul_opendev_logs_5a7/706179/6/check/openstack-tox-py36/5a7826b/testr_results.html
02:53:17 brinzhang damsmith: when microversion > 2.51, we can show the instance action events for a server, but now the non-admin can get the ['host', 'traceback'], that should belong to admin role, this validates mriedem's comment.
02:58:02 openstackgerrit norman shen proposed openstack/nova stable/rocky: Relex python3 version for pep8 https://review.opendev.org/711577
03:10:54 brinzhang dansmith: I was said maybe be not correct, I am not sure they are the same issue, please check.
03:18:37 openstackgerrit Eric Xie proposed openstack/nova master: Catch exception when use invalid architecture of image https://review.opendev.org/711363
03:22:47 brinzhang dansmith: bug 1866292 mainly trace for non-admin can get the 'traceback'

Earlier   Later