Earlier  
Later
New Search
Posted Nick Remark
#openstack-nova - 2020-03-03
13:18:30 Sundar dansmith, sean-k-mooney, gibi, efried, brinzhang: Re. https://review.opendev.org/#/c/674726/3/nova/exception.py@159 , if the client attempts an operation despite documentation that it is unsupported, is that not a client error?
13:21:44 gibi Sundar: for me it is a client error. but I have no hard oppinion on 400 or 403 both works for me
13:21:51 gibi alex_xu: ^^ ?
13:22:18 brinzhang_ gibi, Sundar, me too.
13:22:34 brinzhang_ 400 or 403 all works good for me
13:26:09 Sundar gibi, brinzhang_: It is currently handled in https://review.opendev.org/#/c/674726/3/nova/api/openstack/compute/servers.py@758 . However, the resulting error code is not 403, but is 500. I am still looking into that. Off the top of your head, do you see why?
13:27:46 gibi Sundar: are you sure that you hit Line 760 in your test?
13:30:32 gibi Sundar: as at a first glance your code looks correct
13:31:01 Sundar30 Sorry, got disconnected due to network issues.
13:31:54 gibi 14:27 < gibi> Sundar: are you sure that you hit Line 760 in your test?
13:31:54 gibi 14:30 < gibi> Sundar: as at a first glance your code looks correct
13:33:28 Sundar30 gibi: I'll double check that. Without that, one should have got 403 error code.
13:34:08 Sundar30 Back in 10 min.
13:36:16 gibi Sundar30: I'm on a meeting for 90 minutes so it will take time to answere
13:39:20 brinzhang_ Sundar30: How about inherit Forbidden class? it's code also 403, and your case is suitable for Forbidden, just need to override msg_fmt, do you think so?
13:42:51 brinzhang_ Sundar30: checked again, as gibi said, your code look correct, the phenomenon you said is strange
13:44:42 Sundar30 Back. Let me try some things.
14:36:05 openstackgerrit Brin Zhang proposed openstack/nova master: Store instance action event exc_val fault details https://review.opendev.org/694428
14:36:06 openstackgerrit Brin Zhang proposed openstack/nova master: Expose instance action event details out of the API https://review.opendev.org/694430
14:43:46 openstackgerrit Brin Zhang proposed openstack/nova master: Add instance actions v283 samples test https://review.opendev.org/706251
14:55:13 happyhemant stephenfin: hey hi again do you think `LOG.debug('Got matching_pools: %r', matching_pools)` after every matching_pools and building its image will help getting detailed logs ?
14:56:50 dansmith Sundar30: have you gone through the multinode test to look at the failures?
14:57:19 dansmith Sundar30: some stuff in there makes sense, live migration and such, but some other things are blocked that seem like they shouldn't be
14:57:40 dansmith actually, now that I say this I wonder if these are old results
14:58:14 dansmith ah yeah, from yesterday before you pushed
14:58:51 Sundar30 dansmith: Yea, I have updated the patches. Where do you see the multinode results?
14:59:00 dansmith I just rechecked it so we can get the updates
14:59:06 dansmith Sundar30: https://review.opendev.org/#/c/709641/6
15:00:20 Sundar30 Good
15:03:03 Sundar30 dansmith: We discussed https://review.opendev.org/#/c/674726/3/nova/exception.py@159 earlier today. Are you ok with 403 error code?
15:04:41 dansmith 403 means "forbidden despite proper authorization", which to me could mean "you're not allowed to do this with this thing", which seems perfectly appropriate to me
15:04:52 dansmith I'm also fine with 400, but I definitely don't think 403 is wrong
15:05:45 stephenfin happyhemant: It should help, yes
15:08:03 happyhemant stephenfin: ok thanks so i actually started building new image lets see what we see but i am done for today so will let you know about it tomorrow. Tbh i am completely lost cause of it and doing some silly stuff i hope it will get fixed tomorrow or soon :(
15:24:23 openstackgerrit Dan Smith proposed openstack/nova master: Fix two test cases that use side effects in comprehensions https://review.opendev.org/711039
15:51:27 dansmith gibi: I went through the bottom chunk of the cyborg patches yesterday and many of my concerns have been resolved,
15:51:35 dansmith but I need to focus on the higher ones and the test results still
15:51:51 dansmith Sundar revised the set between yesterday and today too
15:52:02 dansmith have you looked recently and/or how are you feeling on it?
15:56:04 gibi I haven't looked that recently. But I planning to
15:57:04 gibi I can try to get a look through tomorrow morning
15:59:12 dansmith gibi: cool.. I think test coverage is still a problem, even in some of the cases you've already pointed out, but I've tried to continue to hammer on that
16:03:04 openstackgerrit Lee Yarwood proposed openstack/nova master: virt: Provide block_device_info during rescue https://review.opendev.org/700811
16:03:04 openstackgerrit Lee Yarwood proposed openstack/nova master: libvirt: Add support for stable device rescue https://review.opendev.org/700812
16:03:05 openstackgerrit Lee Yarwood proposed openstack/nova master: compute: Report COMPUTE_RESCUE_BFV and check during rescue https://review.opendev.org/701429
16:03:05 openstackgerrit Lee Yarwood proposed openstack/nova master: api: Introduce microverion 2.83 allowing boot from volume rescue https://review.opendev.org/701430
16:03:06 openstackgerrit Lee Yarwood proposed openstack/nova master: compute: Extract _get_bdm_image_metadata into nova.utils https://review.opendev.org/705212
16:03:06 openstackgerrit Lee Yarwood proposed openstack/nova master: libvirt: Support boot from volume stable device instance rescue https://review.opendev.org/701431
16:04:50 gibi dansmith: ack
16:05:41 openstackgerrit Lee Yarwood proposed openstack/nova master: DNM - Test stable device rescue tests with BFV instances https://review.opendev.org/710050
16:18:36 mriedem lyarwood: beware this https://review.opendev.org/#/c/710861/
16:20:16 lyarwood mriedem: oh fun
16:20:43 lyarwood mriedem: thanks for the heads up
16:22:45 mriedem found the related bug https://bugs.launchpad.net/nova/+bug/1788014 so i -1'ed that backport
16:22:45 openstack Launchpad bug 1788014 in OpenStack Compute (nova) rocky "when live migration fails due to a internal error rollback is not handeled correctly." [Medium,Triaged]
16:22:54 mriedem looks like the fix never made it to rocky though so it's still an issue there
16:24:43 lyarwood \o/ thanks
17:36:59 openstackgerrit Balazs Gibizer proposed openstack/nova master: WIP: Hey let's support routed networks y'all! https://review.opendev.org/656885
17:37:00 openstackgerrit Balazs Gibizer proposed openstack/nova master: Support routed net during cold migration https://review.opendev.org/711071
19:35:31 openstackgerrit Michael Bayer proposed openstack/nova master: Remove oslo_db.sqlalchemy.compat reference https://review.opendev.org/711093
19:47:32 openstackgerrit Merged openstack/nova master: Pass the actual target in os-assisted_volume_snapshots policy https://review.opendev.org/701841
20:33:38 openstackgerrit Lee Yarwood proposed openstack/nova master: libvirt: Remove VIR_DOMAIN_BLOCK_REBASE_RELATIVE flag check https://review.opendev.org/702021
21:06:36 openstackgerrit Lee Yarwood proposed openstack/nova stable/pike: Remove exp legacy-tempest-dsvm-full-devstack-plugin-nfs https://review.opendev.org/702061
21:45:44 openstackgerrit Merged openstack/nova master: Remove 'nova.image.api' module https://review.opendev.org/702451
21:52:26 openstackgerrit Rafael Weingärtner proposed openstack/nova master: Enhance os-simple-tenant-usage VM hours accounting https://review.opendev.org/711113
21:53:56 openstackgerrit Merged openstack/nova master: Fix two test cases that use side effects in comprehensions https://review.opendev.org/711039
22:00:18 openstackgerrit Rafael Weingärtner proposed openstack/nova master: Enhance os-simple-tenant-usage VM hours accounting https://review.opendev.org/711113
22:06:45 openstackgerrit Rafael Weingärtner proposed openstack/nova master: Enhance os-simple-tenant-usage VM hours accounting https://review.opendev.org/711113
#openstack-nova - 2020-03-04
02:23:00 openstackgerrit Brin Zhang proposed openstack/nova master: Add PATCH volume attachments api to os-volume_attachments https://review.opendev.org/693828
02:23:01 openstackgerrit Brin Zhang proposed openstack/nova master: Add functional tests for PATCH volume attachments API https://review.opendev.org/710965
04:04:49 openstackgerrit Merged openstack/nova master: Unplug VIFs as part of cleanup of networks https://review.opendev.org/663382
04:34:37 prometheanfire new oslo.db breaks nova https://review.opendev.org/711031
06:34:44 openstackgerrit Michael Bayer proposed openstack/nova master: Remove oslo_db.sqlalchemy.compat reference https://review.opendev.org/711093
09:43:58 openstackgerrit John Garbutt proposed openstack/nova master: Ensure we pass a target in admin actions https://review.opendev.org/663095
09:46:41 openstackgerrit John Garbutt proposed openstack/nova master: Pass the actual target in os-availability-zone policy https://review.opendev.org/706691
09:47:07 openstackgerrit John Garbutt proposed openstack/nova master: Add test coverage of existing os-console-auth-tokens policies https://review.opendev.org/706687
09:47:45 hrw morning
09:48:04 openstackgerrit John Garbutt proposed openstack/nova master: Introduce scope_types in os-agents policy https://review.opendev.org/701645
09:48:09 hrw just wanted to inform that we released CirrOS 0.5.0 - https://github.com/cirros-dev/cirros/releases/tag/0.5.0
09:48:13 openstackgerrit John Garbutt proposed openstack/nova master: Add new default roles in os-agents policies https://review.opendev.org/701648
09:48:22 openstackgerrit John Garbutt proposed openstack/nova master: Pass the actual target in os-agents policy https://review.opendev.org/701649
09:48:58 openstackgerrit John Garbutt proposed openstack/nova master: Add test coverage of existing attach_interfaces policies https://review.opendev.org/705126
09:49:40 openstackgerrit John Garbutt proposed openstack/nova master: Remove old policy enforcement in attach_interfaces https://review.opendev.org/705127
09:50:07 openstackgerrit John Garbutt proposed openstack/nova master: Introduce scope_types in os-attach-interfaces https://review.opendev.org/705799
09:54:44 lyarwood kashyap / stephenfin ; https://review.opendev.org/#/c/702021/ - more trivial clean up if you have time today for a review btw
09:58:05 openstackgerrit John Garbutt proposed openstack/nova master: Fix os-os-deferred-delete policy to be admin_or_owner https://review.opendev.org/707457
09:58:14 openstackgerrit John Garbutt proposed openstack/nova master: Add test coverage of existing deferred_delete policies https://review.opendev.org/707455
09:59:42 kashyap lyarwood: Yep, negative-code++
10:18:20 openstackgerrit Brin Zhang proposed openstack/nova master: Add PATCH volume attachments api to os-volume_attachments https://review.opendev.org/693828
10:18:20 openstackgerrit Brin Zhang proposed openstack/nova master: Add new policy to PATCH update volume API https://review.opendev.org/711194
10:19:57 openstackgerrit Brin Zhang proposed openstack/nova master: Add functional tests for PATCH volume attachments API https://review.opendev.org/710965
10:25:04 openstackgerrit Lee Yarwood proposed openstack/nova master: api: Introduce microverion 2.83 allowing boot from volume rescue https://review.opendev.org/701430
10:25:04 openstackgerrit Lee Yarwood proposed openstack/nova master: compute: Extract _get_bdm_image_metadata into nova.utils https://review.opendev.org/705212
10:25:05 openstackgerrit Lee Yarwood proposed openstack/nova master: libvirt: Support boot from volume stable device instance rescue https://review.opendev.org/701431
10:25:05 openstackgerrit Lee Yarwood proposed openstack/nova master: DNM - Test stable device rescue tests with BFV instances https://review.opendev.org/710050
11:46:24 lyarwood https://storage.gra.cloud.ovh.net/v1/AUTH_dcaab5e32b234d56b626f72581e3644c/zuul_opendev_logs_b78/706898/6/check/nova-tox-functional-py36/b781ccf/testr_results.html - this is new, TypeError: 'TestOpenStackClient' object is not subscriptable, has anyone seen this?
12:05:54 openstackgerrit Stephen Finucane proposed openstack/nova stable/train: Functional test for UnexpectedDeletingTaskStateError https://review.opendev.org/711210
12:06:00 openstackgerrit Lee Yarwood proposed openstack/nova master: functional: Do not provide self.api to _wait_for_server_parameter within test_bug_1831771 https://review.opendev.org/711211
12:06:06 lyarwood stephenfin: ^ I have no idea how why we are only seeing this failure now, any ideas?
12:07:49 stephenfin Not a clue. Very odd

Earlier   Later