Posted	Nick	Remark
#openstack-nova - 2020-03-04
09:47:45	hrw	morning
09:48:04	openstackgerrit	John Garbutt proposed openstack/nova master: Introduce scope_types in os-agents policy https://review.opendev.org/701645
09:48:09	hrw	just wanted to inform that we released CirrOS 0.5.0 - https://github.com/cirros-dev/cirros/releases/tag/0.5.0
09:48:13	openstackgerrit	John Garbutt proposed openstack/nova master: Add new default roles in os-agents policies https://review.opendev.org/701648
09:48:22	openstackgerrit	John Garbutt proposed openstack/nova master: Pass the actual target in os-agents policy https://review.opendev.org/701649
09:48:58	openstackgerrit	John Garbutt proposed openstack/nova master: Add test coverage of existing attach_interfaces policies https://review.opendev.org/705126
09:49:40	openstackgerrit	John Garbutt proposed openstack/nova master: Remove old policy enforcement in attach_interfaces https://review.opendev.org/705127
09:50:07	openstackgerrit	John Garbutt proposed openstack/nova master: Introduce scope_types in os-attach-interfaces https://review.opendev.org/705799
09:54:44	lyarwood	kashyap / stephenfin ; https://review.opendev.org/#/c/702021/ - more trivial clean up if you have time today for a review btw
09:58:05	openstackgerrit	John Garbutt proposed openstack/nova master: Fix os-os-deferred-delete policy to be admin_or_owner https://review.opendev.org/707457
09:58:14	openstackgerrit	John Garbutt proposed openstack/nova master: Add test coverage of existing deferred_delete policies https://review.opendev.org/707455
09:59:42	kashyap	lyarwood: Yep, negative-code++
10:18:20	openstackgerrit	Brin Zhang proposed openstack/nova master: Add PATCH volume attachments api to os-volume_attachments https://review.opendev.org/693828
10:18:20	openstackgerrit	Brin Zhang proposed openstack/nova master: Add new policy to PATCH update volume API https://review.opendev.org/711194
10:19:57	openstackgerrit	Brin Zhang proposed openstack/nova master: Add functional tests for PATCH volume attachments API https://review.opendev.org/710965
10:25:04	openstackgerrit	Lee Yarwood proposed openstack/nova master: api: Introduce microverion 2.83 allowing boot from volume rescue https://review.opendev.org/701430
10:25:04	openstackgerrit	Lee Yarwood proposed openstack/nova master: compute: Extract _get_bdm_image_metadata into nova.utils https://review.opendev.org/705212
10:25:05	openstackgerrit	Lee Yarwood proposed openstack/nova master: libvirt: Support boot from volume stable device instance rescue https://review.opendev.org/701431
10:25:05	openstackgerrit	Lee Yarwood proposed openstack/nova master: DNM - Test stable device rescue tests with BFV instances https://review.opendev.org/710050
11:46:24	lyarwood	https://storage.gra.cloud.ovh.net/v1/AUTH_dcaab5e32b234d56b626f72581e3644c/zuul_opendev_logs_b78/706898/6/check/nova-tox-functional-py36/b781ccf/testr_results.html - this is new, TypeError: 'TestOpenStackClient' object is not subscriptable, has anyone seen this?
12:05:54	openstackgerrit	Stephen Finucane proposed openstack/nova stable/train: Functional test for UnexpectedDeletingTaskStateError https://review.opendev.org/711210
12:06:00	openstackgerrit	Lee Yarwood proposed openstack/nova master: functional: Do not provide self.api to _wait_for_server_parameter within test_bug_1831771 https://review.opendev.org/711211
12:06:06	lyarwood	stephenfin: ^ I have no idea how why we are only seeing this failure now, any ideas?
12:07:49	stephenfin	Not a clue. Very odd
12:07:57	stephenfin	I wonder if that's not being triggered all the time or something
12:12:02	lyarwood	it actually passes locally which is super odd
12:19:49	lyarwood	right, the race isn't actually being triggered all of the time
12:21:14	lyarwood	is there a way to force the functional tests to log in DEBUG (with OS_DEBUG=1) even when they pass?
12:24:26	lyarwood	stephenfin: https://github.com/openstack/nova/blob/5aa8df8f5cd4013b47a381ea929edd7ac425810e/nova/tests/functional/regressions/test_bug_1831771.py#L50-L67 - that isn't guaranteed to race everytime we run the test
13:03:40	stephenfin	lyarwood: okay, so dodgy test. I'll look into making it a more deterministic before we backport it
13:09:24	lyarwood	stephenfin: I've got a change locally to do that, I'll push after lunch
13:15:01	stephenfin	ack
13:38:13	openstackgerrit	Elod Illes proposed openstack/nova stable/rocky: libvirt: remove conditional on VIR_DOMAIN_EVENT_SUSPENDED_POSTCOPY https://review.opendev.org/711231
13:39:38	openstackgerrit	Elod Illes proposed openstack/nova stable/rocky: libvirt: check job status for VIR_DOMAIN_EVENT_SUSPENDED_MIGRATED event https://review.opendev.org/711233
13:40:03	openstackgerrit	Lee Yarwood proposed openstack/nova master: functional: Avoid race and fix use of self.api within test_bug_1831771 https://review.opendev.org/711211
13:40:08	lyarwood	stephenfin: ^ there you go
13:44:08	openstackgerrit	Lucian Petrut proposed openstack/nova master: hyper-v: update support matrix https://review.opendev.org/711234
13:45:40	openstackgerrit	Lucian Petrut proposed openstack/nova master: hyper-v: update support matrix https://review.opendev.org/711234
14:07:27	rishabhhpe	Hello All, When i am creating instance on a VM which is hosted on nodepool VM .. its not able to ping the DHCP IP and even gateway .. is there any way i can troubleshoot it .. i tried with kernel bridge but it is not working .. is there workarund for this ? as my tempest is failing due to this
14:09:25	openstackgerrit	Brin Zhang proposed openstack/nova master: Add new policy to PATCH update volume API https://review.opendev.org/711194
14:10:36	openstackgerrit	Brin Zhang proposed openstack/nova master: Add functional tests for PATCH volume attachments API https://review.opendev.org/710965
14:25:59	gibi	dansmith: I reviewd the first 3 cyborg integration patch. I still have concerns
14:26:13	dansmith	gibi: ack was just catching up
14:26:56	gibi	and I have to leave for today
14:27:19	gibi	will be off tomorrow but I will check back on Firday
14:28:21	gibi	I still left some comments and questions
14:28:27	lyarwood	stephenfin: https://review.opendev.org/#/c/666915/ - did you see my review here btw, I think it's just a docs nit really but I might be missing something.
14:36:58	redrobot	Hi Nova friends! I'm still looking for one more review on https://review.opendev.org/#/c/680562/
14:38:49	lyarwood	efried: https://review.opendev.org/#/c/669121/ - blast from the past but this should be good to land now if you have time to review again.
14:40:52	rishabhhpe	Hello All, can anyone please help me on above problem i raised
14:41:01	lyarwood	redrobot: The people in this channel don't directly control that project, #puppet-openstack is where you will find them. I've +1'd anyway.
14:41:51	redrobot	got it, thanks lyarwood!
14:58:50	openstackgerrit	Lee Yarwood proposed openstack/nova master: DNM - Test TEMPEST_EXTEND_ATTACHED_ENCRYPTED_VOLUME https://review.opendev.org/707593
15:25:01	lyarwood	https://review.opendev.org/#/c/711211/ - any non-RH cores able to review this fix, appears we are randomly hitting it in the gate at the moment.
15:26:58	stephenfin	lyarwood: yup, just hadn't gotten to it now. Will do so before EOD
15:27:03	stephenfin	*to it before now
15:27:26	lyarwood	stephenfin: ack np
15:27:48	openstackgerrit	Stephen Finucane proposed openstack/nova stable/train: Functional test for UnexpectedDeletingTaskStateError https://review.opendev.org/711210
15:27:48	openstackgerrit	Stephen Finucane proposed openstack/nova stable/train: Unplug VIFs as part of cleanup of networks https://review.opendev.org/711251
15:27:49	stephenfin	meanwhile, care to review these incoming patches? Have the affected functional and unit tests passing now
15:27:58	stephenfin	*those (bad timing)
15:28:10	lyarwood	yup of course
15:35:56	efried	lyarwood: If you want to tweak the commit message, I'll fast approve. If you want to twiddle some of those other things at the same time, ditto (none of them impact logic).
15:37:02	efried	lyarwood: gate fix +A
15:38:39	lyarwood	efried: thanks, I'll respin the LUKS compat change now.
15:40:45	efried	lyarwood: tbc, the only thing that *needs* to be fixed in the commit message is the name of the renamed helper function.
15:49:35	lyarwood	efried: ack I'll just update that quickly then
15:50:06	efried	lyarwood: ight. The other things (renames of test cases) could be done in a fup
15:50:08	openstackgerrit	Lee Yarwood proposed openstack/nova master: libvirt: Remove native LUKS compat code https://review.opendev.org/669121
15:50:54	efried	+A
16:04:46	openstackgerrit	Lee Yarwood proposed openstack/nova master: libvirt: FUP I41b7c1653c6a887ee4b08e588c5d422409aebfba https://review.opendev.org/711262
16:04:47	lyarwood	efried: ack thanks again
16:09:21	kukacz_	hello, any idea what might be wrong with instance being unshelved on a host ignoring AggregateInstanceExtraSpecsFilter ? it seems to only happen to instances created before the filtering params were applied on instance types.
16:19:19	dansmith	kukacz_: yeah, that's expected
16:19:41	dansmith	kukacz_: when you boot an instance the flavor is crystalized into the instance to insulate it from further changes to the flavor
16:23:47	openstackgerrit	Kashyap Chamarthy proposed openstack/nova master: libvirt: Parse the 'os' element from domainCapabilities https://review.opendev.org/673790
16:23:47	openstackgerrit	Kashyap Chamarthy proposed openstack/nova master: libvirt: Add methods to detect firmware auto-selection and SB https://review.opendev.org/682627
16:25:43	kukacz_	dansmith: aha. and is there some method how could I push flavor params to existing instances too?
16:25:54	dansmith	kukacz_: nope
16:26:07	dansmith	kukacz_: you could snapshot and then re-deploy them with the new flavor, but that's about it
16:31:17	kukacz_	dansmith: hmm, that's bad. then it seems I don't have a method to safely prevent non-ssd instances being scheduled on ssd node - thinking the classic example used in Nova docs for ages: https://docs.openstack.org/nova/queens/admin/configuration/schedulers.html
16:31:54	dansmith	kukacz_: nova is optimized for cattle, not pets
16:32:48	dansmith	if you're on something new enough you could potentially use the new isolated aggregates thing for your ssd aggregate
16:34:20	kukacz_	dansmith: just for my curiosity - how does the pets/cattle apply in this case?
16:34:52	dansmith	kukacz: it's a pet if you can't shoot it in the head and boot another one in its place
16:35:20	dansmith	https://docs.openstack.org/nova/latest/reference/isolate-aggregates.html
16:37:37	dansmith	also if you're willing to shelve/unshelve, you could just resize those instances to a flavor that has the new key in it
16:38:56	kukacz_	dansmith: unfortunately, this is queens. isolated aggregates seem to be from rocky
16:39:13	dansmith	train actually
16:39:53	kukacz_	dansmith: yes, the resize method is something I was just thinking of. probably a way to go. but it's not my workload. I'll have to ask many customers to follow that rule
16:40:03	dansmith	yup
16:50:48	kukacz_	dansmith: one more detail - how is the original set of flavor parameters stored for each instance? in nova.instances table I see instance_type_id pointing at the current flavor. it must be something else, I guess ...
16:51:23	dansmith	kukacz_: it's a serialized json blob in instance_extra.flavor
16:51:52	kukacz_	dansmith: aha!
16:51:59	kukacz_	dansmith: thank you a lot for all the clarification!
16:52:18	dansmith	kukacz_: how come you're willing to shelve something but not resize it? resize should be faster and less disturbing to the workload
16:54:24	kukacz_	dansmith: it's not problem of willingness to resize. it's just that our customers use shelving to pause billing on temporarily stopped instances. now we'll have to explain them, that they'll also need to issue resize call to avoid their instance end up running on hosts where we don't want them to be
16:55:09	dansmith	oh okay I thought maybe you were shelving proactively
16:56:19	openstackgerrit	Lee Yarwood proposed openstack/nova stable/train: libvirt: Ignore DiskNotFound during update_available_resource https://review.opendev.org/711276
16:57:06	openstackgerrit	Lee Yarwood proposed openstack/nova stable/stein: libvirt: Ignore DiskNotFound during update_available_resource https://review.opendev.org/711277

Earlier   Later