Earlier  
Later
New Search
Posted Nick Remark
#openstack-nova - 2020-01-31
17:14:30 efried stephenfin: jfyi although I opened an issue against blockdiag, I suspect it's possible the problem is in the monkeypatching in doc/source/conf.py
17:15:45 efried mm, maybe not, removing that didn't resolve. But I went and built docs in another repo that uses blockdiag (networking-bagpipe) and didn't have the same problem.
17:16:56 stephenfin efried: Looks like that project has had a lot of releases since so that monkeypatching probably isn't necessary any more. However, I'm not sure how it would affect things. What's the error?
17:17:09 openstackgerrit Mykola Yakovliev proposed openstack/nova master: Fix boot_roles in InstanceSystemMetadata https://review.opendev.org/698040
17:17:29 efried stephenfin: https://github.com/blockdiag/blockdiag/issues/126
17:18:11 stephenfin could you edit that comment so I can read it. Just indent everything by 4 or add ``` before and after the code blocks
17:18:30 stephenfin please and thanks :)
17:18:44 efried stephenfin: done
17:19:33 efried stephenfin: hm, I don't actually see blockdiag being *used* in our repo.
17:20:30 stephenfin neither do I, now that you say it
17:20:56 openstackgerrit Vladyslav Drok proposed openstack/nova master: Fix volume attachment rollback https://review.opendev.org/704847
17:21:13 efried stephenfin: except for a static svg
17:21:35 efried stephenfin: which I would have thought, since it was static, wouldn't affect anything... but we're also using the svg2pdfconverter
17:21:36 efried so maybe
17:21:45 stephenfin Remove it and see what happens? :)
17:21:51 efried remove the svg?
17:22:12 stephenfin Looks like da7e1ede9e73bf0e107b9b37954f204cea544439 may have remove the vestigial traces of blockdiag
17:22:17 stephenfin nah, the extension
17:22:39 efried ...
17:23:04 stephenfin We do use seqdiag
17:23:11 stephenfin but I think that's a different project
17:23:52 stephenfin yup, sure is
17:24:16 efried removing the rsvgconverter extension didn't resolve.
17:25:18 openstackgerrit Mykola Yakovliev proposed openstack/nova master: Fix boot_roles in InstanceSystemMetadata https://review.opendev.org/698040
17:28:22 openstackgerrit Mykola Yakovliev proposed openstack/nova master: Fix boot_roles in InstanceSystemMetadata https://review.opendev.org/698040
17:29:07 openstackgerrit Stephen Finucane proposed openstack/nova master: tests: Validate huge pages https://review.opendev.org/399653
17:30:29 openstackgerrit Mykola Yakovliev proposed openstack/nova master: Fix boot_roles in InstanceSystemMetadata https://review.opendev.org/698040
17:32:21 openstackgerrit Elod Illes proposed openstack/nova master: DNM: test whether 'logs' content is gzipped https://review.opendev.org/705256
17:32:27 efried stephenfin: hm, I also tried blacklisting in doc/requirements but that didn't work. ISTR something about upper-constraints overriding no matter what you do locally.
17:33:03 sean-k-mooney efried: is repoducing as simple as pull master and run tox -e docs locally
17:33:09 stephenfin sean-k-mooney: yup
17:33:42 stephenfin oh, okay, seqdiag uses blockdiag. Lovely
17:33:52 stephenfin as does actdiag
17:34:10 sean-k-mooney cool ill take a look while i wait for test to finish
17:34:26 sean-k-mooney ok it sould like we need a temproy cap then
17:35:18 stephenfin efried: Does that other project also use stestr, out of curiosity?
17:35:37 stephenfin actually, nvm
17:35:59 stephenfin this is docs, not tests
17:36:32 sean-k-mooney right we are invoking sphinx not stestr
17:37:44 stephenfin efried: This is the thing I introduced the monkeypatching to fix
17:37:53 sean-k-mooney we should just put blockdiag<2.0.0 in upper-constrats.txt
17:37:53 stephenfin I remember now. I bet they've moved some modules around
17:38:04 efried I tried to remove the monkeypatching and it didn't help
17:38:22 sean-k-mooney well they did a major version bump so likely
17:38:31 sean-k-mooney the just went form 1.5.4 to 2.0.0
17:38:32 dustinc efried: no, I probably won't be working on this further https://review.opendev.org/#/q/topic:bp/openstacksdk-in-nova+status:open
17:38:33 efried it looks to me like a bug in blockdiag itself, it's trying to get a BufferedReader's buffer.
17:39:12 efried dustinc: okay, I'm going to push the blueprint out of ussuri then.
17:40:53 openstackgerrit Merged openstack/nova stable/rocky: tox: Stop build *all* docs in 'docs' https://review.opendev.org/663888
17:41:02 openstackgerrit Elod Illes proposed openstack/nova master: DNM: test whether 'logs' content is gzipped https://review.opendev.org/705256
17:41:50 efried dustinc: You can abandon the changes I guess. If we find a new owner, we can restore them.
17:42:14 dustinc efried: will do, thanks
17:42:50 sean-k-mooney efried: it does not look like they change that code recently
17:43:25 efried dustinc: You're still driving the provider config changes for the near term though, right? Looks to me like the next action is to you, to rev based on gibi's comments. You agree?
17:43:44 dustinc efried: yes, but priority is low for me at the moment
17:43:59 efried okay. Please let me know if someone needs to take over.
17:46:40 stephenfin efried: done. patch coming
17:46:44 sean-k-mooney efried: it looks like the correct way to get the buffer would be to call getbuffer https://docs.python.org/3/library/io.html#io.BytesIO.getbuffer
17:47:09 efried stephenfin: cool. where?
17:47:26 efried in blockdiag or nova or...
17:47:29 stephenfin for us
17:47:38 stephenfin could be ages before blockdiag get their act together
17:48:01 efried okay, so I should leave the issue open there.
17:48:46 sean-k-mooney stephenfin: im goint to quickly just chagne the deference to the call to function call locally and see if that ifxes it
17:49:00 sean-k-mooney i assume that is what you are going to monky patch
17:49:06 sean-k-mooney or is it something else
17:50:05 efried also if you have reason to believe we no longer need the old monkey patches, could remove those.
17:50:10 efried separate patch
17:50:13 efried brb
17:50:52 stephenfin ack
17:51:06 openstackgerrit Stephen Finucane proposed openstack/nova master: docs: Fix the monkeypatching of blockdiag https://review.opendev.org/705263
17:53:19 openstackgerrit Stephen Finucane proposed openstack/nova master: docs: Fix the monkeypatching of blockdiag https://review.opendev.org/705263
17:56:33 efried stephenfin: tbc, will this ^ work with all versions of blockdiag?
17:56:44 stephenfin yeah, it's the more correct fix tbh
17:56:50 efried okay cool.
17:57:09 stephenfin per commit message, we were previously relying on an import through via module
17:57:13 stephenfin direct import, no problemo
17:58:19 sean-k-mooney stephenfin: so if i just comment out there replacement of the getreader form codec it just works
17:58:39 stephenfin sean-k-mooney: that's what I'm essentially doing
17:58:54 stephenfin and we should submit a patch to the project to fix that
17:59:04 sean-k-mooney ya im runing there tests now
17:59:07 stephenfin but the reason we monkeypatched this in the first place was that the project was on life-support
17:59:23 efried I'll just validate it locally with a couple versions and then fast approve
17:59:42 stephenfin looks like it's revived now so we can hopefully fix it there and bump our minimum to 2.0.1 or whatever
18:07:29 stephenfin efried: I'm not going to bother respinning those since hopefully the fixup patches from sean-k-mooney and I will resolve them pretty soon
18:07:33 stephenfin and if they don't, who cares
18:08:29 efried not I, until the next time it breaks :P
18:08:36 sean-k-mooney ignoring one test failure that they have on there master branch it passes there test so im going to submit a pull request to blockdiag
19:16:44 cmurphy lbragstad: could you help sanity check https://review.opendev.org/#/c/676682/6/nova/policies/admin_actions.py
19:38:05 efried stephenfin: Sending the blockdiag patch. Sorry for the delay, had some distractions. Do you want to fup to fix those links?
19:57:04 lbragstad cmurphy is the question about where the deprecation should live?
19:59:46 openstackgerrit Sundar Nadathur proposed openstack/nova master: ksa auth conf and client for Cyborg access https://review.opendev.org/631242
19:59:47 openstackgerrit Sundar Nadathur proposed openstack/nova master: Add Cyborg device profile groups to request spec. https://review.opendev.org/631243
19:59:47 openstackgerrit Sundar Nadathur proposed openstack/nova master: Define Cyborg ARQ binding notification event. https://review.opendev.org/692707
19:59:48 openstackgerrit Sundar Nadathur proposed openstack/nova master: Create and bind Cyborg ARQs. https://review.opendev.org/631244
19:59:48 openstackgerrit Sundar Nadathur proposed openstack/nova master: Pass accelerator requests to each virt driver from compute manager. https://review.opendev.org/698581
19:59:49 openstackgerrit Sundar Nadathur proposed openstack/nova master: Compose accelerator PCI devices into domain XML in libvirt driver. https://review.opendev.org/631245
19:59:49 openstackgerrit Sundar Nadathur proposed openstack/nova master: Delete ARQs for an instance when the instance is deleted. https://review.opendev.org/673735
19:59:50 openstackgerrit Sundar Nadathur proposed openstack/nova master: Enable hard/soft reboot with accelerators. https://review.opendev.org/697940
19:59:50 openstackgerrit Sundar Nadathur proposed openstack/nova master: Enable start/stop of instances with accelerators. https://review.opendev.org/699553

Earlier   Later