Earlier  
Later
New Search
Posted Nick Remark
#openstack-nova - 2020-01-31
17:46:44 sean-k-mooney efried: it looks like the correct way to get the buffer would be to call getbuffer https://docs.python.org/3/library/io.html#io.BytesIO.getbuffer
17:47:09 efried stephenfin: cool. where?
17:47:26 efried in blockdiag or nova or...
17:47:29 stephenfin for us
17:47:38 stephenfin could be ages before blockdiag get their act together
17:48:01 efried okay, so I should leave the issue open there.
17:48:46 sean-k-mooney stephenfin: im goint to quickly just chagne the deference to the call to function call locally and see if that ifxes it
17:49:00 sean-k-mooney i assume that is what you are going to monky patch
17:49:06 sean-k-mooney or is it something else
17:50:05 efried also if you have reason to believe we no longer need the old monkey patches, could remove those.
17:50:10 efried separate patch
17:50:13 efried brb
17:50:52 stephenfin ack
17:51:06 openstackgerrit Stephen Finucane proposed openstack/nova master: docs: Fix the monkeypatching of blockdiag https://review.opendev.org/705263
17:53:19 openstackgerrit Stephen Finucane proposed openstack/nova master: docs: Fix the monkeypatching of blockdiag https://review.opendev.org/705263
17:56:33 efried stephenfin: tbc, will this ^ work with all versions of blockdiag?
17:56:44 stephenfin yeah, it's the more correct fix tbh
17:56:50 efried okay cool.
17:57:09 stephenfin per commit message, we were previously relying on an import through via module
17:57:13 stephenfin direct import, no problemo
17:58:19 sean-k-mooney stephenfin: so if i just comment out there replacement of the getreader form codec it just works
17:58:39 stephenfin sean-k-mooney: that's what I'm essentially doing
17:58:54 stephenfin and we should submit a patch to the project to fix that
17:59:04 sean-k-mooney ya im runing there tests now
17:59:07 stephenfin but the reason we monkeypatched this in the first place was that the project was on life-support
17:59:23 efried I'll just validate it locally with a couple versions and then fast approve
17:59:42 stephenfin looks like it's revived now so we can hopefully fix it there and bump our minimum to 2.0.1 or whatever
18:07:29 stephenfin efried: I'm not going to bother respinning those since hopefully the fixup patches from sean-k-mooney and I will resolve them pretty soon
18:07:33 stephenfin and if they don't, who cares
18:08:29 efried not I, until the next time it breaks :P
18:08:36 sean-k-mooney ignoring one test failure that they have on there master branch it passes there test so im going to submit a pull request to blockdiag
19:16:44 cmurphy lbragstad: could you help sanity check https://review.opendev.org/#/c/676682/6/nova/policies/admin_actions.py
19:38:05 efried stephenfin: Sending the blockdiag patch. Sorry for the delay, had some distractions. Do you want to fup to fix those links?
19:57:04 lbragstad cmurphy is the question about where the deprecation should live?
19:59:46 openstackgerrit Sundar Nadathur proposed openstack/nova master: ksa auth conf and client for Cyborg access https://review.opendev.org/631242
19:59:47 openstackgerrit Sundar Nadathur proposed openstack/nova master: Add Cyborg device profile groups to request spec. https://review.opendev.org/631243
19:59:47 openstackgerrit Sundar Nadathur proposed openstack/nova master: Define Cyborg ARQ binding notification event. https://review.opendev.org/692707
19:59:48 openstackgerrit Sundar Nadathur proposed openstack/nova master: Create and bind Cyborg ARQs. https://review.opendev.org/631244
19:59:48 openstackgerrit Sundar Nadathur proposed openstack/nova master: Pass accelerator requests to each virt driver from compute manager. https://review.opendev.org/698581
19:59:49 openstackgerrit Sundar Nadathur proposed openstack/nova master: Compose accelerator PCI devices into domain XML in libvirt driver. https://review.opendev.org/631245
19:59:49 openstackgerrit Sundar Nadathur proposed openstack/nova master: Delete ARQs for an instance when the instance is deleted. https://review.opendev.org/673735
19:59:50 openstackgerrit Sundar Nadathur proposed openstack/nova master: Enable hard/soft reboot with accelerators. https://review.opendev.org/697940
19:59:50 openstackgerrit Sundar Nadathur proposed openstack/nova master: Enable start/stop of instances with accelerators. https://review.opendev.org/699553
19:59:51 openstackgerrit Sundar Nadathur proposed openstack/nova master: Enable and use COMPUTE_ACCELERATORS trait. https://review.opendev.org/699554
19:59:51 openstackgerrit Sundar Nadathur proposed openstack/nova master: Bump compute rpcapi version and reduce Cyborg calls. https://review.opendev.org/704227
19:59:52 openstackgerrit Sundar Nadathur proposed openstack/nova master: Add cyborg tempest job. https://review.opendev.org/670999
20:53:28 openstackgerrit Merged openstack/nova master: docs: Fix the monkeypatching of blockdiag https://review.opendev.org/705263
21:13:46 cmurphy lbragstad: yes basically
#openstack-nova - 2020-02-01
10:03:36 openstackgerrit Brin Zhang proposed openstack/nova master: Populate 'updated_at' when aggregate is updated https://review.opendev.org/580271
19:43:42 openstackgerrit Sundar Nadathur proposed openstack/nova master: Enable and use COMPUTE_ACCELERATORS trait. https://review.opendev.org/699554
19:43:42 openstackgerrit Sundar Nadathur proposed openstack/nova master: Bump compute rpcapi version and reduce Cyborg calls. https://review.opendev.org/704227
19:43:43 openstackgerrit Sundar Nadathur proposed openstack/nova master: Add cyborg tempest job. https://review.opendev.org/670999
22:11:36 openstackgerrit Elod Illes proposed openstack/nova master: DNM: test whether 'logs' content is gzipped https://review.opendev.org/705256
#openstack-nova - 2020-02-03
06:13:31 brinzhang gibi: can you restore these https://review.opendev.org/#/q/status:abandoned+project:openstack/nova+branch:master+topic:bp/action-event-fault-details, if not, I will complete this BP based on these, otherwise I will need to resubmit, but it is very similar.
06:14:03 brinzhang gibi: s/if not/""/
06:15:24 brinzhang alex_xu: and you also can restore these.
06:15:37 brinzhang gibi, alex_xu: thanks.
09:31:48 openstackgerrit Sundar Nadathur proposed openstack/nova master: ksa auth conf and client for Cyborg access https://review.opendev.org/631242
09:31:48 openstackgerrit Sundar Nadathur proposed openstack/nova master: Add Cyborg device profile groups to request spec. https://review.opendev.org/631243
09:31:49 openstackgerrit Sundar Nadathur proposed openstack/nova master: Define Cyborg ARQ binding notification event. https://review.opendev.org/692707
09:31:49 openstackgerrit Sundar Nadathur proposed openstack/nova master: Create and bind Cyborg ARQs. https://review.opendev.org/631244
09:31:50 openstackgerrit Sundar Nadathur proposed openstack/nova master: Pass accelerator requests to each virt driver from compute manager. https://review.opendev.org/698581
09:31:50 openstackgerrit Sundar Nadathur proposed openstack/nova master: Compose accelerator PCI devices into domain XML in libvirt driver. https://review.opendev.org/631245
09:31:51 openstackgerrit Sundar Nadathur proposed openstack/nova master: Delete ARQs for an instance when the instance is deleted. https://review.opendev.org/673735
09:31:51 openstackgerrit Sundar Nadathur proposed openstack/nova master: Enable hard/soft reboot with accelerators. https://review.opendev.org/697940
09:31:52 openstackgerrit Sundar Nadathur proposed openstack/nova master: Enable start/stop of instances with accelerators. https://review.opendev.org/699553
09:31:52 openstackgerrit Sundar Nadathur proposed openstack/nova master: Enable and use COMPUTE_ACCELERATORS trait. https://review.opendev.org/699554
09:31:53 openstackgerrit Sundar Nadathur proposed openstack/nova master: Bump compute rpcapi version and reduce Cyborg calls. https://review.opendev.org/704227
09:31:53 openstackgerrit Sundar Nadathur proposed openstack/nova master: Add cyborg tempest job. https://review.opendev.org/670999
09:52:40 openstackgerrit Sundar Nadathur proposed openstack/nova master: Enable and use COMPUTE_ACCELERATORS trait. https://review.opendev.org/699554
09:52:40 openstackgerrit Sundar Nadathur proposed openstack/nova master: Bump compute rpcapi version and reduce Cyborg calls. https://review.opendev.org/704227
09:52:41 openstackgerrit Sundar Nadathur proposed openstack/nova master: Add cyborg tempest job. https://review.opendev.org/670999
10:49:16 openstackgerrit Balazs Gibizer proposed openstack/nova master: Remove extra instance.save() calls related to qos SRIOV ports https://review.opendev.org/702261
10:50:48 openstackgerrit Balazs Gibizer proposed openstack/nova master: Use common server create function for qos func tests https://review.opendev.org/701353
10:52:20 openstackgerrit Balazs Gibizer proposed openstack/nova master: Enable live migration with qos ports https://review.opendev.org/699066
10:55:26 openstackgerrit Balazs Gibizer proposed openstack/nova master: Support unshelve with qos ports https://review.opendev.org/704759
11:28:47 openstackgerrit Balazs Gibizer proposed openstack/nova master: Reduce gen conflict in COMPUTE_STATUS_DISABLED handling https://review.opendev.org/704866
12:36:04 openstackgerrit Balazs Gibizer proposed openstack/nova master: Support unshelve with qos ports https://review.opendev.org/704759
13:01:47 openstackgerrit Huachang Wang proposed openstack/nova master: metadata: export the vCPU IDs that are pinning on the host CPUs https://review.opendev.org/688936
13:01:48 openstackgerrit Huachang Wang proposed openstack/nova master: Create 'mixed' instance from PCPU and VCPU resources https://review.opendev.org/705437
13:05:42 openstackgerrit Huachang Wang proposed openstack/nova master: [WIP] Create 'mixed' instance from PCPU and VCPU resources https://review.opendev.org/705437
13:05:42 openstackgerrit Huachang Wang proposed openstack/nova master: [WIP] metadata: export the vCPU IDs that are pinning on the host CPUs https://review.opendev.org/688936
14:02:23 rlljorge Hi folks, some chance some one look for : https://bugs.launchpad.net/nova/+bug/1860739
14:02:23 openstack Launchpad bug 1860739 in OpenStack Compute (nova) "Cinder backup failed for restore volume snapshot (for instance snapshot)" [Undecided,Confirmed]
14:07:03 stephenfin bauzas: Think you could keep marching through this today? https://review.opendev.org/#/c/697155/
14:07:17 bauzas stephenfin: lemme try
14:07:32 stephenfin ta. lmk if you've any questions
14:08:52 sean-k-mooney stephenfin: do you need me to take a look at that seriese too or will i leave it to bauzas et al
14:09:19 sean-k-mooney thats the nova net begone series right
14:09:20 bauzas sean-k-mooney: you can surely review them if you want
14:09:37 bauzas I'm not really a nova-net expert so having more eyes is better
14:09:42 stephenfin I will never turn down reviewers
14:10:01 bauzas any review is helpful FWIW
14:10:25 sean-k-mooney well basically im just going to double check the commit message and the code make sense and you are not breaking the neutorn path
14:10:37 bauzas even if I (sometimes/always/somehow/pick the one you prefer) disagree with the review and associated comments
14:11:51 sean-k-mooney stephenfin: by the way once this is complete i want to do a pass over os-vif to delete the nova-net only bits
14:13:17 sean-k-mooney we have a few object fields that i think are only there for nova-net so i want to deprecate them and then likely remove them early in V although we could maybe do it in u. time will tell.
14:14:11 sean-k-mooney things like this https://github.com/openstack/os-vif/blob/master/os_vif/objects/network.py#L33
14:14:36 sean-k-mooney the multi_host flag is for nova networks and i dont think we ever use it in os-vif
14:15:30 sean-k-mooney ok we technically do but only in the linux bridge driver and even so only with nova-networks https://github.com/openstack/os-vif/blob/1e4cf6160efc7fb4fd8279bd2a666e4d72f4fb6c/vif_plug_linux_bridge/linux_bridge.py#L101

Earlier   Later