Posted	Nick	Remark
#openstack-nova - 2020-01-22
23:33:18	lucidguy	Things to think about. Thanks again. Have to run. Wife is hating me. heh
23:33:31	sean-k-mooney	https://www.kernel.org/category/releases.html
23:33:37	sean-k-mooney	no worries o/
23:34:50	lucidguy	I guess I should start by updating my local repo and giving 4.19 a try. Sadly I'm not optimistic of the outcome.
23:35:11	lucidguy	have a good one
23:55:21	efried	jroll: we had talked vaguely about you being involved in the development of the CI, so I thought to involve you in that conversation :)
#openstack-nova - 2020-01-23
08:31:30	openstackgerrit	Merged openstack/nova master: Func test for failed and aborted live migration https://review.opendev.org/699065
08:31:36	openstackgerrit	Merged openstack/nova master: Remove unused code https://review.opendev.org/703408
09:27:23	openstackgerrit	Stephen Finucane proposed openstack/nova master: Remove remaining Python 2.7-only dependencies https://review.opendev.org/698895
09:33:54	openstackgerrit	Stephen Finucane proposed openstack/nova master: nova-net: Update API reference guide https://review.opendev.org/703796
09:33:54	openstackgerrit	Stephen Finucane proposed openstack/nova master: Remove 'nova.image.api' module https://review.opendev.org/702451
09:33:55	openstackgerrit	Stephen Finucane proposed openstack/nova master: WIP: nova-net: Remove unused nova-network objects https://review.opendev.org/697156
11:21:15	openstackgerrit	Merged openstack/nova master: Switch to hacking 2.x https://review.opendev.org/695733
11:21:20	openstackgerrit	Merged openstack/nova master: requirements: Limit hacking to one minor version https://review.opendev.org/703405
11:32:52	openstackgerrit	Stephen Finucane proposed openstack/nova master: nova-net: Remove unused nova-network objects https://review.opendev.org/697156
11:32:53	openstackgerrit	Stephen Finucane proposed openstack/nova master: nova-net: Remove unnecessary exception handling https://review.opendev.org/703973
11:32:53	openstackgerrit	Stephen Finucane proposed openstack/nova master: nova-net: Remove unused parameters https://review.opendev.org/703974
11:34:09	stephenfin	dansmith: I'm doing possibly bad stuff with objects in https://review.opendev.org/697156. I _think_ it's okay but would appreciate your input when you're around
11:34:34	stephenfin	dansmith: Also want to figure out how to move objects between projects (nova -> os-vif) since that's seems like an obvious thing to do in that case
11:34:42	stephenfin	sean-k-mooney: Maybe relevant, idk ^
11:43:47	sean-k-mooney	we should not move the network object to os-vif
11:43:53	sean-k-mooney	we already have one
11:44:43	sean-k-mooney	the os vif objects are constucted from info often taken form the nova ones but they are not the same objects
11:57:19	stephenfin	sean-k-mooney: Damn. Okay, maybe you can figure out what's going on. Fancy pulling down the earlier version of that change along with this patch for o.vo https://review.opendev.org/#/c/703970/ ?
11:58:05	gibi	kashyap: rng patch looks good to me, thanks for the update
11:58:20	lucidguy	sean-k-mooney: The only option I see regarding hugepages is reserved_huge_pages. Is that what you were talking about?
11:58:24	stephenfin	If you install that version of the o.vo in the venv and run 'tox -e py36 -- -n nova/tests/unit/objects/test_objects.py::TestObjectVersions.test_obj_make_compatible', it'll fail saying it can't find the 'Network' object
11:58:42	sean-k-mooney	stephenfin: i know dansmith found that the namespace stuff does not seam to be working properly
11:59:29	stephenfin	did he now?
11:59:38	stephenfin	any notes or bugs on that?
11:59:55	sean-k-mooney	lucidguy: no, hugepages is a afeature that is enabled in the flavor/image by setting hw:mem_page_size=large
12:00:38	sean-k-mooney	reserved_huge_pages is intended to allow you say that some of the hugepages on the host are reserved for host use and cannot be used by vms
12:01:00	sean-k-mooney	stephenfin: it cam up on one of his patch let me see if it merged or not
12:01:02	lucidguy	sean-k-mooney: Understood
12:01:25	sean-k-mooney	stephenfin: https://review.opendev.org/#/c/702049/
12:01:33	sean-k-mooney	the ephemeral object patch
12:02:45	sean-k-mooney	stephenfin: line 1175 https://review.opendev.org/#/c/702049/4/nova/tests/unit/objects/test_objects.py
12:03:26	sean-k-mooney	lucidguy: i think these are the docs on hugepage that you want https://docs.openstack.org/nova/latest/admin/huge-pages.html
12:03:47	sean-k-mooney	lucidguy: we have summit presintaion on this too that stephenfin did
12:04:58	lucidguy	I was just looking at that link
12:05:02	lucidguy	Cool
12:07:28	kashyap	gibi: Hi, thanks for looking!
12:09:05	kashyap	gibi: Want me to respin removing the stray word "this"?
12:09:37	gibi	kashyap: if you respin quickly then I can re +2 it. but I'm fine merging the patch as is
12:09:38	sean-k-mooney	stephenfin: i think you need to update https://github.com/openstack/nova/blob/master/nova/tests/unit/objects/test_objects.py#L1225
12:09:58	stephenfin	sean-k-mooney: incoming :)
12:10:25	openstackgerrit	Stephen Finucane proposed openstack/nova master: nova-net: Make the security group API a module https://review.opendev.org/696746
12:10:26	openstackgerrit	Stephen Finucane proposed openstack/nova master: nova-net: Remove remaining nova-network quotas https://review.opendev.org/697152
12:10:26	openstackgerrit	Stephen Finucane proposed openstack/nova master: nova-net: Remove use of legacy 'FloatingIP' object https://review.opendev.org/697153
12:10:27	openstackgerrit	Stephen Finucane proposed openstack/nova master: nova-net: Remove use of legacy 'Network' object https://review.opendev.org/697154
12:10:27	openstackgerrit	Stephen Finucane proposed openstack/nova master: nova-net: Remove use of legacy 'SecurityGroup' object https://review.opendev.org/697155
12:10:28	openstackgerrit	Stephen Finucane proposed openstack/nova master: nova-net: Remove now unnecessary nova-net workaround https://review.opendev.org/702440
12:10:28	openstackgerrit	Stephen Finucane proposed openstack/nova master: nova-net: Update API reference guide https://review.opendev.org/703796
12:10:29	openstackgerrit	Stephen Finucane proposed openstack/nova master: Remove 'nova.image.api' module https://review.opendev.org/702451
12:10:29	openstackgerrit	Stephen Finucane proposed openstack/nova master: nova-net: Remove unnecessary exception handling https://review.opendev.org/703973
12:10:30	openstackgerrit	Stephen Finucane proposed openstack/nova master: nova-net: Remove unused parameters https://review.opendev.org/703974
12:10:30	openstackgerrit	Stephen Finucane proposed openstack/nova master: nova-net: Remove unused nova-network objects https://review.opendev.org/697156
12:10:34	sean-k-mooney	stephenfin: change base.NovaObjectRegistry.obj_classes() to call get_nova_objects https://github.com/openstack/nova/blob/master/nova/tests/unit/objects/test_objects.py#L1159
12:10:36	stephenfin	you b*****
12:10:39	stephenfin	gdi git
12:10:42	stephenfin	:(
12:11:06	sean-k-mooney	so it only compares the version of hte nova object not also the os-vif ones
12:11:18	sean-k-mooney	that is why you are having issues with the network object
12:11:30	stephenfin	Yup, makes sense. Thanks :)
12:11:33	stephenfin	Should be fixed now
12:11:42	sean-k-mooney	along with a rebase :P
12:12:24	stephenfin	I tab-completed 'git rebase --committer-date-is-author-date' instead of 'git rebase --continue' :(
12:12:32	stephenfin	(had already finished the rebase)
12:12:55	sean-k-mooney	ah ok
12:13:19	sean-k-mooney	well you could also delete the nova network object now right?
12:13:30	stephenfin	yup, done https://review.opendev.org/#/c/697156/25/nova/objects/network.py
12:13:30	sean-k-mooney	or is there still nova code using that
12:13:53	sean-k-mooney	oh then you missed removing it form the object versions
12:14:20	openstackgerrit	Stephen Finucane proposed openstack/nova master: nova-net: Remove unused nova-network objects https://review.opendev.org/697156
12:14:22	stephenfin	whoops
12:14:22	sean-k-mooney	line 1102 https://review.opendev.org/#/c/697156/25/nova/tests/unit/objects/test_objects.py
12:14:26	stephenfin	ta
12:14:54	sean-k-mooney	the thing that uses that might also need the get_nova_object change
12:15:11	stephenfin	If it doesn't, it's not obvious
12:15:18	stephenfin	as in there are no tests failing fwict
12:16:11	sean-k-mooney	ya so the issue is all this stuff was set up befor namespaces were added to ovos
12:16:34	sean-k-mooney	so it was really not expecting ot have two object with the same name but be in differne namespaces
12:17:31	jroll	efried: cool, thanks, just wanted to make sure you weren't waiting on me for something in particular there :)
12:18:02	openstackgerrit	Kashyap Chamarthy proposed openstack/nova master: libvirt: Add a default VirtIO-RNG device to guests https://review.opendev.org/616603
12:18:04	kashyap	gibi: --^ Done
12:19:04	gibi	kashyap: thanks, +2
12:19:41	gibi	stephenfin: if you have time there is an easy patch to +2 https://review.opendev.org/616603
12:22:17	stephenfin	kashyap: If you can you address my nit on the releasenote, I'm +2
12:22:25	stephenfin	gibi too ^
12:23:04	kashyap	stephenfin: Yeah, I already hesitated about that first bit. As the URL will take care
12:23:09	kashyap	Let me do it real quick
12:25:03	openstackgerrit	Kashyap Chamarthy proposed openstack/nova master: libvirt: Add a default VirtIO-RNG device to guests https://review.opendev.org/616603
12:25:24	stephenfin	ta. +2
12:25:25	kashyap	Alright, fixed the reno.
12:26:55	kashyap	gibi: Your patient wait is over :D
12:27:30	gibi	done
12:27:52	gibi	today something is wrong with my uplink
12:31:01	openstackgerrit	Balazs Gibizer proposed openstack/nova stable/stein: Mask the token used to allow access to consoles https://review.opendev.org/702181
12:31:18	gibi	elod: fixed your comments in ^^
12:37:21	sean-k-mooney	stephenfin: have you seen issues with nova.tests.functional.test_nova_manage.TestDBArchiveDeletedRowsMultiCell failing out of interest?

Earlier   Later