| Posted | Nick | Remark | |
|---|---|---|---|
| #openstack-nova - 2020-01-23 | |||
| 11:59:55 | sean-k-mooney | lucidguy: no, hugepages is a afeature that is enabled in the flavor/image by setting hw:mem_page_size=large | |
| 12:00:38 | sean-k-mooney | reserved_huge_pages is intended to allow you say that some of the hugepages on the host are reserved for host use and cannot be used by vms | |
| 12:01:00 | sean-k-mooney | stephenfin: it cam up on one of his patch let me see if it merged or not | |
| 12:01:02 | lucidguy | sean-k-mooney: Understood | |
| 12:01:25 | sean-k-mooney | stephenfin: https://review.opendev.org/#/c/702049/ | |
| 12:01:33 | sean-k-mooney | the ephemeral object patch | |
| 12:02:45 | sean-k-mooney | stephenfin: line 1175 https://review.opendev.org/#/c/702049/4/nova/tests/unit/objects/test_objects.py | |
| 12:03:26 | sean-k-mooney | lucidguy: i think these are the docs on hugepage that you want https://docs.openstack.org/nova/latest/admin/huge-pages.html | |
| 12:03:47 | sean-k-mooney | lucidguy: we have summit presintaion on this too that stephenfin did | |
| 12:04:58 | lucidguy | I was just looking at that link | |
| 12:05:02 | lucidguy | Cool | |
| 12:07:28 | kashyap | gibi: Hi, thanks for looking! | |
| 12:09:05 | kashyap | gibi: Want me to respin removing the stray word "this"? | |
| 12:09:37 | gibi | kashyap: if you respin quickly then I can re +2 it. but I'm fine merging the patch as is | |
| 12:09:38 | sean-k-mooney | stephenfin: i think you need to update https://github.com/openstack/nova/blob/master/nova/tests/unit/objects/test_objects.py#L1225 | |
| 12:09:58 | stephenfin | sean-k-mooney: incoming :) | |
| 12:10:25 | openstackgerrit | Stephen Finucane proposed openstack/nova master: nova-net: Make the security group API a module https://review.opendev.org/696746 | |
| 12:10:26 | openstackgerrit | Stephen Finucane proposed openstack/nova master: nova-net: Remove remaining nova-network quotas https://review.opendev.org/697152 | |
| 12:10:26 | openstackgerrit | Stephen Finucane proposed openstack/nova master: nova-net: Remove use of legacy 'FloatingIP' object https://review.opendev.org/697153 | |
| 12:10:27 | openstackgerrit | Stephen Finucane proposed openstack/nova master: nova-net: Remove use of legacy 'Network' object https://review.opendev.org/697154 | |
| 12:10:27 | openstackgerrit | Stephen Finucane proposed openstack/nova master: nova-net: Remove use of legacy 'SecurityGroup' object https://review.opendev.org/697155 | |
| 12:10:28 | openstackgerrit | Stephen Finucane proposed openstack/nova master: nova-net: Remove now unnecessary nova-net workaround https://review.opendev.org/702440 | |
| 12:10:28 | openstackgerrit | Stephen Finucane proposed openstack/nova master: nova-net: Update API reference guide https://review.opendev.org/703796 | |
| 12:10:29 | openstackgerrit | Stephen Finucane proposed openstack/nova master: Remove 'nova.image.api' module https://review.opendev.org/702451 | |
| 12:10:29 | openstackgerrit | Stephen Finucane proposed openstack/nova master: nova-net: Remove unnecessary exception handling https://review.opendev.org/703973 | |
| 12:10:30 | openstackgerrit | Stephen Finucane proposed openstack/nova master: nova-net: Remove unused parameters https://review.opendev.org/703974 | |
| 12:10:30 | openstackgerrit | Stephen Finucane proposed openstack/nova master: nova-net: Remove unused nova-network objects https://review.opendev.org/697156 | |
| 12:10:34 | sean-k-mooney | stephenfin: change base.NovaObjectRegistry.obj_classes() to call get_nova_objects https://github.com/openstack/nova/blob/master/nova/tests/unit/objects/test_objects.py#L1159 | |
| 12:10:36 | stephenfin | you b***** | |
| 12:10:39 | stephenfin | gdi git | |
| 12:10:42 | stephenfin | :( | |
| 12:11:06 | sean-k-mooney | so it only compares the version of hte nova object not also the os-vif ones | |
| 12:11:18 | sean-k-mooney | that is why you are having issues with the network object | |
| 12:11:30 | stephenfin | Yup, makes sense. Thanks :) | |
| 12:11:33 | stephenfin | Should be fixed now | |
| 12:11:42 | sean-k-mooney | along with a rebase :P | |
| 12:12:24 | stephenfin | I tab-completed 'git rebase --committer-date-is-author-date' instead of 'git rebase --continue' :( | |
| 12:12:32 | stephenfin | (had already finished the rebase) | |
| 12:12:55 | sean-k-mooney | ah ok | |
| 12:13:19 | sean-k-mooney | well you could also delete the nova network object now right? | |
| 12:13:30 | stephenfin | yup, done https://review.opendev.org/#/c/697156/25/nova/objects/network.py | |
| 12:13:30 | sean-k-mooney | or is there still nova code using that | |
| 12:13:53 | sean-k-mooney | oh then you missed removing it form the object versions | |
| 12:14:20 | openstackgerrit | Stephen Finucane proposed openstack/nova master: nova-net: Remove unused nova-network objects https://review.opendev.org/697156 | |
| 12:14:22 | stephenfin | whoops | |
| 12:14:22 | sean-k-mooney | line 1102 https://review.opendev.org/#/c/697156/25/nova/tests/unit/objects/test_objects.py | |
| 12:14:26 | stephenfin | ta | |
| 12:14:54 | sean-k-mooney | the thing that uses that might also need the get_nova_object change | |
| 12:15:11 | stephenfin | If it doesn't, it's not obvious | |
| 12:15:18 | stephenfin | as in there are no tests failing fwict | |
| 12:16:11 | sean-k-mooney | ya so the issue is all this stuff was set up befor namespaces were added to ovos | |
| 12:16:34 | sean-k-mooney | so it was really not expecting ot have two object with the same name but be in differne namespaces | |
| 12:17:31 | jroll | efried: cool, thanks, just wanted to make sure you weren't waiting on me for something in particular there :) | |
| 12:18:02 | openstackgerrit | Kashyap Chamarthy proposed openstack/nova master: libvirt: Add a default VirtIO-RNG device to guests https://review.opendev.org/616603 | |
| 12:18:04 | kashyap | gibi: --^ Done | |
| 12:19:04 | gibi | kashyap: thanks, +2 | |
| 12:19:41 | gibi | stephenfin: if you have time there is an easy patch to +2 https://review.opendev.org/616603 | |
| 12:22:17 | stephenfin | kashyap: If you can you address my nit on the releasenote, I'm +2 | |
| 12:22:25 | stephenfin | gibi too ^ | |
| 12:23:04 | kashyap | stephenfin: Yeah, I already hesitated about that first bit. As the URL will take care | |
| 12:23:09 | kashyap | Let me do it real quick | |
| 12:25:03 | openstackgerrit | Kashyap Chamarthy proposed openstack/nova master: libvirt: Add a default VirtIO-RNG device to guests https://review.opendev.org/616603 | |
| 12:25:24 | stephenfin | ta. +2 | |
| 12:25:25 | kashyap | Alright, fixed the reno. | |
| 12:26:55 | kashyap | gibi: Your patient wait is over :D | |
| 12:27:30 | gibi | done | |
| 12:27:52 | gibi | today something is wrong with my uplink | |
| 12:31:01 | openstackgerrit | Balazs Gibizer proposed openstack/nova stable/stein: Mask the token used to allow access to consoles https://review.opendev.org/702181 | |
| 12:31:18 | gibi | elod: fixed your comments in ^^ | |
| 12:37:21 | sean-k-mooney | stephenfin: have you seen issues with nova.tests.functional.test_nova_manage.TestDBArchiveDeletedRowsMultiCell failing out of interest? | |
| 12:37:34 | stephenfin | I haven't paid attention to it, no | |
| 12:38:19 | sean-k-mooney | ok i was wondering if that was the failing db test ye were talking about yesterday | |
| 12:38:22 | sean-k-mooney | i guess not | |
| 12:39:45 | elod | gibi: thx, looking | |
| 12:54:37 | stephenfin | sean-k-mooney: Don't know if I showed this to you before Xmas or not https://github.com/testing-cabal/subunit/pull/40 | |
| 12:55:36 | stephenfin | I don't understand Python's IO model well enough to come up with better, but that fixed things for me for https://review.opendev.org/#/c/682111/ anyway | |
| 12:55:59 | stephenfin | whoops | |
| 12:55:59 | sean-k-mooney | you did not but ill take a look at both | |
| 12:56:12 | stephenfin | https://review.opendev.org/#/c/700522/ | |
| 12:56:49 | sean-k-mooney | why are you importing the print fucntion explcitly | |
| 12:56:57 | sean-k-mooney | are you using py26 lol | |
| 12:57:38 | sean-k-mooney | you can still do that but it was never needed in py27 | |
| 12:58:19 | stephenfin | it definitely is/was :) | |
| 12:58:37 | sean-k-mooney | but ya does that work | |
| 12:58:45 | stephenfin | to use the 'file=foo' thing, anyway | |
| 12:58:58 | sean-k-mooney | oh ya that is python3 only | |
| 12:59:06 | stephenfin | 'zactly | |
| 12:59:20 | sean-k-mooney | but again nova has droped python 2 support so :P | |
| 12:59:36 | stephenfin | so that nova patch just prints a load of junk that overwhelms subunit | |
| 12:59:46 | stephenfin | without my subunit change, it craps out with the subunit parser error | |
| 12:59:55 | stephenfin | with it, it still craps out but with a proper error | |
| 13:00:04 | jawad_axd | Quick question guys: What does cpu allocation 2.0 means ? Is it 2:1? | |
| 13:00:16 | stephenfin | saying the packet is > 4k (I think) | |
| 13:01:06 | jawad_axd | and it is safe to change cpu allocation ratio in running environment? | |
| 13:01:14 | stephenfin | sorry, 4M https://github.com/testing-cabal/subunit/blob/master/python/subunit/v2.py#L202-L208 | |
| 13:01:43 | stephenfin | jawad_axd: yup, 2:1 (20 enabled host CPUs = 40 VCPU inventory) | |
| 13:02:18 | stephenfin | jawad_axd: It should be safe to change so long as you don't lower it to the point that there's less inventory available than you have used | |
| 13:02:56 | stephenfin | I'm not actually sure what would happen then. I assume the periodic task to update placement's inventory would start failing | |
| 13:03:18 | stephenfin | easily tested in a pre-prod environment :) | |
| 13:03:41 | sean-k-mooney | stephenfin: ok well if we have a repoducer that means we have a chance of fixing it | |