| Posted | Nick | Remark | |
|---|---|---|---|
| #openstack-nova - 2020-01-21 | |||
| 15:54:55 | kashyap | sean-k-mooney: gibi: To conclude the discussion: my previous comment still stands: will go with the `diff` noted earlier w/ a TODO in code | |
| 15:54:57 | sean-k-mooney | but they could jsut disbael the RNG | |
| 15:55:04 | kashyap | sean-k-mooney: Yeah, indeed on the legacy OS | |
| 15:55:19 | sean-k-mooney | ya the diff is fine with me | |
| 15:55:23 | kashyap | Okido | |
| 15:55:33 | kashyap | Thanks for bearing with me | |
| 15:56:40 | kashyap | Completely unrelated: I can't even do Ctrl-c in Grrrrrit-- anymore. Is it just me? | |
| 15:57:25 | sean-k-mooney | i got it working but i know other have had issues | |
| 15:57:41 | sean-k-mooney | its a browser thing i think | |
| 15:57:52 | sean-k-mooney | i dont think our gerrit was updated | |
| 16:00:38 | kashyap | sean-k-mooney: I tried it in both FF and Chromium :-( | |
| 16:00:49 | kashyap | (To no effect) | |
| 16:12:48 | sean-k-mooney | kashyap: so in chrome i has the "webkit-user-select: none" css property applied | |
| 16:12:56 | sean-k-mooney | to the comment | |
| 16:14:33 | sean-k-mooney | in firfox 67 it does not | |
| 16:14:57 | kashyap | sean-k-mooney: I see, will fiddle. Thank you for the tip | |
| 16:15:30 | kashyap | sean-k-mooney: Unrelated: do we have any examples of this: | |
| 16:15:33 | kashyap | "* Some properties recognized by Nova may have no effect unless a corresponding property is enabled in the server flavor." | |
| 16:16:19 | kashyap | (The 'hw_rng_model' / 'hw_rng:allowed' used to be one; but now we're changing it.) | |
| 16:16:25 | kashyap | I quoted it from Glance docs; as I'm updating them | |
| 16:21:44 | sean-k-mooney | am hw:mem_page_size in the image will only have an effect if hw:mem_page_size=any or hw:mem_page_size=large | |
| 16:22:31 | sean-k-mooney | i think the realtime mask in the image will also be ignored if you dont enable in in the flaovr but we normally try to make it an irror rather then ignore it | |
| 16:22:44 | sean-k-mooney | this is slightly different however | |
| 16:23:29 | sean-k-mooney | in that its more qulatitive. i.e. it is saying if i have a random number generateor make it of this type | |
| 16:29:19 | kashyap | sean-k-mooney: Yeah, the hw:mem_page_size is not dependent on any other property; so it's different indeed | |
| 16:29:59 | sean-k-mooney | i think the realtime mask is the best example | |
| 16:30:08 | sean-k-mooney | realtiem cpus can only be enabled in the falvor | |
| 16:30:15 | sean-k-mooney | but you can set the mask in the flavor or image | |
| 16:30:29 | sean-k-mooney | and the image mask only works if its enabled in the flavor | |
| 16:30:42 | sean-k-mooney | also http://paste.openstack.org/show/788651/ is what i think is going on with gerrit | |
| 16:30:47 | kashyap | sean-k-mooney: Got the exact property names, please? So I can fix the Gerrit document right away | |
| 16:32:24 | sean-k-mooney | i should have added https://developer.mozilla.org/en-US/docs/Web/CSS/initial | |
| 16:32:39 | kashyap | sean-k-mooney: Thank you :-) | |
| 16:32:40 | sean-k-mooney | so ya inial restores a property to its defaul state which may have changed | |
| 16:33:38 | sean-k-mooney | hehe i like that note " On inherited properties, the initial value may be unexpected. " | |
| 16:33:49 | sean-k-mooney | in other words if you use it it will break | |
| 16:33:54 | sean-k-mooney | eventually | |
| 16:35:30 | openstackgerrit | Kashyap Chamarthy proposed openstack/nova master: libvirt: Add a default VirtIO-RNG device to guests https://review.opendev.org/616603 | |
| 16:36:13 | kashyap | sean-k-mooney: When you can, does the TODO & NOTE added above make sense to you? | |
| 16:38:36 | sean-k-mooney | im not sure i agree with likely to be extended :P but yes they make sense although i proably woudl make them both NOTE | |
| 16:39:34 | sean-k-mooney | mainlly because virtion 1.0 was standarised in 2016 | |
| 16:40:43 | sean-k-mooney | so im not sure how relevent support of explecitly running operating systems that predate that is given libvirt we will default to tansitional device model if you are using the pc machien type | |
| 16:41:52 | sean-k-mooney | rhel 6 or windows server 2013 are the two main things that come to mind but they are not going to be deploy on q35 anyway | |
| 16:52:57 | kashyap | sean-k-mooney: :-) I don't want to be overly confident and remove it yet | |
| 16:53:18 | kashyap | Hence I just wanted to make triple-sure before we remove it (and then later realize, "oh, we need to re-introduce" :-)) | |
| 16:56:32 | openstackgerrit | Kashyap Chamarthy proposed openstack/nova master: libvirt: Add a default VirtIO-RNG device to guests https://review.opendev.org/616603 | |
| 16:56:37 | kashyap | sean-k-mooney: Okay, satisfied your request :-) --^ | |
| 16:56:45 | kashyap | sean-k-mooney: I even added "if a good reason shows up" :D | |
| 17:14:39 | artom | Has the XMLMatcher utility for unit tests not moved to oslo? | |
| 17:14:45 | artom | Keystone has one, we have one... | |
| 17:14:49 | artom | Can't find it in oslo anywhere | |
| 17:15:30 | sean-k-mooney | kashyap: lol ok didnt i mark it as a nit | |
| 17:15:43 | sean-k-mooney | kashyap: e.g. you dont need to respin but sure | |
| 17:16:22 | sean-k-mooney | we have one in nova | |
| 17:16:39 | sean-k-mooney | at least we used too | |
| 17:17:26 | artom | sean-k-mooney, yeah, but I'd like to suggest amodi use it in his whitebox patch | |
| 17:17:37 | sean-k-mooney | you can do self.assertXmlEqual | |
| 17:18:01 | artom | Not in tempest... | |
| 17:18:49 | sean-k-mooney | this is the implementaion https://github.com/openstack/nova/blob/e80300ac20388890539a7f709e526a0a5ba8e63d/nova/test.py#L534-L535 | |
| 17:18:56 | artom | And actually that method just uses the XMLMatcher :) | |
| 17:19:20 | sean-k-mooney | yes from nova.tests.unit import matchers | |
| 17:20:56 | sean-k-mooney | there https://github.com/openstack/nova/blob/e80300ac20388890539a7f709e526a0a5ba8e63d/nova/tests/unit/matchers.py#L404 | |
| 17:22:08 | kashyap | sean-k-mooney: You did, but I aim to please :-) | |
| 17:26:46 | artom | sean-k-mooney, yeah, so I'd rather not import nova bits into whitebox ;) | |
| 17:27:53 | sean-k-mooney | ya we shoudl not but we shoudl have a similar function | |
| 17:28:32 | sean-k-mooney | we dont need 90% of what that is doing as it has extra complexity to be able to ignore things | |
| 17:29:52 | sean-k-mooney | for the whitebox tests i woudl probaly use xpath expression to pull out the content we want to compre from the two doms | |
| 17:30:05 | sean-k-mooney | and then compare teh normalised pretty printed version | |
| 17:30:20 | sean-k-mooney | but i really wold depend on why we were comparing | |
| 17:32:04 | sean-k-mooney | we should not try to have precreated expected xmls for the rebuild tests | |
| 17:32:28 | sean-k-mooney | we shoudl be comparing the relevent xml section between the instance before an after rebuild | |
| 17:32:48 | sean-k-mooney | which i think you already have example of for vcpus | |
| 17:32:49 | artom | That's exactly what it is | |
| 17:33:12 | artom | For the CPUs we pull out the individual IDs | |
| 17:33:28 | artom | Actually yeah, could do that here as well | |
| 17:33:58 | sean-k-mooney | yep for the test that tried to change the number of numa nodes you jsut need to count the numer of cell elements before and after | |
| 17:34:31 | sean-k-mooney | you dont need to do a full xml match. it shoudl be rejected at teh api and the xml should not change for the negitive tests | |
| 17:35:07 | sean-k-mooney | for the positive test the numa/pinning related element also shoudl not change | |
| 17:35:45 | sean-k-mooney | the <nova:metadata/> element will be update with the image uuid however | |
| 17:37:15 | kashyap | sean-k-mooney: And here is the update to Glance's doc: https://review.opendev.org/#/c/703657/ | |
| 17:37:42 | sean-k-mooney | :) im about to go have dinner but ill review it later this evening | |
| 17:54:46 | kashyap | No rush. Thanks for review so far! (Likewise, off for dinner) | |
| 18:21:37 | openstackgerrit | Merged openstack/os-vif master: [Follow Up] OVS DPDK port representors support https://review.opendev.org/665965 | |
| 18:57:32 | openstackgerrit | Adrian Chiris proposed openstack/os-vif master: Revert "[Follow Up] OVS DPDK port representors support" https://review.opendev.org/703672 | |
| 19:00:58 | openstackgerrit | Adrian Chiris proposed openstack/os-vif master: Revert "[Follow Up] OVS DPDK port representors support" https://review.opendev.org/703672 | |
| 19:14:13 | dustinc | gibi: thanks for the feedback on provider config, going through it now/this week | |
| 19:33:51 | melwitt | efried: re: nova-drivers, yeah I hadn't looked at that in awhile. and nova-bugs is an open team, anyone can join on their own | |
| 19:36:02 | efried | oh, gtk | |
| 19:36:10 | melwitt | and what others said is correct, nova-drivers is just for doing blueprint-fu, for those involved in administrative tasks around releases, milestones, bp status, etc | |
| 19:37:24 | melwitt | I didn't join nova-drivers until I was ptl, then I used it to do some of the launchpad stuff described in the ptl guide I wrote | |
| 19:37:36 | openstackgerrit | Merged openstack/nova master: Add ironic hypervisor doc https://review.opendev.org/701998 | |
| 19:37:43 | openstackgerrit | Merged openstack/nova master: functional: Add '_create_server' helper https://review.opendev.org/697540 | |
| 21:33:48 | openstackgerrit | sean mooney proposed openstack/nova stable/queens: Block rebuild when NUMA topology changed https://review.opendev.org/703140 | |
| 21:33:49 | openstackgerrit | sean mooney proposed openstack/nova stable/queens: Disable NUMATopologyFilter on rebuild https://review.opendev.org/703141 | |
| 21:33:49 | openstackgerrit | sean mooney proposed openstack/nova stable/queens: FUP for in-place numa rebuild https://review.opendev.org/703142 | |
| 21:35:53 | efried | frickler: Seen | |
| 21:35:53 | efried | 2020-01-21 18:21:18.373 | ERROR: Cannot uninstall 'PyYAML'. It is a distutils installed project and thus we cannot accurately determine which files belong to it which would lead to only a partial uninstall. | |
| 21:35:53 | efried | a couple of times today. I noticed you seemed to have some clue what this was about when you were helping with https://review.opendev.org/#/c/649097/ -- can you help? | |
| 21:36:18 | efried | frickler: ^ was in the nova-live-migration job btw. | |
| 21:36:39 | efried | gmann: ^ any ideas? | |