Earlier  
Later
New Search
Posted Nick Remark
#openstack-nova - 2020-01-21
16:30:47 kashyap sean-k-mooney: Got the exact property names, please? So I can fix the Gerrit document right away
16:32:24 sean-k-mooney i should have added https://developer.mozilla.org/en-US/docs/Web/CSS/initial
16:32:39 kashyap sean-k-mooney: Thank you :-)
16:32:40 sean-k-mooney so ya inial restores a property to its defaul state which may have changed
16:33:38 sean-k-mooney hehe i like that note " On inherited properties, the initial value may be unexpected. "
16:33:49 sean-k-mooney in other words if you use it it will break
16:33:54 sean-k-mooney eventually
16:35:30 openstackgerrit Kashyap Chamarthy proposed openstack/nova master: libvirt: Add a default VirtIO-RNG device to guests https://review.opendev.org/616603
16:36:13 kashyap sean-k-mooney: When you can, does the TODO & NOTE added above make sense to you?
16:38:36 sean-k-mooney im not sure i agree with likely to be extended :P but yes they make sense although i proably woudl make them both NOTE
16:39:34 sean-k-mooney mainlly because virtion 1.0 was standarised in 2016
16:40:43 sean-k-mooney so im not sure how relevent support of explecitly running operating systems that predate that is given libvirt we will default to tansitional device model if you are using the pc machien type
16:41:52 sean-k-mooney rhel 6 or windows server 2013 are the two main things that come to mind but they are not going to be deploy on q35 anyway
16:52:57 kashyap sean-k-mooney: :-) I don't want to be overly confident and remove it yet
16:53:18 kashyap Hence I just wanted to make triple-sure before we remove it (and then later realize, "oh, we need to re-introduce" :-))
16:56:32 openstackgerrit Kashyap Chamarthy proposed openstack/nova master: libvirt: Add a default VirtIO-RNG device to guests https://review.opendev.org/616603
16:56:37 kashyap sean-k-mooney: Okay, satisfied your request :-) --^
16:56:45 kashyap sean-k-mooney: I even added "if a good reason shows up" :D
17:14:39 artom Has the XMLMatcher utility for unit tests not moved to oslo?
17:14:45 artom Keystone has one, we have one...
17:14:49 artom Can't find it in oslo anywhere
17:15:30 sean-k-mooney kashyap: lol ok didnt i mark it as a nit
17:15:43 sean-k-mooney kashyap: e.g. you dont need to respin but sure
17:16:22 sean-k-mooney we have one in nova
17:16:39 sean-k-mooney at least we used too
17:17:26 artom sean-k-mooney, yeah, but I'd like to suggest amodi use it in his whitebox patch
17:17:37 sean-k-mooney you can do self.assertXmlEqual
17:18:01 artom Not in tempest...
17:18:49 sean-k-mooney this is the implementaion https://github.com/openstack/nova/blob/e80300ac20388890539a7f709e526a0a5ba8e63d/nova/test.py#L534-L535
17:18:56 artom And actually that method just uses the XMLMatcher :)
17:19:20 sean-k-mooney yes from nova.tests.unit import matchers
17:20:56 sean-k-mooney there https://github.com/openstack/nova/blob/e80300ac20388890539a7f709e526a0a5ba8e63d/nova/tests/unit/matchers.py#L404
17:22:08 kashyap sean-k-mooney: You did, but I aim to please :-)
17:26:46 artom sean-k-mooney, yeah, so I'd rather not import nova bits into whitebox ;)
17:27:53 sean-k-mooney ya we shoudl not but we shoudl have a similar function
17:28:32 sean-k-mooney we dont need 90% of what that is doing as it has extra complexity to be able to ignore things
17:29:52 sean-k-mooney for the whitebox tests i woudl probaly use xpath expression to pull out the content we want to compre from the two doms
17:30:05 sean-k-mooney and then compare teh normalised pretty printed version
17:30:20 sean-k-mooney but i really wold depend on why we were comparing
17:32:04 sean-k-mooney we should not try to have precreated expected xmls for the rebuild tests
17:32:28 sean-k-mooney we shoudl be comparing the relevent xml section between the instance before an after rebuild
17:32:48 sean-k-mooney which i think you already have example of for vcpus
17:32:49 artom That's exactly what it is
17:33:12 artom For the CPUs we pull out the individual IDs
17:33:28 artom Actually yeah, could do that here as well
17:33:58 sean-k-mooney yep for the test that tried to change the number of numa nodes you jsut need to count the numer of cell elements before and after
17:34:31 sean-k-mooney you dont need to do a full xml match. it shoudl be rejected at teh api and the xml should not change for the negitive tests
17:35:07 sean-k-mooney for the positive test the numa/pinning related element also shoudl not change
17:35:45 sean-k-mooney the <nova:metadata/> element will be update with the image uuid however
17:37:15 kashyap sean-k-mooney: And here is the update to Glance's doc: https://review.opendev.org/#/c/703657/
17:37:42 sean-k-mooney :) im about to go have dinner but ill review it later this evening
17:54:46 kashyap No rush. Thanks for review so far! (Likewise, off for dinner)
18:21:37 openstackgerrit Merged openstack/os-vif master: [Follow Up] OVS DPDK port representors support https://review.opendev.org/665965
18:57:32 openstackgerrit Adrian Chiris proposed openstack/os-vif master: Revert "[Follow Up] OVS DPDK port representors support" https://review.opendev.org/703672
19:00:58 openstackgerrit Adrian Chiris proposed openstack/os-vif master: Revert "[Follow Up] OVS DPDK port representors support" https://review.opendev.org/703672
19:14:13 dustinc gibi: thanks for the feedback on provider config, going through it now/this week
19:33:51 melwitt efried: re: nova-drivers, yeah I hadn't looked at that in awhile. and nova-bugs is an open team, anyone can join on their own
19:36:02 efried oh, gtk
19:36:10 melwitt and what others said is correct, nova-drivers is just for doing blueprint-fu, for those involved in administrative tasks around releases, milestones, bp status, etc
19:37:24 melwitt I didn't join nova-drivers until I was ptl, then I used it to do some of the launchpad stuff described in the ptl guide I wrote
19:37:36 openstackgerrit Merged openstack/nova master: Add ironic hypervisor doc https://review.opendev.org/701998
19:37:43 openstackgerrit Merged openstack/nova master: functional: Add '_create_server' helper https://review.opendev.org/697540
21:33:48 openstackgerrit sean mooney proposed openstack/nova stable/queens: Block rebuild when NUMA topology changed https://review.opendev.org/703140
21:33:49 openstackgerrit sean mooney proposed openstack/nova stable/queens: Disable NUMATopologyFilter on rebuild https://review.opendev.org/703141
21:33:49 openstackgerrit sean mooney proposed openstack/nova stable/queens: FUP for in-place numa rebuild https://review.opendev.org/703142
21:35:53 efried frickler: Seen
21:35:53 efried 2020-01-21 18:21:18.373 | ERROR: Cannot uninstall 'PyYAML'. It is a distutils installed project and thus we cannot accurately determine which files belong to it which would lead to only a partial uninstall.
21:35:53 efried a couple of times today. I noticed you seemed to have some clue what this was about when you were helping with https://review.opendev.org/#/c/649097/ -- can you help?
21:36:18 efried frickler: ^ was in the nova-live-migration job btw.
21:36:39 efried gmann: ^ any ideas?
23:05:27 efried dustinc: I went through gibi's comments on the provider config series and answered a few of them. I think the main thing is going to be the missing checks for duplicates by name+uuid.
23:06:37 dustinc efried: Thanks! I am also working through the nits and other small stuff since I need to update series anyway. I am only able to work on this bits at a time right this minute but plan to get it all done this week.
23:14:29 efried cool
23:28:33 sean-k-mooney efried: so the PYYAML distutils thing is proably related to the fact we pin pip to a really old version in devstack.
23:29:01 sean-k-mooney we try to pin to a version below 10 to work around that so that pip will remove it anyway
23:30:07 sean-k-mooney without configuring devstack to install in virutal envs with no site packages i dont know if there is a clean way to complete work around package conflict with teh os packages
23:37:46 openstackgerrit Merged openstack/nova stable/ocata: ocata-only: drop non-voting ceph job https://review.opendev.org/700077
23:46:57 gmann efried: sean-k-mooney pip 10 cap is removed now - https://review.opendev.org/#/c/561597/21
23:47:09 gmann which job is failing
23:48:20 sean-k-mooney nova livemigration which is a legacy job
23:49:20 sean-k-mooney gmann: efried was asking about https://review.opendev.org/#/c/649097/
23:49:41 sean-k-mooney but i think that was unrealted
23:50:06 gmann ok
23:50:14 sean-k-mooney oh that was just context for why he tought you would know
23:51:46 sean-k-mooney hum ya it looks like there are a decent number of failure on master https://zuul.opendev.org/t/openstack/builds?job_name=nova-live-migration
23:53:43 sean-k-mooney oh ya th ecompression thing is not fix on legacy jobs...
#openstack-nova - 2020-01-22
00:05:54 sean-k-mooney gmann: efried so it looks like its failing ot install os-testr
00:06:20 sean-k-mooney http://paste.openstack.org/show/788663/
00:06:49 sean-k-mooney or rather willl install os tester that try to replace PyYAML
02:55:17 openstackgerrit melanie witt proposed openstack/nova stable/pike: Avoid redundant initialize_connection on source post live migration https://review.opendev.org/683008
06:02:39 frickler so I started to fix the live-migration job at https://review.opendev.org/703735 , but a better solution would be to make os-testr work with system pyyaml. the latted is depended on by e.g. cloud-init so it's very hard to remove. or set up using os-testr from within a venv only
06:03:03 frickler also, has anyone started work to move that job to zuul v3?
10:47:15 stephenfin frickler: I assume "install everything devstack'y in a virtualenv" is much harder than it seems
10:47:35 stephenfin frickler: and yes, mriedem has started work moving to zuul v3 and I think sean-k-mooney is continuing that
10:51:40 bauzas stephenfin: gibi: worth looking at an already-approved spec that I could work on in Ussuri ? https://review.opendev.org/#/c/702943/
10:58:14 stephenfin bauzas: Sure. Got some downstream release'y stuff to take care of this morning first though
10:58:30 bauzas hah
10:58:32 bauzas your turn
11:36:04 openstackgerrit John Garbutt proposed openstack/nova-specs master: Small fixes to unified limits spec https://review.opendev.org/703773
12:30:06 gibi it seems I need to spend my time today on downstream issues

Earlier   Later